Thomas Stromberg
e09a1221bb
Add rejection reason to 'unable to find driver' error
2020-04-02 06:20:35 -07:00
Sharif Elgamal
0357c89ee5
add issue to todo comment
2020-04-01 17:35:41 -07:00
Sharif Elgamal
4df145518a
Merge branch 'master' of github.com:kubernetes/minikube into delete-on-failure
2020-04-01 15:24:38 -07:00
Thomas Strömberg
5306702515
Merge pull request #7363 from tstromberg/stop-harder
...
Extend maximum stop retry from 30s to 120s
2020-04-01 14:43:14 -07:00
Thomas Strömberg
428e6bd285
Merge pull request #7325 from afbjorklund/version-options
...
Implement options for the minikube version command
2020-04-01 14:41:00 -07:00
Thomas Strömberg
64bd8dee8b
Merge pull request #7299 from afbjorklund/dashboard-kubectl
...
Run dashboard with internal kubectl if not in path
2020-04-01 14:40:23 -07:00
Thomas Stromberg
b71126356f
Extend maximum stop retry from 30s to 120s
2020-04-01 14:24:53 -07:00
Medya Ghazizadeh
a24ae23024
Merge pull request #7356 from afbjorklund/kubectl-version
...
Use kubectl version --short if --output=json fails
2020-04-01 14:17:52 -07:00
Sharif Elgamal
d8151730f4
retry anytime node.Start fails, not just in minikube start
2020-04-01 11:00:39 -07:00
Thomas Strömberg
592bb2e9eb
Merge pull request #7310 from tstromberg/wrong-url
...
mustload: Replace DriverIP with Forwarded(IP|Port)
2020-04-01 08:29:12 -07:00
Anders F Björklund
227fec14ae
Use kubectl version --short if --output=json fails
...
Really old kubernetes clients did not have the --output parameter
Show a friendly reminder to upgrade, instead of an error message.
2020-04-01 17:19:14 +02:00
Thomas Strömberg
28ec78a5cb
lint - add newline after stdlib imports
2020-04-01 05:54:23 -07:00
Sharif Elgamal
673922c8d3
code comments
2020-03-31 15:38:59 -07:00
Sharif Elgamal
fcb5c462f4
add delete-on-failure flag
2020-03-31 15:06:16 -07:00
Sharif Elgamal
fd3e0f505a
clean up minikube start output
2020-03-30 15:31:17 -07:00
Anders F Björklund
a1cc3188bb
Implement options for the minikube version command
...
Add --short and --output options, just like kubectl
2020-03-30 22:19:39 +02:00
Anders F Björklund
5f9515040d
Run dashboard with internal kubectl if not in path
...
If "kubectl" is not in the PATH, then use the same cached binary
as with the "minikube kubectl" command (version matching cluster).
2020-03-30 18:34:20 +02:00
Thomas Stromberg
7f5f12c5f4
Get rid of DriverIP attr to prevent future misuse
2020-03-29 11:44:25 -07:00
Thomas Stromberg
063077c712
mustload: Check apiserver status using forwarded IP/port
2020-03-29 11:34:21 -07:00
Thomas Stromberg
1f31d25c16
Use LookPath to verify conntrack install
2020-03-28 13:19:48 -07:00
Medya Ghazizadeh
801d49afd0
Merge pull request #7292 from linkvt/fix-missing-global-options
...
Show all global flags in options command
2020-03-27 22:13:07 -07:00
Medya Ghazizadeh
da1d411e30
Merge pull request #6879 from prasadkatti/populate_target_port_in_svc_list
...
service list: populate target port
2020-03-27 22:12:18 -07:00
Vincent Link
2420bb1f3a
Show all global flags in cli options help
...
Before this fix the flags shown in `minikube options` were taken from a
list of options (`viperWhiteList`) which seems arbitrary.
I still don't know for sure why this is done but taking all
PersistentFlags (persistent=apply to all sub commands) from the root
command seems like the correct way.
2020-03-27 21:31:38 +01:00
Medya Ghazizadeh
46e87ba054
Merge pull request #7219 from sharifelgamal/cluster-name
...
Get rid of ClusterNameFromMachine
2020-03-25 18:33:48 -07:00
Medya Ghazizadeh
53b9d720e7
Merge pull request #7230 from tstromberg/hugo-switch
...
Make recreateIfNeeded more robust, improve UX
2020-03-25 18:28:07 -07:00
Sharif Elgamal
dc7bdecda4
Merge branch 'master' of github.com:kubernetes/minikube into cluster-name
2020-03-25 15:43:12 -07:00
Thomas Stromberg
f84569aab0
Make crazy cluster_test / mock_driver combination pass tests
2020-03-25 14:46:44 -07:00
Thomas Strömberg
5a316b3bf9
Merge pull request #7068 from vikkyomkar/issue-7067
...
Add --vm flag for users who want to autoselect only VM's
2020-03-25 12:44:16 -07:00
Medya Ghazizadeh
5689d3b8e1
Merge pull request #7210 from priyawadhwa/issue-7184
...
Fix TestStartStopWithPreload bug
2020-03-24 22:42:33 -07:00
Medya Ghazizadeh
5ea20f5a06
Merge pull request #7212 from linkvt/kubernetes-parameters-latest-stable
...
Add 'stable' and 'latest' as valid kubernetes-version values
2020-03-24 22:37:53 -07:00
Priya Wadhwa
646609ec30
review comments
2020-03-24 21:24:43 -07:00
Sharif Elgamal
28672dec78
remove ClusterNameFromMachine
2020-03-24 14:43:11 -07:00
Vincent Link
3ad1dfb4bb
Add 'stable' and 'latest' as valid kubernetes-version values
2020-03-24 21:50:28 +01:00
Sharif Elgamal
2933953cfa
use mustload
2020-03-24 13:18:59 -07:00
Sharif Elgamal
e3bcdbf42a
fix validateSpecificDriver error message
2020-03-24 12:55:31 -07:00
Priya Wadhwa
5ef83f35e2
Add --preload flag to optionally turn off preload
2020-03-24 10:53:02 -07:00
Medya Ghazizadeh
587154196e
Merge pull request #7173 from medyagh/stop_kic
...
stop kubernetes containers on stopping docker/podman driver
2020-03-24 05:42:49 -07:00
Medya Ghazizadeh
20991ac336
Merge pull request #7183 from sharifelgamal/conntrack-msg
...
add friendly error message for missing conntrack
2020-03-23 23:03:09 -07:00
Medya Gh
5f90a319bd
stop k8s in kic and none
2020-03-23 21:01:12 -07:00
Sharif Elgamal
8489c074fe
code cleanup
2020-03-23 20:46:51 -07:00
Sharif Elgamal
ca3f88a734
comment
2020-03-23 20:19:07 -07:00
Sharif Elgamal
4ab849b604
shorter variable names
2020-03-23 20:18:03 -07:00
Sharif Elgamal
8b58738491
check for conntrack at start time, remove useless solution message
2020-03-24 02:54:47 +00:00
Thomas Stromberg
fcb8736cf7
merge to master
2020-03-23 17:30:06 -07:00
Medya Ghazizadeh
93021fbfda
Merge pull request #7174 from afbjorklund/xdg-open
...
Centralize the handling of browser.OpenURL
2020-03-23 17:12:38 -07:00
Thomas Stromberg
16e18724e2
Dedup ExampleCmd, fix command flag ordering
2020-03-23 16:28:39 -07:00
Thomas Stromberg
b99e943684
Improve minikubeCmd, promote to public function
2020-03-23 16:00:53 -07:00
Thomas Strömberg
c50cfc99fa
Merge pull request #7158 from kubernetes/driver-confusion
...
Consistently detect old driver when existing.Driver is unset
2020-03-23 16:00:17 -07:00
Thomas Stromberg
673341ce35
Improve hostDriver comment
2020-03-23 15:51:02 -07:00
Thomas Stromberg
81393a0bc3
Add boilerplate
2020-03-23 14:39:49 -07:00