These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"
"type name will be used as foo.FooBar by other packages,
and that stutters; consider calling this Bar"
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
Some componentconfig options are aliased to native convertible types
(e.g. ProxyMode) but FindAndSet() was unable to detect that and so it
wasn't possible to set these values via `--extra-config`.
This change addresses that by using the reflected value's Kind instead
of a type assertion on its interface.
It's also worth noting that any value with the type Duration (e.g.
proxy.IPTablesSyncPeriod) is also unable to be set for the same reason,
but this commit does not address that.
See https://github.com/kubernetes/minikube/issues/1217
Medya Gh
tstromberg
Anders F Björklund
Arnaud MAZIN
Matt Rickard
dlorenc
Dale Hamel
Eden Li
Jimmi Dyson
Dan Lorenc