Commit Graph

137 Commits (f1c0f61963d83ca27144b48b54d734b25a278944)

Author SHA1 Message Date
Kent Iso b1030dc28a Fix configuration of the metallb with empty load balancing IP range 2021-02-07 23:43:05 +09:00
Ling Samuel b949034e1a
Manage addon images in code, support custom addon images
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:00 +08:00
Daehyeok Mun 36d94a2d88 Migrate MachineName function.
Migrate MachineName function from driver package to config package.
2021-01-08 11:26:10 -08:00
Jituri, Pranav 0ae11fd5c8
fix linting error 2020-12-15 18:22:36 +05:30
Jituri, Pranav 6bbc5f986b
Enable Ingress Addon for Docker Windows 2020-11-21 16:01:06 +05:30
Evgeny Shmarnev f88040aad9
Merge branch 'master' into ISSUE-9664 2020-11-12 13:47:12 +01:00
Evgeny Shmarnev db93039f9c Addressing comments 2020-11-12 13:45:33 +01:00
Sharif Elgamal c01e106b48 better comment 2020-11-11 13:37:40 -08:00
Sharif Elgamal b23cb6c20d find special cloud shell spot for creds 2020-11-11 12:26:50 -08:00
Sharif Elgamal 4f4124c69d try to create credentials file if using env to authenticate 2020-11-10 15:53:54 -08:00
zouyu 3130c9fce0 Add unit test
Signed-off-by: zouyu <zouy.fnst@cn.fujitsu.com>
2020-10-23 10:13:38 +08:00
Thomas Stromberg e2fdc077f8 Use 6 minutes, to use the philosophy of doubling timeouts you hit 2020-10-21 09:54:01 -07:00
Thomas Stromberg 20d1645ce7 Wait up to 5 minutes for addon pods, improve error message 2020-10-21 09:44:39 -07:00
Priya Modali 8936a8c7f8 Merge branch 'master' of https://github.com/kubernetes/minikube into klog 2020-10-13 09:08:27 -07:00
Sharif Elgamal b04610ef9b simplify addon code by fixing gcp-auth failure policy 2020-10-06 16:14:44 -07:00
Priya Modali 43ea47f4e0 Fixed merge conflicts. 2020-09-29 16:17:31 -07:00
Priya Modali 97d96bf925 Switching from glob library to klog library. 2020-09-29 15:49:41 -07:00
Sharif Elgamal ff051f9a33
Make sure gcp-auth addon can be enabled on startup ()
* fix documentation for gcp-auth addon

* make sure kube-system pods are up before enabling gcp-auth

* fix lint

* add failurePolicy for webhook

* only install addons if asked

* better comment

* slightly less hacky code

* defer addons properly

* simplify code for performance
2020-09-29 13:29:14 -07:00
jjanik ae92c289b8 add csi-hostpath-driver addon 2020-09-04 18:54:33 +02:00
jjanik c5ae7b9580 add volumesnapshots addon 2020-09-04 17:10:54 +02:00
Sharif Elgamal ed4271ffbc trim whitespace when setting gcp project id 2020-09-02 11:42:47 -07:00
Thomas Strömberg 3fbbb557b1
Merge pull request from zhijianli88/cleanup-tempfiles2
Cleanup tempfiles2
2020-09-01 16:25:00 -07:00
Thomas Strömberg fba4de74cf
Merge pull request from saltbo/master
fix error usage for the WaitGroup in the pkg addons
2020-09-01 16:21:51 -07:00
Thomas Stromberg 2c5e8fdaee Add detailed JSON & status codes for all error paths 2020-08-30 17:25:11 -07:00
Li Zhijian 95e7203900 add a temp MinikubeHome for TestStart
this test will write a config.json into MinikubeHome, create a temp dir for it

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 11:49:07 +08:00
Li Zhijian 50459e0566 add testing cleanup hook for createTestProfile
T.cleanup() is introduced since go-1.14

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-19 18:10:07 +08:00
Medya Ghazizadeh a13e5e5512
Merge pull request from Dean-Coakley/add-ingress-noneDriver-warn
Add warning for ingress addon enabled with driver of none
2020-08-10 13:17:54 -07:00
Sharif Elgamal 02930c0d51 fix tip output and do not output ending tip disabling 2020-08-06 13:45:46 -07:00
Sharif Elgamal 16ba55d05f better error message 2020-08-06 12:36:54 -07:00
Sharif Elgamal 90dadd0ce6 better error messages for not finding creds 2020-08-06 11:47:09 -07:00
Dean Coakley 9c23485dfb Remove list of alternative drivers 2020-07-29 09:40:43 +01:00
Dean Coakley 4b2974472d Improve error message text 2020-07-28 22:40:55 +01:00
Dean Coakley b27440d4ae Add warning for ingress addon with driver of none 2020-07-28 22:40:15 +01:00
Medya Ghazizadeh 85f1c4f2dd
Merge pull request from concaf/concaf/fix/fix-already-started
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal 1b6eee675b
Automated GCP Credentials Addon Prototype ()
* metadata addon works

* Add code for metadata server image and makefile rules

* remove log message

* update to work with v1.13.11

* update readme

* fix metadata addon stuff for newer codebase

* buncha changes

* just so many changes

* ch-ch-ch-ch-changes

* addon works

* update readme

* boilerplate

* revert unrelated change

* move server code to another repo

* switch addon name to gcp-auth

* metadata -> gcp-auth

* missed one

* automate finding of credentials

* remove unnecessary comment

* address comments

* Update README.md

* Update README.md

* use mustload everywhere

* swap selector condition

* upgrade kube-webhook-certgen to 1.3

* move paths to constants

* add notice to user on addon enable

* adding addon documentation

* move addons documentation inside handbook

* remove old addons docs location

Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Shubham f42f79e56d (Addons) Create a new command in every retry
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd)
states that "... Cmd cannot be reused after calling its Run or
Start methods."

This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.

Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.

Related to   
2020-07-21 21:20:24 +05:30
Ambor e00cf6c1e1 fix error usage for the WaitGroup in the pkg addons 2020-07-21 11:57:06 +08:00
Priya Wadhwa 3a290606db Merge branch 'master' of https://github.com/kubernetes/minikube into json-output 2020-07-10 19:12:50 -04:00
Medya Ghazizadeh d8106f7d06
Merge pull request from colvin/addon-podsecuritypolicies
Include a podsecuritypolicies addon
2020-07-07 15:52:03 -07:00
Priya Wadhwa bd94872a10 add additional steps 2020-07-07 14:25:27 -04:00
Medya Gh e829341b9d improve logging 2020-06-26 15:12:15 -07:00
Medya Gh 64553e281b revert debugging 2020-06-26 15:11:03 -07:00
Medya Gh 742dcd6b00 add addon status verification for 3 addons 2020-06-26 15:08:38 -07:00
Medya Gh 66421a6492 wait for ingress pod be running 2020-06-26 14:22:17 -07:00
Medya Gh 52f4e130b5 lint 2020-06-26 13:20:31 -07:00
Medya Gh 5fbf197b18 remove unrelated changes 2020-06-26 13:20:31 -07:00
Medya Gh 96781c61a2 remove unrelated changes 2020-06-26 13:20:30 -07:00
Medya Gh 058a732909 ingress addon validate deployment after enable 2020-06-26 13:20:30 -07:00
Medya Gh c47854b8fd add validate ingress 2020-06-26 13:20:30 -07:00
Medya Gh a0c33f82c1 ingress addon wait for it 2020-06-26 13:20:30 -07:00