02f03af101
exit if using --schedule with windows as it is not yet supported
2020-10-26 15:17:24 -07:00
055de4edf8
return stopped profile status quickly
2020-10-26 13:20:03 -07:00
7841aea2db
Optionally use ssh for docker-env instead of tcp
...
Since Docker 18.09, it supports ssh: as well as tcp:
for connecting to the docker daemon (in $DOCKER_HOST).
This avoids setting up certificates, but leaves key
handling (host keys and identity keys) to ssh config.
2020-10-25 14:16:28 +01:00
865d3a4a34
Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix
2020-10-23 18:15:07 -07:00
716d793990
Add support for podman v2 to podman-env command
...
Podman v1 (like 1.9.3) uses the varlink bridge,
while podman v2 (like 2.1.x) uses a REST API.
Both are using ssh for their transport, but the
environment variables exported are different.
2020-10-23 11:46:45 +02:00
d0c0d8b54c
revert suppression of emitting errors to stderr
2020-10-22 09:28:31 +01:00
dedf38b61f
Merge pull request #9368 from kadern0/issue-8445
...
Added deprecation warning for --network-plugin=cni
2020-10-21 08:53:50 -07:00
85d45be207
Fix docker-env command
2020-10-20 23:10:08 -07:00
a54ea82e3b
Implement schedule stop for unix
2020-10-20 13:45:59 -07:00
e7f9b3e954
don't pollute json output with errors
...
additionally:
- issue warning insted of error if 'exitCode' is not found
- rebase: use klog instead of glog
don't pollute status json output with errors
2020-10-18 19:56:28 +01:00
29f00628f5
Merge pull request #9459 from medyagh/stopped_kubelet
...
new --wait component "kubelet"
2020-10-15 12:25:11 -05:00
06a64de853
Merge pull request #9417 from joshmue/fix_ssh_native_toggle
...
Fix "--native-ssh" flag of "minikube ssh"
2020-10-14 10:30:51 -07:00
63c4468fd5
address review comments
2020-10-13 16:01:59 -07:00
1d85d6e123
Add warning for --network-plugin=cni (CNI has to be provided, see --cni)
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-10-12 19:27:25 +11:00
59548194bd
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-09 17:45:35 -07:00
8cfe5c1a7b
Fix "--native-ssh" flag of "minikube ssh"
...
In the previous state, the flag was discarded. This commit fixes
that and also makes sure that the SSH client is created after the
default client type is configured according to the flag.
2020-10-09 09:41:19 +02:00
2985e8a21e
Updating unit tests.
2020-10-08 15:10:50 -07:00
c459fea74d
Merge pull request #9414 from prezha/delete-context-when-stopped
...
Delete context when stopped
2020-10-08 15:12:50 -05:00
ab4a0ab558
Cleaning up flags parsing.
2020-10-08 11:18:50 -07:00
32922f4184
Merge pull request #9412 from Asarew/fix-panic-on-updating-mount-after-creation
...
fix panic when updating mount-string with KiC driver after cluster creation without mount configuration
2020-10-08 13:07:31 -05:00
ef2090ac31
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-08 10:27:04 -07:00
c63de60aba
add HostKubeconfigDeleteCtx Reason Exit
2020-10-07 22:58:20 +01:00
85b722c7b6
Setting klog default flag values.
2020-10-07 14:19:35 -07:00
65a2618485
delete context when minikube is stopped
2020-10-07 22:00:26 +01:00
e573b928d5
Merge pull request #9404 from ToonvanStrijp/master
...
Add new flag "--ports" to expose ports for docker & podman drivers
2020-10-07 15:56:29 -05:00
96d7fc4bc0
fix lint tabs
2020-10-07 19:40:59 +02:00
50c37577fd
update flag to ports
2020-10-07 18:08:08 +02:00
93bbf4c399
little bit of clean up
2020-10-07 10:22:53 +02:00
e8a0487e11
fix panic when updating mount-string with docker driver after cluster creation without mount configuration
2020-10-07 09:53:06 +02:00
615f233c77
Remove reference to Virtualbox in "stop" help
2020-10-06 21:07:02 -07:00
d7c517471d
Merge pull request #9316 from priyawadhwa/preload-disk-full
...
preload: print solution message when there is no space left on device
2020-10-06 19:10:53 -05:00
3703f69c25
Applying klogFlags set via cobra.
2020-10-06 11:20:51 -07:00
aae7784309
Merge pull request #9383 from priyawadhwa/status-bg
...
Fix minikube status bug when cluster is paused
2020-10-06 11:22:13 -04:00
dcf9dd10c6
add docker-ports flag
2020-10-06 13:37:03 +02:00
5614ed0edc
Merge pull request #9367 from medyagh/pname_length
...
don't allow profile name to be less than 2 characters
2020-10-05 18:14:15 -05:00
dc0918e6ba
review comments
2020-10-05 16:13:21 -07:00
4cff79008c
fixed merge conflict
2020-10-05 11:47:53 -04:00
e36c937a34
Do some simple cleanup of the golint complaints
...
The "magic strings" and enums still needs another approach
Simply echoing everything twice doesn't seem very useful ?
2020-10-04 13:40:33 +02:00
7d62ce1c1c
convert from exit codes to http codes if appropriate
2020-10-03 15:29:15 -04:00
7046998831
If insufficient storage is the issue, then show that in status
2020-10-02 17:48:52 -04:00
4c6af8812f
Added error handler.
2020-10-02 14:28:50 -07:00
43cc1a2581
Resolved merg conflicts.
2020-10-02 14:10:55 -07:00
8809387628
Adjusting klog initialization to not emit INFO logs by default.
2020-10-02 10:52:57 -07:00
af5fbf7880
Backup snapshot of changes.
2020-10-02 10:44:24 -07:00
0fc0c82337
Merge pull request #9294 from medyagh/docker_network
...
add dedicated network for docker driver
2020-10-01 14:11:42 -05:00
bebad76bd0
Merge pull request #8978 from taciomcosta/master
...
fix: "profile list" shows paused clusters as "Running"
2020-10-01 14:09:30 -05:00
f71272ca79
don't allow profile name to be less than 2 characters
2020-09-30 17:22:45 -07:00
6538306d14
move exit into separate function
2020-09-30 15:31:44 -04:00
db23825bfc
Move exit.Message function so that we aren't exiting from a library
2020-09-30 15:19:06 -04:00
6e91d719dd
Revert status code cmd
2020-09-29 19:38:12 -04:00
43ea47f4e0
Fixed merge conflicts.
2020-09-29 16:17:31 -07:00
97d96bf925
Switching from glob library to klog library.
2020-09-29 15:49:41 -07:00
b84dedc652
address review comments
2020-09-29 15:07:06 -07:00
b7780ec815
address review comments
2020-09-29 14:14:25 -07:00
f0f10d6135
first version
2020-09-29 14:14:24 -07:00
a05dc6516b
Revert bug in `minikube status`
...
When the cluster is Paused, `minikube status` currently says that it is `Running`. Reverting a change I made in a previous PR to take the status of the apiserver should fix this.
2020-09-29 16:56:15 -04:00
e6b510543e
Don't trim whitespace while extracting strings
...
Remove some leading and trailing whitespace from non-string
constructs like description and automatic extraction filters.
But don't change all the translations or the translations here,
since that would make this code change impossible to review.
2020-09-27 17:59:06 +02:00
11cad2b3e6
Merge pull request #9321 from loftkun/removing-duplicate-command-additions
...
Remove duplicate command additions
2020-09-25 14:03:48 -07:00
75332f7c89
Merge pull request #8901 from bluestealth/MiB
...
Use mebibytes instead of megabytes
2020-09-25 11:28:41 -07:00
ed6b756da0
Merge pull request #9308 from priyawadhwa/performance-monit
...
Add PR bot code to repo
2020-09-25 10:34:36 -07:00
7a2cd0f459
Removing Duplicate Command Additions
2020-09-25 17:45:51 +09:00
3ee1eb029c
Update test to use new exit code for insufficient storage
2020-09-24 14:09:46 -04:00
fd44e0d8fb
Force dependency on exp to prevent dirty commit release binaries ( #9309 )
...
* force dependency for release purposes
* revert original idea and add loads of debugging
* hey more debugging cool
* fix debugging
* drilling down debugging
* revert to original solution
* fix comment
2020-09-23 15:00:03 -07:00
183bdb2354
Merge pull request #9302 from dominikbraun/#9297-reason-for-missing-config-permissions
...
Return ExHostPermission for insufficient config file permissions
2020-09-23 14:20:41 -05:00
07642cd7ef
Merge pull request #9300 from ilya-zuyev/gh8891_forbid_base_image_for_vm_drivers
...
Disable base image flag for vm drivers
2020-09-23 14:10:38 -05:00
887390194e
Add more unit tests
2020-09-22 14:19:38 -07:00
bf8ec63ca9
Simplify base-image flag validation
2020-09-22 14:10:47 -07:00
76d3c9d7bb
Fix variable name (avoid collision with imported package)
2020-09-22 13:09:58 -07:00
3d547a937f
Fix Makefile rule to build bot
2020-09-22 14:00:27 -04:00
3f44d470eb
Add performance monitor code
2020-09-22 13:54:23 -04:00
8f4127b202
Use HOST_HOME_PERMISSION kind for insufficient permissions
2020-09-22 18:04:24 +02:00
603ae8fc6d
Return ExHostPermission for insufficient config file permissions
2020-09-22 10:16:27 +02:00
6a60983679
Show invalid flag diagnostic message to user
2020-09-21 23:28:34 -07:00
6bf7ca3dd2
Validate --base-image flag and active driver combo
2020-09-21 23:06:54 -07:00
9fbd2e94bd
update-context: Automatically set the context as current/active in kubeconfig
2020-09-21 00:06:15 +01:00
b9f3638f2a
Merge pull request #9233 from afbjorklund/nic-type
...
Fix copy/paste error in virtualbox nic-type help
2020-09-15 16:05:52 -07:00
48d44221a9
Don't validate Docker storage driver for Podman
...
For podman, "overlay" and "overlay2" are the same
2020-09-13 22:28:17 +02:00
37e521272c
Fix copy/paste error in virtualbox nic-type help
...
It used type "host only" twice, instead of "nat".
2020-09-13 17:25:02 +02:00
ee5b8f130f
Merge pull request #8831 from priyawadhwa/overlay
...
Set preload=false if not using overlay2 as docker storage driver
2020-09-09 11:45:52 -07:00
c4663b8417
Merge pull request #9181 from tstromberg/m1
...
Add Docker Desktop instructions if memory is >minimum but <recommended
2020-09-08 14:25:13 -07:00
b4400ad70a
Merge pull request #8904 from Xcalizorz/master
...
fixes(#8301 ): --help: bool flags which default to 'false' yield confusing output
2020-09-08 13:50:10 -04:00
4708f6215c
fix: profile list shows paused clusters as Running
2020-09-05 18:37:24 -03:00
f15fd81333
Add Docker Desktop instructions if memory is >minimum but <recommended
2020-09-03 11:39:14 -07:00
54443bd337
Update min*Mem constants to use MiB instead of MB
2020-09-03 11:34:40 -07:00
e20223d598
quote variables in GuestMountConflict warning
2020-09-03 18:39:31 +02:00
4e772347d4
exit on existing cluster start with KiC driver mount configuration change
2020-09-03 18:25:10 +02:00
229969aa54
fix grammer
2020-09-03 10:02:07 +02:00
5ae5be7141
fixed misuse of template variable
2020-09-03 10:01:19 +02:00
2b2220ac8b
added warning for changing mount configuration with KiC dirver on existing cluster
2020-09-03 09:51:11 +02:00
dab20a2e12
Merge pull request #9163 from tstromberg/driver-advice
...
docker: Improve overlay module check (behavior & UX)
2020-09-02 14:56:04 -07:00
d1431fe0e5
Merge pull request #9167 from tstromberg/kubectl-advice
...
Simplify kubectl advice messaging
2020-09-02 14:12:17 -07:00
830af29223
Merge pull request #9144 from tstromberg/confusing-warning
...
Remove conflicting & inaccurate Docker Desktop memory warning
2020-09-02 14:01:33 -07:00
4e9a3975df
Simplify kubectl advice messaging
2020-09-02 13:35:40 -07:00
0d4ef00210
Use out.T for a simpler layout
2020-09-02 10:56:06 -07:00
08d874a4a2
Reduce performance-advice message to a single line
2020-09-02 10:38:45 -07:00
ea5af644ec
fix merge conflict
2020-09-02 09:31:42 -04:00
2b8c48cc59
start: fixed the type value for kubectl version mismatch to warning
2020-09-02 21:17:13 +10:00
eff63d7382
chore( #8301 ): Changes https-flag description
2020-09-02 10:24:12 +02:00
dc5951451b
Merge pull request #8872 from kadern0/issue-8857
...
Running internal kubectl command when minikube is called as 'kubectl'
2020-09-01 22:44:44 -07:00
d66a8e68c9
Merge pull request #8907 from sharifelgamal/external-ssh
...
respect native-ssh flag
2020-09-01 22:37:37 -07:00
1859274e8a
refactor conversion functions into util
2020-09-01 21:21:07 -07:00
ad1e2e2de5
Use same conversion logic for bytes -> MiB everywhere
2020-09-01 21:20:09 -07:00
8a26881552
Merge pull request #8159 from Asarew/docker-host-volumes
...
Support for mounting host volumes on start with docker driver
2020-09-01 16:30:45 -07:00
f69c6c5773
Remove conflicting & possibly inaccurate Docker Desktop specific memory warning
2020-09-01 08:40:00 -07:00
8ef7410066
Shorten Docker memory warning
2020-08-30 21:04:10 -07:00
cd91fb8470
Unwrap unnecessary level of error annotation for improved messages
2020-08-30 20:48:20 -07:00
2c5e8fdaee
Add detailed JSON & status codes for all error paths
2020-08-30 17:25:11 -07:00
ac604f25a1
feature: added shorthand for start command output option
2020-08-27 10:07:25 +10:00
d634a85ff9
use daemon info so this works for docker and podman
2020-08-24 17:50:09 -04:00
535294e523
fixed merge conflict
2020-08-24 17:35:03 -04:00
a767b64b41
fix merge conflict
2020-08-21 21:40:32 -04:00
88aece40d2
change name
2020-08-21 15:05:37 -04:00
97acf408e0
fix error wording
2020-08-21 13:34:06 -04:00
e9cfbd0098
add an new flag to stop command --keep-context-active
2020-08-21 10:27:28 -07:00
acd6589c5d
Remove debugging
2020-08-21 09:56:03 -04:00
44b93f4776
Change MemoryCapacity to StorageCapacity to be more accurate
2020-08-21 09:49:48 -04:00
482b2bf624
additional debugging
2020-08-20 17:23:04 -04:00
344a5be6d5
Merge pull request #9033 from vixus0/fix-start-memory-flag
...
Fix --memory flag parsing in minikube start
2020-08-20 14:05:42 -07:00
7eda3a7711
Create new exit code for InsufficientStorage
2020-08-20 15:27:06 -04:00
83eba00d47
add deubgging
2020-08-20 14:42:55 -04:00
6e8f596eac
Fix --memory flag parsing in minikube start
...
Due to the way Go handles variable scope, `mem` was being
redeclared inside the conditional. Outside, we were stuck with the value
provided by `suggestMemoryAllocation`, therefore ignoring the value
passed through the `--memory` flag.
2020-08-20 10:29:26 +02:00
906bcb9cab
fix typo miniube
...
$ sed -i 's/miniube start/minikube start/g' $(git grep -l 'miniube start')
Fixes : #9018
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 13:43:59 +08:00
1783cc2939
Make sure minikube status shows status name and details
2020-08-19 13:32:36 -04:00
3dba974535
Make sure 'minikube status' displays InsufficientStorage for cluster and nodes
...
if there is insufficient storage. Output now looks like:
```
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"StatusDetail": "/var is almost out of disk space",
"Step": "Starting Node",
"StepDetail": "Updating the running docker \"minikube\" container ...",
"BinaryVersion": "v1.12.3",
"Components": {
"kubeconfig": {
"Name": "kubeconfig",
"StatusCode": 500,
"StatusName": ""
}
},
"Nodes": [
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"Components": {
"apiserver": {
"Name": "apiserver",
"StatusCode": 405,
"StatusName": "Stopped"
},
"kubelet": {
"Name": "kubelet",
"StatusCode": 405,
"StatusName": "Stopped"
}
}
}
]
}
```
2020-08-19 13:25:48 -04:00
9708036592
Updated default cmd string when minikube is run as kubectl
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 21:20:50 +10:00
10a3f2e2a8
Running internal kubectl command when minikube is called as 'kubectl'
...
Fixes issue #8857
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 20:52:58 +10:00
51110dbbe8
Merge pull request #8969 from priyawadhwa/cpu-limit
...
skip validations if --force is supplied
2020-08-11 18:16:13 -04:00
f122deeaf3
suggest --force for k8s version
2020-08-11 15:42:05 -04:00
506279c585
change function name
2020-08-11 15:38:42 -04:00
a69b41932c
improve error handling
2020-08-11 14:56:19 -04:00
74309a83e6
include memory check
2020-08-11 14:22:10 -04:00
789dfca804
skip vaildations if --force is supplied
2020-08-11 14:16:40 -04:00
b0afc85327
dont fail on memory check if cpu and disk checks fail
2020-08-11 10:40:40 -07:00
84d198d8b5
refresh cache if there was error
2020-08-11 10:40:40 -07:00
5cb47d75af
return list of errors for cached host info
2020-08-11 10:40:40 -07:00
2b7aaa3f49
avoid duplicate warnings
2020-08-11 10:40:40 -07:00
8b6a0eb4fb
Merge pull request #8948 from kadern0/issue-8897
...
Added startHostTimeout flag
2020-08-11 10:36:21 -07:00
9354d2c0e5
Removed extra flag add.
...
Set default value if not specified by the user.
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-11 19:05:12 +10:00
ab77860c5e
fix typo
2020-08-10 16:21:58 -07:00
9373842ea1
Merge pull request #8885 from lingsamuel/ignore-localhost-proxy-with-scheme
...
Ignore localhost proxy started with scheme.
2020-08-10 12:13:15 -07:00
37a1d3bc0b
Added startHostTimeout flag
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-10 16:23:13 +10:00
e783af2bef
fill up cpu memory if config is missing
2020-08-04 13:26:33 -07:00
e87400db53
addres review comments
2020-08-04 13:26:33 -07:00
b71a7dceca
use cached hostinfo instead
2020-08-04 13:26:33 -07:00
d782f80e23
bring back check for dry run
2020-08-04 13:26:33 -07:00
e59a026450
update comments
2020-08-04 13:26:33 -07:00
71394c43e7
advice user when they allocate too much memory
2020-08-04 13:26:33 -07:00
5923634095
don't set event log on deletion
2020-08-03 14:22:13 -07:00
7ef3a8c11a
respect native-ssh flag
2020-08-03 09:48:30 -07:00
9b86b40536
misspelling
2020-07-30 22:16:32 -07:00
Priya Wadhwa
Sharif Elgamal
Anders F Björklund
Predrag Rogic
Thomas Strömberg
Ilya Zuyev
Medya Ghazizadeh
Medya Gh
Pablo Caderno
Priya Modali
Joshua Mühlfort
ToonvanStrijp
Asare Worae
loftkun
Dominik Braun
Predrag Rogic
Tacio Costa
vinu2003
Zadjad Rezai
Michael Ryan Dempsey
Anshul Sirur
Li Zhijian