Anders F Björklund
807bec0034
Merge branch 'master' into docker-env-ssh
2020-11-22 21:58:08 +01:00
Anders F Björklund
fee0f5310a
Add private network implementation for podman
...
Most of it the same as docker, except for the options.
i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
Daehyeok Mun
97db8b5f4c
Add number of nodes for cluster in `minikube profile list`
...
fixes \#6780
Add the Nodes column with the number of nodes the cluster has into
`minikube profile list` output.
2020-11-21 20:45:08 -08:00
Medya Gh
659e4ce1bd
lint
2020-11-20 15:47:02 -08:00
Medya Gh
301b24ab2e
lint
2020-11-20 15:45:39 -08:00
Medya Gh
b498e6b288
typo
2020-11-20 15:35:04 -08:00
Medya Gh
5a443f09fb
try reload dockerd first before restart
2020-11-20 15:31:05 -08:00
Anders F Björklund
bf73bcc4fe
Merge tag 'v1.15.1' into docker-env-ssh
...
1.15.1 Release
2020-11-19 17:11:02 +01:00
Priya Wadhwa
5a0ab905ed
fix merge conflict
2020-11-17 15:11:23 -08:00
Medya Ghazizadeh
8b39f56a60
Merge pull request #9510 from ilya-zuyev/gh_9463_non_dev_dockerhost
...
Support non-default docker endpoints
2020-11-17 10:17:33 -08:00
Priya Wadhwa
c4dd42a1d8
add --trace flag
2020-11-16 21:39:50 -08:00
Priya Wadhwa
0f23913f1b
Tracing compiles
2020-11-16 20:31:13 -08:00
Anders F Björklund
05427245cd
Merge tag 'v1.15.0' into docker-env-ssh
...
1.15.0 Release
2020-11-15 09:59:49 +01:00
Priya Wadhwa
1c682c6449
Merge branch 'master' of https://github.com/kubernetes/minikube into ss-windows
2020-11-13 16:34:45 -08:00
Medya Ghazizadeh
9b964853a9
Merge pull request #9672 from sadlil/driver-alias
...
Add Support for driver name alias
2020-11-13 16:18:05 -08:00
priyawadhwa
9438167b60
Merge pull request #9671 from Evalle/ISSUE-9664
...
Rename `out.T` to `out.Step`
2020-11-13 10:16:23 -08:00
Sadlil
d6c0256b3e
Add Support for driver name alias
2020-11-13 10:52:10 +00:00
Priya Wadhwa
21d5c01fc5
warn that this only works with docker right now
2020-11-12 14:32:23 -08:00
priyawadhwa
518ac7de56
Merge pull request #9503 from priyawadhwa/schedule-stop-unix
...
Implement schedule stop for unix
2020-11-12 14:20:20 -08:00
Priya Wadhwa
572e22d5a3
Merge branch 'master' of https://github.com/kubernetes/minikube into network-flag
2020-11-12 14:13:26 -08:00
Priya Wadhwa
ad85a7a57e
rename containernetwork to network
2020-11-12 10:36:41 -08:00
Evgeny Shmarnev
f88040aad9
Merge branch 'master' into ISSUE-9664
2020-11-12 13:47:12 +01:00
Evgeny Shmarnev
db93039f9c
Addressing comments
2020-11-12 13:45:33 +01:00
priyawadhwa
8731ff9f23
Merge pull request #9621 from priyawadhwa/json-int-test
...
Fix failing TestJSONOutput/start test
2020-11-11 14:14:57 -08:00
Priya Wadhwa
9bb9355b50
fix merge conflict
2020-11-11 11:57:27 -08:00
Medya Ghazizadeh
eb17495e5b
Merge pull request #9487 from prezha/status-add-watch-flag
...
add --watch flag for minikube status with optional interval duration
2020-11-11 11:50:43 -08:00
Sharif Elgamal
0f408d9d44
Merge pull request #9385 from bluestealth/8990
...
Improve parsing of start flag apiserver-names
2020-11-11 11:14:58 -08:00
Predrag Rogic
7cc4676d4a
move write statuses logic to a separate func
2020-11-11 00:29:25 +00:00
Predrag Rogic
95e6afb1b9
move write statuses logic to a separate func
2020-11-11 00:29:25 +00:00
Predrag Rogic
f57d9bfa73
add --watch flag for minikube status
2020-11-11 00:25:32 +00:00
Priya Wadhwa
5569817c26
Address code review comments
2020-11-10 10:58:31 -08:00
Priya Wadhwa
291e5b6927
fix merge conflict
2020-11-10 10:49:37 -08:00
Thomas Strömberg
b9615bf220
Merge pull request #9390 from prezha/json-output-cleanup
...
reword error message when cluster state exit code is not found
2020-11-10 10:27:25 -08:00
Thomas Strömberg
ea74ac9c1b
Merge pull request #9534 from vinu2003/fix_invalid_profile_creation
...
stop: removed setEventLogPath for stop process
2020-11-10 10:24:10 -08:00
Priya Wadhwa
253b0bafb1
Merge branch 'master' of https://github.com/kubernetes/minikube into json-int-test
2020-11-09 17:53:52 -08:00
Ilya Zuyev
76c62afddb
Fix unit tests for "podman-env --unset"
2020-11-09 14:21:42 -08:00
Ilya Zuyev
0f2c63881a
Merge branch 'master' into gh_9463_non_dev_dockerhost
2020-11-09 14:11:20 -08:00
Priya Wadhwa
7570cbd904
fix merge
2020-11-09 13:53:05 -08:00
Priya Wadhwa
635f2a71b5
fix lint
2020-11-09 13:52:51 -08:00
Ilya Zuyev
aa6a693142
Fix unit tests for "[docker|podman]-env --unset"
2020-11-09 13:44:52 -08:00
Priya Wadhwa
cf1ee6b072
Address review comments
2020-11-09 13:33:18 -08:00
Anders F Björklund
88b884378e
Show result from running the ssh-add command
2020-11-08 15:28:27 +01:00
Anders F Björklund
d2e2ecaf40
Add option to add the ssh key to the ssh agent
2020-11-08 15:23:41 +01:00
Predrag Rogic
432762f9e3
Update generate-docs test to include --help flag
2020-11-07 23:40:41 +00:00
Predrag Rogic
1a9a54e458
Update generate-docs test to include --help flag
2020-11-07 23:07:35 +00:00
Predrag Rogic
0c3843bfc6
call 'strings.ToLower(output)' only once
2020-11-06 22:28:26 +00:00
Priya Wadhwa
e050e8c9bd
Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix
2020-11-06 13:41:53 -08:00
Priya Wadhwa
ab98bbf858
Fix failing TestJSONOutput/start test
2020-11-06 13:34:50 -08:00
Medya Ghazizadeh
3bb967a0b4
Merge pull request #9506 from prezha/add-namespace-support
...
new flag --namespace
2020-11-06 12:20:09 -08:00
Medya Ghazizadeh
7747655476
Merge pull request #9535 from afbjorklund/podman2-env
...
Add support for podman v2 to podman-env command
2020-11-06 12:17:52 -08:00
Priya Wadhwa
cca624698e
switch exit to warning
2020-11-06 12:17:48 -08:00
Priya Wadhwa
a00b7a38e2
Use DurationVar instead of StringVar for flag
2020-11-06 11:58:21 -08:00
Priya Wadhwa
7788cb93d8
Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix
2020-11-06 11:38:26 -08:00
Predrag Rogic
7d99c66efa
fix help flag 'pflag: help requested' error
2020-11-06 02:42:52 +00:00
Priya Wadhwa
19b2be23bc
fix merge conflict
2020-11-05 14:31:39 -08:00
Priya Wadhwa
f869ca5e91
fix merge conflict
2020-11-05 09:44:47 -08:00
Predrag Rogic
d49f4173b3
update --namespace flag description
2020-11-04 22:14:00 +00:00
Predrag Rogic
3427f078c3
add support for namespace
2020-11-04 22:13:45 +00:00
Michael Ryan Dempsey
7a133bd17e
improve parsing of start flag apiserver-names
2020-11-03 10:59:26 -08:00
vinu2003
ec8e2a4f9c
Added check to verify profile path exists
2020-11-03 23:25:32 +11:00
Anders F Björklund
274be7f52d
Split template for docker tcp and ssh in two vars
2020-11-01 15:15:06 +01:00
Anders F Björklund
bfefa72815
Split template for podman v1 and v2 into two vars
2020-11-01 15:14:20 +01:00
Anders F Björklund
b57bf9abcf
Refactor dockerUnsetScript with a helper function
2020-11-01 15:07:02 +01:00
Martin Schimandl
4da751f5d7
Make none driver work as regular user (use sudo on demand)
2020-11-01 14:54:20 +01:00
Anders F Björklund
9f983a8f99
Refactor podmanUnsetScript with a helper function
2020-11-01 14:46:13 +01:00
Predrag Rogic
20a1274c7c
implement "--log_file" and "--log_dir" for klog
2020-10-31 19:57:25 +00:00
vinu2003
bfd2da1b65
removed setEventLogPath for stop process
2020-10-31 18:12:39 +11:00
Ilya Zuyev
69c2b01660
Fix shell arg parsing
2020-10-30 14:39:59 -07:00
Priya Wadhwa
3c8d3cad7c
Merge branch 'master' of https://github.com/kubernetes/minikube into json-output-stop
2020-10-29 13:44:32 -07:00
Priya Wadhwa
39ab9ffc5b
Add --output flags to pause and unpause as well
2020-10-28 13:16:17 -07:00
Sharif Elgamal
5c5a8e160a
account for not setting context, remove debugging
2020-10-28 12:44:58 -07:00
Sharif Elgamal
4a1c9583bd
initial attempt to account for profile in directly kubectl case
2020-10-28 12:16:02 -07:00
Priya Wadhwa
473120648f
Add JSON output to minikube stop
2020-10-28 11:30:11 -07:00
Ilya Zuyev
e0b4957fcc
Fix docker-env -u shell detection
2020-10-27 16:48:20 -07:00
Priya Wadhwa
02f03af101
exit if using --schedule with windows as it is not yet supported
2020-10-26 15:17:24 -07:00
Sharif Elgamal
055de4edf8
return stopped profile status quickly
2020-10-26 13:20:03 -07:00
Priya Wadhwa
ea6ca08d67
Change flag name to --network and exit if used without docker driver
2020-10-26 11:52:26 -07:00
Anders F Björklund
7841aea2db
Optionally use ssh for docker-env instead of tcp
...
Since Docker 18.09, it supports ssh: as well as tcp:
for connecting to the docker daemon (in $DOCKER_HOST).
This avoids setting up certificates, but leaves key
handling (host keys and identity keys) to ssh config.
2020-10-25 14:16:28 +01:00
Priya Wadhwa
865d3a4a34
Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix
2020-10-23 18:15:07 -07:00
Priya Wadhwa
fe2710705e
Add --docker-network flag
2020-10-23 09:31:33 -07:00
Anders F Björklund
716d793990
Add support for podman v2 to podman-env command
...
Podman v1 (like 1.9.3) uses the varlink bridge,
while podman v2 (like 2.1.x) uses a REST API.
Both are using ssh for their transport, but the
environment variables exported are different.
2020-10-23 11:46:45 +02:00
Predrag Rogic
d0c0d8b54c
revert suppression of emitting errors to stderr
2020-10-22 09:28:31 +01:00
Thomas Strömberg
dedf38b61f
Merge pull request #9368 from kadern0/issue-8445
...
Added deprecation warning for --network-plugin=cni
2020-10-21 08:53:50 -07:00
Ilya Zuyev
85d45be207
Fix docker-env command
2020-10-20 23:10:08 -07:00
Priya Wadhwa
a54ea82e3b
Implement schedule stop for unix
2020-10-20 13:45:59 -07:00
Predrag Rogic
e7f9b3e954
don't pollute json output with errors
...
additionally:
- issue warning insted of error if 'exitCode' is not found
- rebase: use klog instead of glog
don't pollute status json output with errors
2020-10-18 19:56:28 +01:00
Medya Ghazizadeh
29f00628f5
Merge pull request #9459 from medyagh/stopped_kubelet
...
new --wait component "kubelet"
2020-10-15 12:25:11 -05:00
Sharif Elgamal
06a64de853
Merge pull request #9417 from joshmue/fix_ssh_native_toggle
...
Fix "--native-ssh" flag of "minikube ssh"
2020-10-14 10:30:51 -07:00
Medya Gh
63c4468fd5
address review comments
2020-10-13 16:01:59 -07:00
Pablo Caderno
1d85d6e123
Add warning for --network-plugin=cni (CNI has to be provided, see --cni)
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-10-12 19:27:25 +11:00
Priya Modali
59548194bd
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-09 17:45:35 -07:00
Joshua Mühlfort
8cfe5c1a7b
Fix "--native-ssh" flag of "minikube ssh"
...
In the previous state, the flag was discarded. This commit fixes
that and also makes sure that the SSH client is created after the
default client type is configured according to the flag.
2020-10-09 09:41:19 +02:00
Priya Modali
2985e8a21e
Updating unit tests.
2020-10-08 15:10:50 -07:00
Medya Ghazizadeh
c459fea74d
Merge pull request #9414 from prezha/delete-context-when-stopped
...
Delete context when stopped
2020-10-08 15:12:50 -05:00
Priya Modali
ab4a0ab558
Cleaning up flags parsing.
2020-10-08 11:18:50 -07:00
Medya Ghazizadeh
32922f4184
Merge pull request #9412 from Asarew/fix-panic-on-updating-mount-after-creation
...
fix panic when updating mount-string with KiC driver after cluster creation without mount configuration
2020-10-08 13:07:31 -05:00
Priya Modali
ef2090ac31
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-08 10:27:04 -07:00
Predrag Rogic
c63de60aba
add HostKubeconfigDeleteCtx Reason Exit
2020-10-07 22:58:20 +01:00
Priya Modali
85b722c7b6
Setting klog default flag values.
2020-10-07 14:19:35 -07:00
Predrag Rogic
65a2618485
delete context when minikube is stopped
2020-10-07 22:00:26 +01:00
Medya Ghazizadeh
e573b928d5
Merge pull request #9404 from ToonvanStrijp/master
...
Add new flag "--ports" to expose ports for docker & podman drivers
2020-10-07 15:56:29 -05:00
ToonvanStrijp
96d7fc4bc0
fix lint tabs
2020-10-07 19:40:59 +02:00
ToonvanStrijp
50c37577fd
update flag to ports
2020-10-07 18:08:08 +02:00
Asare Worae
93bbf4c399
little bit of clean up
2020-10-07 10:22:53 +02:00
Asare Worae
e8a0487e11
fix panic when updating mount-string with docker driver after cluster creation without mount configuration
2020-10-07 09:53:06 +02:00
Thomas Stromberg
615f233c77
Remove reference to Virtualbox in "stop" help
2020-10-06 21:07:02 -07:00
Medya Ghazizadeh
d7c517471d
Merge pull request #9316 from priyawadhwa/preload-disk-full
...
preload: print solution message when there is no space left on device
2020-10-06 19:10:53 -05:00
Priya Modali
3703f69c25
Applying klogFlags set via cobra.
2020-10-06 11:20:51 -07:00
priyawadhwa
aae7784309
Merge pull request #9383 from priyawadhwa/status-bg
...
Fix minikube status bug when cluster is paused
2020-10-06 11:22:13 -04:00
ToonvanStrijp
dcf9dd10c6
add docker-ports flag
2020-10-06 13:37:03 +02:00
Medya Ghazizadeh
5614ed0edc
Merge pull request #9367 from medyagh/pname_length
...
don't allow profile name to be less than 2 characters
2020-10-05 18:14:15 -05:00
Medya Gh
dc0918e6ba
review comments
2020-10-05 16:13:21 -07:00
Priya Wadhwa
4cff79008c
fixed merge conflict
2020-10-05 11:47:53 -04:00
Anders F Björklund
e36c937a34
Do some simple cleanup of the golint complaints
...
The "magic strings" and enums still needs another approach
Simply echoing everything twice doesn't seem very useful ?
2020-10-04 13:40:33 +02:00
Priya Wadhwa
7d62ce1c1c
convert from exit codes to http codes if appropriate
2020-10-03 15:29:15 -04:00
Priya Wadhwa
7046998831
If insufficient storage is the issue, then show that in status
2020-10-02 17:48:52 -04:00
Priya Modali
4c6af8812f
Added error handler.
2020-10-02 14:28:50 -07:00
Priya Modali
43cc1a2581
Resolved merg conflicts.
2020-10-02 14:10:55 -07:00
Priya Modali
8809387628
Adjusting klog initialization to not emit INFO logs by default.
2020-10-02 10:52:57 -07:00
Priya Modali
af5fbf7880
Backup snapshot of changes.
2020-10-02 10:44:24 -07:00
Medya Ghazizadeh
0fc0c82337
Merge pull request #9294 from medyagh/docker_network
...
add dedicated network for docker driver
2020-10-01 14:11:42 -05:00
Medya Ghazizadeh
bebad76bd0
Merge pull request #8978 from taciomcosta/master
...
fix: "profile list" shows paused clusters as "Running"
2020-10-01 14:09:30 -05:00
Medya Gh
f71272ca79
don't allow profile name to be less than 2 characters
2020-09-30 17:22:45 -07:00
Priya Wadhwa
6538306d14
move exit into separate function
2020-09-30 15:31:44 -04:00
Priya Wadhwa
db23825bfc
Move exit.Message function so that we aren't exiting from a library
2020-09-30 15:19:06 -04:00
Priya Wadhwa
6e91d719dd
Revert status code cmd
2020-09-29 19:38:12 -04:00
Priya Modali
43ea47f4e0
Fixed merge conflicts.
2020-09-29 16:17:31 -07:00
Priya Modali
97d96bf925
Switching from glob library to klog library.
2020-09-29 15:49:41 -07:00
Medya Gh
b84dedc652
address review comments
2020-09-29 15:07:06 -07:00
Medya Gh
b7780ec815
address review comments
2020-09-29 14:14:25 -07:00
Medya Gh
f0f10d6135
first version
2020-09-29 14:14:24 -07:00
Priya Wadhwa
a05dc6516b
Revert bug in `minikube status`
...
When the cluster is Paused, `minikube status` currently says that it is `Running`. Reverting a change I made in a previous PR to take the status of the apiserver should fix this.
2020-09-29 16:56:15 -04:00
Anders F Björklund
e6b510543e
Don't trim whitespace while extracting strings
...
Remove some leading and trailing whitespace from non-string
constructs like description and automatic extraction filters.
But don't change all the translations or the translations here,
since that would make this code change impossible to review.
2020-09-27 17:59:06 +02:00
Sharif Elgamal
11cad2b3e6
Merge pull request #9321 from loftkun/removing-duplicate-command-additions
...
Remove duplicate command additions
2020-09-25 14:03:48 -07:00
Thomas Strömberg
75332f7c89
Merge pull request #8901 from bluestealth/MiB
...
Use mebibytes instead of megabytes
2020-09-25 11:28:41 -07:00
Thomas Strömberg
ed6b756da0
Merge pull request #9308 from priyawadhwa/performance-monit
...
Add PR bot code to repo
2020-09-25 10:34:36 -07:00
loftkun
7a2cd0f459
Removing Duplicate Command Additions
2020-09-25 17:45:51 +09:00
Priya Wadhwa
3ee1eb029c
Update test to use new exit code for insufficient storage
2020-09-24 14:09:46 -04:00
Sharif Elgamal
fd44e0d8fb
Force dependency on exp to prevent dirty commit release binaries ( #9309 )
...
* force dependency for release purposes
* revert original idea and add loads of debugging
* hey more debugging cool
* fix debugging
* drilling down debugging
* revert to original solution
* fix comment
2020-09-23 15:00:03 -07:00
Medya Ghazizadeh
183bdb2354
Merge pull request #9302 from dominikbraun/#9297-reason-for-missing-config-permissions
...
Return ExHostPermission for insufficient config file permissions
2020-09-23 14:20:41 -05:00
Medya Ghazizadeh
07642cd7ef
Merge pull request #9300 from ilya-zuyev/gh8891_forbid_base_image_for_vm_drivers
...
Disable base image flag for vm drivers
2020-09-23 14:10:38 -05:00
Ilya Zuyev
887390194e
Add more unit tests
2020-09-22 14:19:38 -07:00
Ilya Zuyev
bf8ec63ca9
Simplify base-image flag validation
2020-09-22 14:10:47 -07:00
Ilya Zuyev
76d3c9d7bb
Fix variable name (avoid collision with imported package)
2020-09-22 13:09:58 -07:00
Priya Wadhwa
3d547a937f
Fix Makefile rule to build bot
2020-09-22 14:00:27 -04:00
Priya Wadhwa
3f44d470eb
Add performance monitor code
2020-09-22 13:54:23 -04:00
Dominik Braun
8f4127b202
Use HOST_HOME_PERMISSION kind for insufficient permissions
2020-09-22 18:04:24 +02:00
Dominik Braun
603ae8fc6d
Return ExHostPermission for insufficient config file permissions
2020-09-22 10:16:27 +02:00
Ilya Zuyev
6a60983679
Show invalid flag diagnostic message to user
2020-09-21 23:28:34 -07:00
Ilya Zuyev
6bf7ca3dd2
Validate --base-image flag and active driver combo
2020-09-21 23:06:54 -07:00
Predrag Rogic
9fbd2e94bd
update-context: Automatically set the context as current/active in kubeconfig
2020-09-21 00:06:15 +01:00
Medya Ghazizadeh
b9f3638f2a
Merge pull request #9233 from afbjorklund/nic-type
...
Fix copy/paste error in virtualbox nic-type help
2020-09-15 16:05:52 -07:00
Anders F Björklund
48d44221a9
Don't validate Docker storage driver for Podman
...
For podman, "overlay" and "overlay2" are the same
2020-09-13 22:28:17 +02:00
Anders F Björklund
37e521272c
Fix copy/paste error in virtualbox nic-type help
...
It used type "host only" twice, instead of "nat".
2020-09-13 17:25:02 +02:00
Sharif Elgamal
ee5b8f130f
Merge pull request #8831 from priyawadhwa/overlay
...
Set preload=false if not using overlay2 as docker storage driver
2020-09-09 11:45:52 -07:00
Thomas Strömberg
c4663b8417
Merge pull request #9181 from tstromberg/m1
...
Add Docker Desktop instructions if memory is >minimum but <recommended
2020-09-08 14:25:13 -07:00
priyawadhwa
b4400ad70a
Merge pull request #8904 from Xcalizorz/master
...
fixes(#8301 ): --help: bool flags which default to 'false' yield confusing output
2020-09-08 13:50:10 -04:00
Tacio Costa
4708f6215c
fix: profile list shows paused clusters as Running
2020-09-05 18:37:24 -03:00
Thomas Stromberg
f15fd81333
Add Docker Desktop instructions if memory is >minimum but <recommended
2020-09-03 11:39:14 -07:00
Thomas Stromberg
54443bd337
Update min*Mem constants to use MiB instead of MB
2020-09-03 11:34:40 -07:00
Asare Worae
e20223d598
quote variables in GuestMountConflict warning
2020-09-03 18:39:31 +02:00
Asare Worae
4e772347d4
exit on existing cluster start with KiC driver mount configuration change
2020-09-03 18:25:10 +02:00
Asare Worae
229969aa54
fix grammer
2020-09-03 10:02:07 +02:00
Asare Worae
5ae5be7141
fixed misuse of template variable
2020-09-03 10:01:19 +02:00
Asare Worae
2b2220ac8b
added warning for changing mount configuration with KiC dirver on existing cluster
2020-09-03 09:51:11 +02:00
Thomas Strömberg
dab20a2e12
Merge pull request #9163 from tstromberg/driver-advice
...
docker: Improve overlay module check (behavior & UX)
2020-09-02 14:56:04 -07:00
Thomas Strömberg
d1431fe0e5
Merge pull request #9167 from tstromberg/kubectl-advice
...
Simplify kubectl advice messaging
2020-09-02 14:12:17 -07:00
Sharif Elgamal
830af29223
Merge pull request #9144 from tstromberg/confusing-warning
...
Remove conflicting & inaccurate Docker Desktop memory warning
2020-09-02 14:01:33 -07:00
Thomas Stromberg
4e9a3975df
Simplify kubectl advice messaging
2020-09-02 13:35:40 -07:00
Thomas Stromberg
0d4ef00210
Use out.T for a simpler layout
2020-09-02 10:56:06 -07:00
Thomas Stromberg
08d874a4a2
Reduce performance-advice message to a single line
2020-09-02 10:38:45 -07:00
Priya Wadhwa
ea5af644ec
fix merge conflict
2020-09-02 09:31:42 -04:00
vinu2003
2b8c48cc59
start: fixed the type value for kubectl version mismatch to warning
2020-09-02 21:17:13 +10:00
Zadjad Rezai
eff63d7382
chore( #8301 ): Changes https-flag description
2020-09-02 10:24:12 +02:00
Thomas Strömberg
dc5951451b
Merge pull request #8872 from kadern0/issue-8857
...
Running internal kubectl command when minikube is called as 'kubectl'
2020-09-01 22:44:44 -07:00
Thomas Strömberg
d66a8e68c9
Merge pull request #8907 from sharifelgamal/external-ssh
...
respect native-ssh flag
2020-09-01 22:37:37 -07:00
Michael Ryan Dempsey
1859274e8a
refactor conversion functions into util
2020-09-01 21:21:07 -07:00
Michael Ryan Dempsey
ad1e2e2de5
Use same conversion logic for bytes -> MiB everywhere
2020-09-01 21:20:09 -07:00
Thomas Strömberg
8a26881552
Merge pull request #8159 from Asarew/docker-host-volumes
...
Support for mounting host volumes on start with docker driver
2020-09-01 16:30:45 -07:00
Thomas Stromberg
f69c6c5773
Remove conflicting & possibly inaccurate Docker Desktop specific memory warning
2020-09-01 08:40:00 -07:00
Thomas Stromberg
8ef7410066
Shorten Docker memory warning
2020-08-30 21:04:10 -07:00
Thomas Stromberg
cd91fb8470
Unwrap unnecessary level of error annotation for improved messages
2020-08-30 20:48:20 -07:00
Thomas Stromberg
2c5e8fdaee
Add detailed JSON & status codes for all error paths
2020-08-30 17:25:11 -07:00
vinu2003
ac604f25a1
feature: added shorthand for start command output option
2020-08-27 10:07:25 +10:00
Priya Wadhwa
d634a85ff9
use daemon info so this works for docker and podman
2020-08-24 17:50:09 -04:00
Priya Wadhwa
535294e523
fixed merge conflict
2020-08-24 17:35:03 -04:00
Priya Wadhwa
a767b64b41
fix merge conflict
2020-08-21 21:40:32 -04:00
Priya Wadhwa
88aece40d2
change name
2020-08-21 15:05:37 -04:00
Priya Wadhwa
97acf408e0
fix error wording
2020-08-21 13:34:06 -04:00
Medya Gh
e9cfbd0098
add an new flag to stop command --keep-context-active
2020-08-21 10:27:28 -07:00
Priya Wadhwa
acd6589c5d
Remove debugging
2020-08-21 09:56:03 -04:00
Priya Wadhwa
44b93f4776
Change MemoryCapacity to StorageCapacity to be more accurate
2020-08-21 09:49:48 -04:00
Priya Wadhwa
482b2bf624
additional debugging
2020-08-20 17:23:04 -04:00
Thomas Strömberg
344a5be6d5
Merge pull request #9033 from vixus0/fix-start-memory-flag
...
Fix --memory flag parsing in minikube start
2020-08-20 14:05:42 -07:00
Priya Wadhwa
7eda3a7711
Create new exit code for InsufficientStorage
2020-08-20 15:27:06 -04:00
Priya Wadhwa
83eba00d47
add deubgging
2020-08-20 14:42:55 -04:00
Anshul Sirur
6e8f596eac
Fix --memory flag parsing in minikube start
...
Due to the way Go handles variable scope, `mem` was being
redeclared inside the conditional. Outside, we were stuck with the value
provided by `suggestMemoryAllocation`, therefore ignoring the value
passed through the `--memory` flag.
2020-08-20 10:29:26 +02:00
Li Zhijian
906bcb9cab
fix typo miniube
...
$ sed -i 's/miniube start/minikube start/g' $(git grep -l 'miniube start')
Fixes : #9018
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 13:43:59 +08:00
Priya Wadhwa
1783cc2939
Make sure minikube status shows status name and details
2020-08-19 13:32:36 -04:00
Priya Wadhwa
3dba974535
Make sure 'minikube status' displays InsufficientStorage for cluster and nodes
...
if there is insufficient storage. Output now looks like:
```
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"StatusDetail": "/var is almost out of disk space",
"Step": "Starting Node",
"StepDetail": "Updating the running docker \"minikube\" container ...",
"BinaryVersion": "v1.12.3",
"Components": {
"kubeconfig": {
"Name": "kubeconfig",
"StatusCode": 500,
"StatusName": ""
}
},
"Nodes": [
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"Components": {
"apiserver": {
"Name": "apiserver",
"StatusCode": 405,
"StatusName": "Stopped"
},
"kubelet": {
"Name": "kubelet",
"StatusCode": 405,
"StatusName": "Stopped"
}
}
}
]
}
```
2020-08-19 13:25:48 -04:00