Commit Graph

3369 Commits (e126545ff61010ad5c008f267d32ae17260462a9)

Author SHA1 Message Date
Predrag Rogic 6731cdee84
Merge branch 'kubernetes:master' into ha 2024-01-09 22:18:49 +00:00
Steven Powell 907aa9b065 addons auto-pause: Revert cleanup on ticker allocations 2024-01-08 16:10:12 -08:00
Steven Powell 77ac34b1d7 addons: Fix auto-pause addon 2024-01-08 16:09:45 -08:00
Predrag Rogic ad7fb3992c
support kubernetes ha cluster topology in minikube 2024-01-07 21:36:17 +00:00
Predrag Rogic 4818ef54de
fix TestValidatePorts 2024-01-06 16:57:15 +00:00
minikube-bot d6ff58a7e3 Update go-github from v56.0.0 to v57.0.0 2023-12-04 10:02:54 +00:00
Steven Powell 6b0f6a676b fix no-limit not being respected on restart 2023-11-09 09:31:57 -08:00
Steven Powell 5fedf0ee11
Merge pull request #17516 from spowelljr/installNividaInKicbase
Kicbase: Install NVIDIA container toolkit during image build
2023-11-03 10:20:17 -07:00
Steven Powell 483ae12499
Merge pull request #17530 from spowelljr/fixNoLimitConfigValidation
Fix no-limit option for config validation
2023-11-02 11:53:30 -07:00
Steven Powell 2446584e90 only install on supported archs 2023-11-01 16:28:44 -07:00
Steven Powell 197b9343b0 fix lint issues 2023-11-01 11:45:09 -07:00
Steven Powell 407c000c6e Fix no-limit option for config validation 2023-10-30 14:59:36 -07:00
Akihiro Suda 4c2180ab68
rootless: support `--container-runtime=docker`
This allows running Kubernetes with (CRI-)Dockerd in Rootless Docker:
```
minikube start --rootless --driver=docker --container-runtime=docker
```

It is still recommended to use `--container-runtime=containerd`.

Fix issue 17322

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-10-30 08:28:40 +09:00
Steven Powell a678fe11bd Add "no-limit" option to cpus & memory flags 2023-10-25 16:10:22 -07:00
minikube-bot 4e6349ef81 Update go-github from v55.0.0 to v56.0.0 2023-10-13 16:44:16 +00:00
Steven Powell f1e05f1945 add g shorthand for gpus 2023-10-05 17:18:31 -07:00
Steven Powell 8266558cf4 update TestValidateGPUs 2023-10-05 17:18:30 -07:00
Steven Powell 55b78ed5cf change gpus flag from bool to string 2023-10-05 17:18:30 -07:00
Steven Powell 76c1fd4dc4 fix possible nil reference in test 2023-10-05 17:18:30 -07:00
Steven Powell ab6a4539bd added unit test for validate func 2023-10-05 17:18:30 -07:00
Steven Powell 311630cea9 fix gpus flag not getting passed to docker 2023-10-05 17:18:30 -07:00
Steven Powell 7f5fbf98fe Automate installing NVIDIA Container Toolkit w/ flag 2023-10-05 17:18:30 -07:00
Steven Powell 53b09081b4 Automate installing NVIDIA Container Toolkit 2023-10-05 17:18:28 -07:00
Steven Powell 79d368e2e8 Fix shorthand when not needed 2023-10-04 15:35:13 -07:00
Medya Ghazizadeh 6dd875c171
Merge pull request #17324 from spowelljr/fixEnablingAddon
Fix enabling & disabling addons with non-existing cluster
2023-10-04 11:45:41 -07:00
Medya Ghazizadeh daf0e6617b
Merge pull request #17325 from spowelljr/checkForHyperVMemoryValidation
Add Hyper-V memory validation for odd numbers
2023-10-04 11:43:26 -07:00
Steven Powell 863f70d57d fix delete if CRI doesn't exist 2023-10-03 16:02:37 -07:00
Steven Powell 816de95c24 suggest memory value 2023-10-02 14:21:36 -07:00
Steven Powell 0292755ea8 Add Hyper-V memory validation 2023-09-29 16:32:27 -07:00
Steven Powell e57a3f8718 Fix enabling & disabling addons with non-existing cluster 2023-09-29 13:03:13 -07:00
Steven Powell 5b5bb38ec2 Fix updating auto-pause-duration 2023-09-25 16:54:38 -07:00
Medya Ghazizadeh ccbd6cfe5d
Merge pull request #17070 from wzslr321/auto-pause-time-config
configure auto-pause-interval addon
2023-09-06 11:37:02 -07:00
minikube-bot 9cd668110f Update go-github from v54.0.0 to v55.0.0 2023-09-05 21:49:30 +00:00
Wiktor Zając f3a784e33a fix imports ordering to reslolve inter issue; make lint passess now 2023-08-31 06:36:27 +02:00
minikube-bot e54dfab81b Update go-github from v53.2.0 to v54.0.0 2023-08-17 22:56:45 +00:00
Steven Powell 5753ca0768
Merge pull request #16865 from JudahNour/makeErrorBetter
--kubernetes-version add support for checking github k8s versions and exit nicely on error
2023-08-17 15:07:58 -07:00
Steven Powell 4f6288a954 Release v1.31.2 2023-08-16 11:23:41 -07:00
Steven Powell 859325e449
Merge pull request #17030 from spowelljr/fixAppendKnow
Fix calling appendKnownHelper when not needed
2023-08-16 11:03:29 -07:00
Wiktor Zając 18dcacdb98 make names consistent - auto-pause-interval 2023-08-16 19:52:04 +02:00
Wiktor Zając 45c3a40fa1 configure auto-pause-interval addon 2023-08-16 19:39:30 +02:00
Steven Powell a3fe75ddce temp: only run on containerd to fix regression 2023-08-14 13:24:57 -07:00
Steven Powell 1c430a46ac
Merge pull request #16934 from sethrylan/fix-16933
Add mkdir for `~/.ssh` directory.
2023-08-10 10:16:26 -07:00
Steven Powell a54049c317 only add envs to command is using containerd 2023-08-09 10:51:06 -07:00
Steven Powell 0fb13b8fce Fix calling appendKnownHelper when not needed 2023-08-09 10:46:08 -07:00
Steven Powell 04070a14b7 Fix version mismatch error 2023-08-02 13:37:45 -07:00
Anders F Björklund 15b4b37bc1 Change the wording of the docker storage warning
The preload is currently only available for overlay2,
so when using another storage driver it will not be used.
2023-07-31 15:16:37 +02:00
Seth Rylan Gainey 2587f3ffdf
Add mkdir for ssh directory. 2023-07-21 23:03:48 +00:00
Steven Powell 473bba4c0e renamed test variable 2023-07-20 10:23:16 -07:00
Steven Powell d5192ce196 Release v1.31.1 2023-07-19 13:48:20 -07:00
Judah Nouriyelian af9184b712 fix duplication 2023-07-14 18:06:04 +00:00
Judah Nouriyelian c7b2561134 Merge branch 'master' of github.com:JudahNour/minikube into makeErrorBetter 2023-07-14 17:22:36 +00:00
Steven Powell 08216d673c
Merge pull request #15519 from msharran/issue/15338
`minikube cp` now supports providing directory as a target
2023-07-14 10:10:04 -07:00
Steven Powell a4a1ba5381
Merge pull request #15868 from norshtein/addon
Don't allow enabling addon on a paused cluster
2023-07-14 10:06:10 -07:00
Steven Powell 085433cd1b
Merge pull request #16852 from aiyijing/fix/subcmd-unable-translate
fix subcommand cannot be translated
2023-07-13 14:40:57 -07:00
Judah Nouriyelian a9b59726fb Merge branch 'makeErrorBetter' of github.com:JudahNour/minikube into makeErrorBetter 2023-07-13 20:38:36 +00:00
Judah Nouriyelian ed906c2d78 adding added files to automation for github package 2023-07-13 20:26:02 +00:00
Judah Nouriyelian aa0a915606 create separate message for internet search 2023-07-13 20:26:02 +00:00
Judah Nouriyelian 6c9b4b21b7 refactor code and fix typos 2023-07-13 20:26:02 +00:00
Judah Nouriyelian 7ebd7765e7 use GetReleaseByTag to speed up version searching 2023-07-13 20:26:02 +00:00
Judah Nouriyelian f0ba2185c5 add support for checking github k8s versions 2023-07-13 20:26:01 +00:00
Judah Nouriyelian 42552bfc3d adding added files to automation for github package 2023-07-13 20:11:33 +00:00
Sharran 955d386541 path lint fix 2023-07-14 01:14:21 +05:30
Sharran 4e2e2f233c fix commit mail id 2023-07-14 00:28:11 +05:30
Steven Powell b8801c3306
Update cmd/minikube/cmd/root.go 2023-07-12 16:10:55 -07:00
AiYijing 164a522b60
Update cmd/minikube/cmd/root.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-07-13 06:39:32 +08:00
AiYijing 67c3d13f1f
Update cmd/minikube/cmd/root.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-07-13 06:36:09 +08:00
Tongyao Si 06fb28c2c3 chore: rename CheckPaused to VerifyNotPaused 2023-07-12 13:26:02 -07:00
Tongyao Si 5c46b3a555 make error message more clear 2023-07-12 13:25:17 -07:00
Judah Nouriyelian c205355974 create separate message for internet search 2023-07-12 19:53:27 +00:00
Judah Nouriyelian 111acc8652 refactor code and fix typos 2023-07-12 19:27:36 +00:00
Judah Nouriyelian a3bf35384a use GetReleaseByTag to speed up version searching 2023-07-12 17:10:52 +00:00
Steven Powell 9502f96cae fix lint 2023-07-12 10:01:12 -07:00
Bogdan Luca 380359c0ef feat: vmware driver support for new minikube iso 2023-07-12 09:40:01 -07:00
Steven Powell 926cfe4469
Merge pull request #16789 from spowelljr/detectBlock
QEMU: Unblock bootpd if start fails to due to blocking
2023-07-11 15:40:52 -07:00
Steven Powell d1276604ad fix lint error 2023-07-11 13:40:47 -07:00
Judah Nouriyelian 54d1939b9b add support for checking github k8s versions 2023-07-11 14:48:57 +00:00
Steven Powell 47b5190e70
Merge branch 'master' into docker-env 2023-07-10 16:26:41 -07:00
Medya Ghazizadeh d18f2762d7
Merge pull request #16850 from aiyijing/fix/unable-translate-group-msg
fix group message can't be translated
2023-07-10 12:15:56 -07:00
aiyijing f601318df7 fix subcommand cannot be translated
Signed-off-by: aiyijing <aiyijing@live.com>
2023-07-09 22:54:25 +08:00
aiyijing 6d0c25e0c0 fix group message can't be translated
Signed-off-by: aiyijing <aiyijing@live.com>
2023-07-09 21:43:56 +08:00
Steven Powell 763215d496 tunnel: Allow one tunnel per profile 2023-07-07 10:12:11 -07:00
Товарищ программист a814542ad3 feat: use automated ssh-agent in docker-env 2023-07-07 00:35:43 +08:00
Товарищ программист 3d1b44055a Add auto add-host and ssh-agent for docker-env 2023-07-02 02:52:41 +08:00
Товарищ программист df8154a5e5 Apply suggestions from code review
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-07-02 02:08:43 +08:00
Товарищ программист e1f77e8f40 Apply suggestions from code review
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-07-02 02:08:27 +08:00
minikube-bot c8d30c3331 Updating kicbase image to v0.0.39-1682028460-15452 2023-07-02 02:08:27 +08:00
Товарищ программист 508adea11f feat: direct image build on containerd via docker-env 2023-07-02 02:08:27 +08:00
Steven Powell 7ba7f7b868
Merge pull request #16761 from spowelljr/sshAgent
Add ability to start & stop ssh-agent process
2023-06-30 13:40:16 -07:00
cui fliter 6f881a7ed6 fix function name in comment
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-06-28 11:59:22 +08:00
Steven Powell 084630dfd3 Unblock bootpd if detected blocked 2023-06-26 14:13:53 -07:00
Steven Powell ca7e0fd59d fix unset tests 2023-06-26 10:54:00 -07:00
Steven Powell 78720ca145 add to SSH template 2023-06-26 10:13:29 -07:00
Steven Powell f417e18928 fix tests 2023-06-23 10:03:43 -07:00
Steven Powell 78730bfaf8 fix name stuttering 2023-06-22 17:09:06 -07:00
Steven Powell f9c89f84e5 Add ability to start & stop ssh-agent process 2023-06-22 17:05:46 -07:00
Steven Powell 6ef429550e QEMU: Made firewall detction simplier and more robust 2023-06-22 14:57:39 -07:00
Medya Ghazizadeh a209cfb661
Merge pull request #16714 from spowelljr/unblock
qemu on maos :Auto unblock bootpd from firewall for socket_vmnet network driver
2023-06-22 10:31:21 -07:00
Steven Powell 29a32586a2 socket_vmnet: Auto unblock bootpd from firewall 2023-06-14 17:06:46 -07:00
Medya Ghazizadeh cc91ebfd6f
Merge pull request #15003 from kpiljoong/fixes/13487
Fix to prevent accepting addons flag when no kubernetes
2023-06-14 11:58:41 -07:00
Oldřich Jedlička 6d28d2aa5f Fix kubectl tab-completion and improve error messages
Try to fix the following issues when `kubectl` is an alias for
`minikube kubectl --` and tab-completion for `kubectl` is enabled:

 1. When `--cluster name` form of command-line option is used, it
    conflicts with argument parsing, `name` is interpreted as plugin name.
    Call to `kubectl --cluster test help` leads to error `Error: flags
    cannot be placed before plugin name: --cluster`. Fix this by using
    `--cluster=name` form, which is correctly handled also in call
    `kubectl --cluster=test help`.
 2. When `--cluster=name` is added as first argument (as seen in original
    code), it still leads to error mentioned above when the command is
    unknown like in the call `kubectl --cluster=test unknown`. Fix this by
    inserting `--cluster=name` after all (sub-)commands and before any
    flags/options.
 3. The original code passed `--cluster=name` to normal `kubectl` calls,
    but omitted it for tab-completion calls. This might lead to wrong tab
    suggestions about pods, deployments and the like. Fix this by always
    adding `--cluster=name` option to the command line.
 4. In case of tab-completion, put the `--cluster=name` immediately after
    `__complete` command to prevent any interference with incomplete
    commands (just in case). This works fine and does not generate any
    errors like mentioned in point 2.
2023-06-13 20:36:12 -07:00