Medya Gh
1207de734b
bump golang lint ci to latest
2021-04-19 15:16:31 -07:00
Daehyeok Mun
fae67405e9
Update outdated moby/hyperkit package in minikube code
2021-03-05 22:27:23 -08:00
Medya Gh
47ed4bc23c
update lint version
2020-07-24 14:45:15 -07:00
Medya Gh
11674e830f
spell
2020-07-10 13:13:45 -07:00
Li Zhijian
24c9ce079d
cleanup TempDir properly
...
a TempDir is like /tmp/minipath255070191/.minikube
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
Medya Gh
d4b48e1e05
clean up after test dirs
2020-04-14 19:33:26 -07:00
Thomas Strömberg
a37ec2ecd7
Merge pull request #7189 from Hellcatlk/UnitTest
...
add unit test for pkg/drivers/hyperkit/iso.go
2020-04-09 04:22:58 -07:00
ZouYu
2e9054f495
add unit test for pkg/drivers/hyperkit/iso.go
...
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
2020-03-25 11:08:27 +08:00
Medya Gh
70c9304724
code review comments
2020-03-13 10:37:29 -07:00
Anders F Björklund
67c7a7a81c
Reduce cyclometric complexity by refactoring
...
19 cmd generateCfgFromFlags cmd/minikube/cmd/start.go:711:1
19 cmd runStart cmd/minikube/cmd/start.go:257:1
18 hyperkit (*Driver).Start pkg/drivers/hyperkit/driver.go:202:1
17 cmd runDelete cmd/minikube/cmd/delete.go:53:1
16 registry TestRegistry pkg/minikube/registry/registry_test.go:39:1
2019-09-21 09:24:39 +02:00
Thomas Stromberg
48d2ace5cc
Remove broken default disk size test that didn't make sense
2019-08-22 11:41:41 -07:00
Sharif Elgamal
a817bffab1
Remove all minikube dependencies from drivers ( #4933 )
...
* Remove all minikube dependencies in driver code
* removing all default config
* okay we need some defaults
* code comments
* hyperkit builds now
* sleep for an appropriate amount of time
* remove constant in favor of string
* try goproxy for travis
* try goproxy for travis
* try goproxy for travis
* let's not try goproxy for now
* let's try goproxy once again
* maybe use the correct url for the proxy
* fix go mod
2019-08-12 14:42:11 -07:00
Medya Gh
99ac1a81e7
moving command runner to its own package
2019-07-04 16:31:07 -07:00
Medya Ghazizadeh
2aac268ba6
Merge pull request #4593 from josedonizetti/add-hyperkit-version
...
Add version to hyperkit driver
2019-07-01 14:38:30 -07:00
Medya Ghazizadeh
449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check
...
Added validation for start memory size
2019-06-30 15:17:28 -07:00
Jose Donizetti
4812761f05
Add gitCommitID to hyperkit version
2019-06-29 09:32:21 -03:00
josedonizetti
931a0a557b
Add hyperkit version
2019-06-29 09:22:51 -03:00
Jose Donizetti
7fe2247692
Improve hyperkit vm stop
2019-06-28 16:36:36 -07:00
Jose Donizetti
6222e74267
Add hyperkit doc
2019-06-28 13:44:15 -07:00
Jituri, Pranav
380883dee3
Fix failing Hyperkit test
2019-06-26 01:45:12 +05:30
Medya Gh
c7bf1ce7cd
type check for drivers
2019-06-24 14:39:21 -07:00
tstromberg
f8c5fad437
Mark as darwin only, to match network.go
2019-05-14 09:05:34 -07:00
Thomas Stromberg
6e693d22ee
lint-a-geddon is here
2019-05-13 21:43:52 -07:00
tstromberg
9a9f9edf5f
First pass at lint-ageddon
2019-05-13 18:31:55 -07:00
Anders F Björklund
edf46f003f
Document all exported functions outside minikube
2019-03-16 16:57:37 +01:00
Thomas Stromberg
07fc64fbe1
Warnf -> Debugf so that it doesn't interfere with output
2019-02-14 20:12:34 -08:00
Thomas Stromberg
7dd7e5417d
glog, not golog
2019-02-14 14:43:22 -08:00
Thomas Stromberg
531e6b0f72
Use h.SetLogger
2019-02-14 14:40:32 -08:00
Thomas Stromberg
0c8a452e97
lowercase error messages
2019-02-14 14:40:16 -08:00
Thomas Stromberg
5c1a72f428
Switch Infof statements to Debugf/Warningf, as they go to stderr
2019-02-14 10:14:41 -08:00
Thomas Stromberg
473f5983cb
Allow driver name to be com.docker.hyper, as seen in integration testing
2019-02-13 13:36:45 -08:00
Thomas Stromberg
4b875ddd7f
Run goimports
2019-02-13 13:35:28 -08:00
Thomas Stromberg
2045dc9ba4
Lint cleanup
2019-02-13 13:35:08 -08:00
Thomas Stromberg
888978c3a9
Improve VM re-use reliability: detect crashing and/or badly installed hyperkit
2019-02-12 13:58:18 -08:00
Thomas Stromberg
f346e5628b
Add logging around the DHCP discovery process
2019-02-12 13:57:02 -08:00
Thomas Stromberg
d57d8d1a1e
Fix broken tests: hyperkit driver format mismatch, console spacing mismatch
2019-02-08 13:58:02 -08:00
balopat
17c0244cf7
reverting unnecessary change
2019-01-28 17:28:57 -08:00
balopat
5af2f1eafc
formatting / removed extra comment
2019-01-28 13:47:24 -08:00
balopat
f70e6a0385
fixing review remarks
2019-01-28 13:42:43 -08:00
balopat
933356e477
lint
2019-01-25 17:20:57 -08:00
balopat
9b97a85a8f
fix stale hyperkit.pid making minikube start hang
2019-01-25 17:08:31 -08:00
bpopovschi
0687fea66a
Added defaultDiskSize setup to hyperkit driver
...
fmt fix
2019-01-14 17:04:07 +02:00
Thomas Stromberg
3706b3b8ac
Fix dangling format issues.
2018-09-28 16:48:37 -07:00
Thomas Stromberg
055c8002b1
Replace %s format directives with %v for errors.
...
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
seborama
ee73cbde6b
Added hyperkit options for enterprise VPN support
...
The purpose of these changes is to enhance Hyperkit support from the
minikube command line for better integration with enterprise networks
behind a VPN.
uuid: Provide VM UUID to restore MAC address (only supported with
Hyperkit driver).
vpnkitSock: Location of the VPNKit socket used for networking. If empty,
disables Hyperkit VPNKitSock, if 'auto' uses Docker for Mac
VPNKit connection, otherwise uses the specified VSock."
vsockPorts: List of guest VSock ports that should be exposed as sockets
on the host (Only supported on with hyperkit now).
Note:
tests pass but file:
`vendor/github.com/google/certificate-transparency/go/x509/root_darwin.go`
has to be edited to correct an issue - not committed since this is in
the vendor directory.
2018-06-04 09:46:20 -07:00
basp
cebd704bd7
Issue #2416 : Added UUID to hyperkit driver section in minikube configuration to be able to regenerate the same mac address for the machine after restarts to give DHCP a change of assigning the previously used IP address.
2018-01-11 09:41:35 -08:00
Hugues Alary
bc55b8b8be
Cleanup NFS Exports after stop and delete
2018-01-03 10:21:04 -08:00
dlorenc
59274b22da
Code review feedback.
2018-01-02 16:18:54 -08:00
dlorenc
e3f3727b4d
Move GetNetAddr.
...
The build constraints in vmnet.go cause issues.
2018-01-02 16:18:54 -08:00
Mohit Gupta
7d9413ccd1
remove the hyperkit prefix so we can move this to other drivers as well with time and fix vendoring issue
2018-01-02 16:18:54 -08:00