Commit Graph

4230 Commits (d782f80e23449a641a95325e081fdd56a08b73e8)

Author SHA1 Message Date
Sharif Elgamal 58d4b0c32f add less restrictive interface name matching 2020-07-21 15:32:38 -07:00
Priya Wadhwa 6a33c03df2 fix unit test 2020-07-21 18:23:22 -04:00
Priya Wadhwa 8bc875d520 Rebased on master; fixed json_output integration test 2020-07-21 18:20:02 -04:00
priyawadhwa 6df5d19d70
Merge pull request #8793 from priyawadhwa/warning
Implement Warning type for JSON output
2020-07-21 18:17:54 -04:00
Medya Ghazizadeh 85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal 1b6eee675b
Automated GCP Credentials Addon Prototype (#8682)
* metadata addon works

* Add code for metadata server image and makefile rules

* remove log message

* update to work with v1.13.11

* update readme

* fix metadata addon stuff for newer codebase

* buncha changes

* just so many changes

* ch-ch-ch-ch-changes

* addon works

* update readme

* boilerplate

* revert unrelated change

* move server code to another repo

* switch addon name to gcp-auth

* metadata -> gcp-auth

* missed one

* automate finding of credentials

* remove unnecessary comment

* address comments

* Update README.md

* Update README.md

* use mustload everywhere

* swap selector condition

* upgrade kube-webhook-certgen to 1.3

* move paths to constants

* add notice to user on addon enable

* adding addon documentation

* move addons documentation inside handbook

* remove old addons docs location

Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Medya Ghazizadeh 24fa6280dc
Merge pull request #8588 from afbjorklund/preload-crio-2
Use preloaded tarball for cri-o container runtime
2020-07-21 13:59:03 -07:00
Priya Wadhwa 6ca72229bb add json unit tests 2020-07-21 15:56:26 -04:00
Priya Wadhwa b4b9013057 Add unit test for problem.DisplayJSON() 2020-07-21 15:51:47 -04:00
Priya Wadhwa 482b9befd6 implement errors in JSON 2020-07-21 15:43:19 -04:00
Medya Ghazizadeh f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
Priya Wadhwa c60e754624 Implement warning type for JSON output 2020-07-21 14:40:31 -04:00
Shubham f42f79e56d (Addons) Create a new command in every retry
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd)
states that "... Cmd cannot be reused after calling its Run or
Start methods."

This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.

Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.

Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
Dean Coakley 328dbc1f97 Improve fix message 2020-07-21 12:29:53 +01:00
Dean Coakley 66f03b89c3 Update formatting Podman->Podman v2 2020-07-21 12:24:03 +01:00
Anders F Björklund 59bf848e54 Use preloaded tarball for cri-o container runtime
Pretty much the same as containerd, minus Restart
2020-07-21 09:05:12 +02:00
dddddai 196789f965 Use RWMutex instead of Mutex 2020-07-21 10:39:45 +08:00
Dean Coakley 0d78fe56af lint 2020-07-21 03:00:13 +01:00
Dean Coakley 622e33b7ab Fix typo 2020-07-21 02:55:37 +01:00
Dean Coakley 62683c9b42 Exit with error on podman2 drivers 2020-07-21 02:39:46 +01:00
priyawadhwa aaebd88251
Merge pull request #8610 from johscheuer/update-storage-provisioner
Update external-provisioner for storage provisioner for Kubernetes 1.18
2020-07-20 19:11:38 -04:00
Medya Ghazizadeh 79088e6ed2
Merge pull request #8581 from afbjorklund/preload-crio
Generate cri-o container runtime preload tarball
2020-07-20 15:55:31 -07:00
Medya Ghazizadeh 2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
Sharif Elgamal f92015df9b allow for prefix interace names for hyperv 2020-07-20 13:07:13 -07:00
Medya Gh 13357d91a4 avoid nil pointer 2020-07-20 12:56:03 -07:00
Anders F Björklund 22585c3a17 Use the preload container run for podman as well
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...

Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
Anders F Björklund 2a9e9b2425 Make sure to prepare the kic volume after creation
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.

This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
Jose Donizetti cd17c872d3 Fix documentation typo 2020-07-18 15:02:09 -03:00
Thomas Stromberg 9546b1ebc6 Merge branch 'master' into kic-image-upgrade 2020-07-17 09:56:42 -07:00
Thomas Strömberg b7e7ef3a65
Merge pull request #8751 from tstromberg/docker-err-suggestion
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:55:04 -07:00
Thomas Stromberg f89094dcf8 Adjust comment 2020-07-17 09:46:53 -07:00
Thomas Stromberg 2b614ae856 Add 'Start Docker' guidance for /pipe/docker_engine errors 2020-07-17 09:45:16 -07:00
Thomas Stromberg 3b1dc975d0 legacy client certs: simplify logic 2020-07-17 07:23:48 -07:00
Lu Fengqi c219b60b05 Add error handling for os.RemoveAll
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
2020-07-17 15:44:04 +08:00
Thomas Stromberg b72eee4e36 Turn Errorf into Infof 2020-07-16 23:07:37 -07:00
Thomas Stromberg 94e866affc Merge to master 2020-07-16 19:53:43 -07:00
Thomas Stromberg 798196d0ad Remove stray log line 2020-07-16 19:37:28 -07:00
Thomas Stromberg be2c27efe0 Find and copy legacy certificate/key paths 2020-07-16 19:37:15 -07:00
Thomas Strömberg bb2fb3ad97
Merge pull request #8573 from tstromberg/cilium
Add support for Cilium CNI (--cni=cilium)
2020-07-16 19:34:44 -07:00
Thomas Stromberg ccd3682116 Refactor upgrade tests 2020-07-16 17:34:46 -07:00
Thomas Stromberg fcc15fa353 Merge to master 2020-07-15 21:04:33 -07:00
Thomas Stromberg 14b4a54ba2 Merge to master 2020-07-15 21:03:49 -07:00
Medya Gh 13d37ff7aa adress review comments 2020-07-15 14:34:01 -07:00
Medya Gh b0e58a3688 rename to FullName 2020-07-15 14:27:06 -07:00
Medya Gh 3aac9a3fff remove duplicate return statement 2020-07-15 14:24:42 -07:00
Medya Gh 8ecb483cb7 use cached error 2020-07-15 14:23:25 -07:00
Medya Gh 7bbb0b6250 spell 2020-07-15 14:09:35 -07:00
Medya Gh de6c10526b move cacheDaemoninfo to oci package 2020-07-15 14:07:50 -07:00
Sharif Elgamal af99a13e8f Merge branch 'master' of github.com:kubernetes/minikube into master 2020-07-15 11:32:48 -07:00
Sharif Elgamal 1467e8f7c4
Merge pull request #8576 from afbjorklund/image-client
cache: Only use docker client for docker runtime
2020-07-15 11:12:52 -07:00
Medya Gh dbfd16f21e add helper fucns for drivers 2020-07-14 15:02:54 -07:00
priyawadhwa c2e63844db
Merge pull request #8709 from priyawadhwa/json-output-download
Implement Download and DownloadProgress types for JSON output
2020-07-14 15:56:56 -04:00
Priya Wadhwa cb03f56b1b remove todo 2020-07-14 13:39:33 -04:00
priyawadhwa f15b0d6e35
Merge pull request #8468 from prasadkatti/mv_kubelet_params_to_cfg_file
Move kubelet params to config file
2020-07-14 09:56:26 -04:00
Sharif Elgamal 9f2f604b93 several fixes 2020-07-13 18:54:40 -07:00
Sharif Elgamal bd721de0cf Merge branch 'master' of github.com:kubernetes/minikube into master 2020-07-13 15:00:38 -07:00
Priya Wadhwa e4ce27abda Add unit tests for register package 2020-07-13 12:08:06 -04:00
Priya Wadhwa e771b72a82 fix lint 2020-07-13 10:05:06 -04:00
Priya Wadhwa 9784ce3051 Rebased on master 2020-07-13 09:57:42 -04:00
Priya Wadhwa d26cd72d36 Implement Info type so that integration tests pass 2020-07-10 19:18:25 -04:00
Priya Wadhwa 3a290606db Merge branch 'master' of https://github.com/kubernetes/minikube into json-output 2020-07-10 19:12:50 -04:00
Sharif Elgamal aa4f7b3b21 update control plane properly on multinode restart 2020-07-10 15:40:21 -07:00
Medya Gh 17f44f69e3 impove applyying default service account 2020-07-10 15:01:06 -07:00
priyawadhwa 442bc138ce
Merge pull request #8676 from priyawadhwa/info
Add Infof function to out package
2020-07-10 17:08:30 -04:00
Medya Ghazizadeh 45677496fa
Merge pull request #8585 from prasadkatti/extra_option_8130
Do not auto-set extra config that user wishes to override
2020-07-10 13:54:19 -07:00
Medya Ghazizadeh 3c9e96ea6b
Merge pull request #8684 from tstromberg/none-cni
none CNI: error if portmap plug-in is required but unavailable
2020-07-10 13:50:54 -07:00
Medya Gh 6d9922b430 address review comments 2020-07-10 13:19:22 -07:00
Medya Gh 4bce402a3b remove debug seconds 2020-07-10 13:18:25 -07:00
Medya Gh 11674e830f spell 2020-07-10 13:13:45 -07:00
Medya Gh c240fa97bc add timeout for node label too 2020-07-10 13:06:43 -07:00
Medya Gh f805be635a add timeout for node label too 2020-07-10 13:04:11 -07:00
Medya Gh f36da5f044 add timeout for node label too 2020-07-10 13:03:50 -07:00
Medya Gh 770f7aeeb4 adjust itmeout 2020-07-10 13:02:06 -07:00
Medya Gh 7088653d33 max 13 min for kubeadm 2020-07-10 13:01:08 -07:00
Medya Gh 6c702e1d29 add timeout for kubeadm init 2020-07-10 12:49:29 -07:00
Medya Ghazizadeh 87e540305c
Merge pull request #8648 from jlucktay/update/profile-name-validation
disallow setting profile names with underscore
2020-07-10 10:43:32 -07:00
Priya Wadhwa 3d105ef98f Download and DownloadProgress implemented 2020-07-10 12:31:08 -04:00
Priya Wadhwa d29a9dca67 Add Download and DownloadProgress types implementations 2020-07-10 11:58:23 -04:00
Prasad Katti 7bc10bb308 Set cgroupDriver and clientCAFile (for 1.16+) via kubelet config 2020-07-09 15:21:26 -07:00
Prasad Katti c483714cbc Move kubelet params to config file 2020-07-09 15:21:25 -07:00
Prasad Katti 332c3bd14f Add unit tests for Exists in extra_options.go 2020-07-09 15:17:00 -07:00
Thomas Strömberg ca9040b42b
Merge pull request #8664 from tstromberg/none-timeout
none: Fix 'minikube delete' issues when the apiserver is down
2020-07-09 14:16:14 -07:00
Sharif Elgamal d0d3973a13 restrict apparmor security opt to docker 2020-07-09 12:58:01 -07:00
Thomas Stromberg 0b3e2ae79b none CNI: error if portmap plug-in is required but unavailable. Make testable 2020-07-08 14:30:48 -07:00
Thomas Stromberg f8068d06f7 Merge branch 'master' into none-timeout 2020-07-08 13:48:34 -07:00
Priya Wadhwa b9cd0caa7c only out.T should be used to convert steps to JSON 2020-07-08 16:30:48 -04:00
Priya Wadhwa 6d95edda7b remove empty test 2020-07-08 16:28:51 -04:00
priyawadhwa b6f0829d7d
Merge pull request #8505 from zhijianli88/cleanup-tempfiles
Cleanup tempfiles
2020-07-08 14:53:51 -04:00
priyawadhwa 7367c72a3e
Merge pull request #8490 from zhijianli88/cleanup
A few cleanup
2020-07-08 14:52:28 -04:00
Priya Wadhwa 3e6ef0b37a fix unit test 2020-07-08 11:10:47 -04:00
Priya Wadhwa 290f48f98e Add Infof function to out package 2020-07-08 11:00:32 -04:00
Medya Ghazizadeh 1bcb375f93
Merge pull request #8147 from nezorflame/fix-error-msg
add new --extra-config option "scheduler"
2020-07-07 15:55:08 -07:00
Medya Ghazizadeh d8106f7d06
Merge pull request #8454 from colvin/addon-podsecuritypolicies
Include a podsecuritypolicies addon
2020-07-07 15:52:03 -07:00
Thomas Stromberg 7df4075297 Don't propagate stopped as an error, so that 'delete' works on stopped none clusters 2020-07-07 15:23:26 -07:00
Thomas Stromberg 53ce804cff retry.Local should respect the maxTime argument 2020-07-07 15:10:30 -07:00
Thomas Stromberg f82d5c6bb2 Reduce apiserver health timeout from 8s to 5s 2020-07-07 15:10:05 -07:00
Priya Wadhwa 1980e066dd fix lint and generate-docs 2020-07-07 15:57:07 -04:00
Priya Wadhwa 6367f71867 Make sure each step is unique 2020-07-07 15:39:47 -04:00
Priya Wadhwa bd94872a10 add additional steps 2020-07-07 14:25:27 -04:00
Priya Wadhwa ddecfd77e7 Include Ln as a Step 2020-07-07 13:24:53 -04:00