Commit Graph

1361 Commits (d05c0908112912af1a53bdc1a353d847ebcebc19)

Author SHA1 Message Date
Sharif Elgamal c92e65ec28
Add templating for proper localization (#4677)
* Add templating for proper localization

* Fixing tests for new translation style

* checking errors is important

* fixing more console tests

* good function names make for happy developers

* add test for OutTemplateStyle

* short function names make for happy developers

* better formatting

* more better variable names
2019-07-10 10:17:28 -07:00
Medya Ghazizadeh 57f6d877ed
Merge pull request #4689 from palnabarun/4664-fix
Fixes the issue which caused all containers to be deleted on minikube delete
2019-07-09 15:23:39 -07:00
Medya Ghazizadeh c8b0b41a6b
Merge pull request #4675 from superbrothers/fix-minikube-service
Fix `minikube service` to show error message if service has no node ports
2019-07-08 21:22:58 -07:00
Nabarun Pal 67874eee9e
Fixes the issue which caused all containers to be deleted on delete
This change only involves the docker container runtime.
2019-07-05 13:28:19 +05:30
Kazuki Suda 6f96fbaa93 Print information of a service as a table 2019-07-05 15:32:19 +09:00
Medya Ghazizadeh 4e5f173a9c
Merge pull request #4687 from medyagh/move_command_runner
moving command runner to its own package
2019-07-04 23:30:21 -07:00
Medya Ghazizadeh cc9960200f
Merge pull request #4676 from josedonizetti/warn-if-kvm2-version-is-old
Add warn if kvm driver version is old
2019-07-04 22:22:13 -07:00
Medya Ghazizadeh 11f8c61604
Merge pull request #4678 from kairen/delete-kubeconfig
Delete kubeconfig context when a machine has been deleted
2019-07-04 22:09:44 -07:00
Medya Gh 99ac1a81e7 moving command runner to its own package 2019-07-04 16:31:07 -07:00
josedonizetti 9210b96ee8 Add upgrade documentation to kvm version warn 2019-07-04 17:25:56 -03:00
Anders F Björklund fa3bc63757 Fix systemd dependencies when using containerd
There is a template bug in the kubelet.service creation,
which causes it to start dockerd instead of containerd.
2019-07-04 20:09:49 +02:00
Kyle Bai 6505dfad62 Delete kubeconfig when a machine has been deleted 2019-07-04 14:47:41 +08:00
Kazuki Suda 7d510c47b1 Fix `minikube service` to show error message if service has no node ports 2019-07-04 00:29:30 +09:00
Medya Ghazizadeh 124b845b60
Merge pull request #4644 from josedonizetti/prefix-kvm-only-flags
Add kvm prefix to flags only used by kvm
2019-07-01 14:43:05 -07:00
Medya Ghazizadeh 2aac268ba6
Merge pull request #4593 from josedonizetti/add-hyperkit-version
Add version to hyperkit driver
2019-07-01 14:38:30 -07:00
Medya Ghazizadeh 449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check
Added validation for start memory size
2019-06-30 15:17:28 -07:00
Medya Ghazizadeh 037e9a5d56
Merge pull request #4641 from josedonizetti/improve-kvm-connection-error-message
Improve kvm connection error message
2019-06-30 12:08:44 -07:00
josedonizetti fe3620020a Add kvm prefix to flags only used by kvm 2019-06-29 12:25:36 -03:00
josedonizetti 4d00a093d1 Fix error naming convention 2019-06-29 11:28:54 -03:00
josedonizetti 84ce1d5564 Add kvm connection error problem message 2019-06-29 10:58:05 -03:00
josedonizetti 23ae121f2b kvm2: simplify connection error message 2019-06-29 10:53:13 -03:00
Jose Donizetti 4812761f05 Add gitCommitID to hyperkit version 2019-06-29 09:32:21 -03:00
josedonizetti 931a0a557b Add hyperkit version 2019-06-29 09:22:51 -03:00
Christophe VILA 8cd38956f2 Make virtualbox DNS settings configurable 2019-06-28 16:38:16 -07:00
Jose Donizetti 7fe2247692 Improve hyperkit vm stop 2019-06-28 16:36:36 -07:00
Jose Donizetti 9dfe660c64 Add support to custom qemu uri on kvm2 driver 2019-06-28 14:12:58 -07:00
Jose Donizetti 8acf4824df Add commit id to docker-machine-driver-kvm2 version 2019-06-28 13:45:54 -07:00
Jose Donizetti 6222e74267 Add hyperkit doc 2019-06-28 13:44:15 -07:00
Jose Donizetti 19ba008d22 Fix doc comment version.gitCommitID doc 2019-06-28 12:15:05 -07:00
Aida Ghazizadeh d5ded27674 Added solution message for not found service. 2019-06-26 23:39:44 -07:00
Jose Donizetti d6a839b20a Fix kvm2 vm driver remove domain 2019-06-26 18:36:52 -07:00
Medya Ghazizadeh 886d159a5b
Proxy: handle lower case proxy env vars 2019-06-26 10:33:50 -07:00
Francis 6bc977ad04 better service retry logic 2019-06-25 17:28:10 -07:00
Jituri, Pranav 380883dee3 Fix failing Hyperkit test 2019-06-26 01:45:12 +05:30
Pranav Jituri 6ba1725c08 Added Memory Size Checking 2019-06-26 00:22:41 +05:30
serhat çetinkaya 9d88171d18 Improve stop behavior to unset curren-tcontext only if needed 2019-06-25 10:55:28 -07:00
Sharif Elgamal 37239ba83d
Merge pull request #4581 from sharifelgamal/translation-bindata
Add translation files into the minikube binary
2019-06-25 10:19:34 -07:00
Deepjyoti Mondal 8be917f0a5 Display commit id for minikube version 2019-06-25 10:12:55 -07:00
Medya Gh 34fda98f4e Improve typecheck for driver options 2019-06-24 15:23:57 -07:00
Sharif Elgamal 12bb8c5c25
Add translation files into the minikube binary 2019-06-24 15:15:01 -07:00
Medya Gh c7bf1ce7cd type check for drivers 2019-06-24 14:39:21 -07:00
Medya Ghazizadeh e0c20a4202
Merge pull request #4558 from afbjorklund/reportcard-new
Fix the reportcard: gofmt, golint and gocyclo
2019-06-24 11:44:42 -07:00
Francis 467d8c975f Clean up profile folder after minikube delete 2019-06-24 09:48:25 -07:00
Thomas Stromberg abff28db7e Universally redirect stdlog messages to glog 2019-06-23 20:58:11 +08:00
Thomas Stromberg d94d94718d Use non-unicode percent signs for proper interpolation 2019-06-23 11:44:03 +08:00
Anders F Björklund f20f223c02 Decrease cyclomatic complexity
Here is the report (from gocyclo), before:

21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
2019-06-22 17:21:42 +02:00
Anders F Björklund c9fabad212 Fix the simple things, gofmt and golint 2019-06-22 16:16:37 +02:00
Sharif Elgamal 247efdea15
Merge pull request #4534 from kubernetes/k8s-1.15.0
Update Kubernetes default version to v1.15.0
2019-06-21 23:27:20 -07:00
Sharif Elgamal 79e00c2e05
%v for errors 2019-06-21 15:40:01 -07:00
Sharif Elgamal 0a23696386
Suppress error message when translation file doesn't exist 2019-06-21 09:57:01 -07:00