Thomas Strömberg
b4ce29d589
Merge pull request #5757 from priyawadhwa/wait_false
...
Set --wait=false to default but still wait for apiserver
2019-10-28 21:52:15 -07:00
Nanik T
994d093766
Add boolean to disable opening browser during test
...
The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.
The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window
2019-10-29 13:23:41 +11:00
Priya Wadhwa
bd5840aacf
improve comments
2019-10-28 18:02:45 -07:00
Priya Wadhwa
f3b1a09c36
Clean up bootstrapper interface to accept list of pods to wait for
...
when waiting for the cluster to start up.
2019-10-28 17:34:04 -07:00
Thomas Strömberg
58018eee85
Merge branch 'master' into f-fix-5329
2019-10-28 16:22:18 -07:00
Priya Wadhwa
993967bcc7
make sure we can get api server pod
2019-10-28 15:20:13 -07:00
Medya Gh
29a015b63f
remove more bin bash c
2019-10-28 14:10:22 -07:00
Priya Wadhwa
f92b308f9a
Rebased on master
2019-10-28 10:46:35 -07:00
Priya Wadhwa
7900b63d2b
Wait for only apiserver by default
...
This PR changes --wait=false to be the default, but to still check for the apiserver in this case. If wait=true, we still wait for all pods to be up and running. This change should speed up `minikube start`, since we won't have to wait for other pods which can take a longer time to start up.
Ref #5681
2019-10-28 10:45:57 -07:00
Medya Ghazizadeh
e2bbf7111e
Merge branch 'master' into NewCmdRunner
2019-10-27 00:18:00 -07:00
Anders F Björklund
74e7b2c866
Fix compile error introduced by vmrun fix
2019-10-26 20:25:03 +02:00
Anders F Björklund
3c48985477
Make sure to look for vmrun, for vmware
...
Otherwise you risk trying to run VMware, just because the
docker-machine-driver-vmware driver has been installed...
2019-10-26 18:13:57 +02:00
Anders F Björklund
d635b8dfc7
Add comments as requested by golint
2019-10-26 13:16:29 +02:00
Anders F Björklund
2b5663185f
Run gofmt
2019-10-26 13:09:25 +02:00
Medya Gh
1b834df3e4
fix unit test
2019-10-25 17:17:27 -07:00
Medya Gh
792de2b0a1
resolve code review
2019-10-25 17:12:55 -07:00
Medya Gh
592ea158ee
fix none docker test
2019-10-25 16:00:36 -07:00
Thomas Strömberg
d32431efba
Merge pull request #5735 from tstromberg/gvisor-yiso
...
gvisor: Use chroot instead of LD_LIBRARY_PATH
2019-10-25 15:41:28 -07:00
Medya Gh
291731c5b2
change shellquote to args
2019-10-25 14:43:25 -07:00
tstromberg
9b2ce99723
Use chroot instead of LD_LIBRARY_PATH for containerd restart
2019-10-25 14:03:01 -07:00
Medya Gh
69dba7c052
Fix exec runner and remove some debug logging
2019-10-25 13:57:00 -07:00
Thomas Strömberg
80f0262dfe
Merge pull request #5731 from tstromberg/v1.16.2
...
Update default Kubernetes version to v1.16.2
2019-10-25 12:45:11 -07:00
tstromberg
416f132ebb
Pass --expected-default-driver to the test rather than minikube
...
Improve VBoxManage detection on Windows
Add missing install_test
2019-10-25 10:43:30 -07:00
tstromberg
d83b4e6f6c
Update default Kubernetes version to v1.16.2
2019-10-25 10:21:12 -07:00
tstromberg
d3618fb94c
Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2
2019-10-25 09:58:07 -07:00
tstromberg
04acb598f5
Use virsh domcapabilites instead of virt-host-validate as it behaves more appropriately
2019-10-25 09:57:58 -07:00
Thomas Stromberg
c50a849349
Add more debug logs
2019-10-24 20:34:38 -07:00
Thomas Stromberg
c153919a56
Mark none driver as Linux only
2019-10-24 20:34:29 -07:00
Medya Gh
01573e4bda
removed more bin bash calls
2019-10-24 17:07:52 -07:00
Medya Gh
0d8c894e6e
fix unit test and remove more bin bash c
2019-10-24 16:09:41 -07:00
Medya Gh
187dfe29f8
getting rid of some of bin bash -c
2019-10-24 14:13:51 -07:00
Medya Gh
900123bcf2
Fixing pointer and unit test
2019-10-24 13:17:52 -07:00
tstromberg
f9b0c77de1
Include output in the error message
2019-10-24 13:16:59 -07:00
Medya Gh
45e5bebdb4
fixing pointer and teeSSH
2019-10-24 13:15:45 -07:00
tstromberg
82cb5a1728
Fix extra comma
2019-10-24 10:57:07 -07:00
Thomas Stromberg
8920a884c3
Minor improvements to the clarity of hypervisor errors
2019-10-24 07:45:40 -07:00
Kenta Iso
01f56844ed
Fix lint error: File is not `goimports` -ed
2019-10-24 21:32:41 +09:00
Thomas Stromberg
c925f65629
Warn about driver status, add more logging
2019-10-23 22:33:05 -07:00
Thomas Stromberg
c4fc450ad4
Add unit tests for driver
2019-10-23 20:24:03 -07:00
Thomas Stromberg
90ac694356
Add tests for new registry methods, split package into two files
2019-10-23 18:13:37 -07:00
Thomas Stromberg
118783cced
Remove dependency between minikube and kvm driver
2019-10-23 14:48:07 -07:00
Thomas Stromberg
4b63c0d973
Update hyperv driver for recent changes
2019-10-23 13:59:19 -07:00
Thomas Stromberg
86315878ae
Merge branch 'master' into drv-select2
2019-10-23 10:59:51 -07:00
Thomas Stromberg
443ae74719
Make unit tests pass again
2019-10-23 09:34:32 -07:00
Javis Zhou
68533aeccb
Fix golint failures
2019-10-23 21:15:04 +08:00
Thomas Stromberg
680b542823
Rename package files appropriately
2019-10-22 20:45:41 -07:00
Thomas Stromberg
1fc11f56f1
Add logic for picking the default driver on a host
2019-10-22 20:38:30 -07:00
Nanik T
80d20091e1
Add --config to instruct kubelet to use internal config file #5329
...
Kubelet startup parameters does not include the --config flag. This flag pass the
location of the configuration file. During minikube startup process this file
is copied over to the VM. Fix test cases.
2019-10-23 08:41:00 +11:00
Medya Gh
05bbcf733a
remove uneeded wrap output
2019-10-21 15:18:04 -07:00
Medya Gh
6e1c4f62ca
trying to fix logs
2019-10-21 13:50:00 -07:00
Medya Gh
6faf9cdbe7
lint and code review
2019-10-21 13:01:06 -07:00
Medya Gh
6bd5d9b157
Merge remote-tracking branch 'upstream/master' into NewCmdRunner
2019-10-21 11:17:28 -07:00
tstromberg
7581cf3e0c
Address merge conflicts
2019-10-21 11:12:06 -07:00
Medya Gh
48cd8620f2
fix stdout,stderr
2019-10-21 10:59:33 -07:00
Thomas Strömberg
cd9a6526d3
Merge pull request #5548 from blueelvis/5358-purge-flag-for-delete
...
Added flags to purge configuration with minikube delete
2019-10-21 10:26:36 -07:00
Thomas Strömberg
c8833827c1
Merge pull request #5624 from nanikjava/f-fix-4883
...
Add validation checking for minikube profile
2019-10-21 10:17:26 -07:00
Thomas Strömberg
523db2099c
Merge pull request #5640 from sharifelgamal/auto-download-off
...
add ability to override autoupdating drivers
2019-10-21 10:16:49 -07:00
tstromberg
35f7c9f38a
Merge branch 'master' into drv-reorg
2019-10-21 09:50:08 -07:00
tstromberg
27a23c5755
Add missing driver import
2019-10-21 09:49:09 -07:00
Thomas Strömberg
a9ca2a35cf
Merge pull request #5662 from govargo/fix-test-cache-binary-kubeadm
...
fix test case TestCacheBinary/ok_kubeadm to download linux kubeadm binary
2019-10-21 09:45:04 -07:00
Thomas Strömberg
967ce4867d
Merge pull request #5663 from afbjorklund/lint-again
...
Pick some lint from the recent master commits
2019-10-21 09:44:14 -07:00
Thomas Strömberg
dbe977d879
Merge pull request #5670 from cueo/sonar-code-smell
...
Reduce code smell reported by SonarCloud
2019-10-21 09:42:25 -07:00
Anders F Björklund
a41ac45fcc
Add missing dash before the image arch
...
This character (-) was removed by mistake, in 5fa6714
It is supposed to be "" for amd64, "-arm64" for arm64.
2019-10-20 16:07:06 +02:00
cueo
6533d9f2e8
Rename methods to match the convention
2019-10-20 19:11:31 +05:30
Pranav Jituri
b3ccd9ae46
Refactored Delete and fixed linting issues
2019-10-20 13:13:35 +05:30
Pranav Jituri
88fd869a81
Merge branch 'master' into 5358-purge-flag-for-delete
...
# Conflicts:
# cmd/minikube/cmd/delete.go
# pkg/minikube/cluster/cluster.go
2019-10-20 12:14:44 +05:30
Pranav Jituri
2ba9cb4c1a
refactoring for delete
2019-10-20 02:19:18 +05:30
Anders F Björklund
96c39bf050
Pick some lint from the recent master commits
2019-10-19 09:37:20 +02:00
Kenta Iso
73035dcec0
fix test case ok kubeadm to download linux kubeadm binary
2019-10-19 16:09:06 +09:00
Thomas Strömberg
56a23cab4a
Merge pull request #5654 from tstromberg/delete-anyways
...
Ensure that delete succeeds even if cluster is unavailable
2019-10-18 16:06:12 -07:00
tstromberg
69e77d86d3
Fix logging strings
2019-10-18 15:50:04 -07:00
tstromberg
13cba07ec8
Fix broken cluster_test
2019-10-18 15:48:26 -07:00
tstromberg
440d0e85e6
Add driver registration back
2019-10-18 15:32:46 -07:00
tstromberg
7cb0cfdf79
Pass lint checks
2019-10-18 13:53:57 -07:00
tstromberg
15daa48ed7
Merge branch 'master' into drv-reorg
2019-10-18 13:01:10 -07:00
Thomas Stromberg
6d7d589a52
Consolidate driver-interaction code into pkg/minikube/driver
2019-10-18 13:00:07 -07:00
Thomas Strömberg
9db86d91fa
Merge pull request #5592 from tstromberg/sshcheck
...
Add networking validation to validateNetwork
2019-10-18 07:24:09 -07:00
Thomas Stromberg
2180c1405b
Ensure that delete succeeds even if cluster is unavailable
2019-10-17 16:23:21 -07:00
Sharif Elgamal
dc94405a34
Merge branch 'master' of github.com:kubernetes/minikube into auto-download-off
2019-10-17 15:32:09 -07:00
Thomas Strömberg
3f866515e9
Merge pull request #5563 from nanikjava/f-fix-5271
...
Make error message more human readable
2019-10-17 15:22:26 -07:00
Thomas Strömberg
ce2b0a3b9a
Merge pull request #5471 from xichengliudui/redundantCode
...
remove the redundant code in util.go
2019-10-17 15:16:40 -07:00
Thomas Strömberg
ccc2042861
Merge branch 'master' into remove-heapster
2019-10-17 15:14:49 -07:00
Thomas Strömberg
0cb5cafb59
Merge pull request #5639 from tstromberg/hyperkit-rnd
...
Speed up RNG initialization on new systemd
2019-10-17 14:54:12 -07:00
Thomas Strömberg
f679efbb8a
Merge pull request #5512 from n0npax/improve-machine-test-coverage
...
Improve machine test coverage
2019-10-17 14:51:28 -07:00
Thomas Strömberg
b89bfbe3d2
Merge pull request #5425 from n0npax/improve-translations-test-coverage
...
improve translations test coverage
2019-10-17 14:50:12 -07:00
Nanik T
824c911c42
Add validation checking for minikube profile
...
Fixes : #4883
New function ProfileNameInReservedKeywords(..) has been added inside
pkg/minikube/config/profile.go
The new function perform validation to make sure the profile name is not
in the list of keywords.
Following are the keywords that are used:
start, stop, status, delete, config, open, profile, addons, cache, logs
The checking is case insensitive to cover combo of upper and lower case
2019-10-18 08:40:18 +11:00
Thomas Strömberg
f74ac2095c
Merge pull request #5565 from RickyRajinder/enable-addons-when-minikube-not-running
...
Allow addon enabling and disabling when minikube is not running
2019-10-17 14:38:36 -07:00
Nanik T
10ff44e582
Modify output text to make it more readable as per PR comment
2019-10-18 06:28:24 +11:00
Sharif Elgamal
a6d7989bfc
add ability to override autoupdating drivers
2019-10-16 14:51:13 -07:00
tstromberg
8ca74ef186
Use the value of --image-repository for connectivity check
2019-10-16 13:38:47 -07:00
Thomas Strömberg
7a7689bef3
Merge pull request #4780 from marekschwarz/DELETE_ALL_PROFILES
...
Added option to delete all profiles
2019-10-16 13:06:25 -07:00
Thomas Stromberg
d2f987adff
Speed up RNG initialization on hyperkit
2019-10-16 10:53:14 -07:00
tstromberg
3f6d9bbf18
Use sudo to get kubelet logs: required by permissions on v1.5 ISO
2019-10-16 10:22:38 -07:00
Medya Gh
74b7054b4a
fixing logs
2019-10-15 12:59:51 -07:00
Medya Gh
aace212e15
fix unit test, remove mount fake runner
2019-10-14 15:49:11 -07:00
Josh Woodcock
88ea55df49
Performance and security enhancment for ingress-dns addon
2019-10-13 18:04:06 -05:00
Medya Gh
390992571f
fix more stuf
2019-10-12 03:12:51 -07:00
Marcin Niemira
3dff822e8b
remove single test due to discussion on GH
2019-10-12 12:43:59 +11:00
Marcin Niemira
780112fc39
Merge branch 'master' of github.com:kubernetes/minikube into improve-machine-test-coverage
2019-10-12 12:37:06 +11:00
Marcin Niemira
b237471a17
add some tests to translate pkg
2019-10-12 12:27:38 +11:00