Commit Graph

1152 Commits (c9f99ece2cb2c4aa7e545e12435c2e3c184352c6)

Author SHA1 Message Date
Sharif Elgamal 6ff68709dd
Merge pull request #5243 from rajalokan/remove-heapster
Remove heapster addon
2019-11-06 11:35:35 -08:00
Anders F Björklund 47fe5b2822 Remove ping, was added in merge conflict
Supposed to be removed in 361222f, along with
some other random changes to comments and such.
2019-11-02 08:59:19 +01:00
Anders F Björklund df1175f51f Merge branch 'master' into reportcard-again 2019-11-01 18:32:37 +01:00
Thomas Strömberg d7569b375c
Merge pull request #5803 from tstromberg/allow-force
Allow CPU count check to be disabled using --force
2019-10-31 12:03:13 -07:00
tstromberg 9cfd2073ba Allow CPU count check to be disabled using --force 2019-10-31 11:28:34 -07:00
Thomas Stromberg 361222f606 Make network validation friendlier, especially to corp networks 2019-10-31 09:49:41 -07:00
tstromberg c34e865ab6 Improve warning message 2019-10-30 14:06:39 -07:00
tstromberg e8be75c74a Warning -> Warningf 2019-10-30 14:06:05 -07:00
tstromberg 4ce2f784f1 Fix failure issues with integration testing for service command 2019-10-30 13:57:08 -07:00
tstromberg 2c0f2a42dd Append newline to --url output 2019-10-30 12:35:25 -07:00
tstromberg f60764b07f service: fix --url mode, add integration tests 2019-10-30 10:44:54 -07:00
Thomas Strömberg ef398338d6
Merge pull request #5530 from medyagh/NewCmdRunner
Refactor command runner interface, allow stdin writes
2019-10-29 22:26:14 -07:00
Thomas Strömberg 74a5d477f2
Merge pull request #5718 from nanikjava/f-fix-test-disable-browser-test
Refactor to remove opening browser and just return url(s)
2019-10-29 13:51:33 -07:00
Thomas Strömberg b4ce29d589
Merge pull request #5757 from priyawadhwa/wait_false
Set --wait=false to default but still wait for apiserver
2019-10-28 21:52:15 -07:00
Nanik T 994d093766 Add boolean to disable opening browser during test
The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.

The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window
2019-10-29 13:23:41 +11:00
Priya Wadhwa bd5840aacf improve comments 2019-10-28 18:02:45 -07:00
Priya Wadhwa f3b1a09c36 Clean up bootstrapper interface to accept list of pods to wait for
when waiting for the cluster to start up.
2019-10-28 17:34:04 -07:00
Priya Wadhwa 5f12e9afa1 Update docs and add error message to generate-docs 2019-10-28 17:12:03 -07:00
Medya Gh 29a015b63f remove more bin bash c 2019-10-28 14:10:22 -07:00
Thomas Strömberg f5ad9014ae
Merge pull request #5758 from tstromberg/inverted-ssh
Do not check sshd for the none driver
2019-10-28 10:56:30 -07:00
Priya Wadhwa f92b308f9a Rebased on master 2019-10-28 10:46:35 -07:00
Priya Wadhwa cf62ff62b2 Remove extra log 2019-10-28 10:46:14 -07:00
Priya Wadhwa 7900b63d2b Wait for only apiserver by default
This PR changes --wait=false to be the default, but to still check for the apiserver in this case. If wait=true, we still wait for all pods to be up and running. This change should speed up `minikube start`, since we won't have to wait for other pods which can take a longer time to start up.

Ref #5681
2019-10-28 10:45:57 -07:00
tstromberg b1fd21e118 Do not check sshd for the none driver 2019-10-28 10:35:20 -07:00
Medya Ghazizadeh e2bbf7111e
Merge branch 'master' into NewCmdRunner 2019-10-27 00:18:00 -07:00
Anders F Björklund d635b8dfc7 Add comments as requested by golint 2019-10-26 13:16:29 +02:00
Anders F Björklund c3498c593b Decrease cyclomatic complexity
Mostly by using the "extract method" pattern.

Here is the report (from gocyclo), before:

21 cmd runStart cmd/minikube/cmd/start.go:272:1
18 cmd validateNetwork cmd/minikube/cmd/start.go:982:1
16 cmd runDelete cmd/minikube/cmd/delete.go:90:1
16 cmd deleteProfile cmd/minikube/cmd/delete.go:177:1
2019-10-26 13:08:23 +02:00
Thomas Strömberg 991d84e9f5
Merge pull request #5732 from tstromberg/config-avail
Hide innocuous viper ConfigFileNotFoundError
2019-10-25 12:45:20 -07:00
tstromberg e46502cfed Add automatic selection message even when there is only one choice 2019-10-25 10:53:20 -07:00
tstromberg 416f132ebb Pass --expected-default-driver to the test rather than minikube
Improve VBoxManage detection on Windows

Add missing install_test
2019-10-25 10:43:30 -07:00
tstromberg a7a692d717 Hide viper ConfigFileNotFoundError 2019-10-25 10:37:33 -07:00
Medya Gh ddabc9ef47 remove extra error word 2019-10-24 14:20:07 -07:00
Medya Gh 187dfe29f8 getting rid of some of bin bash -c 2019-10-24 14:13:51 -07:00
tstromberg b0045275a9 Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2 2019-10-24 10:55:40 -07:00
Thomas Stromberg 8920a884c3 Minor improvements to the clarity of hypervisor errors 2019-10-24 07:45:40 -07:00
Thomas Stromberg c925f65629 Warn about driver status, add more logging 2019-10-23 22:33:05 -07:00
tstromberg bdd0f3831f Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2 2019-10-23 22:15:27 -07:00
Thomas Stromberg dcdac36e98 Add integration tests 2019-10-23 21:45:23 -07:00
tstromberg 5d4bf0848f Merge branch 'master' into drv-select2 2019-10-23 14:09:03 -07:00
Thomas Strömberg 98b3aefcac
Merge pull request #5520 from theVDude/config-cleaup
Remove duplicate setting field in config
2019-10-23 11:44:53 -07:00
Thomas Stromberg 443ae74719 Make unit tests pass again 2019-10-23 09:34:32 -07:00
Thomas Stromberg 1fc11f56f1 Add logic for picking the default driver on a host 2019-10-22 20:38:30 -07:00
Thomas Strömberg fbc1630fc5
Merge pull request #5611 from woodcockjosh/json-output-for-status
Add json output for status
2019-10-21 18:37:34 -07:00
Thomas Strömberg 64edf25cd5
Merge pull request #5658 from tstromberg/drv-reorg
Consolidate driver handling code in pkg/minikube/driver
2019-10-21 14:12:20 -07:00
Medya Gh 6faf9cdbe7 lint and code review 2019-10-21 13:01:06 -07:00
Medya Gh 342397ab46 convert more to exec.Command 2019-10-21 11:40:10 -07:00
Thomas Strömberg 026120ab71
Merge pull request #5655 from tstromberg/simpler-kubectl-check
Improve kubectl skew check logic
2019-10-21 11:38:29 -07:00
Medya Gh 6bd5d9b157 Merge remote-tracking branch 'upstream/master' into NewCmdRunner 2019-10-21 11:17:28 -07:00
tstromberg 7581cf3e0c Address merge conflicts 2019-10-21 11:12:06 -07:00
Josh Woodcock ca7d378aaa Change default status output to not include the ip. Simplify json output 2019-10-21 12:50:00 -05:00