Commit Graph

4616 Commits (c92e65ec28290fb5c9ea876583bdf6a685e3828c)

Author SHA1 Message Date
Sharif Elgamal c92e65ec28
Add templating for proper localization (#4677)
* Add templating for proper localization

* Fixing tests for new translation style

* checking errors is important

* fixing more console tests

* good function names make for happy developers

* add test for OutTemplateStyle

* short function names make for happy developers

* better formatting

* more better variable names
2019-07-10 10:17:28 -07:00
Medya Ghazizadeh 57f6d877ed
Merge pull request #4689 from palnabarun/4664-fix
Fixes the issue which caused all containers to be deleted on minikube delete
2019-07-09 15:23:39 -07:00
Thomas Strömberg fc5c01b1f4
Merge pull request #4647 from blueelvis/start-options-documentation
Add documentation for minikube CLI commands
2019-07-09 14:35:32 -07:00
Medya Ghazizadeh 8e0596d2b1
Merge pull request #4692 from josedonizetti/add-kubectl-flag-examples
Add kubectl help examples
2019-07-09 11:02:48 -07:00
josedonizetti cf468bfe63 Add kubectl examples 2019-07-09 05:11:33 -03:00
Medya Ghazizadeh c8b0b41a6b
Merge pull request #4675 from superbrothers/fix-minikube-service
Fix `minikube service` to show error message if service has no node ports
2019-07-08 21:22:58 -07:00
Medya Ghazizadeh bbae91a677
Merge pull request #4715 from medyagh/simpler_issue
reducing issue template complex tags
2019-07-08 10:20:28 -07:00
Medya Gh 21c778e4f4 making issue template less complex 2019-07-08 10:19:03 -07:00
Medya Ghazizadeh de57713a81
Merge pull request #4695 from afbjorklund/gocyclo-delete
Reduce complexity of the delete command
2019-07-07 16:57:02 -07:00
Anders F Björklund dfbf8013ec Reduce complexity of the delete command 2019-07-06 10:14:58 +02:00
Nabarun Pal 67874eee9e
Fixes the issue which caused all containers to be deleted on delete
This change only involves the docker container runtime.
2019-07-05 13:28:19 +05:30
Kazuki Suda 6f96fbaa93 Print information of a service as a table 2019-07-05 15:32:19 +09:00
Medya Ghazizadeh 4e5f173a9c
Merge pull request #4687 from medyagh/move_command_runner
moving command runner to its own package
2019-07-04 23:30:21 -07:00
Medya Ghazizadeh cc9960200f
Merge pull request #4676 from josedonizetti/warn-if-kvm2-version-is-old
Add warn if kvm driver version is old
2019-07-04 22:22:13 -07:00
Medya Ghazizadeh 24bb4f357f
Merge pull request #4685 from afbjorklund/lint-bindata
Make the generated files pass gofmt and golint
2019-07-04 22:21:35 -07:00
Medya Ghazizadeh 11f8c61604
Merge pull request #4678 from kairen/delete-kubeconfig
Delete kubeconfig context when a machine has been deleted
2019-07-04 22:09:44 -07:00
Medya Gh 99ac1a81e7 moving command runner to its own package 2019-07-04 16:31:07 -07:00
Medya Ghazizadeh b1648ca2e4
Merge pull request #4682 from afbjorklund/kubelet-containerd
Fix systemd dependencies when using containerd
2019-07-04 14:58:01 -07:00
Anders F Björklund 801cd01ada Make the go-bindata generated code pass gofmt -s
But don't abort the build if gofmt is not installed.
2019-07-04 22:57:05 +02:00
Anders F Björklund c41dac7a21 Avoid lint warning with the generated translations
golint wants "Json" to be properly spelled as "JSON"

Note that the sed syntax varies between GNU and BSD.
2019-07-04 22:51:26 +02:00
josedonizetti 4cce597c9d Add upgrade section kvm documentation 2019-07-04 17:27:44 -03:00
josedonizetti 9210b96ee8 Add upgrade documentation to kvm version warn 2019-07-04 17:25:56 -03:00
josedonizetti 5f84ae3cd2 Add extractVMDriverVersion documentation 2019-07-04 17:25:56 -03:00
josedonizetti d7a30e118f Fix start_test.go copyright 2019-07-04 17:25:56 -03:00
josedonizetti f61d62647a Add comment about kvm2 force upgrade 2019-07-04 17:25:56 -03:00
josedonizetti dabf272f33 Add warn if kvm driver version is old 2019-07-04 17:25:56 -03:00
Anders Björklund db7edc5e68 Update docs remove duplicate markdown headers (mdlint) (#4683) 2019-07-04 13:23:52 -07:00
Anders F Björklund fa3bc63757 Fix systemd dependencies when using containerd
There is a template bug in the kubelet.service creation,
which causes it to start dockerd instead of containerd.
2019-07-04 20:09:49 +02:00
Kyle Bai 6505dfad62 Delete kubeconfig when a machine has been deleted 2019-07-04 14:47:41 +08:00
Kazuki Suda 7d510c47b1 Fix `minikube service` to show error message if service has no node ports 2019-07-04 00:29:30 +09:00
Medya Ghazizadeh 68c546ff1d
Merge pull request #4645 from josedonizetti/fix-profile-flag-indentation
Fix profile flag documentation indentation
2019-07-02 19:06:13 -07:00
Medya Ghazizadeh e88e302405
Merge pull request #4663 from afbjorklund/driver-commit
Pass the git commit to the kvm docker build
2019-07-02 10:59:35 -07:00
Anders F Björklund ab1c4e3cc0 Pass the git commit to the kvm docker build
Since there is no git in the build container
2019-07-02 19:51:38 +02:00
Medya Ghazizadeh d0ae1a5910
Merge pull request #4659 from medyagh/sudo_none
exit and warn if none driver is run by not-root user
2019-07-01 21:38:05 -07:00
Medya Gh d269afef16 better format message 2019-07-01 18:27:00 -07:00
Medya Gh c8876b4675 Exit if none is run without sudo 2019-07-01 18:24:17 -07:00
josedonizetti 18d8ecf519 Simplify `-p` documentation 2019-07-01 18:46:38 -03:00
Medya Ghazizadeh 124b845b60
Merge pull request #4644 from josedonizetti/prefix-kvm-only-flags
Add kvm prefix to flags only used by kvm
2019-07-01 14:43:05 -07:00
Medya Ghazizadeh 2aac268ba6
Merge pull request #4593 from josedonizetti/add-hyperkit-version
Add version to hyperkit driver
2019-07-01 14:38:30 -07:00
Medya Ghazizadeh cdf895f81b
Merge pull request #4654 from medyagh/issue_template_improved_international
adding an improved foldable issue page
2019-07-01 00:02:58 -07:00
Medya Gh 91e293f6e9 adding an improved foldable issue page 2019-07-01 00:02:32 -07:00
Medya Ghazizadeh 30157d0dbb
Merge pull request #4652 from medyagh/issue_template_improved
improve github issues tempalte
2019-06-30 23:52:24 -07:00
Medya Gh 61c2805520 improve github issues tempalte 2019-06-30 23:51:52 -07:00
Medya Ghazizadeh 9ee0bdff5e
Merge pull request #4650 from medyagh/issue_pre
making issues log output collapsable
2019-06-30 23:38:41 -07:00
Medya Gh 8b849c97ce making issues log output collapsable 2019-06-30 23:38:11 -07:00
Medya Ghazizadeh 449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check
Added validation for start memory size
2019-06-30 15:17:28 -07:00
Jituri, Pranav 201e4e4bbd First pass of CLI documentation 2019-07-01 03:30:50 +05:30
Medya Ghazizadeh 037e9a5d56
Merge pull request #4641 from josedonizetti/improve-kvm-connection-error-message
Improve kvm connection error message
2019-06-30 12:08:44 -07:00
Medya Ghazizadeh 5a3992b00f
Merge pull request #4642 from josedonizetti/fix-error-naming-convention
Fix error naming convention
2019-06-30 12:06:21 -07:00
josedonizetti a7feb232a1 Fix profile flag documentation indentation 2019-06-29 12:38:32 -03:00