b777d97d76
refactor more
2020-04-06 18:58:42 -07:00
bee681559b
save profile
2020-04-06 18:58:42 -07:00
a35006507b
add new func updateExistingConfigFromFlags
2020-04-06 18:58:42 -07:00
792ca63179
respect the user existing config
2020-04-06 18:58:42 -07:00
eb42d16087
actually error out when driver is specified
2020-04-06 13:51:30 -07:00
78595b13dc
split out node provisioning and starting kubernetes
2020-04-06 11:45:42 -07:00
7d1d965faa
Merge branch 'master' of https://github.com/kubernetes/minikube into generate-docs
2020-04-06 10:26:19 -07:00
f290aa9c3c
Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback
2020-04-06 10:25:20 -07:00
fb2c3ed4b7
fix validateDriver() to exit when detects an error
2020-04-06 23:45:54 +09:00
77d1da04a2
change log level for err
2020-04-03 18:48:39 -07:00
4221e63e13
add logs for wait components
2020-04-03 18:43:37 -07:00
3d037a8871
only failback to next driver if provisioning fails
2020-04-03 17:46:42 -07:00
74551841cc
address review comments
2020-04-02 23:41:45 -07:00
62ca22a662
refactor and rebase
2020-04-02 18:58:51 -07:00
9fc36a6d4e
typo
2020-04-02 17:55:15 -07:00
d6b3cc6109
lint
2020-04-02 17:55:15 -07:00
4c8f79d823
add wait logic to kubeadm
2020-04-02 17:55:15 -07:00
3b39b271ac
fix interpret wait
2020-04-02 17:54:14 -07:00
e4eae47e86
interpret wait flags
2020-04-02 17:54:14 -07:00
31f225d90e
fix lint
2020-04-02 15:16:11 -07:00
b66447ea13
remove random failure for testing
2020-04-02 14:48:28 -07:00
dd957ff2f7
make sure to print error on failure
2020-04-02 14:47:18 -07:00
af8d01d83d
Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback
2020-04-02 14:40:33 -07:00
26c747137e
failback to alternate drivers if startup fails with automatic choice
2020-04-02 14:36:46 -07:00
37a98106c4
Merge pull request #7382 from tstromberg/stderr-fix3
...
Move errors and warnings to output to stderr
2020-04-02 14:36:16 -07:00
78ecf53d40
Merge pull request #7360 from tstromberg/wrong-url
...
Correct assumptions for forwarded hostname & IP handling
2020-04-02 14:33:48 -07:00
5b3834ec63
Merge to master
2020-04-02 12:39:32 -07:00
7004c398b0
Don't generate documentation for hidden commands
2020-04-02 12:05:27 -07:00
cd81888a22
Merge branch 'master' of https://github.com/kubernetes/minikube into generate-docs
2020-04-02 11:09:56 -07:00
7988704bed
fixups
2020-04-02 11:01:26 -07:00
d578626079
delete unneeded files
2020-04-02 10:50:14 -07:00
6fdecf2ebf
Add unit test to check that docs are up to date
...
This requires the following changes:
1. We need to pass in -ldflags to `go test`, since we need to know the curren iso version to correctly generate the description for --iso-url
2. We need to rewrite the description of the --driver flag on `minikube start` because it is operating system specific, which doesn't make sense for our documentation
2020-04-02 10:48:47 -07:00
5307145802
Move errors and warnings to output to stderr
2020-04-02 09:58:13 -07:00
357b5bb28c
Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback
2020-04-02 08:57:34 -07:00
a71edc3920
Merge branch 'master' into wrong-url
2020-04-02 08:32:54 -07:00
e09a1221bb
Add rejection reason to 'unable to find driver' error
2020-04-02 06:20:35 -07:00
0357c89ee5
add issue to todo comment
2020-04-01 17:35:41 -07:00
ac1b3b0c59
merge
2020-04-01 17:32:36 -07:00
c409c4c91c
Add unit tests to make sure docs are up to date
2020-04-01 16:13:54 -07:00
a9dcfe82fe
Update generate-docs command
...
Now, generate-docs will compile all subcommands for one command into one document instead of creating a document per subcommand.
For example, instead of creating:
minikbue_addons_enable.md
minikbue_addons_disable.md
it will now create
addons.md
which will include subsections for `minikube addons enable` and `minikube addons disable`.
2020-04-01 15:59:33 -07:00
4df145518a
Merge branch 'master' of github.com:kubernetes/minikube into delete-on-failure
2020-04-01 15:24:38 -07:00
5306702515
Merge pull request #7363 from tstromberg/stop-harder
...
Extend maximum stop retry from 30s to 120s
2020-04-01 14:43:14 -07:00
428e6bd285
Merge pull request #7325 from afbjorklund/version-options
...
Implement options for the minikube version command
2020-04-01 14:41:00 -07:00
64bd8dee8b
Merge pull request #7299 from afbjorklund/dashboard-kubectl
...
Run dashboard with internal kubectl if not in path
2020-04-01 14:40:23 -07:00
b71126356f
Extend maximum stop retry from 30s to 120s
2020-04-01 14:24:53 -07:00
a24ae23024
Merge pull request #7356 from afbjorklund/kubectl-version
...
Use kubectl version --short if --output=json fails
2020-04-01 14:17:52 -07:00
96a87e89cf
Remove IP check, because it's wrong on Docker
2020-04-01 13:53:17 -07:00
c76fac7d74
Standardize port-forwarding and kubeconfig hostname logic, fix Docker Linux IP
2020-04-01 11:57:32 -07:00
d8151730f4
retry anytime node.Start fails, not just in minikube start
2020-04-01 11:00:39 -07:00
592bb2e9eb
Merge pull request #7310 from tstromberg/wrong-url
...
mustload: Replace DriverIP with Forwarded(IP|Port)
2020-04-01 08:29:12 -07:00
227fec14ae
Use kubectl version --short if --output=json fails
...
Really old kubernetes clients did not have the --output parameter
Show a friendly reminder to upgrade, instead of an error message.
2020-04-01 17:19:14 +02:00
28ec78a5cb
lint - add newline after stdlib imports
2020-04-01 05:54:23 -07:00
673922c8d3
code comments
2020-03-31 15:38:59 -07:00
fcb5c462f4
add delete-on-failure flag
2020-03-31 15:06:16 -07:00
fd3e0f505a
clean up minikube start output
2020-03-30 15:31:17 -07:00
a1cc3188bb
Implement options for the minikube version command
...
Add --short and --output options, just like kubectl
2020-03-30 22:19:39 +02:00
5f9515040d
Run dashboard with internal kubectl if not in path
...
If "kubectl" is not in the PATH, then use the same cached binary
as with the "minikube kubectl" command (version matching cluster).
2020-03-30 18:34:20 +02:00
7f5f12c5f4
Get rid of DriverIP attr to prevent future misuse
2020-03-29 11:44:25 -07:00
063077c712
mustload: Check apiserver status using forwarded IP/port
2020-03-29 11:34:21 -07:00
c57375c486
Remove load balancer start/end IP from start flags
2020-03-29 12:53:25 +08:00
30f0882418
Fixes MachineProfile no longer exist
2020-03-29 11:45:53 +08:00
9adb1bc399
Merge remote-tracking branch 'origin/master' into metallb
2020-03-29 11:31:56 +08:00
377a4746f9
Allows to configure load balancer start/end IP
2020-03-29 11:20:59 +08:00
1f31d25c16
Use LookPath to verify conntrack install
2020-03-28 13:19:48 -07:00
801d49afd0
Merge pull request #7292 from linkvt/fix-missing-global-options
...
Show all global flags in options command
2020-03-27 22:13:07 -07:00
da1d411e30
Merge pull request #6879 from prasadkatti/populate_target_port_in_svc_list
...
service list: populate target port
2020-03-27 22:12:18 -07:00
2420bb1f3a
Show all global flags in cli options help
...
Before this fix the flags shown in `minikube options` were taken from a
list of options (`viperWhiteList`) which seems arbitrary.
I still don't know for sure why this is done but taking all
PersistentFlags (persistent=apply to all sub commands) from the root
command seems like the correct way.
2020-03-27 21:31:38 +01:00
46e87ba054
Merge pull request #7219 from sharifelgamal/cluster-name
...
Get rid of ClusterNameFromMachine
2020-03-25 18:33:48 -07:00
53b9d720e7
Merge pull request #7230 from tstromberg/hugo-switch
...
Make recreateIfNeeded more robust, improve UX
2020-03-25 18:28:07 -07:00
dc7bdecda4
Merge branch 'master' of github.com:kubernetes/minikube into cluster-name
2020-03-25 15:43:12 -07:00
f84569aab0
Make crazy cluster_test / mock_driver combination pass tests
2020-03-25 14:46:44 -07:00
5a316b3bf9
Merge pull request #7068 from vikkyomkar/issue-7067
...
Add --vm flag for users who want to autoselect only VM's
2020-03-25 12:44:16 -07:00
5689d3b8e1
Merge pull request #7210 from priyawadhwa/issue-7184
...
Fix TestStartStopWithPreload bug
2020-03-24 22:42:33 -07:00
5ea20f5a06
Merge pull request #7212 from linkvt/kubernetes-parameters-latest-stable
...
Add 'stable' and 'latest' as valid kubernetes-version values
2020-03-24 22:37:53 -07:00
646609ec30
review comments
2020-03-24 21:24:43 -07:00
28672dec78
remove ClusterNameFromMachine
2020-03-24 14:43:11 -07:00
3ad1dfb4bb
Add 'stable' and 'latest' as valid kubernetes-version values
2020-03-24 21:50:28 +01:00
2933953cfa
use mustload
2020-03-24 13:18:59 -07:00
e3bcdbf42a
fix validateSpecificDriver error message
2020-03-24 12:55:31 -07:00
5ef83f35e2
Add --preload flag to optionally turn off preload
2020-03-24 10:53:02 -07:00
587154196e
Merge pull request #7173 from medyagh/stop_kic
...
stop kubernetes containers on stopping docker/podman driver
2020-03-24 05:42:49 -07:00
20991ac336
Merge pull request #7183 from sharifelgamal/conntrack-msg
...
add friendly error message for missing conntrack
2020-03-23 23:03:09 -07:00
5f90a319bd
stop k8s in kic and none
2020-03-23 21:01:12 -07:00
8489c074fe
code cleanup
2020-03-23 20:46:51 -07:00
ca3f88a734
comment
2020-03-23 20:19:07 -07:00
4ab849b604
shorter variable names
2020-03-23 20:18:03 -07:00
8b58738491
check for conntrack at start time, remove useless solution message
2020-03-24 02:54:47 +00:00
fcb8736cf7
merge to master
2020-03-23 17:30:06 -07:00
93021fbfda
Merge pull request #7174 from afbjorklund/xdg-open
...
Centralize the handling of browser.OpenURL
2020-03-23 17:12:38 -07:00
16e18724e2
Dedup ExampleCmd, fix command flag ordering
2020-03-23 16:28:39 -07:00
b99e943684
Improve minikubeCmd, promote to public function
2020-03-23 16:00:53 -07:00
c50cfc99fa
Merge pull request #7158 from kubernetes/driver-confusion
...
Consistently detect old driver when existing.Driver is unset
2020-03-23 16:00:17 -07:00
673341ce35
Improve hostDriver comment
2020-03-23 15:51:02 -07:00
81393a0bc3
Add boilerplate
2020-03-23 14:39:49 -07:00
b9049288fd
Improve experience for paused cluster
2020-03-23 14:25:59 -07:00
0ce81acbf4
Centralize the handling of browser.OpenURL
...
So we can catch when xdg-open not installed
2020-03-23 21:49:19 +01:00
b8c7638976
Add flag functions
2020-03-23 13:17:34 -07:00
77f97a58f4
Fix uninitalized variable
2020-03-23 13:16:37 -07:00
8f9a2b9413
Consolidate cluster loading from cmd
2020-03-23 12:51:49 -07:00
14f8ee3984
hyperv Delete: call StopHost before removing VM
2020-03-23 09:41:00 -07:00
a55573be12
Fix results when existing is nil
2020-03-23 08:33:49 -07:00
b47cd9c0cb
Consistently detect old driver when existing.Driver is unset
2020-03-23 08:11:45 -07:00
cf887e7a1a
Merge pull request #7105 from prasadkatti/add_desc_node_to_minikube_logs
...
Add kubectl desc nodes to minikube logs
2020-03-21 15:13:12 -07:00
376271afca
Merge branch 'master' into add_desc_node_to_minikube_logs
2020-03-21 12:27:17 -07:00
001f7fde92
Merge to master
2020-03-21 10:56:52 -07:00
69545496c9
Merge pull request #5844 from rajula96reddy/issue-5836
...
Prevent minikube from crashing if namespace or service doesn't exist
2020-03-21 10:26:45 -07:00
a880bb706b
Merge branch 'master' into add_desc_node_to_minikube_logs
2020-03-20 22:48:42 -07:00
c3ffe98943
Merge master
2020-03-20 20:21:57 -07:00
986679bc8d
Merge pull request #6787 from sharifelgamal/m2
...
Implement multi-node cluster capabilities
2020-03-20 19:26:56 -07:00
df80a60622
Merge branch 'master' into add_desc_node_to_minikube_logs
2020-03-20 16:46:34 -07:00
6de56d3a7a
Merge branch 'master' into better-fixhost
2020-03-20 15:37:07 -07:00
4faa31ebcf
Add logic to get desc node output in bootstrapper LogCommands func
2020-03-20 14:56:04 -07:00
35aec77fe4
code comments
2020-03-20 14:07:43 -07:00
4c00ae01ed
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-20 12:43:11 -07:00
bb387039d1
move panic out of library
2020-03-20 11:29:36 -07:00
bb0511c5c8
Merge branch 'master' into better-fixhost
2020-03-20 07:30:48 -07:00
729642ef33
Merge pull request #7112 from tstromberg/apiserver-always
...
Improve error when docker-env is used with non-docker runtime
2020-03-19 20:24:31 -07:00
6a6b77a161
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-19 18:18:03 -07:00
5cd7660d1e
fixHost: only reprovision if necessary, and only once
2020-03-19 17:44:21 -07:00
dadf4bd35d
Improve error message when docker-env is used with an incompatible runtime
2020-03-19 14:04:40 -07:00
39b5c534ab
Add warning if both vm-driver and driver are specified
2020-03-19 12:08:34 -07:00
f9b38dc04e
clean up status output and have multinode survive cluster restarts
2020-03-18 21:28:03 -07:00
9420a941f9
Remove false positives
2020-03-18 16:22:23 -07:00
a24aa5dff7
dramatically simplify start code path
2020-03-18 15:04:56 -07:00
ff8ae7311c
If user doesn't specify driver, don't validate against existing cluster
2020-03-18 12:27:17 -07:00
ce1cc8d34c
Merge pull request #7054 from afbjorklund/image-mirror-version-parse
...
Strip the version prefix before calling semver
2020-03-18 08:10:38 -07:00
3f6d32aff8
Merge pull request #7080 from priyawadhwa/ignores-driver
...
Move some of the driver validation before driver selection
2020-03-18 07:56:25 -07:00
dd707820fc
If memory is specified in config, suggest that for memory allocation
2020-03-17 18:07:48 -07:00
d5490a8fb8
Move driver validation before driver selection
...
If a user passes in a driver via --vm-driver or --driver, then we should make sure it matches the preexisting cluster (if one exists) before we try and get information about the driver. This avoids confusing logs where we tell the user we're using the preexisting driver but then error out because they specified a different driver.
2020-03-17 16:04:43 -07:00
66a6f4e906
fix docker status
2020-03-17 12:28:44 -07:00
e053e4f235
Add --vm flag for users who want to autoselect only VM's
2020-03-17 13:21:05 +05:30
f99d335fed
fix docker driver
2020-03-16 15:36:05 -07:00
74b1f34715
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-16 10:01:38 -07:00
dc6b9bae2b
Add basic unit test for image mirror country
2020-03-15 13:47:56 +01:00
e7af223d72
Strip the version prefix before calling semver
2020-03-15 12:31:14 +01:00
bf1b6d799c
Merge pull request #7048 from afbjorklund/reportcard-1.8.2
...
Improve reportcard for the v1.8.2 release
2020-03-14 19:22:24 -07:00
f54af5d684
function name HostPortBinding changed to ForwardedPort
2020-03-14 21:28:12 +05:30
5987a390e7
Improve reportcard for the v1.8.2 release
...
gofmt: 99%
pkg/minikube/docker/store_test.go
Line 1: warning: file is not gofmted with -s (gofmt)
golint: 99%
pkg/minikube/cruntime/docker.go
Line 40: warning: exported type ErrISOFeature should have comment or be unexported (golint)
Line 44: warning: exported function NewErrISOFeature should have comment or be unexported (golint)
gocyclo: 99%
cmd/minikube/cmd/start.go
Line 801: warning: cyclomatic complexity 18 of function generateCfgFromFlags() is high (> 15) (gocyclo)
2020-03-14 14:25:50 +01:00
75ba4c27df
Merge pull request #7043 from tstromberg/lz4-missing
...
Delete: output underlying status failure, better machine function names
2020-03-13 18:38:24 -07:00
c3b56b6466
let's rearrange a bunch of code
2020-03-13 18:08:10 -07:00
b0e4b32805
Correct name variable
2020-03-13 16:00:30 -07:00
9fa98a834b
status: properly state if cluster does not exist
2020-03-13 15:58:14 -07:00
196a8d7b82
Delete: output underlying status failure, refactor wordy code
2020-03-13 15:51:03 -07:00
d98ebcfb68
lint
2020-03-13 15:32:14 -07:00
36089037d9
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-13 15:24:07 -07:00
a9b73b8ba3
fixing up minikube start path
2020-03-13 15:03:19 -07:00
d81ba5b5cb
Don't skip the check for too old versions for new
...
Even when starting a new profile, we still need to check the
k8s version parameter against the oldest supported version...
This helps guard against accidental errors like confusing the
kubernetes version (v1.17.3) with the minikube version (v1.8.1)
2020-03-13 12:39:32 +01:00
3ed818c488
cosmetic fixes
2020-03-12 15:40:13 -07:00
a29c5739ab
Merge pull request #6988 from tstromberg/v1.18.0-beta
...
Update NewestKubernetesVersion to 1.18.0-beta.2
2020-03-11 17:00:35 -07:00
2412dd5331
Merge pull request #6998 from tstromberg/kubectl-mismatch
...
Improve kubectl mismatch UI for clarity
2020-03-11 15:42:12 -07:00
Medya Gh
Sharif Elgamal
Priya Wadhwa
loftkun
Thomas Strömberg
Medya Ghazizadeh
Anders F Björklund
Zhongcheng Lao
Vincent Link
Thomas Stromberg
Prasad Katti
vikkyomkar