Sharif Elgamal
ed42a7bcf8
Upgrade gcp-auth-webhook to v0.0.6
2021-06-15 14:36:38 -07:00
Ilya Zuyev
1e68bcb3ae
Improve containerd version check. Add user advice
2021-06-15 14:27:38 -07:00
Ilya Zuyev
dd5d8a36e6
check container runtime version for upgrades
2021-06-14 18:28:53 -07:00
Ilya Zuyev
9d65d85314
more debug stuff
2021-06-11 18:16:13 -07:00
Ilya Zuyev
9d64921653
more debug stuff
2021-06-11 16:09:57 -07:00
Ilya Zuyev
78a07e71bb
Add debug log
2021-06-11 13:57:34 -07:00
minikube-bot
9d94dcb734
Updating ISO to v1.21.0-1623378770-11632
2021-06-11 03:27:59 +00:00
Ilya Zuyev
e6cd1d5b1c
Restore containerd config
2021-06-10 19:22:33 -07:00
Andriy Dzikh
806d899988
Add timeout to apiserver health check.
2021-06-10 14:41:32 -07:00
ilya-zuyev
e37f4e4014
Revert "Restore "containerd: upgrade io.containerd.runtime.v1.linux to io.containerd.runc.v2 (suppot cgroup v2)""
2021-06-09 15:26:01 -07:00
minikube-bot
64a41824c5
Update kicbase to v0.0.23
2021-06-09 00:28:52 +00:00
Sharif Elgamal
f78f6afe16
Merge pull request #11601 from spowelljr/fixLog
...
Prevent misleading "save to tar file succeeded" message from being logged
2021-06-08 13:12:41 -07:00
Ilya Zuyev
6261f9d400
Add an exception for 'latest' images
2021-06-07 17:41:50 -07:00
Steven Powell
b4cc318d85
reword warning message
2021-06-07 17:16:29 -07:00
Ilya Zuyev
557d3a5504
fix kicbase cache check
2021-06-07 16:37:04 -07:00
Steven Powell
103d7a6836
removed return from else
2021-06-07 16:31:26 -07:00
Steven Powell
01221e0566
prevent misleading message from being logged
2021-06-07 15:09:08 -07:00
JacekDuszenko
b7a6dd0b5e
implement embed certs global config as EmbedCerts
2021-06-05 23:59:45 +01:00
Ilya Zuyev
6ed370502f
Merge branch 'master' into ilyaz/fix_ctrd
2021-06-04 10:27:41 -07:00
JacekDuszenko
934ac1f109
add json deserialization to embed-certs from global config
2021-06-04 00:05:37 +01:00
Ilya Zuyev
fa2ba4ad19
Trigger build
2021-06-03 16:04:54 -07:00
Sharif Elgamal
47dbbd58f0
Merge pull request #11454 from janisz/fix_extract_error
...
bug: return error on invalid function name in extract.TranslatableStrings
2021-06-02 13:51:03 -07:00
Sharif Elgamal
d76259e86f
Merge pull request #11528 from andriyDev/FixDownloadOnlyTest2
...
Change PreloadExists to report no preload for BareMetal drivers
2021-06-02 12:59:15 -07:00
Medya Ghazizadeh
1bacef6268
Merge pull request #11482 from spowelljr/coreDNSEntryGoFunc
...
Run addCoreDNSEntry in Go func
2021-06-02 12:43:10 -07:00
Medya Ghazizadeh
1b0e6f1827
Merge pull request #11559 from medyagh/img_sha
...
try image without sha before failing
2021-06-02 12:25:32 -07:00
Ilya Zuyev
1cd44ce936
Fix cgroups setting
2021-06-01 22:53:20 -07:00
Ilya Zuyev
1fdd9356aa
Fix cgroups setting
2021-06-01 22:50:17 -07:00
Medya Ghazizadeh
0b83c00ef2
Merge pull request #11525 from medyagh/bump_k8s
...
bump default k8s version and newest
2021-06-01 17:53:54 -07:00
Ilya Zuyev
0096815f3c
Restore config
2021-06-01 17:29:49 -07:00
Medya Gh
853f1cb4db
first try gcr
2021-06-01 15:16:17 -07:00
Medya Gh
2f4b7985c0
try image without sha before failing
2021-06-01 15:11:01 -07:00
Andriy Dzikh
524b2f9987
Move driverAllowPreload to driver.AllowPreload.
2021-06-01 13:35:40 -07:00
Andriy Dzikh
62f172b0b0
Return false from PreloadExists when driver is ssh.
2021-05-27 15:57:48 -07:00
Medya Ghazizadeh
0de4580089
Merge pull request #11529 from spowelljr/breakdownGuesetStart
...
Broke down GUEST_START error code
2021-05-27 15:54:13 -07:00
Steven Powell
c1b044d0d4
remove GUEST_CERTS_EXPIRED error
2021-05-27 15:15:33 -07:00
Steven Powell
8ce4e36295
improved regex
2021-05-27 15:06:24 -07:00
Sharif Elgamal
31417806b7
Merge pull request #11486 from sharifelgamal/gcp-auth-restart
...
gcp-auth addon: do not reapply gcp-auth yamls on minikube restart
2021-05-27 15:05:34 -07:00
Andriy Dzikh
f9f3ef9a09
Pass driverName into Preload and PreloadExists to report no preload for BareMetal.
2021-05-27 15:02:00 -07:00
Andriy Dzikh
a8136ec322
Move InstallOrUpdate to its own package.
2021-05-27 15:01:58 -07:00
Steven Powell
5be0d5fe9f
broke down GUEST_START error code
2021-05-27 14:42:52 -07:00
Medya Gh
c944930310
unit test
2021-05-27 13:09:17 -07:00
Medya Ghazizadeh
89604fcbce
Merge pull request #11516 from medyagh/disable_docker
...
Disable Non-Active Containers Runtimes
2021-05-27 13:07:43 -07:00
Medya Gh
7f528a4061
bump default k8s version and newest
2021-05-27 12:57:23 -07:00
Sharif Elgamal
a790bd1361
better wrapper name
2021-05-27 10:35:30 -07:00
Sharif Elgamal
ad1fc0b8fe
wrap pull secret error
2021-05-27 10:22:42 -07:00
Sharif Elgamal
469d0d5206
Merge branch 'master' of github.com:kubernetes/minikube into anders-kicbase-load
2021-05-27 10:13:16 -07:00
Medya Ghazizadeh
1c1e447348
Merge pull request #11461 from andriyDev/RepeatBinaryDownloads
...
Prevent downloading duplicate binaries already present in preload
2021-05-26 18:25:40 -07:00
Medya Gh
631a661e47
comment
2021-05-26 17:58:58 -07:00
Medya Gh
569b5ce232
more comment
2021-05-26 17:58:58 -07:00
Medya Gh
cecef71f51
disable docker service when containerd
2021-05-26 17:58:58 -07:00
ilya-zuyev
51aa548e23
Merge pull request #11509 from kubernetes/revert-11325-cgroup2
...
Revert "containerd: upgrade `io.containerd.runtime.v1.linux` to `io.containerd.runc.v2` (suppot cgroup v2)"
2021-05-26 16:52:37 -07:00
Steven Powell
99b3212b83
change klog error to warning
2021-05-26 10:26:26 -07:00
Steven Powell
d3a4f9b2f2
add back klog logging
2021-05-26 10:23:48 -07:00
Medya Ghazizadeh
b1ce37b7b5
Merge pull request #11469 from utkarsh-pro/utkarsh-pro/fix/11171
...
Support setting addons from environmental variables
2021-05-26 10:19:22 -07:00
Medya Ghazizadeh
791c941358
Merge pull request #11451 from dinever/fix-test-download
...
Ensure download_test doesn't hit GCR by using mocked getChecksum func
2021-05-26 10:18:08 -07:00
Sharif Elgamal
643cfb91f4
fix last bool
2021-05-26 09:33:33 -07:00
Sharif Elgamal
6db4a51cbb
swap to --refresh
2021-05-26 09:26:10 -07:00
Medya Ghazizadeh
9fa57e09cf
Revert "containerd: upgrade `io.containerd.runtime.v1.linux` to `io.containerd.runc.v2` (suppot cgroup v2)"
2021-05-25 19:41:10 -07:00
Andriy Dzikh
89a6820936
Remove iota from all except first preload enum.
2021-05-25 17:36:46 -07:00
Andriy Dzikh
9638241aeb
Rename preload enum and use iota for values.
2021-05-25 16:31:32 -07:00
Sharif Elgamal
a823439257
allow pods to be refreshed
2021-05-25 13:43:25 -07:00
Andriy Dzikh
38a60356e0
Add comments to each enum value.
2021-05-25 13:04:14 -07:00
Medya Ghazizadeh
08a7f20dea
Merge pull request #11481 from medyagh/guest_pro_docker
...
Unique exit code for when container exists prematurely
2021-05-25 12:40:04 -07:00
Medya Ghazizadeh
b3541115b2
Merge pull request #11478 from sharifelgamal/error-codes
...
Add list of error codes to documentation
2021-05-24 15:25:58 -07:00
Tomasz Janiszewski
7e05765aa4
fix: return error on invalid function name
...
> Wrap returns an error annotating err with a stack trace at the point Wrap is called,
and the supplied message. If err is nil, Wrap returns nil.
https://pkg.go.dev/github.com/pkg/errors#Wrap
2021-05-22 10:07:26 +02:00
Peixuan Ding
b9292bde0d
Add mock for getChecksum
2021-05-22 02:05:12 -04:00
Peixuan Ding
5cf72b6eab
Ignore error in test when there is no generated preload version
2021-05-22 01:50:44 -04:00
Sharif Elgamal
86f9feb535
do not reapply gcp-auth yamls on minikube restart
2021-05-21 17:04:49 -07:00
Sharif Elgamal
efeeca0134
better formatting still
2021-05-21 14:30:52 -07:00
Sharif Elgamal
300e51da4a
fix newlines some more
2021-05-21 14:12:38 -07:00
Medya Gh
6cb7c2166c
spell
2021-05-21 14:09:42 -07:00
Steven Powell
9de7d2da57
improve error message
2021-05-21 14:08:32 -07:00
Sharif Elgamal
62ea4fdfea
fix newlines
2021-05-21 14:03:14 -07:00
Sharif Elgamal
1638cceed2
fix formatting
2021-05-21 13:52:35 -07:00
Steven Powell
9a529acdcd
run addCoreDNSEntry in Go func
2021-05-21 13:50:20 -07:00
Sharif Elgamal
f1e40b6e77
add error strings to doc
2021-05-21 13:45:38 -07:00
Medya Gh
9c9934879c
break guest provision when container exists prematurely
2021-05-21 13:34:34 -07:00
Medya Ghazizadeh
9db3ae665c
Merge pull request #11325 from AkihiroSuda/cgroup2
...
containerd: upgrade `io.containerd.runtime.v1.linux` to `io.containerd.runc.v2` (suppot cgroup v2)
2021-05-21 13:31:22 -07:00
Medya Ghazizadeh
3f2170bb51
Merge pull request #11472 from andriyDev/ErrorCodes
...
Use DRV_NOT_HEALTHY when at least one driver is installed but unhealthy
2021-05-21 11:33:23 -07:00
Sharif Elgamal
e89aca810a
Add list of error codes to documentation
2021-05-21 11:07:59 -07:00
Andriy Dzikh
d59570c1f0
Add DRV_DOCKER_NOT_RUNNING error for cases where specifically docker fails.
2021-05-21 09:43:04 -07:00
Medya Ghazizadeh
d0d62a90e5
Merge pull request #11334 from daehyeok/close_asset
...
Add `Close() error` function into assets.CopyableFile
2021-05-21 09:23:41 -07:00
Utkarsh Srivastava
aa99526399
change variable name from addonList to addonListFlag
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-21 13:39:05 +05:30
Daehyeok Mun
d6691e796c
Add `Close() error` function into assets.CopyableFile
...
Add `Close` function and implemetions to explicitly close os.File which opend by
NewFileAsset.
2021-05-20 21:05:09 -07:00
Andriy Dzikh
ab80af497e
Create error code for found, but unhealthy drivers.
2021-05-20 14:03:08 -07:00
Andriy Dzikh
9692cae437
Add caching to PreloadExists to improve performance.
2021-05-20 13:19:58 -07:00
Andriy Dzikh
8882de007b
Add check to allow downloading of listed binaries if preload is missing.
2021-05-20 10:33:06 -07:00
Andriy Dzikh
b441330f7e
Create unit test for excluding binaries from caching.
2021-05-20 10:18:50 -07:00
Andriy Dzikh
9fb9e940f1
Prevent `minikube start --download-only` from downloading binaries that are part of the Kubernetes release binaries.
2021-05-20 10:18:22 -07:00
Utkarsh Srivastava
69b30c06df
change variable name from addonListName to addonList
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 22:25:38 +05:30
Utkarsh Srivastava
5a3843b074
replace addonList variable with viper provided data
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 21:39:07 +05:30
Medya Ghazizadeh
316f5ea3b2
Merge pull request #11432 from andriyDev/CustomAddonImages
...
Persist custom addon image/registry settings.
2021-05-19 18:30:14 -07:00
Andriy Dzikh
df32362a7f
Add comments to types.go for CustomAddonImages/CustomAddonRegistries.
2021-05-19 15:26:28 -07:00
Sharif Elgamal
5b512a7296
Merge branch 'master' of github.com:kubernetes/minikube into error-codes
2021-05-19 15:26:11 -07:00
Sharif Elgamal
ef304f7c05
add error codes file
2021-05-19 15:25:45 -07:00
Andriy Dzikh
88205c2e65
Allow download_test to mock checksum retrieval.
2021-05-19 09:54:03 -07:00
Andriy Dzikh
6c3113706e
Create unit tests for new utility functions in pkg/minikube/assets/addons.go.
2021-05-18 14:10:39 -07:00
Andriy Dzikh
040e7e7a8d
Persist custom addon image settings.
2021-05-18 14:10:37 -07:00
Andriy Dzikh
7684a14e1a
Move (custom) image selection to its own function.
2021-05-18 14:09:03 -07:00
Andriy Dzikh
62b2c94c0f
Refactor assets/addons.go to de-dupe map parsing.
2021-05-18 14:09:03 -07:00
Medya Ghazizadeh
4f345f2b8f
Merge pull request #11426 from afbjorklund/images-versions
...
Update the bootstrapper images for k8s 1.21
2021-05-18 12:23:43 -07:00
Medya Ghazizadeh
adbcae1848
Merge pull request #11410 from r4j4h/upgrade-metallb-addon-metallb-version
...
metallb-addon: Update metallb from 0.8.2 to 0.9.6
2021-05-18 11:43:13 -07:00
Medya Ghazizadeh
8f85fd9751
Merge pull request #11438 from medyagh/autopause-vm
...
Fix auto-pause on VMs (detect right control-plane IP)
2021-05-18 09:18:33 -07:00
Medya Ghazizadeh
e05cad71c4
Merge pull request #11355 from afbjorklund/driver-order
...
Sort rejected drivers by their preference order
2021-05-17 20:31:34 -07:00
Medya Gh
8ca3d1f799
remove debug
2021-05-17 18:54:02 -07:00
Medya Gh
0068f92327
add port to addons templates
2021-05-17 18:50:12 -07:00
Medya Gh
45fca194af
add apiserver ip to autopause proxy
2021-05-17 18:50:12 -07:00
Medya Ghazizadeh
ee9ed1c3d3
Merge pull request #11404 from prezha/host.minikube.internal
...
add host.minikube.internal to coredns
2021-05-17 18:46:33 -07:00
ilya-zuyev
612d4e4d58
Merge pull request #11433 from ilya-zuyev/ilyaz/fix_fmt_warning
...
fix "no arguments passed" warning
2021-05-17 16:28:56 -07:00
Anders F Björklund
c7e8be0972
Bump the preload version and add a note
...
The image list was wrong for the 1.21 preload tarball
It had the pause and coredns versions from 1.20 still
2021-05-17 23:02:09 +02:00
Anders F Björklund
9f5388af73
Remove k8s 1.11 support from kubeadm images
...
It requires arch suffix, but that code is no longer present.
Should be OK, we have: OldestKubernetesVersion = "v1.14.0"
2021-05-17 22:51:11 +02:00
Predrag Rogic
4e967acbae
avoid error, improve test
2021-05-17 21:18:27 +01:00
Predrag Rogic
260d22cd57
rename func, add comments
2021-05-17 21:14:59 +01:00
Predrag Rogic
3ddb4e30b3
add host.minikube.internal to coredns
2021-05-17 21:14:35 +01:00
Medya Ghazizadeh
2445acacdc
Merge branch 'master' into kube-proxy-conntrack
2021-05-17 12:41:57 -07:00
Ilya Zuyev
5e2b56d808
fix "no arguments passed" warning
2021-05-17 12:37:57 -07:00
Anders F Björklund
821644d304
Add test for images used by pkg/minikube/cni
2021-05-17 12:43:23 +02:00
Anders F Björklund
839b493494
Add more tests to kubeadm for better coverage
2021-05-17 12:21:42 +02:00
Anders F Björklund
eadfae3e37
Add a unittest for kubeadm bootstrapper images
...
Change the image order to make it easier to compare with the
output of `kubeadm images config list` for each release version.
2021-05-17 08:24:34 +02:00
Anders F Björklund
589eea90a0
Update the bootstrapper images for k8s 1.21
...
Including some weird changes like changing the image name and
the tagging syntax for coredns (possibly a mistake upstream)
2021-05-17 08:23:40 +02:00
Anders F Björklund
6ea7e03304
Remove integration test count from documentation
2021-05-17 08:06:19 +02:00
Anders F Björklund
610883ba55
Add documentation for all the DriverState fields
2021-05-16 09:32:31 +02:00
Anders F Björklund
6d0763648e
Keep original preference, for identical priority
...
Unhealthy drivers have their priority lowered
2021-05-16 09:31:37 +02:00
Predrag Rogic
f425739254
prevent kube-proxy trying to change nf_conntrack_max
2021-05-15 19:36:49 +01:00
Medya Ghazizadeh
707af502f3
Merge pull request #11300 from ilya-zuyev/ilyaz/gh_11293
...
Fix getting of gateway IP for podman driver
2021-05-14 17:04:24 -07:00
ilya-zuyev
2a2ffeb380
Merge pull request #11304 from daehyeok/copy_node
...
Implement target node option for cp command
2021-05-14 15:59:11 -07:00
Ilya Zuyev
dcadd32624
Add comment, improve template
2021-05-14 14:38:29 -07:00
Jasmine Hegman
e0838eb289
Update metallb from 0.8.2 to 0.9.6
...
This change isn't strictly necessary but the newer versions of metallb contain some really nice quality of life improvements, and better support newer (installed by default) versions of kubernetes better.
A sample of some improvements this brings to metallb add-on installed by minikube:
- [Layer2 doesn't update when when ip changes](https://github.com/metallb/metallb/pull/520 ) - this hit me, and might be hitting others
- [Allow spaces in configs](https://github.com/metallb/metallb/pull/500 ) - quality of life
- [selflink is deprecated](https://github.com/metallb/metallb/pull/812 ) - Kubernetes deprecation (I believe seeing this is in the logs is what originally caused me to look into upgrading it)
2021-05-14 09:29:14 -07:00
Anders F Björklund
748d9cb254
Use patched version of go-containerregistry
...
It allows adding a tag to a Digest, by doing a "docker pull"
in the daemon.Write function after doing the "docker load"
The digest is not stored in the tarball, so it cannot be
loaded from it. The alternative is instead using a Tag.
2021-05-14 17:34:07 +02:00
Anders F Björklund
3bcfe1bdc4
Move load function from image to download
...
Now we don't have to expose the local cache directory path,
and don't risk mixing the kicbase code with the image code.
Duplicate the digest code for now, it should use the Digest
implementation Tag() from our patched go-containerregistry.
2021-05-14 17:08:03 +02:00
Anders F Björklund
580161ad1c
Load kicbase image from right cache and add log
...
It was silently failing to load from the (wrong) cache directory,
causing the image to be download twice from the network instead.
Add new function to get the path in the cache directory, so that
we don't have to duplicate that both inside and outside module.
2021-05-14 10:11:06 +02:00
Medya Ghazizadeh
33e26502dd
Merge pull request #11366 from spowelljr/fixImageLoad
...
`image load`: overwrite same image unless `--overwrite=false`
2021-05-13 21:18:29 -07:00
Medya Ghazizadeh
01328781b3
Merge pull request #11223 from andriyDev/DownloadLocks
...
Add locks to download functions.
2021-05-13 18:54:37 -07:00
Steven Powell
e1fabfd358
only throw error if not a "no such image" error returned from remove
2021-05-13 17:23:00 -07:00
Medya Ghazizadeh
9e3a66268f
Merge pull request #11384 from dinever/kicbase-tools
...
Add useful tools in the Kicbase Docker image
2021-05-13 14:14:59 -07:00
Andriy Dzikh
268e91f830
Make download.imageExistsInDaemon public to fix bad compilation.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
c0a492b879
Improve comments for ImageToCache and ImageToDaemon.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
0626bb0455
Add comment to explain lock wait timeout.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
9191d03c99
Check releaser is valid before deferring release.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
e9c4c93afa
Remove no longer relevant comment.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
118eae4311
Add function comment to lockDownload.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
248d030d73
Reword test fail message.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
f4b142c42f
Rename downloads to downloadNum.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
fbc041d2a1
Ensure directory exists in CreateDstDownloadMock and add comments.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
5e48738097
Remove SetDownloadMock and rename mockDownload to DownloadMock.
2021-05-13 11:57:01 -07:00
Andriy Dzikh
ad356d5508
Move defer lock release to before error check so the lock is guaranteed to be released.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
a7cbc76d88
Refactor repeated mock sleep function into a single function.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
4fc0ac5c8a
Make download_test run tests in serial.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
fa0803d81e
Refactor download.go to allow more complex download mocking. Modify download_test to prevent using logging.
2021-05-13 11:57:00 -07:00
Andriy Dzikh
5af0dcf3aa
Use spinner for lock message.
2021-05-13 11:57:00 -07:00