56b5524c8e
address review comments
2020-06-16 14:57:19 -07:00
16c3e95260
Merge pull request #8475 from 11janci/jjanik-fix-hostip-vbox
...
Fix host network interface for VBox
2020-06-16 13:40:34 -07:00
4caf260279
add cpu count limit error type for kic drivers
2020-06-16 13:21:56 -07:00
6e08caa4cf
add timed out log
2020-06-16 11:59:17 -07:00
e07446a498
address review comments
2020-06-16 11:56:18 -07:00
0aa313581f
address review comments
2020-06-16 11:27:02 -07:00
e7121b7290
unify TempDir for testing
...
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:53:58 +08:00
24c9ce079d
cleanup TempDir properly
...
a TempDir is like /tmp/minipath255070191/.minikube
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
a64038dfd0
better wording
2020-06-15 14:59:52 -07:00
0e96154fc2
add better solution message when docker needs factory reset
2020-06-15 14:59:17 -07:00
bb6c84f7ad
provide better solution message
2020-06-15 14:52:31 -07:00
804e772efd
Merge pull request #8455 from govargo/add-heapster-alias
...
Add heapster alias to metrics-server addon
2020-06-14 16:46:55 -07:00
bf59d39587
fix host IP for virtualbox
2020-06-14 15:28:08 +02:00
6ef48499b4
Code review comments
2020-06-12 11:00:46 -07:00
ab58dca23d
replace to metrics-server in case of `minikube start --addons heapster`
2020-06-13 01:07:16 +09:00
803461ddcf
if the specified addon doesn't exist, skip enabling
2020-06-13 00:46:12 +09:00
9d71fc635b
remove unneccesary config
2020-06-13 00:46:12 +09:00
d76b58c3ae
Add heapster alias to metrics-server addon
2020-06-13 00:46:12 +09:00
b750ab4964
fix lint
2020-06-11 13:00:46 -07:00
330224f36a
Warn user to restart daemon if context deadline is exceeded
2020-06-11 12:50:11 -07:00
0ec839186d
Change glog.Errorf to glog.Infof so that we don't get an ugly log to stdout
2020-06-11 11:14:04 -07:00
db116c2689
Merge pull request #8428 from tstromberg/minikube-blacklist
...
Replace whitelist/blacklist with allow/deny
2020-06-11 07:18:02 -07:00
b32cb5e6ba
Create a podsecuritypolicies addon
...
Create a new addon, `podsecuritypolicies` that applies the
PodSecurityPolicy and related RBAC configuration from the
https://minikube.sigs.k8s.io/docs/tutorials/using_psp/ tutorial.
Apparently, recent work on the addons system has invalidated the
procedure shown in that tutorial, as the configuration is no longer
automatically applied. The last known working version is `1.6.2`.
This allows clusters started with
`--extra-configs=apiserver.enable-admission-plugins=PodSecurityPolicy`
to succeed, so long as they also include `--addons=podsecuritypolicies`.
2020-06-11 09:51:13 -04:00
ae555bf393
Merge pull request #8342 from prasadkatti/kubelet_flag_to_config
...
Set `failSwapOn` and `clusterDomain` via kubelet config file
2020-06-10 16:53:38 -07:00
bd1bdb3696
Use 'Allowed' instead of 'Allow'
2020-06-10 14:56:22 -07:00
6fcc987cc4
Add v1alpha3
2020-06-10 11:21:26 -07:00
69387a3937
Add in extra args for v1beta1
2020-06-10 10:58:37 -07:00
424e158856
Fix unit tests
2020-06-10 10:41:19 +02:00
09672520ea
Merge branch 'master' into minikube-blacklist
2020-06-09 16:49:39 -07:00
cbd56c53d7
fix unit tests
2020-06-09 14:17:22 -07:00
07b04841ce
RebaseD
2020-06-09 13:49:22 -07:00
a60c7d3d1d
Replace whitelist/blacklist withallow/deny
2020-06-09 13:19:18 -07:00
11096160fe
improve warning message so it fits on one line
2020-06-09 10:25:18 -07:00
e37da349fb
pass in driver to load from tarball
2020-06-09 10:18:53 -07:00
5e1966ea4b
Set leader-elect=false for scheduler and controller manager
...
both the scheduler and controller manager constantly ping the apiserver to ensure leader election. From the docs:
```
Enable this when running replicated components for high availability.
```
which we don't really need in minikube. This should reduce overall overhead by ~12%
2020-06-08 14:39:52 -07:00
94da5201a6
Add TODO
2020-06-08 14:10:11 -07:00
173666d203
Use go-containerregistry library instead of docker CLI
2020-06-08 14:01:06 -07:00
0033381049
rebased on master
2020-06-08 11:24:25 -07:00
99d75c6b5b
WIP
2020-06-08 10:53:47 -07:00
a85b5aa984
fix logviewer config.
2020-06-05 04:55:18 -07:00
21b7cebaf9
Merge pull request #8335 from sakshamkhanna/bugfix/sakshamkhanna/ssh_runner_race_condition
...
added mutex lock over teePrefix()
2020-06-04 14:00:08 -07:00
ffe6c73812
Merge pull request #8373 from priyawadhwa/refactor
...
Refactor downloading kic base image
2020-06-04 13:21:38 -07:00
2011306793
Merge pull request #8368 from medyagh/detect_wsl
...
add support for microsoft wsl for docker driver
2020-06-04 13:21:22 -07:00
c629b9b81c
load from tarball if cached kic image exists
2020-06-04 12:40:19 -07:00
1f6e140e00
try to save image as tarball on download-only
2020-06-04 12:24:07 -07:00
d7297b5b1d
Merge branch 'master' of https://github.com/kubernetes/minikube into cloudshell
2020-06-04 12:18:00 -07:00
de81670130
make warning output prettier by including tags
2020-06-04 12:11:54 -07:00
c8bcdf9d72
Merge pull request #8355 from afbjorklund/image-ref2
...
Add digest to image in daemon after pulling it
2020-06-04 11:47:33 -07:00
6b29b784f2
address review comments
2020-06-04 11:39:28 -07:00
15088526cd
clean up comments
2020-06-04 11:05:52 -07:00
7dfea631d4
Refactor downloading kic base image
2020-06-04 10:48:38 -07:00
5f6391783a
Update versions in the other files
2020-06-04 09:20:32 +02:00
57c6340982
Update dashboardFrontend and dashboardMetrics functions
2020-06-04 09:08:05 +02:00
4eb09e760b
Merge pull request #8275 from ashleyschuett/add-kubevirt-addon
...
Add KubeVirt addon
2020-06-03 22:23:09 +00:00
7b01b2aef5
update comment
2020-06-03 14:50:03 -07:00
98d577d229
add more checks for wsl
2020-06-03 14:47:43 -07:00
276f99b551
improve comment
2020-06-03 14:40:43 -07:00
02749de984
detect wsl and add port forward
2020-06-03 14:39:34 -07:00
66bb306060
minor refactor
2020-06-02 15:00:19 +10:00
05459a2e42
Add digest to image in daemon after pulling it
...
The image was added with digest "none", which caused it to be
written to daemon again next time since reference didn't match.
2020-06-01 23:16:32 +02:00
c061113553
Move some kubelet config to the config file instead of command line
2020-05-31 18:54:39 -07:00
08773015d5
Unify code
2020-05-31 19:06:57 +10:00
366d6c370c
mock shell in test
2020-05-31 15:58:56 +10:00
ae2ceee8e4
minor cleanup
2020-05-31 15:32:57 +10:00
168f67bf39
setup fallback to default everywhere
2020-05-31 13:55:44 +10:00
666cd20b51
Merge branch 'master' of github.com:kubernetes/minikube into add-tests-to-minikube-shell
2020-05-31 13:40:29 +10:00
d1032515ce
usage hint as function
2020-05-31 13:39:41 +10:00
54a9b35a82
fix bug intruduced by refactor
2020-05-31 13:20:48 +10:00
a678b0fb19
ensure all shells set/unset are gren with orginal code
2020-05-31 13:14:25 +10:00
5baa8b7d3f
fix import
2020-05-31 02:44:31 +05:30
030f38e9f7
added mutex lock over teePrefix()
2020-05-31 02:02:47 +05:30
81073a0561
use struct instead of map
...
remove gosec warnings
2020-05-30 20:34:53 +10:00
fae412b703
Fix floating point
2020-05-29 15:14:01 -07:00
d87ca2c217
Add support for docker driver to mkcmp
2020-05-29 14:18:28 -07:00
abba4b3db5
Merge pull request #8091 from priyawadhwa/open
...
Add support for timing per log and printing out timings per log to mkcmp
2020-05-29 13:52:47 -07:00
488e2003f4
fix image digest
2020-05-29 12:19:59 -07:00
bc8c3faf86
add docker hub fall back image
2020-05-29 11:55:21 -07:00
49c3a73563
Add tests to minikube shell
...
Refactor shell.go to use nested structure for shell - prefix/suffix mapping
2020-05-30 01:34:07 +10:00
5dafe6bc84
Add KubeVirt addon
2020-05-29 09:52:18 +02:00
77419ee925
Merge pull request #8154 from priyawadhwa/kvm-flake
...
Upgrade oldest k8s version supported to 1.13
2020-05-28 21:18:01 +00:00
4b280ab362
bump default kubernetes version
2020-05-28 13:44:57 -07:00
ea20609a3a
Merge pull request #8161 from concaf/concaf/addons/ambassador
...
Add Ambassador Ingress controller as an addon
2020-05-28 18:08:41 +00:00
fa6c446374
Bump up major version to 13
2020-05-28 11:08:07 -07:00
4f0613929f
Merge pull request #7973 from sharifelgamal/restart
...
Make sure multinode clusters can survive restarts
2020-05-27 17:41:57 -07:00
96f34ea063
fix tests
2020-05-27 15:54:07 -07:00
7224064b23
respect native-ssh param properly
2020-05-27 15:19:32 -07:00
a7e483a8a4
let's simplify kubeadm again
2020-05-27 10:17:01 -07:00
d0753347b5
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-27 09:58:22 -07:00
b5167834d0
it works! and simpler
2020-05-27 09:58:03 -07:00
1bfdc4b0d1
Merge pull request #8129 from blues-man/master
...
Addons: add OLM support
2020-05-26 23:26:20 +00:00
2b8bac695e
Apply code review changes
...
Rename "cmd*" var to "bin*" in the parallels-specific block
2020-05-23 23:08:10 +02:00
c22a92f9bf
Add HostIP implementation for parallels driver
2020-05-23 20:35:55 +02:00
49905d8fea
Remove Parallels from the list of supported drivers for Linux
...
Parallels Desktop works only on macOS (Darwin)
2020-05-23 16:32:28 +02:00
e225968194
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-21 15:44:31 -07:00
ad437c2c9c
Merge pull request #8229 from afbjorklund/docker-inspect
...
kic: explicitly provide the type in inspect commands
2020-05-21 22:44:20 +00:00
bde6624365
Merge branch 'postmortem' of github.com:sharifelgamal/minikube into restart
2020-05-21 14:54:21 -07:00
39f6806626
add info log for retrieving node by machine name
2020-05-21 14:35:46 -07:00
a7c49e47c1
allow minikube status to display for one node
2020-05-21 12:46:13 -07:00
14937e4677
Never use docker inspect, always provide the type
...
Should avoid errors like: map has no entry for key "State"
When inspecting a volume, rather than a container or image
2020-05-21 17:20:53 +02:00
25045cfc87
Merge pull request #8225 from medyagh/gh_package_login
...
exit with usage when need login to image registry
2020-05-21 05:36:29 +00:00
2c0719e9b4
fix spelling
2020-05-20 17:32:18 -07:00
dcbcecdd35
remnove debugging
2020-05-20 17:09:15 -07:00
489495d04b
resolve review comments
2020-05-20 17:07:50 -07:00
493b35bd45
remove debugging statements
2020-05-20 16:51:19 -07:00
e2eade2aaf
remove debugging
2020-05-20 16:47:48 -07:00
131eb2a85b
exit with usage when need login to github
2020-05-20 16:46:43 -07:00
95584eac43
skip start/stop on github actions
2020-05-20 16:08:44 -07:00
13f0b87f59
better debugging
2020-05-20 15:49:17 -07:00
d5f9490ced
Merge branch 'node-delete-vol' of github.com:sharifelgamal/minikube into restart
2020-05-20 15:00:58 -07:00
01145c3c99
Merge branch 'master' of github.com:kubernetes/minikube into node-delete-vol
2020-05-20 14:59:31 -07:00
bbf4d66b48
delete docker volumes when deleting a single node
2020-05-20 14:59:03 -07:00
3caad25d0e
lint
2020-05-20 14:41:15 -07:00
43d37ec9f3
debugging
2020-05-20 14:19:50 -07:00
dd7e57e110
Merge branch 'restart' of github.com:sharifelgamal/minikube into restart
2020-05-20 13:14:17 -07:00
49cc6ae259
revert old unrelated changes:
2020-05-20 13:13:57 -07:00
70198d807d
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-20 12:55:07 -07:00
6abb399668
make sure to call the correct control plane address
2020-05-20 11:28:35 -07:00
f04798727d
Merge branch 'master' of github.com:kubernetes/minikube into ip-save
2020-05-19 20:58:42 -07:00
add572c1c9
Merge pull request #8216 from sharifelgamal/volume-del
...
multinode: delete worker volumes for docker driver
2020-05-20 00:43:19 +00:00
327ba9e1ab
Merge pull request #8198 from medyagh/fix_proxy
...
fix proxy env not being passed to docker engine
2020-05-19 23:59:19 +00:00
ee5696ffa4
Merge branch 'volume-del' of github.com:sharifelgamal/minikube into restart
2020-05-19 16:34:54 -07:00
6eb0200dae
delete worker node volums for docker driver
2020-05-19 16:32:48 -07:00
c603467c3e
Merge branch 'ip-save' of github.com:sharifelgamal/minikube into restart
2020-05-19 16:00:12 -07:00
0ec156dbb9
remove debugging, add comments
2020-05-19 15:31:14 -07:00
da91c6fee1
refactor saving IP to node
2020-05-19 15:12:05 -07:00
64e44ec02f
Respect --wait flag on soft start
2020-05-19 10:31:28 -07:00
4a4a470fff
Add Ambassador addon
2020-05-19 18:13:57 +05:30
5640da0cb4
lint
2020-05-18 22:52:01 -07:00
32bf4d46a7
add unique
2020-05-18 18:26:11 -07:00
80d1c8741d
improve unit test log
2020-05-18 18:17:45 -07:00
2f2a8357a8
fix proxy envs not being passed to docker engine
2020-05-18 18:04:45 -07:00
46fe5c4ac1
Merge branch 'master' of github.com:kubernetes/minikube into ip-save
2020-05-18 11:56:39 -07:00
faf11e2f05
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-18 11:55:07 -07:00
2754bb6319
Merge pull request #8095 from sharifelgamal/create-node
...
recreate existing control plane node correctly
2020-05-18 11:50:39 -07:00
38d59ea2cc
Merge branch 'create-node' of github.com:sharifelgamal/minikube into ip-save
2020-05-18 11:26:38 -07:00
a451577e24
move node ip save farther down stack
2020-05-15 17:08:10 -07:00
4cbeb18079
stuff
2020-05-15 15:33:03 -07:00
1cc7404e76
swap to bool
2020-05-15 15:24:33 -07:00
5b53495b46
Merge branch 'master' of github.com:kubernetes/minikube into apiserver-crt
2020-05-15 14:56:04 -07:00
6d6bad6217
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-15 13:59:35 -07:00
475bcc889c
move condition around for clarity
2020-05-14 14:12:26 -07:00
b6c19f6223
Addons: add OLM support
2020-05-14 11:16:23 +02:00
a4d872faee
Fix some minor gofmt and golint issues
...
So that "make gofmt" and "make golint" go green again
2020-05-14 07:50:29 +02:00
70bec7a1e2
Merge branch 'master' of github.com:kubernetes/minikube into apiserver-crt
2020-05-13 09:23:59 -07:00
9de7f4630a
dont change oldest
2020-05-12 19:33:16 -07:00
5e17545c19
fix a comment
2020-05-12 17:55:15 -07:00
3c84c3cf31
Merge pull request #8099 from medyagh/update_kube_ver
...
update Kubernetes version to v1.18.2
2020-05-13 00:46:20 +00:00
522c746df4
Merge pull request #8106 from sharifelgamal/vbox
...
fix virtualbox IP address retrieval
2020-05-13 00:08:36 +00:00
50a3266a8a
fix virtualbox IP address retrieval
2020-05-12 16:48:21 -07:00
4eddbc5225
Fix lint
2020-05-12 16:38:41 -07:00
8a4e2610f9
Merge pull request #8104 from medyagh/unit_test_machine
...
make deleting orphaned kics optional
2020-05-12 23:36:17 +00:00
bb2607aab8
fix unit test
2020-05-12 16:25:46 -07:00
97d5251b02
update oldest support version patch
2020-05-12 16:11:05 -07:00
2de9f442bb
update oldest kuberentes version to latest minior 12.9.10
2020-05-12 16:10:54 -07:00
e457618d71
make deleting orphaned kics optional
2020-05-12 16:00:02 -07:00
e65486a017
retrieve virtual switch name from driver object directly
2020-05-12 15:45:18 -07:00
05cd86925e
update newest
2020-05-12 15:22:01 -07:00
7dbbbc66cf
update kuberentes version to v1.18.2
2020-05-12 15:17:55 -07:00
d7813e9199
ControlPaneEndpoint -> ControlPlaneEndpoint
2020-05-12 12:01:42 -07:00
09698e4638
only copy apiserver certs to control plane
2020-05-12 11:53:38 -07:00
6147ad350d
Add support for timing per log and printing out timings per log to mkcmp
2020-05-12 11:07:25 -07:00
335379dc59
it works
2020-05-11 19:25:53 -07:00
afab7c87c6
Merge pull request #7959 from afbjorklund/podman-prompt
...
Use noninteractive sudo when running podman
2020-05-11 21:02:22 +00:00
e892829155
Missing period character in the error template
2020-05-11 22:38:36 +02:00
12122f7dc6
Merge pull request #8053 from medyagh/arm64_docker_solution
...
docker/podman solution message for non-amd64 archs
2020-05-11 19:41:31 +00:00
5a4d3279be
address review comments
2020-05-11 12:28:48 -07:00
d2ae2b35a0
Merge pull request #8057 from afbjorklund/podman-tar
...
Don't run the extraction tar container for podman
2020-05-11 19:22:48 +00:00
d4639c52b9
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-11 11:52:22 -07:00
4886030486
pass everything by reference since we actively change node IP
2020-05-11 11:50:51 -07:00
6b97ee8ee2
Merge pull request #8001 from afbjorklund/podman-start
...
podman: Wrap the start command with cgroup manager too
2020-05-11 17:59:39 +00:00
d89d40c374
Merge pull request #8060 from afbjorklund/podman-cp
...
The podman cp command is not in podman-remote
2020-05-11 17:55:38 +00:00
16af75ed24
Add fix warning for active podman-env as well
2020-05-11 12:15:22 +02:00
c578a7aa1e
Add a PointToHost function for podman as well
...
And add an active variable, similiar to docker
2020-05-10 23:07:12 +02:00
541fb9cf98
The podman cp command is not in podman-remote
...
So use podman exec stdin/stdout as a workaround.
2020-05-10 18:35:41 +02:00
7e3da0f8b0
Merge pull request #8017 from elegos/podman-volumes-extract-tarball-to-volume
...
Podman: disable selinux labels when extracting the tarball (permissions error)
2020-05-09 21:35:43 +00:00
cac41495cf
Don't run the extraction tar container for podman
...
The preloaded images will be extracted anyway, using ssh.
But if creating them on the volume before the container is
booted, means that /var will not be fully copied over to it.
And without /var/lib/dpkg and others, kicbase will not boot.
So skip the parallel extraction for podman, do it afterwards.
Probably shouldn't mount all of /var, but just a sub-set...
2020-05-09 18:36:56 +02:00
46025eccf5
Use the runCmd wrapper for start to not miss error
2020-05-09 14:07:18 +02:00
ac01e92012
Add comment about why podman looks at runtime.GOOS
2020-05-09 14:05:57 +02:00
a7a5148ff6
Don't add cgroup manager param for podman-remote
...
Since it doesn't work for either "run" or "start"
Error: unknown flag: --cgroup-manager
2020-05-09 14:04:04 +02:00
85fae62d4a
Wrap the start command with cgroup manager too
...
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
1bd56a40cf
Don't use cached credentials for sudo podman
...
We want to verify that "NOPASSWD" has been set up properly
Otherwise the sudo timestamp might time out (after 15 mins)
2020-05-09 13:52:58 +02:00
934ad06a82
Use noninteractive sudo when running podman
...
To avoid asking for a password in the middle of minikube commands.
The setup process is supposed to involve adding podman to sudoers...
2020-05-09 13:23:46 +02:00
45acf71459
lint
2020-05-08 19:57:45 -07:00
24971a5ff5
docker/podman fail on non-amd64 systems
2020-05-08 19:56:38 -07:00
bfef99b63d
Copy files directly now that we control kubeadm
2020-05-08 14:12:13 -07:00
753dc44706
Remove unnecessary function
2020-05-08 13:57:11 -07:00
6d1d07c857
Remove unnecessary restart
2020-05-08 13:55:30 -07:00
6bb8371459
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-08 13:53:20 -07:00
ad9b4c1a38
save config
2020-05-08 13:53:16 -07:00
cb4dc30bab
Add unit test
2020-05-08 12:49:54 -07:00
ba267702af
Merge branch 'master' of https://github.com/kubernetes/minikube into embed-certs
2020-05-08 12:38:02 -07:00
f574852125
make it impossible to enable the kubelet service
2020-05-08 12:37:28 -07:00
0fa24990c9
Remove Enable(kubelet) from unpause
...
This way, we won't ever enable kubelet to start when systemd starts, preventing a race condition with `/etc/hosts`
2020-05-08 12:33:45 -07:00
826fb2bbf3
Restart kubelet after updating config files
...
This makes sure the kubelet picks up the correct IP
2020-05-08 12:32:27 -07:00
73d15fc275
Start kubelet after host aliases have been set in /etc/hosts
...
kubelet manages the value of `/etc/hosts` within running containers (e.g. kube-controller-manager). It takes this file from the host, but this causes a race condition between:
1. Us updating /etc/hosts with aliases on IP changes
1. kubelet starting k8s with current value of /etc/hosts
This change removes automatically starting kubelet when systemd comes up. Instead, we start it immediately after making our updates to `/etc/hosts`
2020-05-08 12:30:06 -07:00
34e833511b
Merge pull request #8027 from tstromberg/quiet-ssh2
...
virtualbox: Quiet initial ssh timeout warning
2020-05-08 00:00:39 +00:00
9348667351
Add host alias back after restarting kubelet
2020-05-07 17:00:37 -07:00
5e981137a4
Merge branch 'master' of github.com:kubernetes/minikube into restart
2020-05-07 16:13:25 -07:00
436cee2d84
Fix minikube/kubernetes capitalization, make short help consistent
2020-05-07 14:12:10 -07:00
80960945af
move into separate function
2020-05-07 13:45:34 -07:00
Medya Gh
Medya Ghazizadeh
Li Zhijian
jjanik
Priya Wadhwa
Kenta Iso
Thomas Strömberg
colvin
Marcin Maciaszczyk
gashirar
Marcin Niemira
Anders F Björklund
Prasad Katti
sakshamkhanna
Ashley Schuett
Sharif Elgamal
Mikhail Zholobov
Medya Gh
Shubham
Natale Vinto