Thomas Stromberg
196a8d7b82
Delete: output underlying status failure, refactor wordy code
2020-03-13 15:51:03 -07:00
Sharif Elgamal
d98ebcfb68
lint
2020-03-13 15:32:14 -07:00
Sharif Elgamal
36089037d9
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-13 15:24:07 -07:00
Sharif Elgamal
a9b73b8ba3
fixing up minikube start path
2020-03-13 15:03:19 -07:00
Medya Ghazizadeh
6d16146cb7
Merge pull request #7021 from medyagh/reload_dameojn
...
Fix dockerd internal port changing on restart
2020-03-13 14:15:05 -07:00
Medya Gh
3ec8d429e1
more refactor
2020-03-13 12:25:37 -07:00
Medya Gh
9fe3053a0a
improve docker env warnining formatting
2020-03-13 12:14:16 -07:00
Medya Gh
0da027cdb2
refactor
2020-03-13 12:01:28 -07:00
Sharif Elgamal
b6ab2931d6
run all necessary steps on all nodes
2020-03-13 11:29:46 -07:00
Medya Gh
37ee8b2de6
move replace api server name to apiServerURL
2020-03-13 11:18:45 -07:00
Medya Gh
86d7c40ff0
missed word
2020-03-13 10:45:09 -07:00
Medya Gh
70c9304724
code review comments
2020-03-13 10:37:29 -07:00
Richard Wall
bee2907b8a
Remove controllerManager from the kubeadm v1beta2 template
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-03-13 17:34:40 +00:00
Medya Gh
fcd3a2b476
verify agaibn
2020-03-12 18:59:20 -07:00
Medya Gh
c9cc3d3f30
dont verify docker certs
2020-03-12 18:37:03 -07:00
Medya Gh
48ff543323
err
2020-03-12 16:43:50 -07:00
Medya Gh
ac64cf5134
ki kubeconfig
2020-03-12 16:21:16 -07:00
Medya Gh
99ba89c2dd
ip
2020-03-12 16:01:49 -07:00
Sharif Elgamal
3ed818c488
cosmetic fixes
2020-03-12 15:40:13 -07:00
Medya Gh
084da0c46a
fix maybe
2020-03-12 15:31:38 -07:00
Medya Gh
2e5b4ece36
hard code docker port
2020-03-12 14:50:19 -07:00
Medya Gh
4f097cb369
fix
2020-03-12 14:29:17 -07:00
Medya Gh
d3b20dc3d8
try
2020-03-12 14:28:37 -07:00
Medya Gh
1b0fb63fc9
try again
2020-03-12 14:27:31 -07:00
Medya Gh
7d3117916e
daemon-reload
2020-03-12 14:17:06 -07:00
Medya Gh
4ce5a16254
sudo docker
2020-03-12 11:45:42 -07:00
Medya Gh
94092c8d6a
sudo systemctl
2020-03-12 11:43:34 -07:00
Medya Ghazizadeh
980e3ab9ed
Merge pull request #6985 from priyawadhwa/no-overwrite-tar
...
Merge repositories.json after extracting preloaded tarball so that reference store isn't lost
2020-03-11 18:23:09 -07:00
Thomas Strömberg
a29c5739ab
Merge pull request #6988 from tstromberg/v1.18.0-beta
...
Update NewestKubernetesVersion to 1.18.0-beta.2
2020-03-11 17:00:35 -07:00
Thomas Strömberg
e45b230622
Merge branch 'master' into no-overwrite-tar
2020-03-11 16:59:41 -07:00
Medya Ghazizadeh
d63d3bc1df
Merge pull request #6990 from tstromberg/istio-memory2
...
Plumb config.ClusterConfig throughout addon validation code
2020-03-11 16:16:12 -07:00
Medya Ghazizadeh
c57e41533f
Merge pull request #7015 from tstromberg/lz4-missing
...
none: Skip driver preload and image caching
2020-03-11 16:15:25 -07:00
Priya Wadhwa
701cf5cfc9
Address nits
2020-03-11 15:53:45 -07:00
Medya Ghazizadeh
a5f8ad0e89
Merge pull request #7001 from medyagh/improve_test_log
...
improve misleading log
2020-03-11 15:27:53 -07:00
Thomas Strömberg
45b1156089
Merge pull request #7014 from tstromberg/rename-to-finalize
...
Download to a temporary files and finalize using os.Rename
2020-03-11 15:00:36 -07:00
Thomas Stromberg
8a132547c8
Clarify comment
2020-03-11 14:21:19 -07:00
Thomas Stromberg
97cc383de0
Avoid cache loading for the none driver, Docker already has a cache
2020-03-11 14:18:29 -07:00
Priya Wadhwa
a2e5a5ee8c
removed unused unit test
2020-03-11 14:11:17 -07:00
Priya Wadhwa
01f5300a62
merge reference stores if needed
2020-03-11 14:02:19 -07:00
Thomas Strömberg
d8f5e769bb
Merge pull request #7013 from tstromberg/debug-preload-upload
...
Extra debugging for preload generation process
2020-03-11 13:53:13 -07:00
Thomas Stromberg
727d36d010
downloaders: finalize using os.Rename
2020-03-11 13:48:55 -07:00
Thomas Stromberg
43ce409e79
Extra debugging for preload generation process
2020-03-11 13:09:55 -07:00
Medya Gh
f92edc3087
preload dont use gwait
2020-03-11 09:06:32 -07:00
Medya Gh
a09167b17d
lint
2020-03-11 00:56:29 -07:00
Medya Gh
94dfb49ae9
check for err
2020-03-10 22:45:53 -07:00
Medya Gh
fb9cd3cbf5
block on preload download
2020-03-10 22:33:29 -07:00
Medya Gh
e09f33ef98
improve misleading log
2020-03-10 22:05:30 -07:00
Thomas Stromberg
c82fcb40f8
Merge conflict
2020-03-10 21:01:43 -07:00
Thomas Stromberg
71a22787c3
Update Kubernetes image mapping to match v1.18
2020-03-10 20:48:38 -07:00
Medya Ghazizadeh
12c12c4ca7
Merge pull request #6987 from tstromberg/memory-scaling2
...
Round suggested memory alloc by 100MB for VM's
2020-03-10 20:13:42 -07:00
Thomas Stromberg
c911b9f433
UsingContainerd -> IsRuntimeContainerd
2020-03-10 19:27:49 -07:00
Thomas Stromberg
176c6551a8
IsContainerdRuntime -> IsRuntimeContainerd
2020-03-10 19:08:27 -07:00
Medya Gh
b5681d52c5
lint
2020-03-10 18:45:56 -07:00
Medya Gh
9ff0dc0ebc
pass api server port to kic create container
2020-03-10 18:33:59 -07:00
Thomas Stromberg
bd627f13e4
Plumb config.ClusterConfig throughout addon validation code
2020-03-10 17:49:47 -07:00
Thomas Stromberg
c6333b95aa
Test fixes: Add viper.SetDefault back, and make CalculateSizeInMB return an error instead of exit early
2020-03-10 17:43:56 -07:00
Thomas Stromberg
5ff67c9c1e
Update Newest to 1.18.0-beta.2
2020-03-10 16:11:11 -07:00
Medya Ghazizadeh
ec5dfbb17f
Merge pull request #6959 from afbjorklund/reportcard-cleanup
...
Improve the go reportcard for minikube
2020-03-10 15:11:00 -07:00
Sharif Elgamal
e3227a2ded
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-10 15:02:38 -07:00
Medya Ghazizadeh
3780953132
Merge pull request #6980 from sharifelgamal/cp-bc
...
add unit test of PrimaryControlPlane
2020-03-10 14:46:58 -07:00
Priya Wadhwa
de34ddaaef
Rebased
2020-03-10 14:05:41 -07:00
Priya Wadhwa
fc922cbb9b
Only extract preloaded tarball if images don't exist in daemon
2020-03-10 14:01:27 -07:00
Sharif Elgamal
ef93b291ca
fix build failures
2020-03-10 13:46:06 -07:00
Sharif Elgamal
4627978660
change profile name to be more explicit
2020-03-10 12:06:15 -07:00
Medya Ghazizadeh
caf44e21b4
Merge pull request #6978 from tstromberg/iso-warning
...
Add warning if disk image is missing features
2020-03-10 11:54:19 -07:00
Sharif Elgamal
2a78178113
add unit test of PrimaryControlPlane to avoid regressions related to config changes
2020-03-10 10:30:58 -07:00
Thomas Stromberg
b99304eac3
WarningType -> Warning
2020-03-10 09:07:42 -07:00
Thomas Stromberg
a470d1cf9a
Add warning if disk image is missing features
2020-03-10 07:39:42 -07:00
Thomas Stromberg
3b9ed0bed4
Select new warning emoji with consistent spacing between platforms
2020-03-10 07:37:43 -07:00
Thomas Strömberg
4f5c882ca4
Merge pull request #6969 from sharifelgamal/cp-bc
...
Allow backwards compatibility with 1.6 and earlier configs
2020-03-10 07:19:03 -07:00
Sharif Elgamal
05116abb1f
more fallout for the merge-pocalypse
2020-03-09 19:29:29 -07:00
Sharif Elgamal
64ca925d6c
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-09 16:32:54 -07:00
Priya Wadhwa
eb815a7b9b
use path.join
2020-03-09 12:52:58 -07:00
Sharif Elgamal
424b5170f7
Allow backwards compatibility with 1.6 and earlier configs
2020-03-09 12:01:07 -07:00
Priya Wadhwa
6caa5db0c2
fix bug for windows file separators
2020-03-09 11:51:37 -07:00
Anders F Björklund
bdbc7c00a5
Improve the go reportcard for minikube
...
Fix gofmt, golint, and most of gocyclo
(but not the integration tests just yet)
2020-03-08 21:48:26 +01:00
Medya Ghazizadeh
4f685df202
Merge pull request #6953 from afbjorklund/download-message
...
Don't show download message until downloading
2020-03-08 12:07:38 -07:00
Medya Ghazizadeh
20fe042712
Merge pull request #6941 from afbjorklund/lz4-path
...
Check if lz4 is available before trying to use it
2020-03-08 11:22:44 -07:00
Anders F Björklund
9e72a2ad9c
Don't show download message until downloading
...
For instance if the boot image already exists
2020-03-08 17:41:45 +01:00
Kenta Iso
b0e79375db
make the ssh.SetDefaultClient comment clearly
2020-03-08 22:43:46 +09:00
Kenta Iso
e634d11843
set ssh.SetDefaultClient to use native ssh client for TestCreateSSHShell
2020-03-08 20:19:28 +09:00
Kamesh Sampath
70ca2de554
(fix) Create addon to configure registry helper
...
- Service Account and binding to run the job
- Registry aliases ConfigMap
- Registry aliases daemonset to update the node etc/hosts
fixes: 4604
Signed-off-by: Kamesh Sampath <ksampath@redhat.com>
2020-03-08 09:31:07 +05:30
rajula96reddy
5d8d3f01b5
Modified 'checking if service exists before retry' logic
2020-03-07 23:48:13 +05:30
rajula96reddy
40c1c80b42
Created new error type & made corresponding changes
2020-03-07 23:48:13 +05:30
rajula96reddy
8b2289836a
Modified the previous commit using Erros.New() function
2020-03-07 23:47:18 +05:30
rajula96reddy
061b159991
Formatted the error output
2020-03-07 23:47:18 +05:30
rajula96reddy
5a32eb7c4c
Updated error handling when service or namespace doesn't exist
2020-03-07 23:47:18 +05:30
Anders F Björklund
fea9fd39a0
Check if lz4 is available before trying to use it
2020-03-07 16:27:09 +01:00
Priya Wadhwa
095fd2a526
review comments
2020-03-06 17:36:58 -08:00
Priya Wadhwa
992b51cd4e
move wait function to after startMachine
2020-03-06 17:35:31 -08:00
Priya Wadhwa
84bc0d440b
wait for images to download before configuring runtimes
2020-03-06 17:33:13 -08:00
Priya Wadhwa
09e2fcad69
fall back to caching images if preload fails
2020-03-06 17:30:35 -08:00
Thomas Stromberg
9ac1ad2a7e
Merge master
2020-03-06 16:13:54 -08:00
Thomas Stromberg
e027dfc4d2
More unused code cleanup
2020-03-06 15:57:12 -08:00
Medya Ghazizadeh
1061a2af78
Merge pull request #6924 from medyagh/check_running
...
check if container is running after create
2020-03-06 15:56:28 -08:00
Thomas Stromberg
3fee641a13
Remove remaining PointToHostDockerDaemon calls
2020-03-06 15:15:05 -08:00
Medya Ghazizadeh
1cb225f8ec
Merge pull request #6920 from tstromberg/control-plane-addr
...
Revert controlPlaneEndpoint to localhost
2020-03-06 15:14:49 -08:00
Medya Gh
a58a9f0176
tweak
2020-03-06 15:13:56 -08:00
Medya Gh
cb14468b44
english
2020-03-06 15:11:42 -08:00
Medya Gh
cdb8f9c3f6
make sure container is running after create
2020-03-06 15:08:39 -08:00
Thomas Stromberg
e1049e78b4
Revert controlPlaneEndpoint to localhost
2020-03-06 13:50:27 -08:00
Medya Ghazizadeh
c17e998923
Merge pull request #6915 from tstromberg/fish-2x
...
docker-env: Add semicolons back for fish, required for fish 2.x users
2020-03-06 13:41:02 -08:00
Thomas Stromberg
6f46393123
Remove blank line
2020-03-06 12:15:58 -08:00
Thomas Stromberg
120dce7b56
Remove extraneous calls to oci.PointToHostDockerDaemon
2020-03-06 12:13:51 -08:00
Thomas Stromberg
13da35ced2
Add semicolons back to fish env, required for fish 2.x users
2020-03-06 11:44:30 -08:00
Thomas Strömberg
9396c5c1fd
Merge pull request #6906 from medyagh/already_in_use
...
handle already in use container name
2020-03-06 10:51:50 -08:00
Medya Gh
38ccb88e3f
address code review
2020-03-06 10:25:48 -08:00
Medya Gh
1c37fc5505
lint
2020-03-05 22:45:38 -08:00
Medya Gh
0335fb1ad7
change names
2020-03-05 22:38:47 -08:00
Medya Gh
2a37317a72
improve comment
2020-03-05 22:34:10 -08:00
Medya Gh
1e8dd94a77
fix logic
2020-03-05 22:31:44 -08:00
Medya Ghazizadeh
13d0d3c933
Merge pull request #6898 from priyawadhwa/preloaded-copy-vm
...
Use preloaded tarball for VMs as well
2020-03-05 20:37:37 -08:00
Medya Gh
e1f6820335
fix already in use
2020-03-05 16:42:56 -08:00
Priya Wadhwa
db9cd9f2ef
change dest path
2020-03-05 15:46:12 -08:00
Priya Wadhwa
b91b800fb8
Fix filepaths for windows
2020-03-05 15:23:22 -08:00
tstromberg
b6c96eef30
Skip ISO checksum validation if custom URL is specified
2020-03-05 13:49:48 -08:00
Priya Wadhwa
d2573ca25c
Merge branch 'master' of https://github.com/kubernetes/minikube into preloaded-copy-vm
2020-03-05 13:31:52 -08:00
Priya Wadhwa
6058197e99
fix lint
2020-03-05 12:52:41 -08:00
Medya Ghazizadeh
ba199678ff
Merge pull request #6791 from medyagh/kic_ga
...
promote docker driver priority from "experimental" to "fallback"
2020-03-05 12:51:36 -08:00
Priya Wadhwa
1e5d92c32b
Only copy in preloaded tarball for VMs
2020-03-05 12:07:55 -08:00
Priya Wadhwa
05b9662b9f
Remove extracting tarball to volume so that it only happens once for kic
2020-03-05 11:55:53 -08:00
Priya Wadhwa
2252de247d
return 'not yet implemented' error
2020-03-05 11:34:14 -08:00
Priya Wadhwa
66b7dc3f7a
fix unit tests
2020-03-05 11:33:02 -08:00
Priya Wadhwa
fad655704e
Always download preloaded tarball if available, otherwise cache images
2020-03-05 11:20:17 -08:00
Priya Wadhwa
0bc60fb553
rebased on master
2020-03-05 11:12:42 -08:00
Priya Wadhwa
1cac7786cc
Use preload tarball for VMs
...
Since preloaded tarballs are container runtime specific, I added a Preload() func
to the cruntime interface. To use it with VMs, the tarball is first
copied into the VM and then extracted. The leftover tarball is deleted,
and the container runtime (currently only docker is supported) is
restarted.
2020-03-05 10:44:34 -08:00
Thomas Stromberg
1a01b9450c
Clarify logic around beginDownloadKicArtifacts
2020-03-05 10:23:51 -08:00
Priya Wadhwa
34adb345b2
Merge branch 'master' of github.com:kubernetes/minikube into preloaded-copy-vm
2020-03-05 10:22:16 -08:00
Thomas Stromberg
1f7ae5b35b
Merge to master
2020-03-05 09:57:46 -08:00
Naveen Kumar Sangi
b43977d7cc
fixHost: Use container word for kic drivers
...
Relates to https://github.com/kubernetes/minikube/issues/6859
2020-03-05 01:32:17 -06:00
Sharif Elgamal
1327f9d3a5
Merge pull request #6836 from sharifelgamal/machinename
...
Decouple machine name from profile/cluster name
2020-03-04 21:06:28 -08:00
Thomas Stromberg
883e108dce
Fix hyperv import
2020-03-04 21:05:38 -08:00
Thomas Stromberg
9adf54388d
lint cleanup
2020-03-04 20:49:49 -08:00
Thomas Stromberg
832fb6b4ab
preload: check local cache and status codes
2020-03-04 20:42:05 -08:00
Thomas Stromberg
3e772d0048
Merge master
2020-03-04 20:18:16 -08:00
Medya Ghazizadeh
5b6c7835b3
Merge pull request #6874 from priyawadhwa/skip-cache
...
Only cache k8s images if necessary
2020-03-04 19:06:47 -08:00
Medya Ghazizadeh
d5bc3fdc65
Merge pull request #6888 from sharifelgamal/driver
...
Switch --vm-driver paramter to --driver
2020-03-04 19:04:43 -08:00
Thomas Stromberg
a1ebcbd031
Merge conflicts
2020-03-04 18:01:41 -08:00
Thomas Stromberg
39670fc06f
Add download package & support URL fallback
2020-03-04 17:07:49 -08:00
Sharif Elgamal
4aafc5534c
fix fix to fix fix
2020-03-04 16:38:22 -08:00
Sharif Elgamal
0ff12cafac
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 16:37:54 -08:00
Medya Ghazizadeh
9c1dbe745c
Merge pull request #6889 from tstromberg/symlink-inversion
...
Fix inverted certificate symlink creation logic
2020-03-04 16:29:18 -08:00
Sharif Elgamal
a2dd34cd8c
dummy commit to fix travis:
2020-03-04 16:20:55 -08:00
Priya Wadhwa
c1d8025e87
Use preloaded tarball for VMs as well
2020-03-04 16:17:52 -08:00
Priya Wadhwa
2f4987894a
code review comment
2020-03-04 15:09:24 -08:00
priyawadhwa
d403da451b
Merge pull request #6870 from priyawadhwa/transfer-binaries
...
Add k8s binaries to preloaded tarball
2020-03-04 15:00:11 -08:00
Thomas Stromberg
42670e6e11
Update TestSetupCerts unit test to match code change
2020-03-04 14:59:25 -08:00
Thomas Stromberg
d45471ca8d
Add certificate sync integration test
2020-03-04 14:48:40 -08:00
Thomas Strömberg
41235a7ffa
Merge pull request #6816 from halmai/halmai-patch-1
...
give hint if 'minikube delete' cannot delete the machine directory
2020-03-04 14:44:12 -08:00
Sharif Elgamal
eccb1d5e0a
fix unit test
2020-03-04 14:43:42 -08:00