4d85ac0cd7
Merge pull request #16671 from afbjorklund/docker-machine-reference
...
Remove extra references to docker machine
2023-06-12 13:33:36 -07:00
b1b4dbe4ab
Merge pull request #16670 from afbjorklund/vmwarefusion-removal
...
Remove the obsolete vmwarefusion driver
2023-06-12 13:26:46 -07:00
64df06f08a
Merge pull request #15079 from ComradeProgrammer/fix_14592
...
fix: quit minikube service when there is no available pods
2023-06-12 10:42:08 -07:00
18ff76add7
Merge pull request #15074 from ComradeProgrammer/fix_15007
...
fix: handle DOS-style path for Dockerfile in minikube build
2023-06-12 10:39:07 -07:00
c301dacf93
Remove extra references to docker machine
...
Should only use libmachine and the drivers
2023-06-11 14:35:40 +02:00
0a551357b4
Remove the obsolete vmwarefusion driver
...
It just referred to the "vmware" driver
2023-06-11 14:16:17 +02:00
1cc6c0a29c
Update cmd/minikube/cmd/service.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-06-10 21:43:08 +08:00
0bb29fe744
Update cmd/minikube/cmd/image.go
...
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-06-10 21:30:26 +08:00
76950ebdf0
fix: handle DOS-style path for Dockerfile in minikube build
2023-06-08 08:31:50 +08:00
12c4bf5f1d
Add ability to create extra disks on qemu2 vms
...
Add the ability to create and attach extra disks to qemu2 vms.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2023-06-06 16:28:19 -06:00
55868b1736
fix: quit minikube service when there is no available pods
2023-06-05 16:16:02 -07:00
7489d959a8
Merge pull request #16609 from spowelljr/changeAddonOwners
...
Update addon owners
2023-06-05 12:38:15 -07:00
37d82ecef4
Merge pull request #16610 from spowelljr/automateUpdatingKubernetesVersionsList
...
CI: Automate updating Kubernetes versions list
2023-06-05 12:37:40 -07:00
0168d63fc8
Merge pull request #16569 from JudahNour/addKubernetesVersions
...
--kubernetes-version: assume latest patch version if not specified by user
2023-06-01 10:50:20 -07:00
1079f9b631
CI: Automate updating Kubernetes versions list
2023-05-31 15:16:09 -07:00
5a1b0a14d6
update addon owners
2023-05-31 14:12:34 -07:00
852d9197a1
Refactored code and modified/added tests
2023-05-31 16:55:54 +00:00
c81a3172a4
Refactored code, updated error messages, and generated docs
2023-05-31 15:22:50 +00:00
c2c3f2996d
Add testing for isTwoDigitSemver and changed messages to user.
...
Corrected bug with version prefixes
2023-05-30 20:11:51 +00:00
e01610a0f3
Modified to alert user and exit when there is no associated patch
...
for the major.minor given
2023-05-25 21:51:35 +00:00
cbd577878e
--kubernetes-version: making case insensitive and refactoring handling
2023-05-24 20:26:58 +00:00
3afc728238
modified so alerts user that the patch version is assumed
2023-05-24 16:44:14 +00:00
b0892d0b8e
use ValidKubernetesVersions list for config defaults
2023-05-23 16:31:19 -07:00
a81e4f76ac
accept kubernetes version without patch version
2023-05-23 19:27:26 +00:00
dda802b332
none driver: fix image build
2023-04-26 18:57:16 -07:00
8931619b01
Applied suggestions
2023-04-25 15:11:41 +03:00
455bcb19ef
refactors removePid logic
2023-04-22 13:32:45 +03:00
aab0cb6d2a
Adds mechanism to remove pid from pidfile if mount is sigtermd
2023-04-22 00:50:00 +03:00
3d3e6a14e7
added stuff to reflect suggestions
2023-04-22 00:49:30 +03:00
b196ee46af
Apply suggestions from code review
2023-04-22 00:49:30 +03:00
0170981567
Saves us from passing func as parameter
...
:)
2023-04-22 00:49:30 +03:00
b09cd43e1d
Corrects style issue
2023-04-22 00:49:30 +03:00
8f50ee999a
Corrects mendacious comment
2023-04-22 00:49:30 +03:00
595c8eeeda
Adapts TestTryKillOne log for failing
2023-04-22 00:49:30 +03:00
82abc0dbee
Adapts unit test to new dependency
2023-04-22 00:49:30 +03:00
c55a4caacc
Adds the ownership check as a dependency
...
Otherway I see no obvious way to pass this check
during (say) unit testing
2023-04-22 00:49:30 +03:00
d72f2fb285
Changes pid owner conditional
...
What happened in the failed integration tests was that the starting
process was not "minikube", it was "minikube-linux-" and
"minikube-darwin-" instead.
2023-04-22 00:49:30 +03:00
ddec3100b9
Ensures sigkilling only minikube started processes
...
Adds a helper function to check that the executable name
is minikube.
2023-04-22 00:49:30 +03:00
b5e59b5db4
Renames sigkill function
2023-04-22 00:49:30 +03:00
1d5b316fda
Makes comment more clear
2023-04-22 00:49:30 +03:00
b368c64bb6
Update cmd/minikube/cmd/delete.go
2023-04-22 00:49:30 +03:00
db14047b65
Changes helper killProcess function name
2023-04-22 00:49:30 +03:00
43ff38b27d
Changes variable name in test
2023-04-22 00:49:30 +03:00
ee22b47795
Apply suggestions from code review
2023-04-22 00:49:30 +03:00
51e46b6d8d
Refactors GetPids
...
Moves GetPids inside cmd/delete.go as a helper function
Adds description
2023-04-22 00:49:30 +03:00
ead0b401ae
Changes name to unittest tool
2023-04-22 00:48:58 +03:00
badc971403
Adds source for cross platform killable process to test
...
As a way to clean the minikube repo dir.
2023-04-22 00:48:58 +03:00
b1bd26ab06
Adds unit test for new helper function tryKillOne
...
also adds that pleasedontkillme pkg, for the trykillone to be
tested against, so that we can run unit tests cross-platform:
no sure exec.Command("sleep", ....) is avail on windows...
2023-04-22 00:48:58 +03:00
3f47e72752
Modularizes killProcess()
...
adds helper functions for killing one process, given one pid
adds helper function to read pids out of a given pidfile
2023-04-22 00:48:34 +03:00
07d20708a5
Corrects error handling in killProcess
...
If we encountered just one err, we're returning it
If we're returning multiple errors, we're outing 'em
and return a multiple-errors error
2023-04-22 00:47:06 +03:00
Steven Powell
Anders F Björklund
Товарищ программист
Товарищ программист
Blaine Gardner
Medya Ghazizadeh
Steven Powell
Judah Nouriyelian
x7upLime