fad8355f99
Merge pull request #4058 from moduspwnens/master
...
Fixed status checking with non-default apiserver-port.
2019-04-08 11:48:29 -07:00
56391663e6
Merge pull request #4048 from uthark/patch-1
...
Fixed url for issues.
2019-04-05 23:48:26 -07:00
160dc8567e
Escape ‘%’ in console.OutStyle arguments
2019-04-05 17:27:01 +13:00
d102550644
Fixed status checking with non-default apiserver-port.
2019-04-04 21:43:43 -04:00
7e9fd03030
Fixed url for issues.
...
The url for issues is https://github.com/kubernetes/minikube/issues , not https://github.com/kubernetes/minikube/issue .
2019-04-03 18:24:48 -04:00
e3cd27264d
Escape systemd special chars in —docker-env
2019-03-29 16:56:51 +13:00
c57deb5ee5
Add test
2019-03-28 18:34:06 +01:00
3086480a2e
Add port name to service struct used in minikube service
2019-03-27 21:19:46 +01:00
04c6f70667
Fix reversed err comparison and improve logging
2019-03-26 22:44:24 -07:00
e98f2d7af8
Merge branch 'master' into no-infinite-loops
2019-03-26 17:19:28 -07:00
0e679a3d72
Fix mount test that broke due to merge conflict
2019-03-26 17:14:52 -07:00
9c94b2fac6
Merge branch 'master' into no-infinite-loops
2019-03-26 17:11:39 -07:00
7d36629d5b
Update testdata templates for v1.14
2019-03-26 17:09:30 -07:00
5e00adc98f
Add missing 's' to comment string
2019-03-26 16:54:47 -07:00
e57189af7a
Merge pull request #3967 from tstromberg/default-k8s
...
Update default Kubernetes version to v1.14.0
2019-03-26 16:53:09 -07:00
950421d2d2
Merge pull request #3985 from tstromberg/mount-intr
...
More reliable unmount w/ SIGINT, particularly on kvm2
2019-03-26 15:32:53 -07:00
ca51bada64
Merge pull request #3965 from tstromberg/v1.14-tmpl
...
Fix all the kubeadm config generation bugs, add tests across versions
2019-03-26 15:32:30 -07:00
2cd7ab397a
Merge pull request #3982 from tstromberg/more-log-pods
...
Add addon-manager, dashboard, and storage-provisioner to minikube logs
2019-03-26 15:31:57 -07:00
10e4981b54
Merge pull request #3989 from tstromberg/mount-names
...
mount: Allow names to be passed in for gid/uid
2019-03-26 15:31:45 -07:00
9edda72985
Block on cache downloads before using the results
2019-03-26 14:59:17 -07:00
807963ac74
Use r for mockRunner instead of h
2019-03-26 14:45:18 -07:00
13c3826ead
Merge pull request #3970 from tstromberg/bring_ya_errs_to_the_project_maybe_we_can_solve_it
...
Improve console output for new problems package
2019-03-26 14:44:55 -07:00
53a246b71c
Fix function name case
2019-03-26 14:42:02 -07:00
0b21fc317c
Merge pull request #3988 from afbjorklund/typo
...
misspell: Fix minor typo in the problems database
2019-03-26 14:38:12 -07:00
6f516ff647
Merge branch 'master' into mount-names
2019-03-26 14:30:42 -07:00
7233a2d50d
Allow mount to work when the uid/gid of docker changes
2019-03-26 14:27:50 -07:00
34a36aeb2a
misspell: Fix minor typo in the problems database
2019-03-26 21:58:55 +01:00
0ebfe462b9
Add --download-only option to start command
...
Make it possible to download files without loading or installing,
and without starting the host... Download: ISO, binaries, images.
2019-03-26 21:43:54 +01:00
54f68e068e
Move the cache functions from kubeadm to machine
2019-03-26 21:43:18 +01:00
adcbcf113b
Refactor: move cache calls into separate functions
...
Need to split out the caching functions, from the loading/copying.
Also need to make the lists accessible from outside the functions.
2019-03-26 21:43:18 +01:00
7530fcba90
Allow both tag and digest, for the cache images
2019-03-26 21:29:44 +01:00
646949004c
Merge pull request #3976 from tstromberg/in_style
...
Rename MINIKUBE_IN_COLOR to MINIKUBE_IN_STYLE
2019-03-26 13:29:25 -07:00
bec7074fe7
Update go-containerregistry library
2019-03-26 21:29:06 +01:00
9c3488a26f
Make flag substitution cleaner, update tests
2019-03-26 13:04:58 -07:00
d4edae2d8c
Fix tests than broke with the merge against master
2019-03-26 12:57:19 -07:00
b26a93e4ee
Merge branch 'master' into v1.14-tmpl
2019-03-26 12:48:54 -07:00
c861ab7dc1
Switch mount ssh impl from native to CommandRunner
2019-03-26 12:14:06 -07:00
c91da2a65f
Upgrade addon-manager to v9.0 for compatibility with Kubernetes v1.14
2019-03-26 11:33:42 -07:00
48e4808b72
Remove special unrelated docker check
2019-03-26 10:54:39 -07:00
ec135dc4da
Add addon-manager, dashboard, and storage-provisioner to minikube logs
2019-03-26 10:43:03 -07:00
e878c1a0a0
Rename MINIKUBE_IN_COLOR to MINIKUBE_IN_STYLE
2019-03-26 06:56:10 -07:00
a143711b6a
Merge remote-tracking branch 'origin/master' into image-name
2019-03-26 21:15:24 +08:00
4667c28164
Merge branch 'master' into cyclo
2019-03-26 07:16:28 +01:00
f74751c3b7
Merge pull request #3934 from afbjorklund/more-lint
...
Clean up lint and other small report card issues
2019-03-25 21:42:21 -07:00
cbda4fc856
Merge branch 'master' into v1.14-tmpl
2019-03-25 20:54:26 -07:00
17ee8f568b
Minor UI tweaks to problem package
2019-03-25 20:47:35 -07:00
aec8c78f5d
Merge pull request #3596 from flyingcircle/master
...
Issue #3253 , improve kubernetes-version error string
2019-03-25 18:59:50 -07:00
89ab0be3b0
Merge pull request #3958 from andahme/no-wait-on-addon-manager
...
Update kubeadm bootstrap logic so it does not wait for addon-manager
2019-03-25 18:58:59 -07:00
9deb531889
Merge pull request #3947 from afbjorklund/hidden
...
Add explicit kvm2 flag for hidden KVM signature
2019-03-25 18:58:05 -07:00
4ccc7a2b17
Merge pull request #3961 from afbjorklund/tarball-tmp
...
Use a temp file, when writing the cached image
2019-03-25 18:57:54 -07:00
294b26b5f1
Update default Kubernetes version to v1.14.0
2019-03-25 18:56:32 -07:00
a1317476c2
Merge pull request #3931 from tstromberg/bring_ya_errs_to_the_project_maybe_we_can_solve_it
...
Add solution catalog to help users who run into known problems
2019-03-25 18:33:07 -07:00
9f753c3027
Fix all the kubeadm config generation bugs I could find, add tests across versions
2019-03-25 18:25:01 -07:00
3194ec7026
Use a temp file, when writing the cached image
2019-03-25 21:53:07 +01:00
e843038597
More refactoring, add INVALID_PROXY_HOSTNAME
2019-03-25 13:28:31 -07:00
ea57b6149f
Add boilerplate
2019-03-25 13:05:47 -07:00
82e4db98c2
Rename Solution to Advice, add new known problems
2019-03-25 13:04:16 -07:00
cc5d4e9724
Merge branch 'master' into rkt-remove
2019-03-25 11:31:09 -07:00
44a4e290be
Merge pull request #3948 from afbjorklund/status
...
Fix the spelling of API in the template as well
2019-03-25 09:59:13 -07:00
3cd76a7984
Update kubeadm bootstrap logic so it does not wait for addon-manager at start
2019-03-25 10:00:03 -05:00
bfc7d7931b
Clean up lint and other small report card issues
...
Add helper for "go vet", and don't use the test files variable.
Also return an exit code from golint (why is this not default?)
2019-03-24 21:30:58 +01:00
348c085a22
Fix the spelling of API in the template as well
...
The matching code was changed in commit 46640ce
2019-03-24 16:09:41 +01:00
6491e35c20
Add explicit kvm2 flag for hidden KVM signature
2019-03-24 09:47:38 +01:00
2590fc7b9a
Remove the rkt container runtime
...
It has not been updated since kubernetes 1.9 or so
2019-03-24 08:50:58 +01:00
ecc484d523
Make gofmt silent again, complaining on assets
2019-03-23 12:24:41 +01:00
8c28ca4202
Select an accessible image repository for some users
...
Now it's possible to fallback to a mirror site for those users
who cannot access the main k8s.gcr.io repository. You may also
set the --image-mirror-country to forcibly use a known local
mirror in the specific location.
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-03-23 16:58:55 +08:00
aeb1605aff
Remove arch suffixes in image names
...
Removing arch suffixes in image names to make sure image caching
work with kubeadm since 1.12.0.
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-03-23 16:32:17 +08:00
702d471308
Merge pull request #3714 from laozc/custom-image-repository
...
Add --image-repository flag so that users can select an alternative repository mirror
2019-03-22 09:24:18 -07:00
2502d2060c
Run gofmt -w -s
2019-03-22 09:19:58 -07:00
f0d21d7c28
# This is a combination of 2 commits.
...
# This is the 1st commit message:
Issue #3253 , improve kubernetes-version error string
# This is the commit message #2 :
Issue #3253 , improve kubernetes-version error string
2019-03-22 08:25:35 -04:00
daec030cdf
Render asset template when enabling/disabling addon
2019-03-22 15:28:20 +08:00
7e57cf6ec6
Add some ssh issues
2019-03-21 22:24:37 -07:00
cbac94a53d
Merge pull request #3879 from marcosdiez/extra_config_for_kubeadm
...
--extra-config now work for kubeadm as well
2019-03-21 22:03:06 -07:00
ce71b0dbd6
Merge branch 'master' into bring_ya_errs_to_the_project_maybe_we_can_solve_it
2019-03-21 22:01:06 -07:00
1ff174b796
Run: gofmt -s -w
2019-03-21 22:00:14 -07:00
37e259f7ea
Implement the new problem package
2019-03-21 21:44:51 -07:00
7ae074106c
Merge remote-tracking branch 'origin/master' into custom-image-repository
2019-03-22 10:42:09 +08:00
c4ae58f4d3
Merge pull request #3896 from brb/do-not-wait-for-dns-pod-with-cni
...
Do not wait for k8s-app pods when starting with CNI
2019-03-21 11:49:45 -07:00
06d9210937
Merge pull request #3927 from tstromberg/noswap-2.0
...
Remove the swap partition from minikube.iso
2019-03-21 11:48:25 -07:00
88c45bf5b2
Merge branch 'master' into lint
2019-03-21 11:34:45 -07:00
f9a136a2f2
Merge pull request #3841 from afbjorklund/reportcard
...
Address the low-hanging fruit on report card
2019-03-21 11:33:28 -07:00
460ef571e2
Merge branch 'master' into lint
2019-03-21 11:32:47 -07:00
44d490a042
Merge branch 'mount-intr' of github.com:tstromberg/minikube into mount-intr
2019-03-21 11:24:23 -07:00
cbddc376d2
SIGINT should be exit code 2
2019-03-21 11:23:55 -07:00
4e28becd7e
everybody likes passing tests
2019-03-21 06:33:46 -03:00
7de36ed9a1
allow --extra-config work on kubeadm as well. example: --extra-config kubeadm.ignore-preflight-errors=SystemVerification
...
missing variable
2019-03-21 06:33:46 -03:00
daeb238766
Merge remote-tracking branch 'origin/master' into custom-image-repository
2019-03-21 13:23:11 +08:00
bf4f6ee91c
Clarify why disabling the Swap preflight is good for certain users
2019-03-20 20:50:20 -07:00
3d0f722a6c
Remove -q, as it is not available in this version of findmnt
2019-03-20 20:02:35 -07:00
79aafd525f
Merge branch 'master' into mount-intr
2019-03-20 19:56:43 -07:00
6751e394f8
Merge pull request #3833 from afbjorklund/cruntime-version
...
Cruntime version
2019-03-20 19:55:45 -07:00
0d6c92153f
Merge branch 'master' into reportcard
2019-03-20 19:16:02 -07:00
84b92d1b8f
Merge pull request #3885 from afbjorklund/cache-1.14
...
Update list of cached images for kubernetes 1.14
2019-03-20 19:14:52 -07:00
fd54141f04
Merge pull request #3810 from tstromberg/k8s114
...
Update minikube to be compatible with Kubernetes v1.14.0-beta.1
2019-03-20 19:10:59 -07:00
605088ff72
Keep Initializers as the first element, fix v1.14 test which still included Initializers
2019-03-20 17:23:07 -07:00
7f6eecad37
Merge pull request #3872 from tstromberg/more-logs
...
logs: Add kube-proxy, dmesg, uptime, uname + newlines between log sources
2019-03-20 16:47:34 -07:00
88091b2323
Fix DefaultLegacyAdmissionControllers comment
2019-03-20 16:45:39 -07:00
66b18c878c
Merge branch 'master' into k8s114
2019-03-20 16:43:32 -07:00
c1a0264161
Merge pull request #3832 from tstromberg/k8s-v1.10.0
...
Skip "pull" command if using Kubernetes 1.10, which does not support it.
2019-03-20 16:42:39 -07:00
7eeb0a7925
Revert "Use --kubeconfig for v1.10.x, instead of skipping the pull"
...
This reverts commit 0c1b51ced3
2019-03-20 16:40:12 -07:00
4756b15bc1
Merge branch 'master' into lint
2019-03-20 10:16:09 -07:00
177ce6597d
Merge pull request #3830 from tstromberg/find-probelms
...
Add problem detection for #3818 - no providers available
2019-03-20 10:14:04 -07:00
1eca3e096b
Merge branch 'master' into k8s-v1.10.0
2019-03-20 10:12:49 -07:00
0c1b51ced3
Use --kubeconfig for v1.10.x, instead of skipping the pull
2019-03-20 10:07:25 -07:00
443accf1e0
Update link to drive docs in xhyve driver
...
Signed-off-by: Marco Vito Moscaritolo <mavimo@gmail.com>
2019-03-19 08:53:11 +01:00
2d8e577b33
Do not wait for k8s-app pods when starting with CNI
...
Previously, minikube was waiting for some pods labeled with
"k8s-app" (e.g. "kube-dns") to be ready before indicating that
"minikube start" was successful. However, in the case of
"network-plugin=cni", network of such pods is managed by a CNI
plugin which is usually started after "minikube start" has returned
making the waiting for the pods to fail with:
Error starting cluster: wait: waiting for k8s-app=kube-dns: timed out
waiting for the condition
This commit omits waiting for "k8s-app" pods if minikube is started
with "network-plugin=cni".
Reported-by: Michal Rostecki <mrostecki@opensuse.org>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
2019-03-18 11:13:55 +01:00
03bdce47ee
Decrease cyclomatic complexity for test
...
Mostly by using the "extract method" pattern.
Here was the report (from gocyclo), before:
17 tunnel TestTunnelManagerCleanup pkg/minikube/tunnel/tunnel_manager_test.go:174:1
44 tunnel TestTunnel pkg/minikube/tunnel/tunnel_test.go:35:1
34 kubeconfig configEquals pkg/util/kubeconfig/config_test.go:420:1
25 integration testMounting test/integration/mount_test.go:36:1
18 integration testTunnel test/integration/tunnel_test.go:37:1
2019-03-16 23:04:24 +01:00
00c9846a19
Decrease cyclomatic complexity for code
...
Mostly by using the "extract method" pattern.
Here was the report (from gocyclo), before:
16 kubeadm (*KubeadmBootstrapper).UpdateCluster pkg/minikube/bootstrapper/kubeadm/kubeadm.go:374:1
16 cluster StartHost pkg/minikube/cluster/cluster.go:64:1
16 tunnel setupRoute pkg/minikube/tunnel/tunnel.go:135:1
16 provision configureAuth pkg/provision/buildroot.go:218:1
21 util setElement pkg/util/config.go:50:1
2019-03-16 22:18:14 +01:00
5497b966be
Rename stutter and move classes between packages
...
Removing the kubeconfig module is probably not a big deal,
since it was already hiding under the "util" directory...
But the layout of the Bootstrapper is slightly irritating,
as long as it is contained in a different "kubeadm" module.
2019-03-16 16:57:56 +01:00
dba916a016
Document all exported functions inside minikube
...
Make config get/set more symmetrical, as well.
2019-03-16 16:57:43 +01:00
edf46f003f
Document all exported functions outside minikube
2019-03-16 16:57:37 +01:00
40caf8317c
Merge remote-tracking branch 'upstream/master' into custom-image-repository
2019-03-15 18:01:48 +08:00
016e3f3178
Merge pull request #3767 from tstromberg/cache_images_int_test2
...
caching: Fix containerd, improve console messages, add integration tests
2019-03-14 08:19:25 -07:00
0422b9c567
Add kube-proxy and dmesg logs + newlines between log sources
2019-03-13 14:53:14 -07:00
1ec970a7fd
Remove random unicode character
2019-03-11 16:18:42 -07:00
c713b186e8
unmount on sigint/sigterm, --options and --mode, improve mount UI
2019-03-11 16:18:06 -07:00
5f290a1a6e
Merge pull request #3819 from presslabs/fix-tunnel-error
...
Fix tunnel error logging
2019-03-11 09:37:26 -07:00
90527daf72
Update list of cached images for kubernetes 1.14
2019-03-10 15:57:10 +01:00
6d96a67456
Run go vet on all code, not just pkg and cmd
2019-03-10 14:33:24 +01:00
0d8e591a4a
Fix some misc typos, as reported by misspell
...
minikube/pkg/gvisor/enable.go
Line 120: warning: "downlaods" is a misspelling of "downloads" (misspell)
minikube/pkg/minikube/console/style.go
Line 96: warning: "embarassed" is a misspelling of "embarrassed" (misspell)
2019-03-10 13:43:04 +01:00
dabe7665f2
Return error from Close, as reported by go vet
...
minikube/pkg/minikube/tunnel/registry.go
Line 124: error: result of fmt.Errorf call not used (vet)
Line 161: error: result of fmt.Errorf call not used (vet)
2019-03-10 13:40:39 +01:00
7d1fdab6bc
Add unit test for container runtime version
...
This only tests the happy path of the current iso versions.
2019-03-10 10:37:55 +01:00
112a66c21a
Add some error reporting to the version method
2019-03-10 10:18:26 +01:00
0c67b60604
Add Version() function to the Manager interface
...
Helps with troubleshooting container runtimes
2019-03-10 10:09:13 +01:00
f968cb7709
Don't try to run the images pull command on old versions of kubeadm
2019-03-08 10:52:13 -08:00
6a36191bb4
Merge branch 'master' into find-probelms
2019-03-08 10:20:39 -08:00
4a7e68c6b7
Add detection for #3818 - no providers available
2019-03-08 09:51:08 -08:00
229137c06b
Fix tunnel error logging
2019-03-07 11:38:26 +02:00
56a51ffe0d
Merge branch 'master' into cache_images_int_test2
2019-03-06 15:21:11 -08:00
a4841d9d72
Merge pull request #3796 from kron4eg/patch-1
...
Change DefaultMountVersion to 9p2000.L
2019-03-06 14:13:50 -08:00
327fdd8d4b
Update kubeadm config generation to be compatible with v1.14.0-beta.1
2019-03-06 13:32:33 -08:00
ae27bb1e85
Update default to v1.13.4
2019-03-06 11:37:29 -08:00
1607e9f8ea
Change DefaultMountVersion to 9p2000.L
...
Fixes #2290
2019-03-05 14:45:36 +02:00
5b709b2b0a
Failure to read documentation isn't really a crash
2019-03-04 20:23:23 +01:00
46640cef68
Address all lint except undocumented and stutter
...
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"
"type name will be used as foo.FooBar by other packages,
and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
794bc6cedd
Merge pull request #3780 from afbjorklund/logs
...
Fix minikube logs for other container runtimes
2019-03-01 15:49:23 -08:00
df5bbc3c8a
Fix minikube logs for other container runtimes
...
It is only Docker that adds the "k8s_" prefix, since CRI
only handles containers that are used by Kubernetes anyway.
Also need to use "sudo" when running all crictl commands,
including logs. And only list containers that are running.
2019-03-01 20:56:45 +01:00
b9675da28b
Add comment about optimization
2019-03-01 11:03:06 -08:00
a11e1c3c27
retry updateKubeProxyConfigMap
2019-03-01 10:54:18 -08:00
eae5b34100
Only restart kube-proxy if necessary, make certain steps retialble
2019-03-01 10:53:55 -08:00
a2865f183a
Back to the original 10 minute timeout :(
2019-03-01 10:50:39 -08:00
2f1f52edba
Add reconfiguring style
2019-02-28 16:40:55 -08:00
c40602b327
ReasonableStartTime = 8, for folks with CrashLooping DNS on none
2019-02-28 16:40:46 -08:00
a4be5ee438
Have StartCluster/RestartCluster block until system pods are healthy
2019-02-28 16:27:35 -08:00
3b2a81d409
Increase ReasonableStartTime from 5 to 9 minutes
2019-02-28 16:26:42 -08:00
4c48753ba0
Docker doesn't need to use sudo
2019-02-28 12:05:30 -08:00
e09133892f
Fix docker/containerd caching, improve msgs, add tests
2019-02-27 13:58:33 -08:00
167d1584a6
Add flag for disabling the VirtualBox VTX check
...
Currently this is broken upstream, provide workaround...
Already available in docker-machine, so port to minikube.
2019-02-22 18:29:29 +01:00
e753a90be0
Add test cases for NewKubeletConfig
2019-02-18 11:03:04 +08:00
39fcf1fe20
Add test cases for custom image repository feature
2019-02-18 01:00:22 +08:00
Thomas Strömberg
Kubernetes Prow Robot
Jan Janik
Benn Linger
Oleg Atamanenko
Arnaud Jardiné
Anders F Björklund
Zhongcheng Lao
Andy Daniels
flyingcircle
Marcos Diez
Marco Vito Moscaritolo
Martynas Pumputis
Calin Don
Artiom Diomin