Commit Graph

24 Commits (ae87c281a8e7fc2b75b51b9613ab89640fed3216)

Author SHA1 Message Date
Nir Soffer 62529ec03e
spelling: Fix spelling errors with codespell (#21273)
Fix trivial spelling errors using codespell[1]:

    codespell --skip '*.yaml,*.tmpl,*.json,*.html,*.patch,go.sum' -w

And rejecting some false positives fixes:

    ./CHANGELOG.md:907: fliter ==> filter
    ./third_party/go9p/clnt_write.go:48: Writen ==> Written
    ./third_party/kubeadm/app/features/features.go:69: AtLeast ==> at least
    ./site/content/en/docs/contrib/translations.md:106: certificats ==> certificates
    ./site/content/en/docs/contrib/translations.md:113: espace ==> escape
    ./site/content/en/docs/tutorials/amd.md:75: HSA ==> HAS
    ./site/content/en/docs/tutorials/amd.md:87: HSA ==> HAS
    ./pkg/minikube/config/extra_options_test.go:143: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:151: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:152: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:168: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:177: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:178: expRes ==> express

There are more spelling errors that need manual selection:

    ./CHANGELOG.md:234: issuse ==> issue, issues
    ./CHANGELOG.md:543: Pris ==> Prise, Prism
    ./hack/benchmark/time-to-k8s/page.go:73: readin ==> reading, read in
    ./hack/benchmark/image-build/generate-chart.go:82: INTERATIVE ==> INTERACTIVE, ITERATIVE
    ./hack/benchmark/image-build/generate-chart.go:87: INTERATIVE ==> INTERACTIVE, ITERATIVE
    ./hack/benchmark/image-build/generate-chart.go:137: INTERATIVE ==> INTERACTIVE, ITERATIVE
    ./hack/benchmark/image-build/generate-chart.go:162: interative ==> interactive, iterative
    ./hack/benchmark/image-build/generate-chart.go:195: INTERATIVE ==> INTERACTIVE, ITERATIVE
    ./third_party/go9p/fmt.go:132: Tread ==> Thread, Treat
    ./third_party/go9p/fmt.go:133: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:33: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:170: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:171: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:225: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:263: Tread ==> Thread, Treat
    ./third_party/go9p/packt.go:165: Tread ==> Thread, Treat
    ./third_party/go9p/packt.go:168: Tread ==> Thread, Treat
    ./third_party/go9p/srv_srv.go:305: Tread ==> Thread, Treat
    ./third_party/go9p/srv_srv.go:349: Tread ==> Thread, Treat
    ./third_party/go9p/unpack.go:170: Tread ==> Thread, Treat
    ./site/content/en/docs/tutorials/multi_control_plane_ha_clusters.md:145: Virual ==> Virtual, Visual, Viral
    ./pkg/drivers/krunkit/krunkit.go:392: Terminte ==> Terminate, Termite
    ./pkg/drivers/common/common.go:283: drawin ==> drawing, draw in, drawn
    ./pkg/drivers/kic/oci/oci.go:175: stroed ==> stored, stroked, strode
    ./pkg/minikube/out/out.go:412: isT ==> is, it, its, it's, sit, list
    ./pkg/minikube/out/out.go:413: isT ==> is, it, its, it's, sit, list
    ./pkg/minikube/out/out.go:414: isT ==> is, it, its, it's, sit, list
    ./pkg/minikube/shell/shell_test.go:152: writed ==> wrote, written, write, writer
    ./pkg/minikube/bootstrapper/kubeadm/kubeadm.go:710: wil ==> will, well

If we find a way to prevent the false positives we can use this command
for spell checking in the CI.

[1] https://github.com/codespell-project/codespell
2025-08-11 11:27:20 -07:00
x7upLime 8931619b01 Applied suggestions 2023-04-25 15:11:41 +03:00
x7upLime 3d3e6a14e7 added stuff to reflect suggestions 2023-04-22 00:49:30 +03:00
x7upLime 3b3d2905a1 Changes variable name in integrataion test 2023-04-22 00:49:30 +03:00
x7upLime ee22b47795 Apply suggestions from code review 2023-04-22 00:49:30 +03:00
x7upLime b5d5bbe38c Removes external lib dependency
Since the test is failing on architectures/platform I can't reproduce
on.. I'm readapting the test in such a way to minimize the amount of
code that can be responsible for the error.

We're not looking for all system processes in order to find our
mount processes(ps -ef); we're looking directly at the mount
processes that have been spawned by our test instead.

To say that a process is no longer alive:
We try to wait for conclusion to get the processState.
If the wait results in an *ExitError, it means that either
the proc has failed to run, or it exited failing(see doc);
in both cases we're happy.. since we previously made a check
to know that those same processes were alive.
2023-04-22 00:48:58 +03:00
x7upLime 70a0ed2aac Modifies integration test label
yeah.. perhaps that's a better name
2023-04-22 00:47:06 +03:00
x7upLime 849de9086b Adds documentation for validateMountCmd test
working towards #11571 :)
2023-04-22 00:47:06 +03:00
x7upLime 07f3f440ff Fixes lint error
The message from the linter makes a good point..
we're storing a reference for the mount processes, but we're not
using them.. Thus the committed lines.
2023-04-22 00:47:06 +03:00
x7upLime 47981b75d9 Add integration test for mount-clean mechanism
I copied as much code as I could from the previous tests
that seemed more alike to the one I was trying to build.

I put it inside the functional mount tests,
with the other mount-command related tests,
as I thought (as per comments on "TestFunctional()") it
could safely share a profile in parallel..
2023-04-22 00:47:06 +03:00
Akihiro Suda 6ab61b7a75
CI: add functional_docker_rootless_containerd_ubuntu
Fix issue 12456

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-01-12 08:13:58 +09:00
Steven Powell 2e4ea3c259 replace MkdirTemp with t.TempDir in tests 2022-04-01 19:18:20 -07:00
Steven Powell 1aa1f04e9b remove old build tags 2022-03-30 16:43:29 -07:00
Steven Powell 2d20e0ac80 add test skips back 2021-11-23 08:52:58 -08:00
Steven Powell 8c4f907b7b try fixing bad mount error 2021-11-22 17:13:37 -08:00
Steven Powell 6e68f73606 skip mount/any-port until mouting issue resolved 2021-11-17 12:07:06 -08:00
KallyDev 70022d9b2e
Move from deprecated ioutil to os and io packages 2021-10-08 08:57:19 +08:00
Steven Powell 145f9fc9ab run `go fmt` 2021-09-13 11:58:43 -07:00
Medya Gh ccf4af0997 change depricated golint to revive and fix lint issues 2021-08-12 18:11:16 -07:00
Andriy Dzikh 5ca1164fb9 Create test for mounting with port. 2021-07-14 17:52:21 -07:00
Ilya Zuyev fe392b4233 When getting a gateway IP for podman container inspect per-network data as well 2021-05-05 15:09:46 -07:00
Ilya Zuyev 30f8a38fff add functional_podman_ubuntu test
Fix test error messages

Fix test comment and docs
2021-05-05 13:49:51 -07:00
Medya Gh 1207de734b bump golang lint ci to latest 2021-04-19 15:16:31 -07:00
Sharif Elgamal 0ed5b13995 add docs for all integration tests and generate docs with them 2021-04-16 13:42:41 -07:00