Commit Graph

1317 Commits (ae87c281a8e7fc2b75b51b9613ab89640fed3216)

Author SHA1 Message Date
minikube-bot 5c17d7a6b1 CI: Update gh from 2.82.0 to 2.82.1 2025-10-25 08:04:55 +00:00
Medya Ghazizadeh 32550882d8
Merge pull request #21765 from minikube-bot/auto_bump_gh_version
CI: Update gh from 2.81.0 to 2.82.0
2025-10-20 16:06:01 -07:00
Nir Soffer 7bc97d7ce1 kvm: Convert to internal driver
Remove the docker-machine-driver-kvm2 wrapper and use the kvm driver as
internal driver.

To avoid dependency on libvirt shared library on Linux, we build now
with the libvirt_dlopen build tag. This is used only linux to avoid
linking with libvirt shared library. This is not documnted but can be
found in the source.
f7cdeba997/domain.go (L30)

With this we don't need libvirt devel libraries during build, and in
runtime we will fail if libvirt shared library is not installed.

With this change minikube can not be built for linux !amd64 since building
libvirt go binding requires CGO, and it does not work by changing GOARCH.
2025-10-19 17:20:47 +03:00
minikube-bot 7490a298eb CI: Update gh from 2.81.0 to 2.82.0 2025-10-18 08:04:53 +00:00
Medya Ghazizadeh 13941d0719
Merge pull request #21697 from minikube-bot/auto_bump_gh_version
CI: Update gh from 2.80.0 to 2.81.0
2025-10-06 13:51:50 -07:00
minikube-bot 011c65a653 CI: Update gh from 2.80.0 to 2.81.0 2025-10-06 10:02:24 +00:00
Nir Soffer b4f0f94982 Remove trailing whitespace
My editor is configured to remove trailing spaces automatically. Adding
as a separate commit to minimize the actual change and allow commit this
change separately from the kvm driver change.
2025-10-03 22:19:58 +03:00
Nir Soffer 6736ba978e hack: Fix review comment for failed iso build
When we fixed the way we detect failure #21544, we broke the heredoc.
The script fails now with[1]:

    ./hack/jenkins/build_iso.sh: line 74: unexpected EOF while looking for matching `)'
    Build step 'Execute shell' marked build as failure

Fixes:
- Use unquoted delimiter (EOF, not 'EOF') to allow variable expansion in
  the content.
- Fix content indentation to avoid unwanted leading whitespace
- Fix location of the EOF - it must be start of the last line
- Add the missing closing ")"
- Remove the unneeded double quote
- Unify indentation to 4 spaces for consistency with the rest of the
  file.

[1] https://storage.googleapis.com/minikube-builds/logs/21409/e4af2e4/iso_build.txt
2025-09-30 21:38:12 +03:00
Medya Ghazizadeh 23a200a51c
Merge pull request #21653 from minikube-bot/auto_bump_gh_version
CI: Update gh from 2.78.0 to 2.80.0
2025-09-30 11:05:04 -07:00
minikube-bot d64bac8155 CI: Update gotestsum from v1.12.3 to v1.13.0 2025-09-29 10:09:33 +00:00
minikube-bot 721fb778ab CI: Update gh from 2.78.0 to 2.80.0 2025-09-29 10:02:27 +00:00
Medya Ghazizadeh dfb4f364ff
Merge pull request #21544 from medyagh/iso_fail_comment_fix
ci: fix failed ISO not commenting on PR
2025-09-26 12:56:22 -07:00
Predrag Rogic 0e4fa50244
set sysctl params for inotify, to avoid 'too many open files' errors 2025-09-20 04:03:41 +01:00
Medya Ghazizadeh 3a8d719855 review comment 2025-09-17 14:02:50 -07:00
Medya Ghazizadeh 398f3ecca1 ci: fix failed ISO not commenting on PR 2025-09-12 23:04:30 -07:00
minikube-bot 18eea256f6 Kicbase/ISO: Update cni-plugins from v1.7.1 to v1.8.0 2025-09-08 17:52:16 +00:00
minikube-bot 1b116ed090 CI: Update gh from 2.76.2 to 2.78.0 2025-08-25 13:40:25 -07:00
minikube-bot 63a496bf4d
Update go from 1.24.0 to 1.24.6 (#21348)
* Update go from 1.24.5 to 1.24.6

* Updating kicbase image to v0.0.47-1755508051-21348
2025-08-18 12:38:34 -07:00
dependabot[bot] 059ceb838f
Build(deps): Bump golang.org/x/oauth2 (#21313)
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.21.0 to 0.27.0.
- [Commits](https://github.com/golang/oauth2/compare/v0.21.0...v0.27.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-version: 0.27.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-12 11:35:17 -07:00
dependabot[bot] 56a5aa1df0
Build(deps): Bump google.golang.org/grpc (#21315)
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.64.0 to 1.64.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.64.0...v1.64.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-version: 1.64.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-12 11:35:06 -07:00
dependabot[bot] 5219b65b7c
Build(deps): Bump golang.org/x/net (#21320)
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.26.0 to 0.38.0.
- [Commits](https://github.com/golang/net/compare/v0.26.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-12 10:17:01 -07:00
Nir Soffer 62529ec03e
spelling: Fix spelling errors with codespell (#21273)
Fix trivial spelling errors using codespell[1]:

    codespell --skip '*.yaml,*.tmpl,*.json,*.html,*.patch,go.sum' -w

And rejecting some false positives fixes:

    ./CHANGELOG.md:907: fliter ==> filter
    ./third_party/go9p/clnt_write.go:48: Writen ==> Written
    ./third_party/kubeadm/app/features/features.go:69: AtLeast ==> at least
    ./site/content/en/docs/contrib/translations.md:106: certificats ==> certificates
    ./site/content/en/docs/contrib/translations.md:113: espace ==> escape
    ./site/content/en/docs/tutorials/amd.md:75: HSA ==> HAS
    ./site/content/en/docs/tutorials/amd.md:87: HSA ==> HAS
    ./pkg/minikube/config/extra_options_test.go:143: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:151: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:152: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:168: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:177: expRes ==> express
    ./pkg/minikube/config/extra_options_test.go:178: expRes ==> express

There are more spelling errors that need manual selection:

    ./CHANGELOG.md:234: issuse ==> issue, issues
    ./CHANGELOG.md:543: Pris ==> Prise, Prism
    ./hack/benchmark/time-to-k8s/page.go:73: readin ==> reading, read in
    ./hack/benchmark/image-build/generate-chart.go:82: INTERATIVE ==> INTERACTIVE, ITERATIVE
    ./hack/benchmark/image-build/generate-chart.go:87: INTERATIVE ==> INTERACTIVE, ITERATIVE
    ./hack/benchmark/image-build/generate-chart.go:137: INTERATIVE ==> INTERACTIVE, ITERATIVE
    ./hack/benchmark/image-build/generate-chart.go:162: interative ==> interactive, iterative
    ./hack/benchmark/image-build/generate-chart.go:195: INTERATIVE ==> INTERACTIVE, ITERATIVE
    ./third_party/go9p/fmt.go:132: Tread ==> Thread, Treat
    ./third_party/go9p/fmt.go:133: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:33: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:170: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:171: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:225: Tread ==> Thread, Treat
    ./third_party/go9p/p9.go:263: Tread ==> Thread, Treat
    ./third_party/go9p/packt.go:165: Tread ==> Thread, Treat
    ./third_party/go9p/packt.go:168: Tread ==> Thread, Treat
    ./third_party/go9p/srv_srv.go:305: Tread ==> Thread, Treat
    ./third_party/go9p/srv_srv.go:349: Tread ==> Thread, Treat
    ./third_party/go9p/unpack.go:170: Tread ==> Thread, Treat
    ./site/content/en/docs/tutorials/multi_control_plane_ha_clusters.md:145: Virual ==> Virtual, Visual, Viral
    ./pkg/drivers/krunkit/krunkit.go:392: Terminte ==> Terminate, Termite
    ./pkg/drivers/common/common.go:283: drawin ==> drawing, draw in, drawn
    ./pkg/drivers/kic/oci/oci.go:175: stroed ==> stored, stroked, strode
    ./pkg/minikube/out/out.go:412: isT ==> is, it, its, it's, sit, list
    ./pkg/minikube/out/out.go:413: isT ==> is, it, its, it's, sit, list
    ./pkg/minikube/out/out.go:414: isT ==> is, it, its, it's, sit, list
    ./pkg/minikube/shell/shell_test.go:152: writed ==> wrote, written, write, writer
    ./pkg/minikube/bootstrapper/kubeadm/kubeadm.go:710: wil ==> will, well

If we find a way to prevent the false positives we can use this command
for spell checking in the CI.

[1] https://github.com/codespell-project/codespell
2025-08-11 11:27:20 -07:00
minikube-bot 04a22388c1
CI: Update gh from 2.74.2 to 2.76.2 (#21227) 2025-08-04 16:42:19 -07:00
Medya Ghazizadeh 931291170f
license: don't fail if output dir doesn't exist & download from github assets first (#21206)
* copy licenses to gh assests as well

* download licneses from github

* try head first to make code more simple

* remove debug

* fix extra dash

* create license directory if doesnt exist

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha

* Apply suggestion from prezha
2025-08-01 20:02:13 -07:00
Nir Soffer 56975bc752
Add krunkit driver supporting GPU acceleration on macOS (#20826)
* krunkit: Add krunkit driver

krunkit is a tool to launch configurable virtual machines using the
libkrun platform, optimized for GPU accelerated virtual machines and AI
workloads on Apple silicon.

It is mostly compatible with vfkit; the driver is a simplified copy of
the vfkit driver. Unlike vfkit, krunkit is available only on Apple
silicon.

Changes compared to vfkit driver:
- krunkit requires unix socket for networking, so we must use
  vment-helper.
- krunkit does not support HardStop, so we kill it using SIGKILL.
- We must enable vmnet offloading, required for krunkit.
- The code was simplified since vmnet-helper is always used
- Code was cleaned up to use .ResolveStorePath()
- Unused Upgrade() function was removed
- Types and functions that should not be public made private

We require krunkit 0.2.2, supporting --restul-uri=unix://.

* reason: Make vment-helper error driver agnostic

Previously it was used only for vfkit, so we suggested to fallback to
the `nat` network. This advice is not relevant to krunkit or to qemu
(which can also use vmnet-helper).

Change the error to recommend installing vment-helper. We need to think
how we can recommend other networks for vfkit and qemu. Another solution
is to create error for every driver+network combination but this seems
hard to manage.

* hack: Add krunkit integration test

This is the same way that we test vfkit. This test is not running in the
CI.

Issues:
- Need to install and configure vment-helper (requires root).

* site: Add krunkit driver documentation
2025-07-21 12:59:28 -07:00
Medya Ghazizadeh 7d8d9741db
fix dirty commit version (#21062)
* fix release script detecting dirty commit

* add go-licenses to gitignore

* add more help text
2025-07-14 10:49:49 -07:00
Cosmic Oppai 78989b99c2
Update common.ps1 (#20820) 2025-07-10 10:31:11 -07:00
Medya Ghazizadeh 4756f9c0aa
login docker (#21042) 2025-07-08 10:06:19 -07:00
Medya Ghazizadeh 8c6446f0c1
ci: login to docker during build process (#21027)
* login to docker during build process

* add readonly token for docker hub

* use stdin

* add quote

* try with -p

* remove one

* add comment
2025-07-03 13:42:20 -07:00
minikube-bot dbebd8768e
CI: Update gh from 2.74.1 to 2.74.2 (#20967) 2025-06-23 11:58:24 -07:00
minikube-bot 4bea142841
CI: Update gotestsum from v1.12.2 to v1.12.3 (#20975) 2025-06-23 11:57:49 -07:00
minikube-bot 16ff3bf929
CI: Update gh from 2.74.0 to 2.74.1 (#20937) 2025-06-17 10:56:36 -07:00
minikube-bot 4bca65a646
CI: Update gh from 2.73.0 to 2.74.0 (#20867) 2025-06-03 15:27:30 -07:00
minikube-bot 85a9ffb4ec
CI: Update gh from 2.72.0 to 2.73.0 (#20839) 2025-05-28 13:01:29 -07:00
Nir Soffer 56ed2662b0
vfkit: Minor docs, test, and help fixes (#20815)
* vfkit: Fix help text for --extra-disks

vfkit can use extra disks but we forgot to mention it in the help text.

* vfkit: Remove stale tap

vfkit in cfergeau/crc will no longer be updated now that it’s in the main repo.

* vfkit: Fix status in index

The vfkit driver is preferred now.
2025-05-21 20:30:26 -07:00
minikube-bot 9171dbbc18
Kicbase/ISO: Update cni-plugins from v1.6.2 to v1.7.1 (#20771)
* Kicbase/ISO: Update cni-plugins from v1.6.2 to v1.7.1

* Updating kicbase image to v0.0.46-1747341282-20771

* Updating ISO to v1.35.0-1747341198-20771
2025-05-16 11:31:38 -07:00
minikube-bot a141f42521
Kicbase/ISO: Update cri-dockerd from v0.3.15 to v0.4.0 (#20747)
* Kicbase/ISO: Update cri-dockerd from v0.3.15 to v0.4.0

* Updating kicbase image to v0.0.46-1747166185-20747

* Updating ISO to v1.35.0-1747160120-20747
2025-05-14 14:49:05 -07:00
minikube-bot c8b44b65a4
CI: Update gotestsum from v1.12.1 to v1.12.2 (#20738) 2025-05-12 10:18:09 -07:00
minikube-bot dd51a5f9a8
CI: Update gh from 2.71.2 to 2.72.0 (#20698) 2025-05-08 11:26:56 -07:00
minikube-bot 9797ec1b10
CI: Update gh from 2.70.0 to 2.71.2 (#20664) 2025-04-28 14:57:30 -04:00
minikube-bot 8d3946f8d4
CI: Update gh from 2.66.1 to 2.70.0 (#20420) 2025-04-24 11:52:39 -07:00
minikube-bot 87be78cacf
CI: Update gotestsum from v1.12.0 to v1.12.1 (#20541) 2025-03-18 15:04:18 -07:00
minikube-bot 7512311745
Update go from 1.23.4 to 1.24.0 (#20510)
* Update go from 1.23.4 to 1.24.0

* Updating kicbase image to v0.0.46-1741597657-20510
2025-03-10 10:37:40 -07:00
minikube-bot 4d1052b78b CI: Update gh from 2.65.0 to 2.66.1 2025-02-03 10:02:35 +00:00
锦南路之花 de79a33d2c fix: fix missing kicbase in release 2025-01-27 11:28:37 -08:00
Predrag Rogic dd5d320e41 fix verion comparison in check_install_golang script 2025-01-15 16:45:06 -08:00
Medya Gh 49981a7920 remove gopath and check installing go on release job 2025-01-15 15:42:35 -08:00
minikube-bot 298599cc50 Update go from 1.23.3 to 1.23.4 2025-01-15 15:10:49 -08:00
锦南路之花 bfc2436dda fix: add missing latest rpm and deb links and packages 2025-01-15 12:04:07 -08:00
Medya Ghazizadeh 970161c10c
delete macos test infra (#20244) 2025-01-13 19:31:06 -08:00