This was done by running:
make update-inspektor-gadget-version
ig-crd.yaml is removed because this was removed by Inspektor Gadget in
v0.42.0 (released in July).
See:
1d81a61312
Signed-off-by: Alban Crequy <alban.crequy@gmail.com>
Remove the docker-machine-driver-kvm2 wrapper and use the kvm driver as
internal driver.
To avoid dependency on libvirt shared library on Linux, we build now
with the libvirt_dlopen build tag. This is used only linux to avoid
linking with libvirt shared library. This is not documnted but can be
found in the source.
f7cdeba997/domain.go (L30)
With this we don't need libvirt devel libraries during build, and in
runtime we will fail if libvirt shared library is not installed.
With this change minikube can not be built for linux !amd64 since building
libvirt go binding requires CGO, and it does not work by changing GOARCH.
My editor is configured to remove trailing spaces automatically. Adding
as a separate commit to minimize the actual change and allow commit this
change separately from the kvm driver change.
When we fixed the way we detect failure #21544, we broke the heredoc.
The script fails now with[1]:
./hack/jenkins/build_iso.sh: line 74: unexpected EOF while looking for matching `)'
Build step 'Execute shell' marked build as failure
Fixes:
- Use unquoted delimiter (EOF, not 'EOF') to allow variable expansion in
the content.
- Fix content indentation to avoid unwanted leading whitespace
- Fix location of the EOF - it must be start of the last line
- Add the missing closing ")"
- Remove the unneeded double quote
- Unify indentation to 4 spaces for consistency with the rest of the
file.
[1] https://storage.googleapis.com/minikube-builds/logs/21409/e4af2e4/iso_build.txt
Replace traditional append-in-loop patterns with modern Go functions slices.Sorted(), slices.Collect(), and maps.Keys()/maps.Values()
Changes made (5 files):
- cmd/minikube/cmd/config/addons_list.go: Use slices.Sorted(maps.Keys())
- cmd/minikube/cmd/version.go: Use slices.Sorted(maps.Keys())
- hack/changelog/changelog.go: Use slices.Collect(maps.Keys())
- pkg/minikube/node/cache.go: Use slices.Collect(maps.Keys())
- pkg/minikube/registry/registry.go: Use slices.Collect(maps.Values())
Files skipped due to complexity:
- pkg/drivers/kic/oci/oci.go
- pkg/drivers/hyperkit/driver.go
- pkg/drivers/kvm/gpu.go
- pkg/drivers/kvm/numa.go [Unrelated slice optimization possible, can be addressed along with other similar code]
- pkg/minikube/tunnel/kic/*
- cmd/minikube/cmd/service.go
- hack/legacy_fill_db/filldb.go
These cases require more sophisticated transformation logic that might be better addressed in separate issue/PR
Medya Ghazizadeh
ComradeProgrammer
minikube-bot
Alban Crequy
Nir Soffer
Medya Ghazizadeh
Predrag Rogic
dependabot[bot]
Kaviraj Sankameeswaran