Commit Graph

268 Commits (a940203ed49d1e127c6b856bf29115a6c5182b45)

Author SHA1 Message Date
Medya Ghazizadeh ddd9ba27c5
Merge pull request #10991 from kubernetes/dependabot/go_modules/github.com/shirou/gopsutil/v3-3.21.3
Bump github.com/shirou/gopsutil/v3 from 3.21.2 to 3.21.3
2021-04-07 16:59:51 -07:00
Ilya Zuyev d1431f67a6 exit if run amd64 binary on M1 cpu 2021-04-07 15:44:03 -07:00
Medya Ghazizadeh 726e26b154
Merge pull request #10983 from alonyb/upgrade-spinner
upgrade spinner library
2021-04-05 13:17:03 -07:00
dependabot[bot] b102765347
Bump github.com/shirou/gopsutil/v3 from 3.21.2 to 3.21.3
Bumps [github.com/shirou/gopsutil/v3](https://github.com/shirou/gopsutil) from 3.21.2 to 3.21.3.
- [Release notes](https://github.com/shirou/gopsutil/releases)
- [Commits](https://github.com/shirou/gopsutil/compare/v3.21.2...v3.21.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-05 07:59:28 +00:00
dependabot[bot] 32e9c4d034
Bump github.com/cheggaaa/pb/v3 from 3.0.6 to 3.0.7
Bumps [github.com/cheggaaa/pb/v3](https://github.com/cheggaaa/pb) from 3.0.6 to 3.0.7.
- [Release notes](https://github.com/cheggaaa/pb/releases)
- [Commits](https://github.com/cheggaaa/pb/compare/v3.0.6...v3.0.7)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-05 07:58:50 +00:00
alonyb ef114ccc1c upgrade spinner library 2021-04-04 15:28:45 -05:00
dependabot[bot] ab1dce0e69
Bump google.golang.org/api from 0.40.0 to 0.43.0
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.40.0 to 0.43.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md)
- [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.40.0...v0.43.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-30 02:09:34 +00:00
Medya Gh 11c9b70b06 klog 2021-03-29 15:01:06 -07:00
Medya Ghazizadeh 660cc42e88
Merge pull request #10823 from azhao155/yzhao/feature/auto-hook
Add auto-pause webhook to inject env into pods for redirecting in-cluster kubectl request to reverse proxy of api server.
2021-03-29 09:53:14 -07:00
dependabot[bot] daea14dbf8
Bump golang.org/x/text from 0.3.4 to 0.3.5
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.4 to 0.3.5.
- [Release notes](https://github.com/golang/text/releases)
- [Commits](https://github.com/golang/text/compare/v0.3.4...v0.3.5)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-29 07:41:47 +00:00
Medya Ghazizadeh f567893cdb
Merge pull request #10872 from tharun208/feat/docker_env_status
add docker-env and podman-env to minikube status
2021-03-23 20:44:11 -07:00
Tharun d72eea61c9 add test for docker-env status check and fix feedbacks
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-23 23:25:38 +05:30
Predrag Rogic d3750704de
k8s libs: upgrade to v0.20.5 2021-03-23 14:30:22 +00:00
Predrag Rogic 03050a6b81
k8s libs: upgrade to v0.20.5 2021-03-23 14:28:55 +00:00
Predrag Rogic 368703ca35
k8s libs: upgrade to v0.20.5 2021-03-23 14:28:00 +00:00
hetong07 5f0720e042 update go.sum and go.mod to reflect https://github.com/machine-drivers/machine/pull/33 2021-03-22 21:51:34 -07:00
dependabot[bot] dfe6c07adb
Bump github.com/otiai10/copy from 1.0.2 to 1.5.0
Bumps [github.com/otiai10/copy](https://github.com/otiai10/copy) from 1.0.2 to 1.5.0.
- [Release notes](https://github.com/otiai10/copy/releases)
- [Commits](https://github.com/otiai10/copy/compare/v1.0.2...v1.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-23 04:19:19 +00:00
dependabot[bot] a3b51cb912
Bump github.com/shirou/gopsutil/v3 from 3.21.1 to 3.21.2
Bumps [github.com/shirou/gopsutil/v3](https://github.com/shirou/gopsutil) from 3.21.1 to 3.21.2.
- [Release notes](https://github.com/shirou/gopsutil/releases)
- [Commits](https://github.com/shirou/gopsutil/compare/v3.21.1...v3.21.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-23 03:48:08 +00:00
Medya Ghazizadeh 141a7da152
Merge pull request #10818 from afbjorklund/box-cli
Add a red box around docker desktop registry port
2021-03-22 18:48:51 -07:00
dependabot[bot] 3c5d1d6579
Bump k8s.io/klog/v2 from 2.4.0 to 2.8.0
Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.4.0 to 2.8.0.
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/master/RELEASE.md)
- [Commits](https://github.com/kubernetes/klog/compare/v2.4.0...v2.8.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-23 00:34:51 +00:00
dependabot[bot] 892ad3d55d
Bump k8s.io/client-go from 0.18.8 to 0.20.5
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.18.8 to 0.20.5.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.18.8...v0.20.5)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-22 07:43:27 +00:00
Anders F Björklund 1c5d35e3f3 Pull image after load with go-containerregistry 2021-03-21 18:01:17 +01:00
Anders F Björklund 2cfc608bbf Add progressbar when downloading kic base image 2021-03-21 14:20:29 +01:00
Medya Gh f17f8a458f go mod tidy 2021-03-15 17:06:20 -07:00
dependabot[bot] 8615fc142d
Bump github.com/cheggaaa/pb/v3 from 3.0.1 to 3.0.6
Bumps [github.com/cheggaaa/pb/v3](https://github.com/cheggaaa/pb) from 3.0.1 to 3.0.6.
- [Release notes](https://github.com/cheggaaa/pb/releases)
- [Commits](https://github.com/cheggaaa/pb/compare/v3.0.1...v3.0.6)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-15 20:18:13 +00:00
dependabot[bot] a2d3a8a412
Bump golang.org/x/mod from 0.4.1 to 0.4.2
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.4.1 to 0.4.2.
- [Release notes](https://github.com/golang/mod/releases)
- [Commits](https://github.com/golang/mod/compare/v0.4.1...v0.4.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-15 07:52:15 +00:00
Yanshu Zhao 91f9bd6ef9 Add webhook to inject env to redirect inner cluster requests to haproxy
in auto-pause
2021-03-15 05:56:44 +00:00
Anders F Björklund 5cf8dce944 Add a red box around docker desktop registry port
To make it harder to miss the notice, with the rest of the emojis

Also remove some stray "on" text, but do add "driver" and "port"
2021-03-14 16:18:53 +01:00
Medya Gh ee74d42eba merge conflict 2021-03-11 01:14:06 -08:00
dependabot[bot] 024d496a16
Bump github.com/google/go-cmp from 0.5.4 to 0.5.5
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.4 to 0.5.5.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.5.4...v0.5.5)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-10 08:07:48 +00:00
Medya Gh 938f552d30 fix go mod 2021-03-09 19:47:28 -08:00
Medya Gh 77693d6661 fix go mod 2021-03-09 19:47:28 -08:00
Anders F Björklund 72f37b8780 Update go-container registry to 0.4.1 + patch 2021-03-09 19:47:28 -08:00
dependabot[bot] 7d8a60a3de
Bump github.com/libvirt/libvirt-go
Bumps [github.com/libvirt/libvirt-go](https://github.com/libvirt/libvirt-go) from 3.4.0+incompatible to 3.9.0+incompatible.
- [Release notes](https://github.com/libvirt/libvirt-go/releases)
- [Commits](https://github.com/libvirt/libvirt-go/compare/v3.4.0...v3.9.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-10 01:56:44 +00:00
dependabot[bot] 0ad437b3a8
Bump github.com/google/uuid from 1.1.2 to 1.2.0
Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.1.2 to 1.2.0.
- [Release notes](https://github.com/google/uuid/releases)
- [Commits](https://github.com/google/uuid/compare/v1.1.2...v1.2.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-10 01:14:57 +00:00
dependabot[bot] 5f1e4928fe
Bump github.com/hashicorp/go-getter from 1.5.1 to 1.5.2
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.5.1 to 1.5.2.
- [Release notes](https://github.com/hashicorp/go-getter/releases)
- [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml)
- [Commits](https://github.com/hashicorp/go-getter/compare/v1.5.1...v1.5.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-10 00:33:24 +00:00
dependabot[bot] f2e805bb0f
Bump github.com/hashicorp/go-retryablehttp from 0.6.6 to 0.6.8
Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.6.6 to 0.6.8.
- [Release notes](https://github.com/hashicorp/go-retryablehttp/releases)
- [Commits](https://github.com/hashicorp/go-retryablehttp/compare/v0.6.6...v0.6.8)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-08 07:35:57 +00:00
Medya Gh 776f09b243 mod tidy 2021-03-05 22:27:47 -08:00
Daehyeok Mun fae67405e9 Update outdated moby/hyperkit package in minikube code 2021-03-05 22:27:23 -08:00
Steven Powell 4ec33e1bc8 go mod tidy 2021-03-04 13:00:55 -07:00
Steven Powell 5fbebbe64d ran go mod tidy 2021-03-03 17:13:02 -07:00
Steven Powell fd4c792938
Revert "Bump go.opentelemetry.io/otel/sdk from 0.16.0 to 0.18.0" 2021-03-03 17:09:29 -07:00
dependabot[bot] d93b479310
Bump go.opentelemetry.io/otel/sdk from 0.16.0 to 0.18.0
Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 0.16.0 to 0.18.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-go/compare/v0.16.0...v0.18.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-03 22:21:19 +00:00
Ilya Zuyev 494501cdf4 go mod tidy 2021-03-02 15:13:33 -08:00
dependabot[bot] 5de23fcf55
Bump github.com/pborman/uuid from 1.2.0 to 1.2.1
Bumps [github.com/pborman/uuid](https://github.com/pborman/uuid) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/pborman/uuid/releases)
- [Commits](https://github.com/pborman/uuid/compare/v1.2...v1.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-02 18:15:57 +00:00
dependabot[bot] 39204d8d72
Bump github.com/spf13/cobra from 1.0.0 to 1.1.3
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.0.0 to 1.1.3.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spf13/cobra/compare/v1.0.0...v1.1.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-01 07:42:50 +00:00
Steven Powell a0b0564260 Fixed audit.json error when `delete --purge` ran 2021-02-23 17:31:39 -07:00
Sharif Elgamal a5a5b1a284 go mod tidy 2021-02-23 14:28:30 -08:00
Sharif Elgamal 7f75dfffda drop support for github packages for kicbase 2021-02-23 14:16:02 -08:00
dependabot[bot] e384189123
Bump cloud.google.com/go/storage from 1.10.0 to 1.13.0
Bumps [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) from 1.10.0 to 1.13.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/master/CHANGES.md)
- [Commits](https://github.com/googleapis/google-cloud-go/compare/pubsub/v1.10.0...spanner/v1.13.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-22 20:44:44 +00:00
Predrag Rogic 1de86bd2c7
fix go.sum that got out-of-sync with go.mod after packages' version bump 2021-02-22 16:51:30 +00:00
Medya Ghazizadeh b09523131d
Merge pull request #10560 from kubernetes/dependabot/go_modules/github.com/cloudevents/sdk-go/v2-2.3.1
Bump github.com/cloudevents/sdk-go/v2 from 2.1.0 to 2.3.1
2021-02-22 01:06:40 -08:00
dependabot[bot] fde4a4c50a
Bump google.golang.org/api from 0.29.0 to 0.40.0
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.29.0 to 0.40.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md)
- [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.29.0...v0.40.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-22 07:36:52 +00:00
dependabot[bot] ec0d14f839
Bump github.com/cloudevents/sdk-go/v2 from 2.1.0 to 2.3.1
Bumps [github.com/cloudevents/sdk-go/v2](https://github.com/cloudevents/sdk-go) from 2.1.0 to 2.3.1.
- [Release notes](https://github.com/cloudevents/sdk-go/releases)
- [Commits](https://github.com/cloudevents/sdk-go/compare/v2.1.0...v2.3.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-22 07:34:51 +00:00
Medya Gh a66d2a3124 bupm oldest kubernetes version to v1.14.0 2021-02-20 10:07:26 -08:00
Kent Iso 3e6aaa1194 Fix Build ERROR of go mod. Update opentelemetry-operations-go version and non-existing packages 2021-02-21 01:26:29 +09:00
dependabot[bot] 1c15e58fee
Bump go.opentelemetry.io/otel from 0.13.0 to 0.17.0
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 0.13.0 to 0.17.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-go/compare/v0.13.0...v0.17.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-20 03:53:05 +00:00
Medya Ghazizadeh ae0c0aa517
Merge pull request #10522 from kubernetes/dependabot/go_modules/github.com/shirou/gopsutil/v3-3.21.1
Bump github.com/shirou/gopsutil/v3 from 3.20.12 to 3.21.1
2021-02-19 19:43:11 -08:00
Medya Ghazizadeh 27942a1a22
Merge pull request #10521 from kubernetes/dependabot/go_modules/github.com/olekukonko/tablewriter-0.0.5
Bump github.com/olekukonko/tablewriter from 0.0.4 to 0.0.5
2021-02-19 19:40:49 -08:00
dependabot[bot] bd189edc21
Bump go.opencensus.io from 0.22.4 to 0.22.6
Bumps [go.opencensus.io](https://github.com/census-instrumentation/opencensus-go) from 0.22.4 to 0.22.6.
- [Release notes](https://github.com/census-instrumentation/opencensus-go/releases)
- [Commits](https://github.com/census-instrumentation/opencensus-go/compare/v0.22.4...v0.22.6)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-20 00:34:26 +00:00
dependabot[bot] 720e6ce117
Bump github.com/shirou/gopsutil/v3 from 3.20.12 to 3.21.1
Bumps [github.com/shirou/gopsutil/v3](https://github.com/shirou/gopsutil) from 3.20.12 to 3.21.1.
- [Release notes](https://github.com/shirou/gopsutil/releases)
- [Commits](https://github.com/shirou/gopsutil/compare/v3.20.12...v3.21.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-20 00:33:39 +00:00
dependabot[bot] e2c973d6b3
Bump github.com/olekukonko/tablewriter from 0.0.4 to 0.0.5
Bumps [github.com/olekukonko/tablewriter](https://github.com/olekukonko/tablewriter) from 0.0.4 to 0.0.5.
- [Release notes](https://github.com/olekukonko/tablewriter/releases)
- [Commits](https://github.com/olekukonko/tablewriter/compare/v0.0.4...v0.0.5)

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-20 00:33:27 +00:00
Anders F Björklund f1c0f61963 Update libmachine module to machine-drivers@master 2021-02-09 08:03:13 +01:00
Medya Ghazizadeh de03a37a1e
Merge pull request #10399 from alonyb/fix-validate-descriptor
Upgrade spinner library to only spin in a terminal
2021-02-08 15:58:13 -08:00
alonyb 750a92db4a update go.sum file 2021-02-08 14:26:29 -05:00
Anders F Björklund 75637f5797 Remove s3 and gcs patches from go-getter module
Makes the binary 5 MB bigger, but avoids forking

Upstream has a different approach, in their v2
2021-02-08 11:59:55 +01:00
Thomas Stromberg c6a27bd9ea Merge to master 2021-01-14 14:22:55 -08:00
Medya Ghazizadeh 31aa5c1bad
Merge pull request #10118 from azhao155/yzhao/fix/flacknessDocker-ENV
avoid race condition in bootstrap certs for parallel runs
2021-01-13 11:46:41 -08:00
Yanshu Zhao baf929b14e Add file lock for protect certs generation 2021-01-13 07:21:31 +00:00
Thomas Stromberg 6ec94aa064 Merge to master 2021-01-08 15:40:24 -08:00
Thomas Stromberg 66a671fc86 Experimental macOS/arm64 work 2021-01-08 15:38:31 -08:00
Priya Wadhwa 15aa8e1d5d Enable --force-systemd for containerd runtime 2021-01-06 14:35:47 -08:00
Kubernetes Prow Robot 5b27fb6887
Merge pull request #10074 from afbjorklund/go_getter-update
Update go-getter from 1.4.2 to 1.5.1
2021-01-06 10:15:54 -08:00
Medya Gh f753287d27 replace build badge on readme 2021-01-05 14:56:53 -08:00
Anders F Björklund 6c7b94314e Update go-getter to 1.5.1
Add build tags for disabling s3 and gcs
    -tags "go_getter_nos3 go_getter_nogcs"

    Since github.com/aws/aws-sdk-go/aws and
    cloud.google.com/go/storage are so big...
2021-01-05 07:51:24 +01:00
Anders F Björklund a78e1e97b7 Update go-containerregistry to 0.3.0 2021-01-01 17:18:00 +01:00
Ruben Baez b330cdb29c
Merge branch 'master' into w/add-spinner 2020-12-08 14:39:44 -05:00
alonyb 6b89930222 add older lines in go sum 2020-12-08 14:37:00 -05:00
alonyb 7a9979b6e7 restore go sum 2020-12-07 14:56:27 -05:00
alonyb b6ee8f2f67 remove old versions of the spinner 2020-12-04 12:01:49 -05:00
alonyb 88947d6e0f add break line in windows case 2020-12-04 06:26:29 -05:00
Medya Ghazizadeh c90956172c
Merge pull request #9822 from medyagh/storage_prov_v4
bump storage provsioner to multi arch
2020-12-02 13:57:37 -08:00
Medya Gh 8916ac46ea update storage provsioner 2020-12-02 13:08:54 -08:00
Priya Wadhwa f3ffb7e966 Merge branch 'master' of https://github.com/kubernetes/minikube into metrics-code 2020-11-30 10:10:45 -08:00
Priya Wadhwa 46f82272e0 Add metrics script to collect data for cloud monitoring 2020-11-23 16:14:06 -08:00
Priya Wadhwa 0f23913f1b Tracing compiles 2020-11-16 20:31:13 -08:00
Priya Wadhwa 129f6d4a22 go mod tidy 2020-11-06 11:59:46 -08:00
Priya Wadhwa f869ca5e91 fix merge conflict 2020-11-05 09:44:47 -08:00
Predrag Rogic 80dbe48a50
update klog version to v2.4.0 2020-11-02 23:47:12 +00:00
Priya Wadhwa a2d00e534d remove my forked dependency now that https://github.com/VividCortex/godaemon/pull/28 merged 2020-10-30 11:19:13 -07:00
Thomas Strömberg b8b432c8fe
Merge pull request #9464 from prezha/update-kubernetes-version-i1
Add hack/update package to automate PR generation
2020-10-28 11:17:32 -07:00
Thomas Strömberg c462ac8061
Merge pull request #9517 from legal90/fix-parallels-library
Update "parallels" driver library and make this driver built into minikube
2020-10-28 07:55:38 -07:00
Sharif Elgamal 777ac141d4 go mod tidy 2020-10-26 13:20:47 -07:00
Sharif Elgamal 055de4edf8 return stopped profile status quickly 2020-10-26 13:20:03 -07:00
Priya Wadhwa 865d3a4a34 Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix 2020-10-23 18:15:07 -07:00
Priya Wadhwa 44f033d531 Replace godaemon library with fork 2020-10-23 15:26:48 -07:00
Mikhail Zholobov 5d6ad5458f
Update "parallels" driver library to the latest
It contains the fix for macOS 11
2020-10-23 19:08:19 +02:00
Medya Ghazizadeh 717b738d6d
Merge pull request #9365 from ilya-zuyev/gh_7422-reuse_hyperkit_driver
hyperkit driver should be happy with current minimum verison
2020-10-21 13:42:05 -05:00
Priya Wadhwa a54ea82e3b Implement schedule stop for unix 2020-10-20 13:45:59 -07:00
Anders F Björklund 02786bb74c Update go-getter to 1.4.2 and add checksum patch
Need a patch for the broken kubernetes sha256 checksums,
version 1.19.3 and matching older don't have newlines...
2020-10-20 17:39:31 +02:00