Commit Graph

2749 Commits (a85e15549035ed604517152325b47eace33c7028)

Author SHA1 Message Date
Sharif Elgamal 7b5381b697 add generate-docs script 2021-06-16 09:23:54 -07:00
Ilya Zuyev 32cd4cb12b Allow running amd64 bianry on M1 2021-06-15 15:30:12 -07:00
Dongjoon Hyun 4eb3c6332d
Fix a download link to use arm64 instead of amd64 2021-06-14 15:11:49 -07:00
JacekDuszenko b7a6dd0b5e implement embed certs global config as EmbedCerts 2021-06-05 23:59:45 +01:00
dmpe 8badb789e8 smaller documentation fix 2021-06-05 20:59:52 +02:00
dmpe 445684d44d fix(start): minikube start with --image-repository: add new test for URLs with ports, fixing fix validation logic 2021-06-05 20:50:00 +02:00
Vishal Jain 03b793c7d0 Fix names. 2021-06-05 11:18:07 -07:00
Vishal Jain ebe03d7687 Added Mock to DeleteProfile Test. 2021-06-02 19:45:41 -07:00
Vishal Jain 36a6f87600 Added Mock of Minikube Delete Profiles Test portion. 2021-06-02 19:45:41 -07:00
Sharif Elgamal d76259e86f
Merge pull request #11528 from andriyDev/FixDownloadOnlyTest2
Change PreloadExists to report no preload for BareMetal drivers
2021-06-02 12:59:15 -07:00
Sharif Elgamal 343015001a
Merge pull request #11504 from ilya-zuyev/ilyaz/fix_delete_paused
Fix delete command for paused kic driver with containerd/crio runtime
2021-06-01 13:14:05 -07:00
Sharif Elgamal 31417806b7
Merge pull request #11486 from sharifelgamal/gcp-auth-restart
gcp-auth addon: do not reapply gcp-auth yamls on minikube restart
2021-05-27 15:05:34 -07:00
Andriy Dzikh a8136ec322 Move InstallOrUpdate to its own package. 2021-05-27 15:01:58 -07:00
Ilya Zuyev eff0bc7161 trigger build to update github status 2021-05-26 22:02:41 -07:00
Ilya Zuyev 1b562da2b0 apply to crio as well 2021-05-26 17:09:13 -07:00
Ilya Zuyev 2244e26fe4 Merge branch 'master' into ilyaz/fix_delete_paused 2021-05-26 16:58:40 -07:00
Ilya Zuyev 2628f8bb04 fix quoting 2021-05-26 15:27:31 -07:00
Ilya Zuyev 2a7f0dca85 simplify the code 2021-05-26 13:41:10 -07:00
Ilya Zuyev 773500bc74 do not unapuse for docker/crio 2021-05-26 12:49:08 -07:00
Medya Ghazizadeh b1ce37b7b5
Merge pull request #11469 from utkarsh-pro/utkarsh-pro/fix/11171
Support setting addons from environmental variables
2021-05-26 10:19:22 -07:00
Sharif Elgamal 6db4a51cbb swap to --refresh 2021-05-26 09:26:10 -07:00
Ilya Zuyev 4567aaa72f trigger bulid 2021-05-25 18:03:35 -07:00
Medya Ghazizadeh 08a7f20dea
Merge pull request #11481 from medyagh/guest_pro_docker
Unique exit code for when container exists prematurely
2021-05-25 12:40:04 -07:00
Ilya Zuyev 017bd42e17 update logs 2021-05-24 22:52:47 -07:00
Ilya Zuyev 4265887fa9 unpause before delete 2021-05-24 18:54:57 -07:00
Medya Ghazizadeh b3541115b2
Merge pull request #11478 from sharifelgamal/error-codes
Add list of error codes to documentation
2021-05-24 15:25:58 -07:00
Medya Gh 6d8c001a00 spell 2021-05-21 13:57:37 -07:00
Medya Gh 9c9934879c break guest provision when container exists prematurely 2021-05-21 13:34:34 -07:00
Medya Ghazizadeh 3f2170bb51
Merge pull request #11472 from andriyDev/ErrorCodes
Use DRV_NOT_HEALTHY when at least one driver is installed but unhealthy
2021-05-21 11:33:23 -07:00
Sharif Elgamal e89aca810a Add list of error codes to documentation 2021-05-21 11:07:59 -07:00
Andriy Dzikh d59570c1f0 Add DRV_DOCKER_NOT_RUNNING error for cases where specifically docker fails. 2021-05-21 09:43:04 -07:00
Medya Ghazizadeh d0d62a90e5
Merge pull request #11334 from daehyeok/close_asset
Add `Close() error` function into assets.CopyableFile
2021-05-21 09:23:41 -07:00
Utkarsh Srivastava aa99526399
change variable name from addonList to addonListFlag
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-21 13:39:05 +05:30
Daehyeok Mun d6691e796c Add `Close() error` function into assets.CopyableFile
Add `Close` function and implemetions to explicitly close os.File which opend by
NewFileAsset.
2021-05-20 21:05:09 -07:00
Medya Ghazizadeh b5499b4c2a
Merge pull request #11394 from ilya-zuyev/ilyaz/gh_11335_test_net_plugins_false_start
Skip network tests with disabled CNI for containerd/crio runtimes
2021-05-20 16:20:04 -07:00
Steven Powell a60a6e215b
Merge pull request #11387 from vigothehacker/issue-11382
Use the first non flag argument for the log file name instead of the first argument
2021-05-20 15:51:33 -07:00
Ilya Zuyev 5600ee6755 Reorganize functional tests 2021-05-20 14:43:51 -07:00
Andriy Dzikh b2d771cd89 Use unhealthy error code if no driver is picked and any driver is installed but unhealthy. 2021-05-20 14:03:53 -07:00
Utkarsh Srivastava 69b30c06df
change variable name from addonListName to addonList
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 22:25:38 +05:30
Utkarsh Srivastava 5a3843b074
replace addonList variable with viper provided data
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 21:39:07 +05:30
Ilya Zuyev d185d765a1 update tests 2021-05-19 15:13:21 -07:00
Medya Ghazizadeh 72e8341536
Merge pull request #11431 from briandealwis/resume
Add "resume" as an alias for "unpause"
2021-05-19 15:04:35 -07:00
Ilya Zuyev 03600d9afc Add integration test 2021-05-19 13:25:42 -07:00
Ilya Zuyev 039b727cb9 check if cni is not disabled for containerd/crio 2021-05-18 22:48:14 -07:00
Medya Ghazizadeh e05cad71c4
Merge pull request #11355 from afbjorklund/driver-order
Sort rejected drivers by their preference order
2021-05-17 20:31:34 -07:00
Medya Ghazizadeh cd73e832dd
Merge pull request #11371 from afbjorklund/driver-alternate
Fix error picking non-default alternate drivers
2021-05-17 18:54:43 -07:00
Medya Gh f6a89cea06 goimport 2021-05-17 18:39:09 -07:00
Brian de Alwis 49fb17d9fc Add "resume" as an alias for "unpause" 2021-05-17 18:34:11 -07:00
Anders F Björklund 6d0763648e Keep original preference, for identical priority
Unhealthy drivers have their priority lowered
2021-05-16 09:31:37 +02:00
Anders F Björklund dedfdfbfcf Sort rejected drivers by their preference order
Don't show drivers not being selected by default
2021-05-15 09:41:12 +02:00
ilya-zuyev 2a2ffeb380
Merge pull request #11304 from daehyeok/copy_node
Implement target node option for cp command
2021-05-14 15:59:11 -07:00
Evan Baker eca8a2d540
fix typo in flag documentation: sytemd -> systemd
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2021-05-14 17:00:03 -05:00
Medya Ghazizadeh 33e26502dd
Merge pull request #11366 from spowelljr/fixImageLoad
`image load`: overwrite same image unless `--overwrite=false`
2021-05-13 21:18:29 -07:00
Daehyeok Mun 7c2e963392 Implement target node option for cp command 2021-05-13 10:47:09 -07:00
VigoTheHacker a086536f38 Merge branch 'kubernetes:master' into issue-11382 2021-05-13 15:15:12 +05:30
Peixuan Ding 7b98243ea3 Add missing apiserver-names config update 2021-05-13 02:02:34 -04:00
Peixuan Ding d156e5cbed Fix TestKubernetesUpgrade
Signed-off-by: Peixuan Ding <pding@freewheel.com>
2021-05-12 21:35:22 -04:00
VigoTheHacker 5246729910 use global variables in logFileName 2021-05-13 06:44:57 +05:30
Steven Powell 9d3ee7e2e1 use overwrite flag for local images 2021-05-12 14:26:34 -07:00
Steven Powell e59ced9029 updated flag description and renamed force arg to overwrite and made it non-optional 2021-05-12 14:26:34 -07:00
Steven Powell 826f1852ab replace over-write with overwrite 2021-05-12 14:26:34 -07:00
Steven Powell 83366b7929 added over-write flag for image load 2021-05-12 14:26:32 -07:00
Steven Powell 32a91d6eb2 image load loads image even if name:tag already exists 2021-05-12 14:24:49 -07:00
VigoTheHacker eca1d9e4f2 change the funnction param value from a global variable to a locally set variable 2021-05-12 23:58:35 +05:30
Anders F Björklund 6ea3ffee1f Show suggestion for rejected unhealthy drivers
Normally how to add root permissions for the user, to be able to
run the "docker" or "podman" driver (through group or through sudo)
2021-05-12 07:15:26 +02:00
VigoTheHacker 5f3b63fb30 read the first non flag argument for the lag file name 2021-05-12 08:50:16 +05:30
Medya Ghazizadeh c214b040e6
Merge pull request #11381 from sharifelgamal/test-doc
Make sure all tests have comments
2021-05-11 18:05:36 -07:00
Sharif Elgamal 8b67bf15e5 fix error message 2021-05-11 15:26:23 -07:00
Sharif Elgamal 971c74f381 fix spelling 2021-05-11 15:23:07 -07:00
Sharif Elgamal 972dae8133 Make sure all tests have comments 2021-05-11 15:17:43 -07:00
Medya Ghazizadeh c136fe3cfd
Merge pull request #11060 from afbjorklund/retro-arch
Allow building minikube for outdated architectures
2021-05-11 12:22:03 -07:00
ilya-zuyev 1f2d50f297
Merge pull request #11247 from hex0punk/goroutine-leak-fix
Goroutine leak fix
2021-05-11 12:02:54 -07:00
Anders F Björklund 97b152f9a8 Fix error picking non-default alternate drivers
We should not select drivers like "ssh" or "none",
unless explicitly requested by the user. Wrong var...
2021-05-11 18:00:39 +02:00
Anders F Björklund fb728a8893 Switch place of minikube image ls and list
Just to make it more similar to the docker image commands.

Both ls/list and rm/remove are equivalent commands, though.
2021-05-09 09:37:02 +02:00
Medya Ghazizadeh 8f167f4213
Merge pull request #10899 from daehyeok/overwrite_flag
Refactoring generate/update config file code.
2021-05-07 16:30:15 -07:00
Medya Ghazizadeh a2d62511d2
Merge pull request #11191 from zhijianli88/shell-completion
completion: add specific shell completion
2021-05-07 16:16:54 -07:00
Daehyeok Mun 50637dd149 clean up `updateExistingConfigFromFlags` function.
Add missing flags to overwrite.
Reuse validate/set function from `generateNewClusterConfig`
2021-05-06 14:07:43 -07:00
Daehyeok Mun afc9ed5222 Clean up `generateNewConfigFromFlags` function
split validate/set code with helper function to reuse later.
2021-05-06 14:07:43 -07:00
Medya Ghazizadeh 65692f3181
Merge pull request #11294 from andriyDev/UsernameMixin
Add the current user's name to log file hashes to prevent collision.
2021-05-06 10:22:46 -07:00
Andriy Dzikh 5776597eb3 Move deferred close to before error exit. 2021-05-05 16:18:15 -07:00
Andriy Dzikh 98f4d4706b Add --file flag to 'minikube logs' to automatically put logs into a file. 2021-05-05 16:18:15 -07:00
Andriy Dzikh 65c0f0ff35 Add the current user's name to log file hashes to prevent collision. 2021-05-05 12:38:47 -07:00
Sharif Elgamal e27e9a1e1b return pointer to k8sissue 2021-05-03 12:25:17 -07:00
Sharif Elgamal 9dbe957234 Merge branch 'master' of github.com:kubernetes/minikube into warn-k8s 2021-05-03 12:22:34 -07:00
hex0punk 2474931ab3 prevents a goroutine from being leaked in call to readByteWithTimeout 2021-04-29 22:48:05 -07:00
hex0punk f0226e50a9 Revert "prevents a goroutine from being leaked in call to readByteWithTimeout"
This reverts commit 8810120de6.
2021-04-29 22:45:39 -07:00
hex0punk 8810120de6 prevents a goroutine from being leaked in call to readByteWithTimeout 2021-04-29 22:42:33 -07:00
Predrag Rogic 394def7a74
identify appropriate cni then configure cruntime accordingly 2021-04-29 23:36:46 +01:00
ilya-zuyev 9947c61a83
Merge pull request #11185 from prezha/workout-cni-and-cruntimes
improve how cni and cruntimes work together
2021-04-29 15:01:18 -07:00
Medya Ghazizadeh ac2b98d744
Merge pull request #11169 from spowelljr/addBetaNotifications
Add opt-in notifications for beta releases
2021-04-29 14:03:59 -07:00
Li Zhijian 5943260780 completion: add specific shell completion
Previously, `minikube completion` is unable to auto-complete the
specific shell as other go-lang applications. For example, when user
type below command:
```
minikube$ minikube completion <tab> <tab>
```
In minikube, there is no candidate shells coming up, which is different
from kubectl:
```
$ kubectl completion <tab> <tab>
bash  zsh
```

After this patch, as following, the candidata shell appears:
```
minikube$ minikube completion <tab> <tab>
bash  fish  zsh
```

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2021-04-29 18:30:27 +08:00
Sharif Elgamal 8657b72645 address comments 2021-04-28 17:29:28 -07:00
Sharif Elgamal fb5f275baa abstract kubernetes issues away 2021-04-28 16:01:59 -07:00
Steven Powell c9ccfece9b removed get prefix from funcs 2021-04-28 15:34:48 -07:00
Sharif Elgamal 7afe98b855 add 1.21.0 2021-04-28 08:59:15 -07:00
Sharif Elgamal 661e62aacd warn about performance for certain versions of kubernetes 2021-04-27 13:54:06 -07:00
csiepka ae450f6c7b
Correct typo in start_flags.go
Steps to reproduce the issue:
minikube start --memory=2G

Current Output (truncated):
smile minikube v1.14.1 on Linuxmint 19.3
sparkles Using the docker driver based on existing profile
exclamation You cannot change the memory size for an exiting minikube cluster. Please first delete the cluster.

Correction:
"exiting" to "existing" in output:

Expected output:
exclamation You cannot change the memory size for an existing minikube cluster. Please first delete the cluster.
2021-04-26 11:59:17 -07:00
Medya Ghazizadeh cbe11ca8ff
Merge pull request #11003 from tklauser/x-term
Use golang.org/x/term
2021-04-25 22:56:14 -07:00
Medya Ghazizadeh d6e011bf77
Merge pull request #10918 from afbjorklund/kicbase-cache
Add code for downloading kicbase image to cache
2021-04-25 22:25:06 -07:00
Predrag Rogic e3b45667a6
improve how cni and cruntimes work together 2021-04-25 17:40:34 +01:00