Commit Graph

10460 Commits (a4e9e362d40d843d86d574cfaa0e204fecfaa903)

Author SHA1 Message Date
Thomas Stromberg f7f7ca7fcd Switch back to CleanupWithLogs, make more things fatal so that logs come sooner 2020-05-08 19:03:03 -07:00
Thomas Stromberg 625b316f98 Revert comment removal 2020-05-08 17:19:32 -07:00
Thomas Stromberg 28d0a465e6 Merge to master 2020-05-08 17:17:02 -07:00
Medya Ghazizadeh 271ca3a7f0
Merge pull request #8035 from priyawadhwa/embed-certs
Wait to add aliases to /etc/hosts before starting kubelet
2020-05-08 23:52:02 +00:00
Medya Ghazizadeh d995b1dedf
Merge pull request #8049 from afbjorklund/cpus
Document that minikube with kubeadm needs 2 CPUs
2020-05-08 22:08:23 +00:00
Priya Wadhwa 2915aaf597 Remove test 2020-05-08 14:12:47 -07:00
Priya Wadhwa bfef99b63d Copy files directly now that we control kubeadm 2020-05-08 14:12:13 -07:00
Priya Wadhwa 753dc44706 Remove unnecessary function 2020-05-08 13:57:11 -07:00
Priya Wadhwa 6d1d07c857 Remove unnecessary restart 2020-05-08 13:55:30 -07:00
Sharif Elgamal 6bb8371459 Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-08 13:53:20 -07:00
Sharif Elgamal ad9b4c1a38 save config 2020-05-08 13:53:16 -07:00
Thomas Strömberg 4f194d21ba
Merge pull request #8041 from tstromberg/service-cmd-race
TestFunctional/parallel/ServiceCmd: Add logging
2020-05-08 13:32:04 -07:00
Thomas Stromberg 2868c7981b Run 'minikube logs' when sub-tests fail, remove some extraneous logging 2020-05-08 13:12:30 -07:00
Priya Wadhwa cb4dc30bab Add unit test 2020-05-08 12:49:54 -07:00
Priya Wadhwa ba267702af Merge branch 'master' of https://github.com/kubernetes/minikube into embed-certs 2020-05-08 12:38:02 -07:00
Priya Wadhwa f574852125 make it impossible to enable the kubelet service 2020-05-08 12:37:28 -07:00
Priya Wadhwa 0fa24990c9 Remove Enable(kubelet) from unpause
This way, we won't ever enable kubelet to start when systemd starts, preventing a race condition with `/etc/hosts`
2020-05-08 12:33:45 -07:00
Priya Wadhwa 826fb2bbf3 Restart kubelet after updating config files
This makes sure the kubelet picks up the correct IP
2020-05-08 12:32:27 -07:00
Priya Wadhwa 73d15fc275 Start kubelet after host aliases have been set in /etc/hosts
kubelet manages the value of `/etc/hosts` within running containers (e.g. kube-controller-manager). It takes this file from the host, but this causes a race condition between:

1. Us updating /etc/hosts with aliases on IP changes
1. kubelet starting k8s with current value of /etc/hosts

This change removes automatically starting kubelet when systemd comes up. Instead, we start it immediately after making our updates to `/etc/hosts`
2020-05-08 12:30:06 -07:00
Anders F Björklund 39e135cf03 Document that minikube with kubeadm needs 2 CPUs 2020-05-08 17:34:08 +02:00
Medya Ghazizadeh 7102dcbec7
Merge pull request #8039 from tstromberg/update-golint
Update golangci-lint to v1.26.0 (low priority)
2020-05-08 00:07:57 +00:00
Medya Ghazizadeh bf541b42c2
Merge pull request #8038 from tstromberg/kic-delete-prompt
Use the appropriate OCI for deletePossibleKicLeftOver when known
2020-05-08 00:02:44 +00:00
Medya Ghazizadeh 34e833511b
Merge pull request #8027 from tstromberg/quiet-ssh2
virtualbox: Quiet initial ssh timeout warning
2020-05-08 00:00:39 +00:00
Priya Wadhwa 9348667351 Add host alias back after restarting kubelet 2020-05-07 17:00:37 -07:00
Thomas Stromberg 03059f135b Make ServiceCmd easier to debug 2020-05-07 16:44:42 -07:00
Sharif Elgamal 5e981137a4 Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-07 16:13:25 -07:00
Medya Ghazizadeh 294a5c3e7b
Merge pull request #8036 from tstromberg/help-me
Make `minikube help` output consistent
2020-05-07 23:12:00 +00:00
Thomas Stromberg e06e180a52 Cite issue #8040 for TODO's 2020-05-07 16:00:08 -07:00
Thomas Stromberg 84c8e633ed Update golangci-lint to v1.26.0 2020-05-07 15:35:33 -07:00
Thomas Stromberg 64e47992e4 Only delete leftovers for the appropriate OCI if known 2020-05-07 15:19:09 -07:00
Priya Wadhwa fce75622cf Add start/stop test for plain old docker 2020-05-07 14:19:31 -07:00
Thomas Stromberg cad2960ed5 Run generate-docs 2020-05-07 14:18:00 -07:00
Thomas Stromberg eefcc04b36 Shorten long text 2020-05-07 14:14:10 -07:00
Thomas Stromberg 436cee2d84 Fix minikube/kubernetes capitalization, make short help consistent 2020-05-07 14:12:10 -07:00
Priya Wadhwa 80960945af move into separate function 2020-05-07 13:45:34 -07:00
Priya Wadhwa ced1914fed remove unnecessary code 2020-05-07 13:43:03 -07:00
Priya Wadhwa 69a39c100c Add kic 2020-05-07 13:41:37 -07:00
Priya Wadhwa 8ac42815aa Restart kubelet if soft start 2020-05-07 13:40:26 -07:00
Priya Wadhwa 163ab88408 Restart kubelet in a function that is called on soft start 2020-05-07 13:22:09 -07:00
Priya Wadhwa a353d564dd Add comments 2020-05-07 13:03:07 -07:00
Priya Wadhwa c037a97392 Restart kubeadm on soft `minikube start`
This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different.

This should fix the embed-certs integration test which has been flaky for a while.
2020-05-07 12:59:55 -07:00
Thomas Stromberg 68cd6f96db Merge branch 'master' into quiet-ssh2 2020-05-07 11:30:31 -07:00
Sharif Elgamal 358f167ae8 keepContext 2020-05-07 11:21:58 -07:00
Medya Ghazizadeh 269b938945
Merge pull request #8022 from tstromberg/better-restart
restart: validate configs with new hostname, add logging
2020-05-07 18:12:52 +00:00
Thomas Strömberg 1c60122567
Merge pull request #7860 from medyagh/hyperkit_version_warn
site: add instructions to  upgrade hyperkit
2020-05-07 10:11:27 -07:00
Thomas Strömberg 9d322942f8
Merge pull request #7997 from aledbf/ingress
Update ingress-nginx addon
2020-05-07 10:08:48 -07:00
Kubernetes Prow Robot 3a025104bd
Merge pull request #8030 from anencore94/bugfix
Fix a typo in roadmap document
2020-05-07 00:03:08 -07:00
anencore94 6efa4ad37d Fix a typo in roadmap document
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2020-05-07 15:49:52 +09:00
Thomas Stromberg 32e4e64bc4 Quiet initial ssh timeout message 2020-05-06 17:58:21 -07:00
Sharif Elgamal 65c5d5725a Merge branch 'better-restart' of github.com:tstromberg/minikube into restart 2020-05-06 17:14:58 -07:00