Medya Ghazizadeh
d2ae2b35a0
Merge pull request #8057 from afbjorklund/podman-tar
...
Don't run the extraction tar container for podman
2020-05-11 19:22:48 +00:00
Medya Ghazizadeh
6b97ee8ee2
Merge pull request #8001 from afbjorklund/podman-start
...
podman: Wrap the start command with cgroup manager too
2020-05-11 17:59:39 +00:00
Medya Ghazizadeh
d89d40c374
Merge pull request #8060 from afbjorklund/podman-cp
...
The podman cp command is not in podman-remote
2020-05-11 17:55:38 +00:00
Medya Ghazizadeh
9c6054883d
Merge pull request #8062 from afbjorklund/podman-point
...
Add a PointToHost function for podman as well
2020-05-11 17:55:14 +00:00
Thomas Strömberg
acd2ae1bbe
Merge pull request #8051 from tstromberg/better-postmortem2
...
Run 'minikube logs' when sub-tests fail, remove some extraneous logging
2020-05-11 10:34:33 -07:00
Anders F Björklund
16af75ed24
Add fix warning for active podman-env as well
2020-05-11 12:15:22 +02:00
Medya Ghazizadeh
c21b0096a6
Merge pull request #8064 from afbjorklund/podman-remote-docs
...
Docs: podman-remote is also called podman
2020-05-11 07:41:59 +00:00
Anders F Björklund
fb3824ed52
Docs: podman-remote is also called podman
...
The "podman-remote" program is installed as "podman"
on platforms without a local client (i.e. not Linux)
So we need different documentation for different OS.
Eventually it will be called "podman" everywhere...
2020-05-10 23:42:18 +02:00
Anders F Björklund
c578a7aa1e
Add a PointToHost function for podman as well
...
And add an active variable, similiar to docker
2020-05-10 23:07:12 +02:00
Anders F Björklund
541fb9cf98
The podman cp command is not in podman-remote
...
So use podman exec stdin/stdout as a workaround.
2020-05-10 18:35:41 +02:00
Medya Ghazizadeh
7e3da0f8b0
Merge pull request #8017 from elegos/podman-volumes-extract-tarball-to-volume
...
Podman: disable selinux labels when extracting the tarball (permissions error)
2020-05-09 21:35:43 +00:00
Anders F Björklund
cac41495cf
Don't run the extraction tar container for podman
...
The preloaded images will be extracted anyway, using ssh.
But if creating them on the volume before the container is
booted, means that /var will not be fully copied over to it.
And without /var/lib/dpkg and others, kicbase will not boot.
So skip the parallel extraction for podman, do it afterwards.
Probably shouldn't mount all of /var, but just a sub-set...
2020-05-09 18:36:56 +02:00
Anders F Björklund
46025eccf5
Use the runCmd wrapper for start to not miss error
2020-05-09 14:07:18 +02:00
Anders F Björklund
ac01e92012
Add comment about why podman looks at runtime.GOOS
2020-05-09 14:05:57 +02:00
Anders F Björklund
a7a5148ff6
Don't add cgroup manager param for podman-remote
...
Since it doesn't work for either "run" or "start"
Error: unknown flag: --cgroup-manager
2020-05-09 14:04:04 +02:00
Anders F Björklund
85fae62d4a
Wrap the start command with cgroup manager too
...
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
Anders F Björklund
3fa4b9164d
The podman volume prune does not support filter
2020-05-09 13:58:12 +02:00
Anders F Björklund
1bd56a40cf
Don't use cached credentials for sudo podman
...
We want to verify that "NOPASSWD" has been set up properly
Otherwise the sudo timestamp might time out (after 15 mins)
2020-05-09 13:52:58 +02:00
Anders F Björklund
9673b421df
Skip deleting leftovers if bin not available
...
Avoids spamming the log with extra drivers
2020-05-09 13:49:15 +02:00
Anders F Björklund
c1be17346b
Also delete podman containers and volumes
...
When deleting all minikube profiles, that is
2020-05-09 13:41:06 +02:00
Anders F Björklund
934ad06a82
Use noninteractive sudo when running podman
...
To avoid asking for a password in the middle of minikube commands.
The setup process is supposed to involve adding podman to sudoers...
2020-05-09 13:23:46 +02:00
Medya Gh
45acf71459
lint
2020-05-08 19:57:45 -07:00
Medya Gh
24971a5ff5
docker/podman fail on non-amd64 systems
2020-05-08 19:56:38 -07:00
Thomas Stromberg
f7f7ca7fcd
Switch back to CleanupWithLogs, make more things fatal so that logs come sooner
2020-05-08 19:03:03 -07:00
Thomas Stromberg
625b316f98
Revert comment removal
2020-05-08 17:19:32 -07:00
Thomas Stromberg
28d0a465e6
Merge to master
2020-05-08 17:17:02 -07:00
Medya Ghazizadeh
271ca3a7f0
Merge pull request #8035 from priyawadhwa/embed-certs
...
Wait to add aliases to /etc/hosts before starting kubelet
2020-05-08 23:52:02 +00:00
Medya Ghazizadeh
d995b1dedf
Merge pull request #8049 from afbjorklund/cpus
...
Document that minikube with kubeadm needs 2 CPUs
2020-05-08 22:08:23 +00:00
Priya Wadhwa
2915aaf597
Remove test
2020-05-08 14:12:47 -07:00
Priya Wadhwa
bfef99b63d
Copy files directly now that we control kubeadm
2020-05-08 14:12:13 -07:00
Priya Wadhwa
753dc44706
Remove unnecessary function
2020-05-08 13:57:11 -07:00
Priya Wadhwa
6d1d07c857
Remove unnecessary restart
2020-05-08 13:55:30 -07:00
Thomas Strömberg
4f194d21ba
Merge pull request #8041 from tstromberg/service-cmd-race
...
TestFunctional/parallel/ServiceCmd: Add logging
2020-05-08 13:32:04 -07:00
Thomas Stromberg
2868c7981b
Run 'minikube logs' when sub-tests fail, remove some extraneous logging
2020-05-08 13:12:30 -07:00
Priya Wadhwa
cb4dc30bab
Add unit test
2020-05-08 12:49:54 -07:00
Priya Wadhwa
ba267702af
Merge branch 'master' of https://github.com/kubernetes/minikube into embed-certs
2020-05-08 12:38:02 -07:00
Priya Wadhwa
f574852125
make it impossible to enable the kubelet service
2020-05-08 12:37:28 -07:00
Priya Wadhwa
0fa24990c9
Remove Enable(kubelet) from unpause
...
This way, we won't ever enable kubelet to start when systemd starts, preventing a race condition with `/etc/hosts`
2020-05-08 12:33:45 -07:00
Priya Wadhwa
826fb2bbf3
Restart kubelet after updating config files
...
This makes sure the kubelet picks up the correct IP
2020-05-08 12:32:27 -07:00
Priya Wadhwa
73d15fc275
Start kubelet after host aliases have been set in /etc/hosts
...
kubelet manages the value of `/etc/hosts` within running containers (e.g. kube-controller-manager). It takes this file from the host, but this causes a race condition between:
1. Us updating /etc/hosts with aliases on IP changes
1. kubelet starting k8s with current value of /etc/hosts
This change removes automatically starting kubelet when systemd comes up. Instead, we start it immediately after making our updates to `/etc/hosts`
2020-05-08 12:30:06 -07:00
Anders F Björklund
39e135cf03
Document that minikube with kubeadm needs 2 CPUs
2020-05-08 17:34:08 +02:00
Medya Ghazizadeh
7102dcbec7
Merge pull request #8039 from tstromberg/update-golint
...
Update golangci-lint to v1.26.0 (low priority)
2020-05-08 00:07:57 +00:00
Medya Ghazizadeh
bf541b42c2
Merge pull request #8038 from tstromberg/kic-delete-prompt
...
Use the appropriate OCI for deletePossibleKicLeftOver when known
2020-05-08 00:02:44 +00:00
Medya Ghazizadeh
34e833511b
Merge pull request #8027 from tstromberg/quiet-ssh2
...
virtualbox: Quiet initial ssh timeout warning
2020-05-08 00:00:39 +00:00
Priya Wadhwa
9348667351
Add host alias back after restarting kubelet
2020-05-07 17:00:37 -07:00
Thomas Stromberg
03059f135b
Make ServiceCmd easier to debug
2020-05-07 16:44:42 -07:00
Medya Ghazizadeh
294a5c3e7b
Merge pull request #8036 from tstromberg/help-me
...
Make `minikube help` output consistent
2020-05-07 23:12:00 +00:00
Thomas Stromberg
e06e180a52
Cite issue #8040 for TODO's
2020-05-07 16:00:08 -07:00
Thomas Stromberg
84c8e633ed
Update golangci-lint to v1.26.0
2020-05-07 15:35:33 -07:00
Thomas Stromberg
64e47992e4
Only delete leftovers for the appropriate OCI if known
2020-05-07 15:19:09 -07:00