Commit Graph

1865 Commits (a4d9a5bc051347924c8694a17b3e523dfabe7693)

Author SHA1 Message Date
Medya Gh 27bd2a9e0b fix message 2020-04-17 00:28:40 -07:00
Medya Gh 2a38fa3cfc enable tunnel and service for docker on windows 2020-04-16 23:44:07 -07:00
Medya Gh 1b85d484a9 remove unrelate change 2020-04-16 15:15:42 -07:00
Medya Gh bb327e250d adjust try 2020-04-16 15:14:59 -07:00
priyawadhwa abaa998913
Merge pull request #7558 from priyawadhwa/monitor-1
Add support for specifying pr when running mkcmp
2020-04-16 12:28:21 -07:00
Priya Wadhwa 3c46aa1aee fix lint 2020-04-16 12:08:28 -07:00
Prasad Katti 06fadf8213 Skip preload download if --image-repository is set 2020-04-15 22:24:24 -07:00
Sharif Elgamal 1554d8e969
Merge pull request #7586 from govargo/feature/add-status-node-section
Add master node/worker node type to `minikube status`
2020-04-14 19:44:46 -07:00
Medya Gh d4b48e1e05 clean up after test dirs 2020-04-14 19:33:26 -07:00
Medya Gh 649819b963 clean up temp dir in unit test 2020-04-14 19:11:08 -07:00
Pablo Caderno fba5f9a2d3 Added validation for profile name
It must be container friendly
2020-04-14 14:52:04 +10:00
Kenta Iso 29f1144de3 Add node type to each node in `minikube status` 2020-04-14 11:53:29 +09:00
Kenta Iso 47333325e8 add master node/worker node section to `minikube status` 2020-04-14 11:53:29 +09:00
Thomas Stromberg 4c5f545bc6 uninstallKubernetes: Pass back DeletionErrors rather than fatal exits 2020-04-10 12:43:45 -07:00
Thomas Stromberg d69d92c46a kic: Use SSHRunner by default 2020-04-10 09:16:34 -07:00
Medya Ghazizadeh a604a8270c
Merge pull request #7553 from govargo/fix-delete-nodename
Fix `minikube delete` output nodename missing with KIC driver
2020-04-09 17:02:57 -07:00
Priya Wadhwa 0cd476982d Add support for specifing pr when running mkcmp
This PR adds support for running:

./out/mkcmp pr://1000

which downloads the minikube binary generated by Jenkins for PR 1000 before running mkcmp.
2020-04-09 12:19:22 -07:00
Sharif Elgamal e4b4a5ac8d Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback 2020-04-09 10:53:47 -07:00
Thomas Strömberg 10f2f0ac1f
Merge pull request #7525 from tstromberg/parr-boot
start: Parallelize mount, cache push, and addon enablement
2020-04-09 10:51:33 -07:00
Sharif Elgamal 198247d9f1 make alternate driver text more clear 2020-04-09 10:32:25 -07:00
Thomas Strömberg aee3c1d4b8
Merge branch 'master' into driver-fallback 2020-04-09 08:24:06 -07:00
Kenta Iso 903fe744b1 Add output deleteingHost using KIC driver 2020-04-10 00:15:20 +09:00
Thomas Strömberg bef505a117
Merge pull request #7500 from nestoralonso/patch-1
Update error message for the user UI in start.go
2020-04-09 05:10:19 -07:00
Thomas Stromberg 1e8801ceb8 Make addons.Start thread-safe 2020-04-08 21:23:35 -07:00
Thomas Stromberg 16a8c38682 none: Add support for OpenRC init (Google CloudShell) 2020-04-08 18:20:30 -07:00
Sharif Elgamal c40a942a1f Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback 2020-04-08 18:08:32 -07:00
Medya Ghazizadeh 689eca4a75
Merge pull request #7509 from medyagh/extra_opt_overwrite
Respect driver.FlagDefaults even if --extra-config is set
2020-04-08 16:48:36 -07:00
Medya Ghazizadeh 35248a1f31
Merge pull request #7451 from loftkun/exit-when-driver-validation-failed
fix validateDriver() to exit() when it detects an error.
2020-04-08 15:30:02 -07:00
Medya Ghazizadeh aec3afec2d
Merge pull request #7513 from tomocy/fix-typo
Fix typo
2020-04-08 13:57:54 -07:00
Thomas Strömberg 4f704271d7
Merge pull request #7385 from priyawadhwa/generate-docs
Automatically generate commands docs and add unit test
2020-04-08 11:28:03 -07:00
tomocy ec10017443 Fix typo 2020-04-08 22:43:47 +09:00
Medya Gh 9116393aa3 fix wait retry logic 2020-04-08 00:36:52 -07:00
nestoralonso df5da4d453
Update start.go
It's necessary to add the start argument in this scenario because the suggested command doesn't work as printed:
'sudo minikube --driver=none'->'sudo minikube start --driver=none'
2020-04-07 22:01:38 -05:00
Sharif Elgamal 45bf65ca19 Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback 2020-04-07 18:26:59 -07:00
Medya Ghazizadeh e098a3c4ca
Merge pull request #7449 from medyagh/fix_soft_start_nondocker
Behavior change: start with no arguments uses existing cluster config
2020-04-07 17:12:52 -07:00
Sharif Elgamal 5df9ead41c never exit during provisioning 2020-04-07 16:29:40 -07:00
Priya Wadhwa 09dd0acb9b Update docs contents 2020-04-07 15:15:08 -07:00
Priya Wadhwa 8ee163c846 Rebased on master 2020-04-07 15:13:06 -07:00
Thomas Strömberg 668144124e
Merge pull request #7482 from tstromberg/dry-run
Disable update check for (--interactive|--dry-run), make non-blocking
2020-04-07 13:58:35 -07:00
Medya Gh 65e1ff3be4 remove duplicate checking existing driver flag 2020-04-07 13:55:21 -07:00
Thomas Stromberg b6d66f16b4 Disable update check for (--interactive|--dry-run), make non-blocking 2020-04-07 09:38:33 -07:00
Kenta Iso 30f68e09ef fix node name of `minikube status` to match worker node name 2020-04-07 22:55:11 +09:00
Medya Gh dfd9f7a9d1 handle Port 0 in configs 2020-04-07 03:06:44 -07:00
Medya Gh e683dd315b warn if changed memory cpu of an exiting cluster 2020-04-07 01:53:50 -07:00
Medya Gh 26c999a811 fix select default cni 2020-04-07 01:29:50 -07:00
Medya Gh c4f5f4dded fix 2020-04-06 22:53:44 -07:00
Medya Gh 84693eaf0a add wait flag to updateExistingConfigFromFlags 2020-04-06 18:58:42 -07:00
Medya Gh ee1f8fffb3 remove duplicate setDockerProxy 2020-04-06 18:58:42 -07:00
Medya Gh 2c037b42f2 fix unit test 2020-04-06 18:58:42 -07:00
Medya Gh 1d892a2e0b fix it 2020-04-06 18:58:42 -07:00
Medya Gh b777d97d76 refactor more 2020-04-06 18:58:42 -07:00
Medya Gh bee681559b save profile 2020-04-06 18:58:42 -07:00
Medya Gh a35006507b add new func updateExistingConfigFromFlags 2020-04-06 18:58:42 -07:00
Medya Gh 792ca63179 respect the user existing config 2020-04-06 18:58:42 -07:00
Sharif Elgamal eb42d16087 actually error out when driver is specified 2020-04-06 13:51:30 -07:00
Sharif Elgamal 78595b13dc split out node provisioning and starting kubernetes 2020-04-06 11:45:42 -07:00
Priya Wadhwa 7d1d965faa Merge branch 'master' of https://github.com/kubernetes/minikube into generate-docs 2020-04-06 10:26:19 -07:00
Sharif Elgamal f290aa9c3c Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback 2020-04-06 10:25:20 -07:00
loftkun fb2c3ed4b7 fix validateDriver() to exit when detects an error 2020-04-06 23:45:54 +09:00
Medya Gh 77d1da04a2 change log level for err 2020-04-03 18:48:39 -07:00
Medya Gh 4221e63e13 add logs for wait components 2020-04-03 18:43:37 -07:00
Sharif Elgamal 3d037a8871 only failback to next driver if provisioning fails 2020-04-03 17:46:42 -07:00
Medya Gh 74551841cc address review comments 2020-04-02 23:41:45 -07:00
Medya Gh 62ca22a662 refactor and rebase 2020-04-02 18:58:51 -07:00
Medya Gh 9fc36a6d4e typo 2020-04-02 17:55:15 -07:00
Medya Gh d6b3cc6109 lint 2020-04-02 17:55:15 -07:00
Medya Gh 4c8f79d823 add wait logic to kubeadm 2020-04-02 17:55:15 -07:00
Medya Gh 3b39b271ac fix interpret wait 2020-04-02 17:54:14 -07:00
Medya Gh e4eae47e86 interpret wait flags 2020-04-02 17:54:14 -07:00
Sharif Elgamal 31f225d90e fix lint 2020-04-02 15:16:11 -07:00
Sharif Elgamal b66447ea13 remove random failure for testing 2020-04-02 14:48:28 -07:00
Sharif Elgamal dd957ff2f7 make sure to print error on failure 2020-04-02 14:47:18 -07:00
Sharif Elgamal af8d01d83d Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback 2020-04-02 14:40:33 -07:00
Sharif Elgamal 26c747137e failback to alternate drivers if startup fails with automatic choice 2020-04-02 14:36:46 -07:00
Thomas Strömberg 37a98106c4
Merge pull request #7382 from tstromberg/stderr-fix3
Move errors and warnings to output to stderr
2020-04-02 14:36:16 -07:00
Thomas Strömberg 78ecf53d40
Merge pull request #7360 from tstromberg/wrong-url
Correct assumptions for forwarded hostname & IP handling
2020-04-02 14:33:48 -07:00
Thomas Stromberg 5b3834ec63 Merge to master 2020-04-02 12:39:32 -07:00
Priya Wadhwa 7004c398b0 Don't generate documentation for hidden commands 2020-04-02 12:05:27 -07:00
Priya Wadhwa cd81888a22 Merge branch 'master' of https://github.com/kubernetes/minikube into generate-docs 2020-04-02 11:09:56 -07:00
Priya Wadhwa 7988704bed fixups 2020-04-02 11:01:26 -07:00
Priya Wadhwa d578626079 delete unneeded files 2020-04-02 10:50:14 -07:00
Priya Wadhwa 6fdecf2ebf Add unit test to check that docs are up to date
This requires the following changes:

1. We need to pass in -ldflags to `go test`, since we need to know the curren iso version to correctly generate the description for --iso-url

2. We need to rewrite the description of the --driver flag on `minikube start` because it is operating system specific, which doesn't make sense for our documentation
2020-04-02 10:48:47 -07:00
Thomas Stromberg 5307145802 Move errors and warnings to output to stderr 2020-04-02 09:58:13 -07:00
Sharif Elgamal 357b5bb28c Merge branch 'master' of github.com:kubernetes/minikube into driver-fallback 2020-04-02 08:57:34 -07:00
Thomas Stromberg a71edc3920 Merge branch 'master' into wrong-url 2020-04-02 08:32:54 -07:00
Thomas Stromberg e09a1221bb Add rejection reason to 'unable to find driver' error 2020-04-02 06:20:35 -07:00
Sharif Elgamal 0357c89ee5 add issue to todo comment 2020-04-01 17:35:41 -07:00
Sharif Elgamal ac1b3b0c59 merge 2020-04-01 17:32:36 -07:00
Priya Wadhwa c409c4c91c Add unit tests to make sure docs are up to date 2020-04-01 16:13:54 -07:00
Priya Wadhwa a9dcfe82fe Update generate-docs command
Now, generate-docs will compile all subcommands for one command into one document instead of creating a document per subcommand.

For example, instead of creating:

minikbue_addons_enable.md
minikbue_addons_disable.md

it will now create

addons.md

which will include subsections for `minikube addons enable` and `minikube addons disable`.
2020-04-01 15:59:33 -07:00
Sharif Elgamal 4df145518a Merge branch 'master' of github.com:kubernetes/minikube into delete-on-failure 2020-04-01 15:24:38 -07:00
Thomas Strömberg 5306702515
Merge pull request #7363 from tstromberg/stop-harder
Extend maximum stop retry from 30s to 120s
2020-04-01 14:43:14 -07:00
Thomas Strömberg 428e6bd285
Merge pull request #7325 from afbjorklund/version-options
Implement options for the minikube version command
2020-04-01 14:41:00 -07:00
Thomas Strömberg 64bd8dee8b
Merge pull request #7299 from afbjorklund/dashboard-kubectl
Run dashboard with internal kubectl if not in path
2020-04-01 14:40:23 -07:00
Thomas Stromberg b71126356f Extend maximum stop retry from 30s to 120s 2020-04-01 14:24:53 -07:00
Medya Ghazizadeh a24ae23024
Merge pull request #7356 from afbjorklund/kubectl-version
Use kubectl version --short if --output=json fails
2020-04-01 14:17:52 -07:00
Thomas Stromberg 96a87e89cf Remove IP check, because it's wrong on Docker 2020-04-01 13:53:17 -07:00
Thomas Stromberg c76fac7d74 Standardize port-forwarding and kubeconfig hostname logic, fix Docker Linux IP 2020-04-01 11:57:32 -07:00
Sharif Elgamal d8151730f4 retry anytime node.Start fails, not just in minikube start 2020-04-01 11:00:39 -07:00
Thomas Strömberg 592bb2e9eb
Merge pull request #7310 from tstromberg/wrong-url
mustload: Replace DriverIP with Forwarded(IP|Port)
2020-04-01 08:29:12 -07:00
Anders F Björklund 227fec14ae Use kubectl version --short if --output=json fails
Really old kubernetes clients did not have the --output parameter

Show a friendly reminder to upgrade, instead of an error message.
2020-04-01 17:19:14 +02:00
Thomas Strömberg 28ec78a5cb
lint - add newline after stdlib imports 2020-04-01 05:54:23 -07:00
Sharif Elgamal 673922c8d3 code comments 2020-03-31 15:38:59 -07:00
Sharif Elgamal fcb5c462f4 add delete-on-failure flag 2020-03-31 15:06:16 -07:00
Sharif Elgamal fd3e0f505a clean up minikube start output 2020-03-30 15:31:17 -07:00
Anders F Björklund a1cc3188bb Implement options for the minikube version command
Add --short and --output options, just like kubectl
2020-03-30 22:19:39 +02:00
Anders F Björklund 5f9515040d Run dashboard with internal kubectl if not in path
If "kubectl" is not in the PATH, then use the same cached binary
as with the "minikube kubectl" command (version matching cluster).
2020-03-30 18:34:20 +02:00
Thomas Stromberg 7f5f12c5f4 Get rid of DriverIP attr to prevent future misuse 2020-03-29 11:44:25 -07:00
Thomas Stromberg 063077c712 mustload: Check apiserver status using forwarded IP/port 2020-03-29 11:34:21 -07:00
Zhongcheng Lao c57375c486
Remove load balancer start/end IP from start flags 2020-03-29 12:53:25 +08:00
Zhongcheng Lao 30f0882418
Fixes MachineProfile no longer exist 2020-03-29 11:45:53 +08:00
Zhongcheng Lao 9adb1bc399
Merge remote-tracking branch 'origin/master' into metallb 2020-03-29 11:31:56 +08:00
Zhongcheng Lao 377a4746f9
Allows to configure load balancer start/end IP 2020-03-29 11:20:59 +08:00
Thomas Stromberg 1f31d25c16 Use LookPath to verify conntrack install 2020-03-28 13:19:48 -07:00
Medya Ghazizadeh 801d49afd0
Merge pull request #7292 from linkvt/fix-missing-global-options
Show all global flags in options command
2020-03-27 22:13:07 -07:00
Medya Ghazizadeh da1d411e30
Merge pull request #6879 from prasadkatti/populate_target_port_in_svc_list
service list: populate target port
2020-03-27 22:12:18 -07:00
Vincent Link 2420bb1f3a Show all global flags in cli options help
Before this fix the flags shown in `minikube options` were taken from a
list of options (`viperWhiteList`) which seems arbitrary.
I still don't know for sure why this is done but taking all
PersistentFlags (persistent=apply to all sub commands) from the root
command seems like the correct way.
2020-03-27 21:31:38 +01:00
Medya Ghazizadeh 46e87ba054
Merge pull request #7219 from sharifelgamal/cluster-name
Get rid of ClusterNameFromMachine
2020-03-25 18:33:48 -07:00
Medya Ghazizadeh 53b9d720e7
Merge pull request #7230 from tstromberg/hugo-switch
Make recreateIfNeeded more robust, improve UX
2020-03-25 18:28:07 -07:00
Sharif Elgamal dc7bdecda4 Merge branch 'master' of github.com:kubernetes/minikube into cluster-name 2020-03-25 15:43:12 -07:00
Thomas Stromberg f84569aab0 Make crazy cluster_test / mock_driver combination pass tests 2020-03-25 14:46:44 -07:00
Thomas Strömberg 5a316b3bf9
Merge pull request #7068 from vikkyomkar/issue-7067
Add --vm flag for users who want to autoselect only VM's
2020-03-25 12:44:16 -07:00
Medya Ghazizadeh 5689d3b8e1
Merge pull request #7210 from priyawadhwa/issue-7184
Fix TestStartStopWithPreload bug
2020-03-24 22:42:33 -07:00
Medya Ghazizadeh 5ea20f5a06
Merge pull request #7212 from linkvt/kubernetes-parameters-latest-stable
Add 'stable' and 'latest' as valid kubernetes-version values
2020-03-24 22:37:53 -07:00
Priya Wadhwa 646609ec30 review comments 2020-03-24 21:24:43 -07:00
Sharif Elgamal 28672dec78 remove ClusterNameFromMachine 2020-03-24 14:43:11 -07:00
Vincent Link 3ad1dfb4bb Add 'stable' and 'latest' as valid kubernetes-version values 2020-03-24 21:50:28 +01:00
Sharif Elgamal 2933953cfa use mustload 2020-03-24 13:18:59 -07:00
Sharif Elgamal e3bcdbf42a fix validateSpecificDriver error message 2020-03-24 12:55:31 -07:00
Priya Wadhwa 5ef83f35e2 Add --preload flag to optionally turn off preload 2020-03-24 10:53:02 -07:00
Medya Ghazizadeh 587154196e
Merge pull request #7173 from medyagh/stop_kic
stop kubernetes containers on stopping docker/podman driver
2020-03-24 05:42:49 -07:00
Medya Ghazizadeh 20991ac336
Merge pull request #7183 from sharifelgamal/conntrack-msg
add friendly error message for missing conntrack
2020-03-23 23:03:09 -07:00
Medya Gh 5f90a319bd stop k8s in kic and none 2020-03-23 21:01:12 -07:00
Sharif Elgamal 8489c074fe code cleanup 2020-03-23 20:46:51 -07:00
Sharif Elgamal ca3f88a734 comment 2020-03-23 20:19:07 -07:00
Sharif Elgamal 4ab849b604 shorter variable names 2020-03-23 20:18:03 -07:00
Sharif Elgamal 8b58738491 check for conntrack at start time, remove useless solution message 2020-03-24 02:54:47 +00:00
Thomas Stromberg fcb8736cf7 merge to master 2020-03-23 17:30:06 -07:00
Medya Ghazizadeh 93021fbfda
Merge pull request #7174 from afbjorklund/xdg-open
Centralize the handling of browser.OpenURL
2020-03-23 17:12:38 -07:00
Thomas Stromberg 16e18724e2 Dedup ExampleCmd, fix command flag ordering 2020-03-23 16:28:39 -07:00
Thomas Stromberg b99e943684 Improve minikubeCmd, promote to public function 2020-03-23 16:00:53 -07:00
Thomas Strömberg c50cfc99fa
Merge pull request #7158 from kubernetes/driver-confusion
Consistently detect old driver when existing.Driver is unset
2020-03-23 16:00:17 -07:00
Thomas Stromberg 673341ce35 Improve hostDriver comment 2020-03-23 15:51:02 -07:00
Thomas Stromberg 81393a0bc3 Add boilerplate 2020-03-23 14:39:49 -07:00
Thomas Stromberg b9049288fd Improve experience for paused cluster 2020-03-23 14:25:59 -07:00
Anders F Björklund 0ce81acbf4 Centralize the handling of browser.OpenURL
So we can catch when xdg-open not installed
2020-03-23 21:49:19 +01:00
Thomas Stromberg b8c7638976 Add flag functions 2020-03-23 13:17:34 -07:00
Thomas Stromberg 77f97a58f4 Fix uninitalized variable 2020-03-23 13:16:37 -07:00
Thomas Stromberg 8f9a2b9413 Consolidate cluster loading from cmd 2020-03-23 12:51:49 -07:00
Thomas Stromberg 14f8ee3984 hyperv Delete: call StopHost before removing VM 2020-03-23 09:41:00 -07:00