Commit Graph

191 Commits (9b147f788da440f985d88c85634ce0af684581d5)

Author SHA1 Message Date
Medya Gh ca2d0f97ec move advice to its own file 2020-06-17 15:07:17 -07:00
Medya Gh 488e2003f4 fix image digest 2020-05-29 12:19:59 -07:00
Asare Worae 1909c4bb7c add support for `--docker-volume` command line flag to mount host volumes on start 2020-05-15 11:44:24 +02:00
Medya Ghazizadeh d2ae2b35a0
Merge pull request #8057 from afbjorklund/podman-tar
Don't run the extraction tar container for podman
2020-05-11 19:22:48 +00:00
Anders F Björklund cac41495cf Don't run the extraction tar container for podman
The preloaded images will be extracted anyway, using ssh.

But if creating them on the volume before the container is
booted, means that /var will not be fully copied over to it.
And without /var/lib/dpkg and others, kicbase will not boot.
So skip the parallel extraction for podman, do it afterwards.

Probably shouldn't mount all of /var, but just a sub-set...
2020-05-09 18:36:56 +02:00
Anders F Björklund 85fae62d4a Wrap the start command with cgroup manager too
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
Priya Wadhwa 163ab88408 Restart kubelet in a function that is called on soft start 2020-05-07 13:22:09 -07:00
Priya Wadhwa a353d564dd Add comments 2020-05-07 13:03:07 -07:00
Priya Wadhwa c037a97392 Restart kubeadm on soft `minikube start`
This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different.

This should fix the embed-certs integration test which has been flaky for a while.
2020-05-07 12:59:55 -07:00
Anders F Björklund e2d7d94dfc Use the correct binary for unpacking the preload
Previously hardcoded to *always* use a Docker volume,
even if using a different container driver (podman).
2020-05-01 22:11:28 +02:00
Anders F Björklund 78a22f5056 Remove prefix parameter and add prefix command
Move the "sudo" prefix to a central location, instead of
having it all over the place. Assume only needed on Linux.
2020-04-28 13:52:52 +02:00
Anders F Björklund 6644c5cc64 Merge branch 'master' into podman-sudo 2020-04-25 18:05:33 +02:00
Medya Gh 63f9bfbb61
addres review comments 2020-04-24 14:07:54 -07:00
Medya Gh 038aef6b48
unexport warnIfSlow func 2020-04-23 00:33:40 -07:00
Medya Gh 366dc8d127
add helper for img plull command 2020-04-20 13:13:37 -07:00
Medya Gh ac66bf2f90
first working version 2020-04-19 19:59:50 -07:00
Anders F Björklund 22aa1aff22 Handle more state and status for the podman driver 2020-04-19 09:45:16 +02:00
Anders F Björklund d7dc7bf7b2 The podman driver should not be run as root
Use sudo for the podman commands instead

Wrap the docker commands with env prefix
2020-04-19 09:42:17 +02:00
Medya Ghazizadeh 825ba532d1
Merge pull request #7603 from alonyb/w/add-registery-addon
Add registry addon feature for docker on mac/windows
2020-04-17 19:50:43 -07:00
Alonyb bfa45ef79a delete unnecesary func 2020-04-16 19:49:26 -05:00
Medya Gh 891e7a6520 spell 2020-04-16 16:53:04 -07:00
Medya Gh bf15f9a00c fix build err 2020-04-16 16:20:04 -07:00
Medya Gh 934f900f16 improve kic start and kill 2020-04-16 16:10:44 -07:00
Medya Gh 1c125e78da address review comments 2020-04-15 10:17:23 -07:00
Alonyb 62904e5dcc fix lint 2020-04-15 09:30:10 -05:00
Medya Gh 34fafc783f fine tune 2020-04-14 22:20:28 -07:00
Medya Gh 29280ceff6 lint 2020-04-14 21:33:21 -07:00
Medya Gh 7303ccf07d lint 2020-04-14 21:31:12 -07:00
Medya Gh 54aa958f01 use oci to delete 2020-04-14 20:51:18 -07:00
Medya Gh b2bcd9a5cb allow SSH commands to run in kic driver 2020-04-14 20:26:10 -07:00
Ruben Baez d372027b03
Merge pull request #4 from alonyb/patch-1
documentation
2020-04-10 20:11:42 -05:00
Alonyb 201a2bbc62 remove driver and use clusterConfig 2020-04-10 18:50:57 -05:00
Alonyb c4ef1b3798 add return port logic 2020-04-10 14:46:31 -05:00
Alonyb 50c2ec4eaf add oci port mapping of registery 2020-04-10 08:20:12 -05:00
Medya Gh 1eb6ce1710 build error 2020-04-09 21:56:00 -07:00
Medya Gh e7e9f3ca1c address review comments 2020-04-09 21:50:09 -07:00
Medya Gh 983808f956 lint 2020-04-09 21:01:49 -07:00
Medya Gh f7f04a83c2 add killing apiserver proc to both kic and none 2020-04-09 20:53:15 -07:00
Medya Gh ded8273a2e add kill containers to kic stop 2020-04-09 20:01:11 -07:00
Thomas Strömberg 6d05265a2e
Merge pull request #7539 from tstromberg/openrc
none: Add support for OpenRC init (Google CloudShell)
2020-04-09 04:55:57 -07:00
Thomas Stromberg 16a8c38682 none: Add support for OpenRC init (Google CloudShell) 2020-04-08 18:20:30 -07:00
Priya Wadhwa 70329bf51d Code review comments 2020-04-08 13:44:04 -07:00
Priya Wadhwa accba6aa7f code review comments 2020-04-07 15:00:28 -07:00
Priya Wadhwa b509d69182 Extract preloaded tarball as soon as minikube volume is created
Extracting preload currently takes 6 seconds. This PR begins preload extraction as soon as the minikube volume is created, and runs it in parallell with creating the container node and setting up SSH.

This shaves 2-3 secnods off of `node.StartHost`
2020-04-07 14:19:20 -07:00
Thomas Stromberg 46f31480df Make slow command detection consistent across kic/oci 2020-03-26 14:03:22 -07:00
Priya Wadhwa 9d75c7c35a Rebased, resolved merge conflicts 2020-03-25 10:07:58 -07:00
Priya Wadhwa d2171be291 rebased' 2020-03-24 16:39:54 -07:00
Priya Wadhwa 1d72a1c826 don't extract volume if tarball doesn't exist 2020-03-24 15:01:31 -07:00
Medya Gh aec6fdc25a initialize kic runner in stop 2020-03-23 21:01:12 -07:00
Medya Gh 7619a5075a fix logging 2020-03-23 21:01:12 -07:00
Medya Gh 47c8e9c87b dont return on error kic sto 2020-03-23 21:01:12 -07:00
Medya Gh 5f90a319bd stop k8s in kic and none 2020-03-23 21:01:12 -07:00
Medya Gh fae3e34319 add stop force stop 2020-03-23 20:59:21 -07:00
Medya Gh 298be78e5f remove duplicate code 2020-03-23 20:59:21 -07:00
Medya Gh beec3b1ce1 stop kubelet on docker stop 2020-03-23 20:59:21 -07:00
Priya Wadhwa bfe8aee3b5 Pass in container runtime to preload tarball name
This way we don't have to individually check if we support a container runtime
2020-03-23 12:29:49 -07:00
Priya Wadhwa 0e5974367f rebased on master' 2020-03-23 10:59:02 -07:00
vikkyomkar f54af5d684 function name HostPortBinding changed to ForwardedPort 2020-03-14 21:28:12 +05:30
Priya Wadhwa 89c6c72adb Skip preload if not running on amd64
Also make sure that preload is available before attempting to run preload.
2020-03-13 16:24:28 -07:00
Thomas Stromberg 895967235a Improve error message output 2020-03-13 16:18:14 -07:00
Thomas Stromberg 196a8d7b82 Delete: output underlying status failure, refactor wordy code 2020-03-13 15:51:03 -07:00
Medya Gh 70c9304724 code review comments 2020-03-13 10:37:29 -07:00
Medya Gh 99ba89c2dd ip 2020-03-12 16:01:49 -07:00
Medya Gh 084da0c46a fix maybe 2020-03-12 15:31:38 -07:00
Medya Gh b5681d52c5 lint 2020-03-10 18:45:56 -07:00
Medya Gh 9ff0dc0ebc pass api server port to kic create container 2020-03-10 18:33:59 -07:00
Thomas Stromberg 6f46393123 Remove blank line 2020-03-06 12:15:58 -08:00
Thomas Stromberg 120dce7b56 Remove extraneous calls to oci.PointToHostDockerDaemon 2020-03-06 12:13:51 -08:00
Medya Gh 38ccb88e3f address code review 2020-03-06 10:25:48 -08:00
Medya Gh 1c37fc5505 lint 2020-03-05 22:45:38 -08:00
Medya Gh 0335fb1ad7 change names 2020-03-05 22:38:47 -08:00
Medya Gh 2a37317a72 improve comment 2020-03-05 22:34:10 -08:00
Medya Gh 1e8dd94a77 fix logic 2020-03-05 22:31:44 -08:00
Medya Gh e1f6820335 fix already in use 2020-03-05 16:42:56 -08:00
Thomas Stromberg 1f7ae5b35b Merge to master 2020-03-05 09:57:46 -08:00
Thomas Stromberg a1ebcbd031 Merge conflicts 2020-03-04 18:01:41 -08:00
Sharif Elgamal 0ff12cafac Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-04 16:37:54 -08:00
Medya Gh db5903d3ed lint 2020-03-04 10:40:32 -08:00
Medya Gh 54df61d677 point to host daemon more places 2020-03-04 10:37:10 -08:00
Sharif Elgamal 28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-03 12:16:47 -08:00
Sharif Elgamal 4cd3ef81a5
more changes 2020-03-02 15:21:37 -08:00
Priya Wadhwa 481010d8dc added overlay2 to preloaded images tarball name 2020-03-02 14:10:41 -08:00
Priya Wadhwa 6b0e942e7e Rebased on master 2020-03-02 13:33:27 -08:00
Medya Gh 4709af55df resolve review comments 2020-02-26 12:44:25 -08:00
Priya Wadhwa 97bf128703 only use preloaded volumes for docker runtime 2020-02-21 12:53:24 -08:00
Priya Wadhwa c99bf76ee4 Add checksum verification 2020-02-21 12:03:31 -08:00
Priya Wadhwa 5ac8520ab8 skip transferring binaries and transferring imagse if using preloaded volume 2020-02-20 14:59:43 -08:00
Priya Wadhwa b0f685c072 Move all preloading code into preload package 2020-02-20 14:43:24 -08:00
Priya Wadhwa 055e4bb618 Add run to docker command 2020-02-20 09:57:19 -08:00
Priya Wadhwa 335637f4a3 Name tarball by k8s version name 2020-02-20 09:42:04 -08:00
Priya Wadhwa bb11bc666b Create volume of preloaded images and mount it in 2020-02-19 23:02:36 -08:00
Medya Gh a4ee4186bd create docker volumes explictily with a label 2020-02-14 01:01:53 -08:00
Medya Ghazizadeh 398c7ef00b
Add podman driver (#6515) 2020-02-12 19:11:44 -07:00
Medya Gh 4b9d15a34c point to host docker 2020-02-04 16:09:43 -08:00
Medya Gh 0e5059ddd0 log warning if docker is stuck 2020-01-30 21:36:56 -08:00
Medya Gh 968fe86869 unexport more funcs 2020-01-30 21:01:27 -08:00
Medya Gh 23e125649d rename createConfig 2020-01-30 18:13:11 -08:00
Medya Gh b20322a8c2 rename funcs 2020-01-30 18:12:04 -08:00
Medya Gh 58b637b05f delete all cleans up stale kic profiles 2020-01-30 16:42:14 -08:00
Medya Gh 8e0ffdf1cf resolve conflict 2020-01-30 16:20:55 -08:00