priyawadhwa
6df5d19d70
Merge pull request #8793 from priyawadhwa/warning
...
Implement Warning type for JSON output
2020-07-21 18:17:54 -04:00
Medya Ghazizadeh
85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
...
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal
1b6eee675b
Automated GCP Credentials Addon Prototype ( #8682 )
...
* metadata addon works
* Add code for metadata server image and makefile rules
* remove log message
* update to work with v1.13.11
* update readme
* fix metadata addon stuff for newer codebase
* buncha changes
* just so many changes
* ch-ch-ch-ch-changes
* addon works
* update readme
* boilerplate
* revert unrelated change
* move server code to another repo
* switch addon name to gcp-auth
* metadata -> gcp-auth
* missed one
* automate finding of credentials
* remove unnecessary comment
* address comments
* Update README.md
* Update README.md
* use mustload everywhere
* swap selector condition
* upgrade kube-webhook-certgen to 1.3
* move paths to constants
* add notice to user on addon enable
* adding addon documentation
* move addons documentation inside handbook
* remove old addons docs location
Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Medya Ghazizadeh
24fa6280dc
Merge pull request #8588 from afbjorklund/preload-crio-2
...
Use preloaded tarball for cri-o container runtime
2020-07-21 13:59:03 -07:00
Medya Ghazizadeh
f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
...
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
Priya Wadhwa
c60e754624
Implement warning type for JSON output
2020-07-21 14:40:31 -04:00
Shubham
f42f79e56d
(Addons) Create a new command in every retry
...
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd )
states that "... Cmd cannot be reused after calling its Run or
Start methods."
This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.
Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.
Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
Anders F Björklund
59bf848e54
Use preloaded tarball for cri-o container runtime
...
Pretty much the same as containerd, minus Restart
2020-07-21 09:05:12 +02:00
priyawadhwa
aaebd88251
Merge pull request #8610 from johscheuer/update-storage-provisioner
...
Update external-provisioner for storage provisioner for Kubernetes 1.18
2020-07-20 19:11:38 -04:00
Medya Ghazizadeh
79088e6ed2
Merge pull request #8581 from afbjorklund/preload-crio
...
Generate cri-o container runtime preload tarball
2020-07-20 15:55:31 -07:00
Medya Ghazizadeh
2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
...
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
Medya Gh
13357d91a4
avoid nil pointer
2020-07-20 12:56:03 -07:00
Anders F Björklund
22585c3a17
Use the preload container run for podman as well
...
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...
Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
Anders F Björklund
2a9e9b2425
Make sure to prepare the kic volume after creation
...
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.
This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
Jose Donizetti
cd17c872d3
Fix documentation typo
2020-07-18 15:02:09 -03:00
Thomas Stromberg
9546b1ebc6
Merge branch 'master' into kic-image-upgrade
2020-07-17 09:56:42 -07:00
Thomas Strömberg
b7e7ef3a65
Merge pull request #8751 from tstromberg/docker-err-suggestion
...
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:55:04 -07:00
Thomas Stromberg
f89094dcf8
Adjust comment
2020-07-17 09:46:53 -07:00
Thomas Stromberg
2b614ae856
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:45:16 -07:00
Thomas Stromberg
3b1dc975d0
legacy client certs: simplify logic
2020-07-17 07:23:48 -07:00
Thomas Stromberg
b72eee4e36
Turn Errorf into Infof
2020-07-16 23:07:37 -07:00
Thomas Stromberg
94e866affc
Merge to master
2020-07-16 19:53:43 -07:00
Thomas Stromberg
798196d0ad
Remove stray log line
2020-07-16 19:37:28 -07:00
Thomas Stromberg
be2c27efe0
Find and copy legacy certificate/key paths
2020-07-16 19:37:15 -07:00
Thomas Strömberg
bb2fb3ad97
Merge pull request #8573 from tstromberg/cilium
...
Add support for Cilium CNI (--cni=cilium)
2020-07-16 19:34:44 -07:00
Thomas Stromberg
ccd3682116
Refactor upgrade tests
2020-07-16 17:34:46 -07:00
Thomas Stromberg
fcc15fa353
Merge to master
2020-07-15 21:04:33 -07:00
Thomas Stromberg
14b4a54ba2
Merge to master
2020-07-15 21:03:49 -07:00
Medya Gh
13d37ff7aa
adress review comments
2020-07-15 14:34:01 -07:00
Medya Gh
b0e58a3688
rename to FullName
2020-07-15 14:27:06 -07:00
Medya Gh
3aac9a3fff
remove duplicate return statement
2020-07-15 14:24:42 -07:00
Medya Gh
8ecb483cb7
use cached error
2020-07-15 14:23:25 -07:00
Medya Gh
7bbb0b6250
spell
2020-07-15 14:09:35 -07:00
Medya Gh
de6c10526b
move cacheDaemoninfo to oci package
2020-07-15 14:07:50 -07:00
Sharif Elgamal
af99a13e8f
Merge branch 'master' of github.com:kubernetes/minikube into master
2020-07-15 11:32:48 -07:00
Sharif Elgamal
1467e8f7c4
Merge pull request #8576 from afbjorklund/image-client
...
cache: Only use docker client for docker runtime
2020-07-15 11:12:52 -07:00
Medya Gh
dbfd16f21e
add helper fucns for drivers
2020-07-14 15:02:54 -07:00
priyawadhwa
c2e63844db
Merge pull request #8709 from priyawadhwa/json-output-download
...
Implement Download and DownloadProgress types for JSON output
2020-07-14 15:56:56 -04:00
Priya Wadhwa
cb03f56b1b
remove todo
2020-07-14 13:39:33 -04:00
priyawadhwa
f15b0d6e35
Merge pull request #8468 from prasadkatti/mv_kubelet_params_to_cfg_file
...
Move kubelet params to config file
2020-07-14 09:56:26 -04:00
Sharif Elgamal
9f2f604b93
several fixes
2020-07-13 18:54:40 -07:00
Sharif Elgamal
bd721de0cf
Merge branch 'master' of github.com:kubernetes/minikube into master
2020-07-13 15:00:38 -07:00
Priya Wadhwa
e4ce27abda
Add unit tests for register package
2020-07-13 12:08:06 -04:00
Priya Wadhwa
e771b72a82
fix lint
2020-07-13 10:05:06 -04:00
Priya Wadhwa
9784ce3051
Rebased on master
2020-07-13 09:57:42 -04:00
Priya Wadhwa
d26cd72d36
Implement Info type so that integration tests pass
2020-07-10 19:18:25 -04:00
Priya Wadhwa
3a290606db
Merge branch 'master' of https://github.com/kubernetes/minikube into json-output
2020-07-10 19:12:50 -04:00
Sharif Elgamal
aa4f7b3b21
update control plane properly on multinode restart
2020-07-10 15:40:21 -07:00
priyawadhwa
442bc138ce
Merge pull request #8676 from priyawadhwa/info
...
Add Infof function to out package
2020-07-10 17:08:30 -04:00
Medya Ghazizadeh
45677496fa
Merge pull request #8585 from prasadkatti/extra_option_8130
...
Do not auto-set extra config that user wishes to override
2020-07-10 13:54:19 -07:00