Ilya Zuyev
618d09ab76
Fix network settings parsing
2021-05-05 17:14:33 -07:00
Ilya Zuyev
01f76f7d4f
Add debug logs
2021-05-05 16:29:11 -07:00
Ilya Zuyev
adc53aa677
Fix error handling
2021-05-05 15:58:16 -07:00
Ilya Zuyev
61c1b301be
Fix linter errors
2021-05-05 15:31:11 -07:00
Ilya Zuyev
fe392b4233
When getting a gateway IP for podman container inspect per-network data as well
2021-05-05 15:09:46 -07:00
minikube-bot
625a06ce6d
Update kicbase to v0.0.22
2021-05-05 21:18:37 +00:00
minikube-bot
c5b65cab51
Update kicbase to v0.0.21
2021-04-30 18:08:55 +00:00
minikube-bot
fff23925e0
Updating kicbase image to v0.0.20-1619543236-11212
2021-04-27 17:16:43 +00:00
Medya Ghazizadeh
30d659c635
Merge pull request #11055 from afbjorklund/kic-os-update
...
Update kicbase base image
2021-04-24 21:09:32 -07:00
Medya Gh
1207de734b
bump golang lint ci to latest
2021-04-19 15:16:31 -07:00
Medya Ghazizadeh
60d8401f59
Merge pull request #11086 from sharifelgamal/mock-mirror
...
avoid network calls for mirror unit tests
2021-04-16 13:46:31 -07:00
Sharif Elgamal
1319b6e398
refactor checkRepository to make mocking easier
2021-04-14 12:51:16 -07:00
minikube-bot
0e1fd72042
Updating kicbase image to v0.0.20-1618262794-11055
2021-04-12 21:36:41 +00:00
Anders F Björklund
f527fb675a
Address security concerns with the go code
...
As flagged by the github code scanning
2021-04-12 20:38:21 +02:00
minikube-bot
f7c204d907
Update kicbase to v0.0.20
2021-04-09 19:23:04 +00:00
minikube-bot
831c3dfdbd
Updating kicbase image to v0.0.19-1617905290-11019
2021-04-08 18:17:37 +00:00
Medya Ghazizadeh
1e3370298a
Merge pull request #11001 from lilongfeng0902/minikube-lilf
...
minor spelling errors
2021-04-07 17:35:39 -07:00
Anders F Björklund
db3fd51194
Rename ListOptions to ListContainersOptions
2021-04-06 22:39:43 +02:00
李龙峰
7ae82c573b
Propagation not Propogation
2021-04-06 14:52:52 +08:00
minikube-bot
53babcc152
Update kicbase to v0.0.19
2021-04-05 22:22:23 +00:00
Predrag Rogic
387ad774bb
multinode: fix kindnet and dns issues
2021-04-05 16:18:37 +01:00
Predrag Rogic
06d4313f3f
kvm2 driver: add static ip
2021-03-27 23:33:24 +00:00
Medya Ghazizadeh
894ca125cb
Merge pull request #10858 from prezha/fix-create-network-race
...
create network: use locks and reservations to solve race condition
2021-03-24 17:47:21 -07:00
Daehyeok Mun
9b23841ee3
Add solution message if Docker is rootless
2021-03-20 13:20:30 -07:00
Predrag Rogic
f4a375181a
create network: use locks and reservations to solve race condition
2021-03-18 18:38:06 +00:00
Predrag Rogic
474f6734b1
create network: use locks to solve race conditions
2021-03-17 22:56:22 +00:00
Predrag Rogic
223792b993
create network: use locks to solve race conditions
2021-03-17 14:32:39 +00:00
Daehyeok Mun
fae67405e9
Update outdated moby/hyperkit package in minikube code
2021-03-05 22:27:23 -08:00
Medya Ghazizadeh
d2cb052fca
Merge pull request #10653 from Loyen/add-listen-address-flag
...
Add flag "--listen-address" for docker and podman driver
2021-03-05 12:56:22 -08:00
Patrik Freij
3110bd15fc
Lowercase minikube in information message
2021-03-05 15:50:52 +01:00
Patrik Freij
0d1d169bf6
Set non-local traffic message as a Tip message
...
To stay consistent with other messages. Also moved it above the warning
message regarding what IP is set as listen-address to make more sense in
the message flow.
2021-03-03 17:07:23 +01:00
Patrik Freij
bb5bf9546c
Add info message about not using it for production
...
To add more context to the warning message for --listen-address
2021-03-02 20:21:39 +01:00
phantooom
529881e01c
fix: fix kvm2 numa simulate ut&lint
2021-03-02 22:40:42 +08:00
phantooom
badc5d4532
add more check for kvm2 support simulate numa node
2021-03-02 22:27:26 +08:00
phantooom
e11f23a4c9
kvm2 driver support simulate numa node
2021-03-02 22:27:26 +08:00
Patrik Freij
9b5a96e76d
Make warning more informative for --listen-address
2021-03-01 23:10:58 +01:00
Patrik Freij
bad8561d0d
Skip custom listenAddress if equal to default
2021-03-01 23:06:13 +01:00
Patrik Freij
cb116e4c1c
Add --listen-address for docker driver
2021-02-28 23:14:08 +01:00
minikube-bot
2c292cca75
Update kicbase to v0.0.18
2021-02-25 23:14:51 +00:00
Medya Gh
f272822d15
bump kic base
2021-02-24 13:45:53 -08:00
Medya Gh
e9e81cef25
bump kicbase
2021-02-24 13:29:10 -08:00
Medya Gh
549bb10a52
update kicbase with pause
2021-02-24 12:30:06 -08:00
Medya Gh
72135d70d9
add auto pause proxy
2021-02-24 12:30:06 -08:00
Medya Ghazizadeh
460342a5f2
Merge pull request #10575 from hetong07/issue_10519
...
Improve the error message of setting cgroup memory limit.
2021-02-24 11:53:54 -08:00
Sharif Elgamal
7f75dfffda
drop support for github packages for kicbase
2021-02-23 14:16:02 -08:00
hetong07
9a30756d38
Improve the error message of setting cgroup memory limit.
2021-02-22 20:18:22 -08:00
Jiefeng He
d6e9174435
update new tag, SHA, and doc due to new kicbase image
2021-02-21 17:27:24 -08:00
Medya Gh
d120656161
update image
2021-02-20 10:55:56 -08:00
Medya Gh
712ab628a6
update kicbase
2021-02-20 10:11:35 -08:00
Medya Ghazizadeh
5c6c20f68e
Merge pull request #10528 from sharifelgamal/crio-storage
...
fix crio by hardcoding mountopt
2021-02-19 22:54:33 -08:00
Sharif Elgamal
9abb3bed51
update kicbase image
2021-02-19 18:08:41 -08:00
Medya Ghazizadeh
6bf3c23699
Merge pull request #10479 from prezha/fix-kvm-network-cleanup
...
improve kvm network delete/cleanup
2021-02-19 16:31:26 -08:00
Medya Ghazizadeh
fb27ab7e7f
Merge pull request #10439 from prezha/prevent-oci-overlapping-net
...
prevent oci try to create overlapping network
2021-02-19 16:23:18 -08:00
Medya Ghazizadeh
629926a2bd
Merge pull request #10418 from afbjorklund/kicbase-210119
...
Update kicbase base image and sync with kind
2021-02-19 11:33:11 -08:00
Sharif Elgamal
17af0f999b
update kicbase image for testing
2021-02-18 19:20:17 -08:00
Medya Ghazizadeh
0edb126f13
Merge pull request #10512 from hetong07/cgroup_memory_fix
...
cgroup v2: skip setting --memory limits when not configurable.
2021-02-18 18:56:57 -08:00
Sharif Elgamal
96c5b6a0d4
Merge pull request #10408 from sharifelgamal/kic-test
...
populate kic.txt properly in kicbase
2021-02-18 18:42:17 -08:00
Sharif Elgamal
74e2127a87
update kicbase image for the last time
2021-02-18 18:28:02 -08:00
hetong07
556a8d7930
Move the user facing warning inside hasMemoryCgroup().
2021-02-18 16:43:19 -08:00
Sharif Elgamal
114364409d
add github packages to script
2021-02-18 16:17:09 -08:00
hetong07
e8c2a23398
Provide an advice for users on how to modify Grub setting.
2021-02-18 16:09:51 -08:00
hetong07
7b0bf57f4c
Stop using --memory for cgroup v2.
2021-02-18 15:43:26 -08:00
Sharif Elgamal
31ea98ca50
update kicbase to newest build
2021-02-18 15:04:34 -08:00
Medya Ghazizadeh
369f93f393
Merge pull request #10468 from afbjorklund/cgroups-warning
...
Make sure to show debian warning also for cgroup 2
2021-02-18 14:25:59 -08:00
Sharif Elgamal
f11498046b
messed up boilerplate
2021-02-18 11:52:38 -08:00
Sharif Elgamal
3f04535045
add dockerhub to autopush
2021-02-18 11:47:59 -08:00
Medya Ghazizadeh
75be14d2ce
Merge pull request #10507 from afbjorklund/docker-memswap
...
Stop using --memory-swap if it is not available
2021-02-18 11:15:32 -08:00
Anders F Björklund
eabc02d3c4
Stop using --memory-swap if it is not available
...
With Debian and Ubuntu kernels, it needs to be configured.
And now with cgroups v2, it starts throwing errors at run.
2021-02-18 18:54:36 +01:00
Sharif Elgamal
fd897f4f23
fix up repo stuff
2021-02-17 10:32:48 -08:00
Sharif Elgamal
ea16737271
syntax
2021-02-17 09:37:34 -08:00
Sharif Elgamal
9aeb4a75fa
update kicbase image
2021-02-17 09:35:32 -08:00
Predrag Rogic
6d61795352
simplify free subnet query for oci net create
2021-02-17 03:04:47 +00:00
Predrag Rogic
4018ee3682
move to separate network package and fix naming
2021-02-17 03:04:47 +00:00
Predrag Rogic
d48b0a58e8
add ip conflict auto-resolution also to kvm and consolidate
2021-02-17 03:04:47 +00:00
Predrag Rogic
c6446e5fbd
prevent oci try to create overlapping network
2021-02-17 03:04:47 +00:00
Predrag Rogic
a5f75b4a29
fix wording
2021-02-17 02:45:22 +00:00
Predrag Rogic
fc07cfd395
fix wording
2021-02-17 02:45:22 +00:00
Predrag Rogic
1f50c63adb
fix wording
2021-02-17 02:45:22 +00:00
Predrag Rogic
5c8ea8dc5b
improve kvm network delete/cleanup
2021-02-17 02:45:03 +00:00
Kent Iso
5bffb823b2
Add ProfileLableKey to make sure that preload side car will be target of deletion. minikube delete doesn't check CreatedByLabelKey
2021-02-17 10:27:54 +09:00
Kent Iso
fd58d0fc90
Add CreatedByLabelKey to make sure that preload side car will be target of deletion
2021-02-17 10:06:12 +09:00
Kent Iso
e3cd93aa1a
Change prepareVolume func to add container name for preload side car
2021-02-17 10:06:12 +09:00
Anders F Björklund
2c87f6e1ad
Make sure to show debian warning also for cgroup 2
...
Move check to function, to cut down on complexity
2021-02-13 18:37:54 +01:00
Medya Ghazizadeh
ee6283ecf1
Merge pull request #10293 from afbjorklund/ssh-validate
...
ssh: validate the ssh-key parameter if given
2021-02-11 15:05:19 -08:00
Anders F Björklund
b7de621033
Explicitly remove podman volume and network
...
The --filter and --label functionality was broken,
in earlier versions of podman (before version 3.0)
2021-02-10 20:57:20 +01:00
Priya Wadhwa
51169d68ea
Add context to remaining necessary functions
2021-02-08 15:19:01 -08:00
Priya Wadhwa
a6372b35a3
Add 5 minute timeout to deleting leftover cvolumes and containers
2021-02-08 15:15:08 -08:00
Anders F Björklund
f316c0fdce
Clean up accumulated golint with missing godoc
2021-02-08 20:10:31 +01:00
Predrag Rogic
f519ec50cc
support ancient versions of docker again (template parsing issue)
2021-02-05 01:54:09 +00:00
Yanshu Zhao
67458418ca
Change test naming
2021-02-02 21:39:34 +00:00
Yanshu Zhao
84e7c47e8a
reduce lock scope
2021-02-02 21:20:31 +00:00
Yanshu Zhao
8009a5b3a8
change naming
2021-02-02 20:59:29 +00:00
Yanshu Zhao
4665993109
Add header file for the test
2021-02-02 16:57:47 +00:00
Yanshu Zhao
397b7b2286
Use global flag and only print one warning for the same cmd per binaray
...
run
2021-02-02 16:28:04 +00:00
Daehyeok Mun
4500be129f
Validate minimum docker version
2021-02-01 13:54:20 -08:00
Anders F Björklund
40e4521bb2
ssh: validate the ssh-key parameter if given
2021-01-28 08:48:40 +01:00
Medya Gh
70253a9c87
update kicbase and iso to last build
2021-01-20 16:41:10 -08:00
Medya Gh
91a7436617
bump kicbase version
2021-01-20 15:46:14 -08:00
Anders F Björklund
541193c945
Address review comments, rename to ssh-ip-address
2021-01-16 14:44:56 +01:00
Anders F Björklund
abb556f7f5
Merge branch 'master' into generic
2021-01-13 20:15:17 +01:00
Ilya Zuyev
813094bafb
Merge branch 'master' into ilyaz/multiarch_kicbase
2021-01-12 10:48:01 -08:00
Ilya Zuyev
7ca15031e8
fix kicbase sha1
2021-01-11 18:30:39 -08:00
Anders F Björklund
1663a030ed
Only add docker group for the docker runtime
2021-01-11 18:12:06 +01:00
Anders F Björklund
b2121eae39
Rename the generic driver to the ssh driver
...
Now that we have forked the machine driver
2021-01-09 14:36:32 +01:00
Anders F Björklund
e53f537b39
Merge branch 'master' into generic
2021-01-09 14:11:09 +01:00
Ilya Zuyev
2622e9583c
bump kicbase version to v0.0.16-snapshot1
2021-01-08 13:49:27 -08:00
Ilya Zuyev
921306d88a
fix fallback kicbaseimages list
2021-01-08 13:31:13 -08:00
Anders F Björklund
40ec0e8015
Avoid the hard-coded dependency on systemctl
2021-01-08 18:31:15 +01:00
Anders F Björklund
fb6cf6b6b6
Add placeholder for docs for the generic driver
...
But most of it is identical to the "none" driver
2021-01-08 18:16:58 +01:00
Anders F Björklund
e4ebaeabf6
Complete the container runtime and config change
2021-01-08 17:36:23 +01:00
Anders F Björklund
b856a475e6
Remove systemd dependency from none driver
...
Use the minikube "sysinit" module instead
2021-01-08 09:12:54 +01:00
Anders F Björklund
1d6c86c8b5
Also remove unused machine SetConfigFromFlags
...
Setting the config directly instead in minikube
2021-01-06 21:05:53 +01:00
Anders F Björklund
a120c543bf
Change meaning of Stop/Start/Restart to minikube
...
The "none" driver has redefined stop and start to mean the
kubelet rather than the host itself. Use the same API here.
Killing actual containers remotely remains to be implemented.
Only stop the kubelet service for now, and assuming systemd.
2021-01-06 20:09:25 +01:00
Anders F Björklund
a77e3de85f
Use CommonDrivers and drop machine GetCreateFlags
...
This makes the machine driver specific to minikube
2021-01-06 18:42:19 +01:00
Anders F Björklund
fa05fcd6d0
Fork the generic driver to the minikube code base
2021-01-06 18:35:09 +01:00
Ilya Zuyev
65cf998d6f
Merge branch 'master' into ilyaz/multiarch_kicbase
2021-01-05 16:30:26 -08:00
Ilya Zuyev
6335658103
Revert single-arch kicbase fallback support
2021-01-05 16:29:48 -08:00
Anders F Björklund
f22a3802c7
Handle podman installations without default bridge
2021-01-05 17:06:52 +01:00
Yanshu Zhao
0f734e6339
Change function name
2020-12-31 00:03:34 +00:00
Yanshu Zhao
f94b1674b1
Change tests into a loop
2020-12-30 23:27:37 +00:00
Yanshu Zhao
f044b1fa91
Add unit test for docker network inspect
2020-12-30 02:28:44 +00:00
Yanshu Zhao
4a940d0079
Fix docker inspect network go template
2020-12-27 08:38:39 +00:00
Priya Wadhwa
a3b80e1fff
add log
2020-12-22 14:57:04 -08:00
Priya Wadhwa
bd413794c2
Avoid creating network if it is the default
2020-12-22 14:56:27 -08:00
Priya Wadhwa
55f496492c
fix merge conflict
2020-12-16 10:37:51 -08:00
Thomas Strömberg
f85bed1150
Merge pull request #9753 from blueelvis/'bug/9078-tunnel-windows-docker'
...
Fix minikube tunnel for Docker on Windows
2020-12-15 07:59:44 -08:00
Jituri, Pranav
a8463f3453
fix linting errors
2020-12-15 18:25:10 +05:30
Jituri, Pranav
ce17200bd8
address review comment
2020-12-15 18:09:43 +05:30
Ilya Zuyev
6044006afe
add multi-arch images to kic driver list
2020-12-13 22:29:17 -08:00
Thomas Strömberg
b4bf2bde33
Merge pull request #9866 from afbjorklund/podman-network-fix
...
Fix podman network inspect format and error
2020-12-11 10:20:46 -08:00
Medya Ghazizadeh
442a9cf2d3
Merge pull request #9911 from medyagh/update_kicbase_16_1
...
Update kicbase 15 snapshot4 on head
2020-12-10 16:55:28 -08:00
Medya Ghazizadeh
6b079476c6
Merge pull request #9918 from lingsamuel/remove-verbose-options
...
Remove verbose options
2020-12-10 15:58:01 -08:00
Anders F Björklund
c3d0621d97
Only use sudo with the none driver when on linux
2020-12-10 21:07:10 +01:00
Anders F Björklund
a6941f21ca
Fix podman network inspect format and error
...
Somehow this ended up with the docker network inspect format,
instead of the CNI based one used by podman network inspect ?
2020-12-10 07:32:34 +01:00
Ling Samuel
634f0ae0a9
Remove verbose options
2020-12-10 14:29:38 +08:00
Medya Gh
d3c375420e
bump kicbase on head v0.0.15-snapshot4
2020-12-09 17:32:46 -08:00
Medya Gh
a55a0b0286
bump kicbase on head
2020-12-09 17:20:09 -08:00
Medya Ghazizadeh
6eadee30b8
Merge pull request #9802 from afbjorklund/podman-host-cleanup
...
Some more cleanup of missing code for podman-env
2020-12-09 15:00:37 -08:00
Jituri, Pranav
74cdda9e9a
Resolve review comments
2020-12-09 16:54:19 +05:30
Medya Gh
0e85b1819a
bump kic base on head
2020-12-08 13:49:17 -08:00
Medya Ghazizadeh
0898ca21e4
Merge pull request #9801 from afbjorklund/podman-env-existing
...
Add support for restoring existing podman env
2020-12-08 10:25:50 -08:00
Priya Wadhwa
f373155d55
merge conflict
2020-12-03 10:56:41 -08:00
Medya Ghazizadeh
8fc54b430b
Merge pull request #9716 from afbjorklund/podman-network
...
Add private network implementation for podman
2020-12-02 14:16:41 -08:00
Anders F Björklund
da778ea870
Some more cleanup of missing code for podman-env
...
There is a lot of code duplication from docker-env
Most of it also applies for podman (CONTAINER_HOST)
2020-11-29 23:35:37 +01:00
Anders F Björklund
dae980a355
Add support for restoring existing podman env
...
If user had a podman environment configured before podman-env,
restore it on unset (similar to existing code for docker-env)
2020-11-29 22:56:47 +01:00
Medya Gh
7bc81b1cbd
add imagesha
2020-11-25 14:22:29 -08:00
Medya Gh
8639a067e6
bump kic image on head
2020-11-25 14:07:24 -08:00
Medya Ghazizadeh
5d5a12c60f
Merge pull request #9734 from priyawadhwa/updae-iso-kic
...
Update ISO and kicbase to include scheduled stop
2020-11-24 10:10:59 -08:00
Anders F Björklund
fee0f5310a
Add private network implementation for podman
...
Most of it the same as docker, except for the options.
i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
Medya Ghazizadeh
131d7248c4
Merge pull request #9710 from valaparthvi/issue9690
...
convert dockerNetworkInspect to a struct
2020-11-20 14:16:01 -08:00