Commit Graph

6216 Commits (93d010455ef2250afed801afd11f48fc34445dcd)

Author SHA1 Message Date
Steven Powell b7634e12bf
Merge pull request #13071 from spowelljr/skipMountModeMac
mount: Skip chmod-ing mounted folder on macOS
2021-12-03 09:02:20 -08:00
Steven Powell 3063fb45dd skip chmod-ing mounted folder on macOS 2021-12-02 14:34:34 -08:00
minikube-bot 846e0c4edb Updating ISO to v1.24.0-1638385553-13059 2021-12-01 20:01:11 +00:00
Medya Ghazizadeh 61984694f6
Merge pull request #13018 from spowelljr/fixMountMode
mount: Fix `--mode` not being respected
2021-11-30 12:51:26 -08:00
Medya Gh 1982860139 bump k8s lib 2021-11-29 16:46:18 -08:00
Steven Powell 006934bde5 add chmod error 2021-11-29 10:48:23 -08:00
Steven Powell ef64db3a95 fix mount mode not being respected 2021-11-23 15:59:24 -08:00
Medya Ghazizadeh d7d2bc1f00
Merge pull request #12973 from spowelljr/updateOldestVersion
Update OldestKubernetesVersion to v1.16.0
2021-11-23 10:35:08 -08:00
Medya Ghazizadeh 2237e230f4
Merge pull request #12997 from minikube-bot/auto_bump_k8s_versions
bump default/newest kubernetes versions
2021-11-22 13:50:20 -08:00
Medya Ghazizadeh 3686ba58f0
Merge pull request #11598 from daehyeok/copy_from
Support copy file from node to local host or between nodes.
2021-11-22 13:42:35 -08:00
minikube-bot 12b711e797 bump default/newest kubernetes versions 2021-11-22 08:02:49 +00:00
Medya Gh 5d0ce59625 tests docs change name 2021-11-18 10:55:32 -08:00
Steven Powell 3c125f10e9
Merge pull request #12972 from mpuckett159/bug/fix-docker-env-typo
Fix typo in help text for minikube docker-env command
2021-11-17 13:51:52 -05:00
Steven Powell c432ea13f1 update OldestKubernetesVersion to v1.16.0 2021-11-17 12:52:09 -05:00
Marcus Puckett d831158c0c Fix typo in help text for minikube docker-env
In the help text for the `minikube docker-env` command the suggestions for setting the docker command for Windows (cmd and powershell) don't work as output because if you don't pass the `--shell` flag, it adds a line at the beginning that will cause the cmd example to fail, and doesn't specify that you need to set the flag `--shell powershell` for it to work properly. I've updated the help text to provide a command that will work as expected for both shells.
2021-11-16 22:48:55 -08:00
Sharif Elgamal cf09e50b4e iterate through arguments 2021-11-16 09:24:33 -08:00
Sharif Elgamal 558ece4a8e no need to explicitly translate title, Fmt does it for us 2021-11-15 17:03:09 -08:00
Sharif Elgamal d8ec4704e4 support functions with multiple string args 2021-11-15 16:52:39 -08:00
Sharif Elgamal ea7bc858c7 allow for fmt.Sprintf in Advice text 2021-11-15 16:31:25 -08:00
Medya Ghazizadeh 8bd28a6599
Merge pull request #12933 from klaases/go2
update suggestion messaging for --no-kubernetes
2021-11-12 12:21:14 -08:00
Medya Ghazizadeh 80b4e238cf
Merge pull request #12900 from AkihiroSuda/rootless-crio
Support CRI-O runtime with Rootless Docker driver (`--driver=docker --container-runtime=cri-o`)
2021-11-11 16:05:36 -08:00
klaases 4238bc1319 update message by runtime 2021-11-11 14:49:18 -08:00
Medya Ghazizadeh 75e2466cf9
Merge pull request #12923 from sharifelgamal/sched-ctd
fix scheduled stop test for containerd on docker driver
2021-11-11 12:45:12 -08:00
Sharif Elgamal d226d04eab fix schedule stop test for containerd on docker driver 2021-11-10 09:09:50 -08:00
Steven Powell 413d10192e
Merge pull request #12907 from spowelljr/addFileSharingError
Add error message for file sharing
2021-11-09 15:14:53 -05:00
Steven Powell 414b3ddf78
Merge pull request #12740 from spowelljr/discardUnpackedLayers
containerd preload: discard unpacked layers to reduce size
2021-11-09 14:30:15 -05:00
Steven Powell ab3f316ce6 bump preload version 2021-11-09 13:54:03 -05:00
Steven Powell 5c4e70bb26 add error message for file sharing 2021-11-09 10:58:16 -05:00
Akihiro Suda d7e728487c
Support CRI-O runtime with Rootless Docker driver
Follow-up to PR 12359 (containerd runtime with Rootless Docker driver).

Usage (needs cgroup v2):
```
dockerd-rootless-setuptool.sh install
docker context use rootless
minikube start --driver=docker --container-runtime=cri-o
```

See site/content/en/docs/drivers/includes/docker_usage.inc

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-11-09 16:09:52 +09:00
Steven Powell 69aa495d02 address lint concerns 2021-11-08 09:23:00 -05:00
Sharif Elgamal ef9a1a3a4f
Merge pull request #12863 from medyagh/hyperkit_suggestion
update suggestion for disabling internet sharing on hyperkit
2021-11-04 15:14:01 -07:00
Medya Ghazizadeh f8c34933fd
Update pkg/minikube/reason/known_issues.go
Co-authored-by: Sharif Elgamal <selgamal@google.com>
2021-11-04 15:07:40 -07:00
Medya Ghazizadeh bd973bba7c
Update pkg/minikube/reason/known_issues.go
Co-authored-by: Sharif Elgamal <selgamal@google.com>
2021-11-04 15:07:33 -07:00
Medya Ghazizadeh 94c74a2f52
Merge pull request #12848 from medyagh/no_kubernetes
Add --no-kubernetes flag  to start minikube without kubernetes
2021-11-04 14:46:48 -07:00
Medya Gh 8a7f43439a improve wording 2021-11-04 14:45:50 -07:00
Medya Gh 2ec8dc516a update suggestion for disalbing internet sharing on hyperkit 2021-11-04 14:43:43 -07:00
Medya Gh f4055654a1 spell 2021-11-04 12:48:28 -07:00
Medya Gh 75e6ba6637 better translate 2021-11-04 12:35:12 -07:00
Daehyeok Mun a88aec8b46 Support copy file from node to local host or between nodes. 2021-11-03 14:49:32 -07:00
Medya Gh 5bcdba0a09 add more constants 2021-11-03 14:16:04 -07:00
Medya Gh bfdc3cfdea address review comments 2021-11-03 14:13:04 -07:00
Medya Gh c827bf849f better name 2021-11-02 15:44:30 -07:00
Medya Gh 79f1b8c55c add --no-kubernetes flag to start minikube without kubernetes 2021-11-02 15:41:40 -07:00
Steven Powell 22969595a7 convert containerd config to v2 2021-11-02 15:18:52 -07:00
Sharif Elgamal 3342d3aa34
Merge pull request #12811 from nbusseneau/pr/fix-virtualbox-ip
virtualbox: change default `host-only-cidr`
2021-11-02 13:38:16 -07:00
Steven Powell 2de2ef09a4 discard unpacked layers 2021-11-02 13:36:50 -07:00
Nicolas Busseneau 02a43c52e2
virtualbox: change default `host-only-cidr`
We change the default `--host-only-cidr` to `192.168.59.1/24` in order
to be compatible with the new default host-only networking restrictions
implemented in VirtualBox 6.1.28.

This fixes access denied errors on `minikube start` when using
VirtualBox >= 6.1.28:

```
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
```

More details:

VirtualBox 6.1.28 introduced new restrictions on host-only networking:
https://www.virtualbox.org/wiki/Changelog-6.1#v28

Manual: https://www.virtualbox.org/manual/ch06.html#network_hostonly

> On Linux, Mac OS X and Solaris Oracle VM VirtualBox will only allow IP
> addresses in 192.68.56.0/21 range to be assigned to host-only
> adapters. For IPv6 only link-local addresses are allowed. If other
> ranges are desired, they can be enabled by creating
> /etc/vbox/networks.conf and specifying allowed ranges there. For
> example, to allow 10.0.0.0/8 and 192.168.0.0/16 IPv4 ranges as well as
> 2001::/64 range put the following lines into /etc/vbox/networks.conf:
>
>      * 10.0.0.0/8 192.168.0.0/16
>      * 2001::/64
>
> Lines starting with the hash # are ignored. Next example allows any
> addresses, effectively disabling range control:
>
>      * 0.0.0.0/0 ::/0

These new restrictions manifest in the form of the following issue on
`minikube start` due to the default `--host-only-cidr` used by the
VirtualBox driver being `192.168.99.1/24`:

```console
😄  minikube v1.23.2 on Ubuntu 18.04
  Using the virtualbox driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
🔥  Deleting "minikube" in virtualbox ...
🤦  StartHost failed, but will try again: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet0 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp

🔥  Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
😿  Failed to start virtualbox VM. Running "minikube delete" may fix it: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet1 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp

  Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet1 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp

╭───────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                           │
│    😿  If the above advice does not help, please let us know:                             │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                           │
│                                                                                           │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────╯
```

While the above is the primary error, other errors will be reported if
the adapter already exists (this happens when the adapter was created
before updating to VirtualBox 6.1.28, on a version of VirtualBox without
the new restrictions). Some examples:

```
 Exiting due to IF_VBOX_NOT_VISIBLE: Failed to start host: creating host: create: creating: Error setting up host only network on machine start: The host-only adapter we just created is not visible. This is a well known VirtualBox bug. You might want to uninstall it and reinstall at least version 5.0.12 that is is supposed to fix this issue
```

```
  minikube is unable to connect to the VM: dial tcp 192.168.99.112:22: i/o timeout

	This is likely due to one of two reasons:

	- VPN or firewall interference
	- virtualbox network configuration issue

	Suggested workarounds:

	- Disable your local VPN or firewall software
	- Configure your local VPN or firewall to allow access to 192.168.99.112
	- Restart or reinstall virtualbox
	- Use an alternative --vm-driver
	- Use --force to override this connectivity check

  Exiting due to GUEST_PROVISION: Failed to validate network: dial tcp 192.168.99.112:22: i/o timeout
```

When switching to a valid CIDR, `minikube start` works as usual:

```console
😄  minikube v1.23.2 on Ubuntu 18.04
  Using the virtualbox driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.22.2 on Docker 20.10.8 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
```

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
2021-11-02 15:30:46 +01:00
minikube-bot 79766cee83 bump default/newest kubernetes versions 2021-11-01 08:03:05 +00:00
Sharif Elgamal 6bbf98d57f
Merge pull request #12794 from prezha/improve-ingress
support k8s < v1.19 & watch-ingress-without-class
2021-10-28 10:40:09 -07:00
Steven Powell 2aa49b6295
Merge pull request #12806 from minikube-bot/iso-release-v1.24.0
Update ISO to v1.24.0
2021-10-28 09:55:13 -07:00