Commit Graph

4189 Commits (93517b95d8386878ed9c2d3d3e75883ab1f2c111)

Author SHA1 Message Date
Medya Ghazizadeh 993504e054
Merge pull request #8800 from priyawadhwa/improve-json
Improve json integration test
2020-07-23 10:23:36 -07:00
Medya Ghazizadeh f230ca0c55
Merge pull request #8804 from medyagh/hot_upgrade_fix
Stop kube-system containers before applying configuration updates
2020-07-23 10:03:54 -07:00
Medya Ghazizadeh b7b26ea2d5
Merge pull request #8737 from dddddai/master
Use RWMutex instead of Mutex
2020-07-23 09:57:25 -07:00
Medya Gh 44b6703e68 update comment 2020-07-23 09:17:30 -07:00
Medya Gh d5cc6afc9b update comment 2020-07-23 09:17:06 -07:00
Priya Wadhwa 2cba801d50 fix order 2020-07-22 20:47:41 -04:00
Priya Wadhwa a03f25e976 add step to register 2020-07-22 18:50:42 -04:00
Priya Wadhwa 22226ffc8f fixed merge conflict 2020-07-22 18:46:57 -04:00
priyawadhwa 25566c90f0
Merge pull request #8796 from priyawadhwa/error
Add support for Error type to JSON output
2020-07-22 18:43:46 -04:00
Priya Wadhwa df0bc948bc Add logging to none driver 2020-07-22 18:42:38 -04:00
Medya Gh 9fa1dfdaec
stop conainers before hot upgrade 2020-07-22 15:14:57 -07:00
Priya Wadhwa 3f18ecb052 add log 2020-07-22 15:01:22 -04:00
Priya Wadhwa efe1ce278a Add docs 2020-07-22 14:20:41 -04:00
Medya Ghazizadeh f2100e365d
Merge pull request #8697 from medyagh/improv_sa_apply
improve applying default service account
2020-07-22 11:00:07 -07:00
Sharif Elgamal ad083ba7ac
Merge pull request #8778 from sharifelgamal/hyerpv
allow for prefixed interface names for hyperv
2020-07-21 16:07:42 -07:00
Sharif Elgamal 58d4b0c32f add less restrictive interface name matching 2020-07-21 15:32:38 -07:00
Priya Wadhwa 6a33c03df2 fix unit test 2020-07-21 18:23:22 -04:00
Priya Wadhwa 8bc875d520 Rebased on master; fixed json_output integration test 2020-07-21 18:20:02 -04:00
priyawadhwa 6df5d19d70
Merge pull request #8793 from priyawadhwa/warning
Implement Warning type for JSON output
2020-07-21 18:17:54 -04:00
Medya Ghazizadeh 85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal 1b6eee675b
Automated GCP Credentials Addon Prototype (#8682)
* metadata addon works

* Add code for metadata server image and makefile rules

* remove log message

* update to work with v1.13.11

* update readme

* fix metadata addon stuff for newer codebase

* buncha changes

* just so many changes

* ch-ch-ch-ch-changes

* addon works

* update readme

* boilerplate

* revert unrelated change

* move server code to another repo

* switch addon name to gcp-auth

* metadata -> gcp-auth

* missed one

* automate finding of credentials

* remove unnecessary comment

* address comments

* Update README.md

* Update README.md

* use mustload everywhere

* swap selector condition

* upgrade kube-webhook-certgen to 1.3

* move paths to constants

* add notice to user on addon enable

* adding addon documentation

* move addons documentation inside handbook

* remove old addons docs location

Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Medya Ghazizadeh 24fa6280dc
Merge pull request #8588 from afbjorklund/preload-crio-2
Use preloaded tarball for cri-o container runtime
2020-07-21 13:59:03 -07:00
Priya Wadhwa 6ca72229bb add json unit tests 2020-07-21 15:56:26 -04:00
Priya Wadhwa b4b9013057 Add unit test for problem.DisplayJSON() 2020-07-21 15:51:47 -04:00
Priya Wadhwa 482b9befd6 implement errors in JSON 2020-07-21 15:43:19 -04:00
Medya Ghazizadeh f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
Priya Wadhwa c60e754624 Implement warning type for JSON output 2020-07-21 14:40:31 -04:00
Shubham f42f79e56d (Addons) Create a new command in every retry
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd)
states that "... Cmd cannot be reused after calling its Run or
Start methods."

This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.

Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.

Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
Anders F Björklund 59bf848e54 Use preloaded tarball for cri-o container runtime
Pretty much the same as containerd, minus Restart
2020-07-21 09:05:12 +02:00
dddddai 196789f965 Use RWMutex instead of Mutex 2020-07-21 10:39:45 +08:00
priyawadhwa aaebd88251
Merge pull request #8610 from johscheuer/update-storage-provisioner
Update external-provisioner for storage provisioner for Kubernetes 1.18
2020-07-20 19:11:38 -04:00
Medya Ghazizadeh 79088e6ed2
Merge pull request #8581 from afbjorklund/preload-crio
Generate cri-o container runtime preload tarball
2020-07-20 15:55:31 -07:00
Medya Ghazizadeh 2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
Sharif Elgamal f92015df9b allow for prefix interace names for hyperv 2020-07-20 13:07:13 -07:00
Medya Gh 13357d91a4 avoid nil pointer 2020-07-20 12:56:03 -07:00
Anders F Björklund 22585c3a17 Use the preload container run for podman as well
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...

Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
Anders F Björklund 2a9e9b2425 Make sure to prepare the kic volume after creation
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.

This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
Jose Donizetti cd17c872d3 Fix documentation typo 2020-07-18 15:02:09 -03:00
Thomas Stromberg 9546b1ebc6 Merge branch 'master' into kic-image-upgrade 2020-07-17 09:56:42 -07:00
Thomas Strömberg b7e7ef3a65
Merge pull request #8751 from tstromberg/docker-err-suggestion
Add 'Start Docker' guidance for /pipe/docker_engine errors
2020-07-17 09:55:04 -07:00
Thomas Stromberg f89094dcf8 Adjust comment 2020-07-17 09:46:53 -07:00
Thomas Stromberg 2b614ae856 Add 'Start Docker' guidance for /pipe/docker_engine errors 2020-07-17 09:45:16 -07:00
Thomas Stromberg 3b1dc975d0 legacy client certs: simplify logic 2020-07-17 07:23:48 -07:00
Thomas Stromberg b72eee4e36 Turn Errorf into Infof 2020-07-16 23:07:37 -07:00
Thomas Stromberg 94e866affc Merge to master 2020-07-16 19:53:43 -07:00
Thomas Stromberg 798196d0ad Remove stray log line 2020-07-16 19:37:28 -07:00
Thomas Stromberg be2c27efe0 Find and copy legacy certificate/key paths 2020-07-16 19:37:15 -07:00
Thomas Strömberg bb2fb3ad97
Merge pull request #8573 from tstromberg/cilium
Add support for Cilium CNI (--cni=cilium)
2020-07-16 19:34:44 -07:00
Thomas Stromberg ccd3682116 Refactor upgrade tests 2020-07-16 17:34:46 -07:00
Thomas Stromberg fcc15fa353 Merge to master 2020-07-15 21:04:33 -07:00