Commit Graph

366 Commits (9200267c043447c06a1bc46fa89d34b42ef2f9e8)

Author SHA1 Message Date
Steven Powell 5a66196a20 update message 2021-12-15 15:58:00 -08:00
Steven Powell b17834c96b added env to suppress Docker performance messages 2021-12-14 13:46:52 -08:00
Steven Powell 8d7a636bfe don't output Docker performance issues when user wants JSON 2021-12-09 14:38:18 -08:00
Steven Powell 016b3ac40a trim space earlier 2021-10-21 13:28:52 -07:00
Steven Powell fbd4d27582 fix podman network inspect index check 2021-10-21 10:01:10 -07:00
Anders F Björklund 75804c43ad Match the lower case of the podman error message
Turns out that Docker says "No such network",
but Podman says "no such network". Little nuances.
2021-10-10 12:25:18 +02:00
Steven Powell dafbe6aac3 add created by label for podman 2021-09-29 13:47:59 -07:00
Steven Powell 145f9fc9ab run `go fmt` 2021-09-13 11:58:43 -07:00
Akihiro Suda 323225483e
Support Rootless Docker
Requirements:
- Install rootless Docker 20.10 or later, see https://rootlesscontaine.rs/getting-started/docker/
- Enable cgroup v2 delegation, see https://rootlesscontaine.rs/getting-started/common/cgroup2/

Usage: `minikube start --driver=docker --container-runtime=containerd`.
The `--container-runtime` flag needs to be set to "containerd".
CRI-O can be also supported later.

Closes issue 10836 ("add support for rootless Docker").

Support for rootless Podman (issue 8719) is not covered in this commit.

---

Code reading guide:
- `deploy/kicbase/Dockerfile`: updated to install fuse-overlayfs and containerd-fuse-overlayfs, which is used
  instead of `overlayfs` snapshotter

- `deploy/kicbase/entrypoint`: updated to verify cgroup v2 delegation.
  Mostly from 8a83ee46b2/images/base/files/usr/local/bin/entrypoint

- `cmd/minikube/cmd/start_flags.go`: updated to set `KubeletInUserNamespace` feature gate when rootless

- `pkg/drivers/kic/oci`: updated to use port forwarding, because rootless container IPs are not reachable from the host

- `pkg/minikube/cruntime`: updated to generate `/etc/containerd/config.toml` with rootless support.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-08-27 17:21:53 +09:00
Medya Ghazizadeh 81c2bb2796
Merge pull request #11708 from afbjorklund/info-klog
Make sure to log errors from DaemonInfo
2021-07-07 13:29:05 -04:00
Medya Gh 89c7853601 bump go mod libs manually 2021-06-29 15:24:59 -04:00
Anders F Björklund 3b533a07cb Make sure to log errors from DaemonInfo 2021-06-22 07:56:11 +02:00
Medya Gh 6cb7c2166c spell 2021-05-21 14:09:42 -07:00
Medya Gh 9c9934879c break guest provision when container exists prematurely 2021-05-21 13:34:34 -07:00
Ilya Zuyev dcadd32624 Add comment, improve template 2021-05-14 14:38:29 -07:00
Ilya Zuyev a1ae930d2f Simplify the code 2021-05-06 11:17:43 -07:00
Ilya Zuyev 6e2eae0d0a Simplify the code 2021-05-06 11:13:10 -07:00
Ilya Zuyev f4e142d442 Simplify the code 2021-05-06 10:35:22 -07:00
Ilya Zuyev 8d2b811fcf Remove debug logs 2021-05-05 22:01:21 -07:00
Ilya Zuyev 6cf6ba2ff2 Fix network settings parsing 2021-05-05 19:31:12 -07:00
Ilya Zuyev 829cc42a65 Fix network settings parsing 2021-05-05 19:11:56 -07:00
Ilya Zuyev 618d09ab76 Fix network settings parsing 2021-05-05 17:14:33 -07:00
Ilya Zuyev 01f76f7d4f Add debug logs 2021-05-05 16:29:11 -07:00
Ilya Zuyev adc53aa677 Fix error handling 2021-05-05 15:58:16 -07:00
Ilya Zuyev 61c1b301be Fix linter errors 2021-05-05 15:31:11 -07:00
Ilya Zuyev fe392b4233 When getting a gateway IP for podman container inspect per-network data as well 2021-05-05 15:09:46 -07:00
Sharif Elgamal 1319b6e398 refactor checkRepository to make mocking easier 2021-04-14 12:51:16 -07:00
Medya Ghazizadeh 1e3370298a
Merge pull request #11001 from lilongfeng0902/minikube-lilf
minor spelling errors
2021-04-07 17:35:39 -07:00
李龙峰 7ae82c573b Propagation not Propogation 2021-04-06 14:52:52 +08:00
Medya Ghazizadeh 894ca125cb
Merge pull request #10858 from prezha/fix-create-network-race
create network: use locks and reservations to solve race condition
2021-03-24 17:47:21 -07:00
Daehyeok Mun 9b23841ee3 Add solution message if Docker is rootless 2021-03-20 13:20:30 -07:00
Predrag Rogic f4a375181a
create network: use locks and reservations to solve race condition 2021-03-18 18:38:06 +00:00
Predrag Rogic 223792b993
create network: use locks to solve race conditions 2021-03-17 14:32:39 +00:00
hetong07 9a30756d38 Improve the error message of setting cgroup memory limit. 2021-02-22 20:18:22 -08:00
Medya Ghazizadeh fb27ab7e7f
Merge pull request #10439 from prezha/prevent-oci-overlapping-net
prevent oci try to create overlapping network
2021-02-19 16:23:18 -08:00
hetong07 556a8d7930 Move the user facing warning inside hasMemoryCgroup(). 2021-02-18 16:43:19 -08:00
hetong07 e8c2a23398 Provide an advice for users on how to modify Grub setting. 2021-02-18 16:09:51 -08:00
hetong07 7b0bf57f4c Stop using --memory for cgroup v2. 2021-02-18 15:43:26 -08:00
Medya Ghazizadeh 369f93f393
Merge pull request #10468 from afbjorklund/cgroups-warning
Make sure to show debian warning also for cgroup 2
2021-02-18 14:25:59 -08:00
Medya Ghazizadeh 75be14d2ce
Merge pull request #10507 from afbjorklund/docker-memswap
Stop using --memory-swap if it is not available
2021-02-18 11:15:32 -08:00
Anders F Björklund eabc02d3c4 Stop using --memory-swap if it is not available
With Debian and Ubuntu kernels, it needs to be configured.

And now with cgroups v2, it starts throwing errors at run.
2021-02-18 18:54:36 +01:00
Predrag Rogic 6d61795352
simplify free subnet query for oci net create 2021-02-17 03:04:47 +00:00
Predrag Rogic 4018ee3682
move to separate network package and fix naming 2021-02-17 03:04:47 +00:00
Predrag Rogic d48b0a58e8
add ip conflict auto-resolution also to kvm and consolidate 2021-02-17 03:04:47 +00:00
Predrag Rogic c6446e5fbd
prevent oci try to create overlapping network 2021-02-17 03:04:47 +00:00
Kent Iso 5bffb823b2 Add ProfileLableKey to make sure that preload side car will be target of deletion. minikube delete doesn't check CreatedByLabelKey 2021-02-17 10:27:54 +09:00
Kent Iso fd58d0fc90 Add CreatedByLabelKey to make sure that preload side car will be target of deletion 2021-02-17 10:06:12 +09:00
Kent Iso e3cd93aa1a Change prepareVolume func to add container name for preload side car 2021-02-17 10:06:12 +09:00
Anders F Björklund 2c87f6e1ad Make sure to show debian warning also for cgroup 2
Move check to function, to cut down on complexity
2021-02-13 18:37:54 +01:00
Anders F Björklund b7de621033 Explicitly remove podman volume and network
The --filter and --label functionality was broken,
in earlier versions of podman (before version 3.0)
2021-02-10 20:57:20 +01:00