Commit Graph

32 Commits (80ded8a1c51c6843d5cc3030f006ce38f9f5c861)

Author SHA1 Message Date
Medya Gh c58a3b63db Fixing filepath to be os agnostic 2019-06-05 19:31:50 -07:00
Thomas Stromberg 6e693d22ee lint-a-geddon is here 2019-05-13 21:43:52 -07:00
Anders F Björklund a73dfc5f9e Merge branch 'master' into cyclo 2019-04-12 20:03:20 +02:00
Thomas Stromberg 7233a2d50d Allow mount to work when the uid/gid of docker changes 2019-03-26 14:27:50 -07:00
Anders F Björklund 03bdce47ee Decrease cyclomatic complexity for test
Mostly by using the "extract method" pattern.

Here was the report (from gocyclo), before:

17 tunnel TestTunnelManagerCleanup pkg/minikube/tunnel/tunnel_manager_test.go:174:1
44 tunnel TestTunnel pkg/minikube/tunnel/tunnel_test.go:35:1
34 kubeconfig configEquals pkg/util/kubeconfig/config_test.go:420:1
25 integration testMounting test/integration/mount_test.go:36:1
18 integration testTunnel test/integration/tunnel_test.go:37:1
2019-03-16 23:04:24 +01:00
Nicholas Goozeff d516caadb3
Merge branch 'master' into bug3044 2019-01-20 20:58:15 +11:00
Nicholas Goozeff 919c9d9d36 Remove extra debug logging for mount command. 2018-11-28 15:45:25 +11:00
Nicholas Goozeff ff93c6e067 Fix bug in construction of mount command for testing.
Only check access time is set for windows OS.
2018-11-10 18:32:41 +11:00
Thomas Stromberg 1b254773ef Call t.Parallel() after t.Skip() to avoid confusion while debugging. 2018-11-07 16:40:21 -08:00
Nicholas Goozeff 14244b3645 Test cases for issue #3044 - timestamps of mounted files incorrect with windows host. 2018-10-31 05:42:27 +01:00
Thomas Strömberg 2ec03ebf61
Merge pull request #3260 from tstromberg/disable-mount-osx
Disable mount tests in Darwin to workaround panic: timeout bug
2018-10-19 17:03:08 -07:00
Thomas Stromberg 88ab68305b Add runtime import for Darwin check. 2018-10-19 16:16:32 -07:00
Thomas Stromberg 1f968bc893 More merge conflicts. 2018-10-19 14:20:17 -07:00
Thomas Stromberg 13e580b588 Fix merge breakage. 2018-10-19 14:16:03 -07:00
Thomas Stromberg 72e596507a Merge branch 'master' into consistent_err_formatting 2018-10-19 14:08:35 -07:00
Thomas Stromberg f20bf4d3b2 Disable mount tests in Darwin to workaround panic: timedout bug
These tests reliably cause a "panic: timed out" condition due to
hitherto unknown reasons. See issue #3200 for context.

dlorenc mentioned that this test never worked, so when I re-enabled it
recently for all platforms in af61bf790c,
it introduced a persistent test failure for darwin.

I'll leave issue #3200 open until we are able to re-enable this test.
2018-10-17 14:58:40 -07:00
Thomas Stromberg c079bb1934 Update integration tests to handle newly persistant dashboard. 2018-10-03 15:06:30 -07:00
Thomas Stromberg 5ea3ef88ec Revert "Remove lint issues from integration tests, mostly by adding error"
This reverts commit af61bf790c.
2018-09-28 17:00:55 -07:00
Thomas Stromberg 8540e3a038 Consistently use %v for formatting error messages. 2018-09-28 16:18:22 -07:00
Thomas Stromberg 055c8002b1 Replace %s format directives with %v for errors.
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
Thomas Stromberg af61bf790c Remove lint issues from integration tests, mostly by adding error
handlers.
2018-09-28 11:57:48 -07:00
Matt Rickard 3180e2e897 Merge pull request #1938 from r2d4/integration-test-cleanup-
Integration test cleanup
2017-09-12 14:28:28 -07:00
Matt Rickard 53341aa30d golint, go vet, etc. changes 2017-09-11 14:17:58 -07:00
Matt Rickard 9747484e9e Move k8s utils to pkg/util 2017-09-08 20:14:28 -07:00
Matt Rickard f966c8cf31 Add NewMinikubeRunner, separate start args
* Separate start args from args passed to every command.  This is so
that we can call `minikube logs` and `minikube status` with the proper
flags (for the bootstrapper)

* Add a NewMinikubeRunner function to make getting a minikube runner
easier.
2017-09-08 20:14:21 -07:00
Matt Rickard 211ebb8a69 Use kubernetes client in integration tests 2017-08-23 13:09:30 -07:00
dlorenc 0b5bd79d50 Refactor of retries in integration tests. 2017-08-23 10:19:11 -07:00
Aaron Prindle 88613090a9 Added none driver 2017-05-19 14:51:19 -07:00
dlorenc 56b45d6488 Move the pod setup outside of the mount test loop. (#1423)
Deleting pods with HVs takes some time, so let's do that separately.
2017-04-27 12:50:04 -07:00
dlorenc c9bb006283 Add retries to GetPod calls. (#1420) 2017-04-26 16:53:41 -07:00
Aaron Prindle b3ad7539b1 Changed mount syntax to be host-path:vm-path 2017-04-19 10:15:04 -07:00
Aaron Prindle 8e801e3975 Update mount implementation, add mount integration tests, and check that path exists. 2017-04-06 13:39:25 -07:00