Anders F Björklund
a7a5148ff6
Don't add cgroup manager param for podman-remote
...
Since it doesn't work for either "run" or "start"
Error: unknown flag: --cgroup-manager
2020-05-09 14:04:04 +02:00
Anders F Björklund
85fae62d4a
Wrap the start command with cgroup manager too
...
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
Anders F Björklund
934ad06a82
Use noninteractive sudo when running podman
...
To avoid asking for a password in the middle of minikube commands.
The setup process is supposed to involve adding podman to sudoers...
2020-05-09 13:23:46 +02:00
Priya Wadhwa
ba267702af
Merge branch 'master' of https://github.com/kubernetes/minikube into embed-certs
2020-05-08 12:38:02 -07:00
Thomas Stromberg
436cee2d84
Fix minikube/kubernetes capitalization, make short help consistent
2020-05-07 14:12:10 -07:00
Priya Wadhwa
163ab88408
Restart kubelet in a function that is called on soft start
2020-05-07 13:22:09 -07:00
Priya Wadhwa
a353d564dd
Add comments
2020-05-07 13:03:07 -07:00
Priya Wadhwa
c037a97392
Restart kubeadm on soft `minikube start`
...
This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different.
This should fix the embed-certs integration test which has been flaky for a while.
2020-05-07 12:59:55 -07:00
Giacomo Mr. Wolf Furlan
9c43c47b06
Podman: disable selinux labels when extracting the tarball to prevent permission errors
2020-05-07 02:09:09 +02:00
Medya Gh
7914d057d1
fall back to github if gcr.io is not available
2020-05-04 13:12:50 -07:00
Medya Ghazizadeh
6eeb929b3d
Merge pull request #7962 from afbjorklund/podman-gateway
...
Get the gateway by inspecting container network
2020-05-04 20:05:56 +00:00
Medya Ghazizadeh
1da92a1c84
Merge pull request #7961 from afbjorklund/podman-preload
...
Use the correct binary for unpacking the preload
2020-05-04 20:04:19 +00:00
Medya Ghazizadeh
e0685c8f5d
Merge pull request #7984 from medyagh/detect_windows_container
...
Detect windows container and exit with instructions
2020-05-04 20:01:17 +00:00
Anders F Björklund
cc6506d2c9
Remove logging statement from containerGateway
2020-05-03 09:42:32 +02:00
Medya Gh
bcecda8e20
add comment for error type
2020-05-02 18:48:52 -07:00
Medya Gh
2102a20605
wrap errors
2020-05-02 18:38:23 -07:00
Medya Gh
4572d0634f
exit with usage if container type is windows
2020-05-02 18:29:33 -07:00
Medya Gh
ee9004f93b
add os type to DaemonInfo
2020-05-02 17:02:19 -07:00
Anders F Björklund
743f9f7efc
Don't show any podman hint about restarting sudo
2020-05-01 22:21:32 +02:00
Anders F Björklund
e2d7d94dfc
Use the correct binary for unpacking the preload
...
Previously hardcoded to *always* use a Docker volume,
even if using a different container driver (podman).
2020-05-01 22:11:28 +02:00
Anders F Björklund
3531efda7b
Get the gateway by inspecting container network
2020-05-01 15:05:21 +02:00
Thomas Strömberg
7b39b102d6
Merge pull request #7930 from sharifelgamal/cni
...
Automatically apply CNI on multinode clusters
2020-04-29 09:14:38 -07:00
Thomas Strömberg
dee6d518ce
Merge pull request #7631 from afbjorklund/podman-sudo
...
Add "sudo" to podman calls
2020-04-29 08:53:41 -07:00
Thomas Strömberg
2f78bff4ed
Merge pull request #7858 from priyawadhwa/upgrade-kic
...
Upgrade docker driver base image to v0.0.10
2020-04-29 08:48:45 -07:00
Anders F Björklund
78a22f5056
Remove prefix parameter and add prefix command
...
Move the "sudo" prefix to a central location, instead of
having it all over the place. Assume only needed on Linux.
2020-04-28 13:52:52 +02:00
Sharif Elgamal
5848bbe011
Merge branch 'master' of github.com:kubernetes/minikube into cni
2020-04-27 14:15:19 -07:00
Sharif Elgamal
228c1b092c
automatically apply kic overlay when detecting multinode clusters
2020-04-27 14:15:12 -07:00
Anders F Björklund
1744ffe773
Restore the configured state added for podman
...
Reverted 22aa1aff22
by accident
2020-04-27 22:27:53 +02:00
Priya Wadhwa
2459caea75
update SHA
2020-04-27 10:47:10 -07:00
Anders F Björklund
998ab840fb
Use simple version of podman info format parameter
...
So that it works with the older versions of podman
2020-04-26 22:54:45 +02:00
Anders F Björklund
795128131f
Remove old Copy function added in merge conflict
2020-04-26 22:52:10 +02:00
Anders F Björklund
28106fa2d7
Use constants instead of the KIC prefix strings
2020-04-26 15:22:57 +02:00
Anders F Björklund
88c8a24d55
Pass the container implementation on to systemd
2020-04-25 22:43:40 +02:00
Anders F Björklund
7185140c57
Remove extra quotes added in conflict resolution
...
Reverted f264ac171e
by accident
2020-04-25 22:09:52 +02:00
Anders F Björklund
7647b1f998
Don't try to limit podman memory without cgroup
...
Podman requires both memcg and memcg_swap for it (--memory).
Docker will still limit memory, without swap limit support.
2020-04-25 22:01:51 +02:00
Anders F Björklund
6644c5cc64
Merge branch 'master' into podman-sudo
2020-04-25 18:05:33 +02:00
Medya Gh
63f9bfbb61
addres review comments
2020-04-24 14:07:54 -07:00
Medya Gh
ef01ed481c
get rid of global CliRunner
2020-04-23 14:37:03 -07:00
Medya Gh
17f420cc71
warn slow part of cli runner
2020-04-23 01:23:49 -07:00
Medya Gh
d9f1b532d0
unexport warnIfSlow func
2020-04-23 00:33:59 -07:00
Medya Gh
038aef6b48
unexport warnIfSlow func
2020-04-23 00:33:40 -07:00
Medya Gh
8a0a210763
convert more funcs to use cli runner
2020-04-23 00:29:37 -07:00
Medya Gh
c6e1445ccb
convert more to cli runner
2020-04-23 00:12:41 -07:00
Medya Gh
29df4260ef
make all oci volume calls go through runner
2020-04-22 23:27:54 -07:00
Medya Gh
915058ef8e
lint
2020-04-22 23:01:04 -07:00
Medya Gh
72baa1dad2
convert execs to cliRunner
2020-04-22 22:49:48 -07:00
Medya Gh
c6895c2058
add cli runner to info
2020-04-22 22:34:11 -07:00
Medya Gh
fad745f607
adding runner for oci package
2020-04-22 22:16:18 -07:00
Priya Wadhwa
d39b822a3c
upgrade to v0.0.10
2020-04-22 14:44:24 -07:00
Medya Gh
b639c6112d
fix delete and add integeration test
2020-04-20 20:38:31 -07:00
Medya Gh
366dc8d127
add helper for img plull command
2020-04-20 13:13:37 -07:00
Medya Gh
d2415d778e
add json parser for critcl images
2020-04-19 20:36:22 -07:00
Medya Gh
ac66bf2f90
first working version
2020-04-19 19:59:50 -07:00
Medya Gh
c017c98e81
add preload funcs for containerd
2020-04-19 19:33:11 -07:00
Anders F Björklund
19be5619d6
Resource limits seem to work ok when not rootless
2020-04-19 09:45:16 +02:00
Anders F Björklund
024cd6b108
Use the same kind of named /var mount for podman
...
The internal anonymous mounts do not seem to have the same
issues as the external path mounts, so we can do all of /var
2020-04-19 09:45:16 +02:00
Anders F Björklund
8987b1067a
Also persist the kubelet and the cni state dirs
2020-04-19 09:45:16 +02:00
Anders F Björklund
223424652c
Also create and mount the container runtime dirs
2020-04-19 09:45:16 +02:00
Anders F Björklund
df3aec6b0a
Missed to wrap one podman inspect in sudo proper
2020-04-19 09:45:16 +02:00
Anders F Björklund
f57faf8036
Only remount the /var/lib/minikube directory
2020-04-19 09:45:16 +02:00
Anders F Björklund
22aa1aff22
Handle more state and status for the podman driver
2020-04-19 09:45:16 +02:00
Anders F Björklund
f264ac171e
Remove extra single-quotes from format parameter
...
podman
Error: template parsing error: template: image:1: function "json" not defined
2020-04-19 09:42:17 +02:00
Anders F Björklund
d7dc7bf7b2
The podman driver should not be run as root
...
Use sudo for the podman commands instead
Wrap the docker commands with env prefix
2020-04-19 09:42:17 +02:00
Medya Ghazizadeh
825ba532d1
Merge pull request #7603 from alonyb/w/add-registery-addon
...
Add registry addon feature for docker on mac/windows
2020-04-17 19:50:43 -07:00
Alonyb
bfa45ef79a
delete unnecesary func
2020-04-16 19:49:26 -05:00
Medya Gh
891e7a6520
spell
2020-04-16 16:53:04 -07:00
Medya Gh
bf15f9a00c
fix build err
2020-04-16 16:20:04 -07:00
Medya Gh
934f900f16
improve kic start and kill
2020-04-16 16:10:44 -07:00
Medya Gh
1c125e78da
address review comments
2020-04-15 10:17:23 -07:00
Alonyb
62904e5dcc
fix lint
2020-04-15 09:30:10 -05:00
Medya Gh
34fafc783f
fine tune
2020-04-14 22:20:28 -07:00
Medya Gh
29280ceff6
lint
2020-04-14 21:33:21 -07:00
Medya Gh
7303ccf07d
lint
2020-04-14 21:31:12 -07:00
Medya Gh
54aa958f01
use oci to delete
2020-04-14 20:51:18 -07:00
Medya Gh
b2bcd9a5cb
allow SSH commands to run in kic driver
2020-04-14 20:26:10 -07:00
Medya Gh
f22a36332e
add shut down to stop
2020-04-14 20:21:40 -07:00
Medya Ghazizadeh
b913981fd9
Merge pull request #7658 from medyagh/kic_apparmor
...
unconfine apparmor for kic
2020-04-14 19:39:35 -07:00
Medya Gh
d4b48e1e05
clean up after test dirs
2020-04-14 19:33:26 -07:00
Medya Gh
b7f0bfc369
unconfine apparmor for kic
2020-04-13 16:44:17 -07:00
Ruben Baez
d372027b03
Merge pull request #4 from alonyb/patch-1
...
documentation
2020-04-10 20:11:42 -05:00
Alonyb
201a2bbc62
remove driver and use clusterConfig
2020-04-10 18:50:57 -05:00
Alonyb
c4ef1b3798
add return port logic
2020-04-10 14:46:31 -05:00
Alonyb
50c2ec4eaf
add oci port mapping of registery
2020-04-10 08:20:12 -05:00
Medya Gh
4dd2152fae
update crio version in kicbase
2020-04-10 01:42:58 -07:00
Medya Gh
1eb6ce1710
build error
2020-04-09 21:56:00 -07:00
Medya Gh
e7e9f3ca1c
address review comments
2020-04-09 21:50:09 -07:00
Medya Gh
983808f956
lint
2020-04-09 21:01:49 -07:00
Medya Gh
f7f04a83c2
add killing apiserver proc to both kic and none
2020-04-09 20:53:15 -07:00
Medya Gh
ded8273a2e
add kill containers to kic stop
2020-04-09 20:01:11 -07:00
Priya Wadhwa
3a12fbd1f5
Fix spelling
2020-04-09 10:50:20 -07:00
Thomas Strömberg
6d05265a2e
Merge pull request #7539 from tstromberg/openrc
...
none: Add support for OpenRC init (Google CloudShell)
2020-04-09 04:55:57 -07:00
Thomas Strömberg
a37ec2ecd7
Merge pull request #7189 from Hellcatlk/UnitTest
...
add unit test for pkg/drivers/hyperkit/iso.go
2020-04-09 04:22:58 -07:00
Thomas Stromberg
16a8c38682
none: Add support for OpenRC init (Google CloudShell)
2020-04-08 18:20:30 -07:00
Priya Wadhwa
70329bf51d
Code review comments
2020-04-08 13:44:04 -07:00
Priya Wadhwa
accba6aa7f
code review comments
2020-04-07 15:00:28 -07:00
Priya Wadhwa
b509d69182
Extract preloaded tarball as soon as minikube volume is created
...
Extracting preload currently takes 6 seconds. This PR begins preload extraction as soon as the minikube volume is created, and runs it in parallell with creating the container node and setting up SSH.
This shaves 2-3 secnods off of `node.StartHost`
2020-04-07 14:19:20 -07:00
Medya Gh
a0263c2513
adjust more
2020-04-03 20:59:03 -07:00
Medya Gh
a62d611e0b
adjust kill time
2020-04-03 20:59:03 -07:00
Medya Gh
8f51d7de58
adjust warn if slow for ps and volume
2020-04-03 20:59:03 -07:00
Thomas Strömberg
37a98106c4
Merge pull request #7382 from tstromberg/stderr-fix3
...
Move errors and warnings to output to stderr
2020-04-02 14:36:16 -07:00