Commit Graph

2053 Commits (740ee60b5ff5955476e16fbb893fe2a6f80ea0ea)

Author SHA1 Message Date
tstromberg 3f6d9bbf18 Use sudo to get kubelet logs: required by permissions on v1.5 ISO 2019-10-16 10:22:38 -07:00
Medya Gh 74b7054b4a fixing logs 2019-10-15 12:59:51 -07:00
Medya Gh aace212e15 fix unit test, remove mount fake runner 2019-10-14 15:49:11 -07:00
Josh Woodcock 88ea55df49 Performance and security enhancment for ingress-dns addon 2019-10-13 18:04:06 -05:00
Medya Gh 390992571f fix more stuf 2019-10-12 03:12:51 -07:00
Marcin Niemira 3dff822e8b
remove single test due to discussion on GH 2019-10-12 12:43:59 +11:00
Marcin Niemira 780112fc39
Merge branch 'master' of github.com:kubernetes/minikube into improve-machine-test-coverage 2019-10-12 12:37:06 +11:00
Marcin Niemira b237471a17
add some tests to translate pkg 2019-10-12 12:27:38 +11:00
Marek Schwarz d13f58fc3b Merge branch 'master' into DELETE_ALL_PROFILES 2019-10-11 23:04:23 +02:00
Medya Gh eac02204d9 add unit test for cmdToStr 2019-10-11 13:11:15 -07:00
Medya Gh c71b6775d6 fix more commands to bin bash 2019-10-11 00:25:01 -07:00
RickyRajinder 96edacc0a9 Changed command runner
Fixed test

Print error message

Change minikube running check to after check if exists

Updates Set and adds test for disabling

Fix action for minikube not running

Fix import order
2019-10-11 00:09:28 -07:00
Medya Gh 466123aceb fix some lint nad test 2019-10-10 13:45:59 -07:00
Thomas Strömberg 63f1a3ae27
Merge pull request #5593 from sharifelgamal/k8s-1.16.1
Update default Kubernetes version to 1.16.1
2019-10-10 13:40:26 -07:00
Sharif Elgamal 18966680a6 update kubeadm_test with new k8s version 2019-10-10 13:25:51 -07:00
Sharif Elgamal 2cbe4f7b71 Update default Kubernetes version to 1.16.1 2019-10-10 13:01:02 -07:00
Marek Schwarz ae731d4393 Merge branch 'master' into DELETE_ALL_PROFILES 2019-10-10 21:22:45 +02:00
Marek Schwarz a0c844e07e Refactor 2019-10-10 21:22:17 +02:00
Medya Gh f8b38d2e22 Merge remote-tracking branch 'upstream/master' into NewCmdRunner 2019-10-10 12:08:44 -07:00
Thomas Strömberg d591d81bad
Merge branch 'master' into w/upgrade-linter 2019-10-10 09:37:56 -07:00
Medya Gh fcf17fb42f bin bash all the way 2019-10-10 09:23:26 -07:00
Medya Gh 57ac160f9f move everything to RunCmd 2019-10-10 00:03:45 -07:00
Medya Gh 7109b22249 refactor more 2019-10-09 16:06:13 -07:00
Cornelius Weig c00d8b37c8 Fix issues found by new linter version 2019-10-09 22:42:17 +02:00
Nanik T 733f7bc3f3 Move the non-found-service test into separate function and modify the error text to include service name 2019-10-10 07:13:47 +11:00
Medya Ghazizadeh c0e51aa37b
Merge pull request #5566 from nanikjava/f-fix-4963
Use configured DNS domain in bootstrapper kubeadm templates
2019-10-09 11:50:46 -07:00
Thomas Strömberg db4ef8c714
Merge pull request #5508 from pucheGit/douga-termstyledetection
Adjusted Terminal Style Detection
2019-10-09 11:30:44 -07:00
Medya Gh 79e65c1b44 fix 2019-10-08 19:23:05 -07:00
Medya Gh da5cae6af0 shellquoting more 2019-10-08 18:31:02 -07:00
Medya Gh 83f736d9ff fix unit test for cert 2019-10-08 17:33:19 -07:00
Medya Gh 25e3d870e5 fixing with shelquote 2019-10-08 17:08:38 -07:00
Medya Gh 91618aa38b get rid of ExecCmd all the way 2019-10-08 15:13:54 -07:00
Sharif Elgamal 4ba549a18a
Merge pull request #5487 from n0npax/improve-notify-test-coverage
Improve notify test coverage
2019-10-08 13:24:37 -07:00
Medya Gh 927146361c get rid of ExecCmd2 2019-10-08 13:10:37 -07:00
Medya Gh b8181a081f move more to exec.Cmd2 2019-10-08 11:39:10 -07:00
Nanik T 2be877840c Use configured DNS domain in bootstrapper kubeadm templates
Fixes #4963

Following are the file changes:

kubeadm.go --> Add DNSDomain as one the field
kubeadm_test.go --> Add new test case to test the dns changes
templates.go --> Add the new DNSDomain into the template

Add new testdata for the kubeadm_test.go
2019-10-08 19:30:10 +11:00
Medya Ghazizadeh da8500a43f
Merge pull request #5492 from laozc/kubelet-systemd-perm
Change systemd unit files perm to 644
2019-10-07 22:46:37 -07:00
Medya Gh 0c435b050b fix unit test for cert 2019-10-07 22:43:07 -07:00
Medya Gh a78deab26f adding a new ExecCmd2 2019-10-07 22:23:23 -07:00
Nanik T 75ce59d500 Fix linting 2019-10-08 10:12:35 +11:00
Nanik T 197215f85d Make error message more human readable
Changes made:
* service.go - changes to the error string returned
* service_test.go - modify TestWaitAndMaybeOpenService test case to accomodate
for the new changes
2019-10-08 09:02:43 +11:00
Medya Gh 8fcdae926e refactor 2019-10-06 22:06:29 -07:00
Medya Gh 9df56183fd fix fakerunner runcmd unit test 2019-10-06 19:17:36 -07:00
Medya Gh 7709c77c8b fix formatting 2019-10-06 17:07:54 -07:00
Marek Schwarz c4107aeece Merge branch 'master' into DELETE_ALL_PROFILES 2019-10-06 14:22:05 +02:00
Medya Ghazizadeh 63497aa383
Merge pull request #5507 from woodcockjosh/add-dns-ingress-addon
Add ingress-dns addon
2019-10-05 19:49:59 -07:00
Medya Gh 46442073e9 improve error wrap 2019-10-04 13:07:29 -07:00
Medya Gh c7af9e78fa remove extra error wrap 2019-10-04 12:57:21 -07:00
Medya Gh 36de216aa6 fixing fake_runner for interface 2019-10-04 12:51:18 -07:00
Medya Gh 27321d5f33 add ExecCmd and convert kubeadm,cert to new interface 2019-10-04 10:55:51 -07:00
Medya Gh 2f276e27ef fix format type 2019-10-03 15:39:48 -07:00
Marek Schwarz 0c9cd491ce Replaced driver "hyperkit" by "virtualbox" in testfiles
Removed debug code
2019-10-03 22:33:24 +02:00
Marek Schwarz b8abe562b3 Added more debug code 2019-10-03 22:20:47 +02:00
Marek Schwarz ee97b87ef9 Added debug code 2019-10-03 21:31:28 +02:00
Marek Schwarz ae6f47d562 Appended "/.minikube" to testMinikubeDir for machine_test 2019-10-03 21:21:48 +02:00
Marek Schwarz 8a4b3b942f Added more debug code 2019-10-03 18:41:49 +02:00
Marek Schwarz 280e11880d Merge branch 'master' into DELETE_ALL_PROFILES
Explicitly unset viper MachineProfile in machine_test
2019-10-03 18:32:36 +02:00
Marek Schwarz 1efdf11abb Merge branch 'master' into DELETE_ALL_PROFILES 2019-10-03 12:02:59 +02:00
Marcin Niemira e73c104955
add requested comment 2019-10-03 15:30:31 +10:00
Marcin Niemira c20fe509e3
revert filepath.Join due to discussion on GH 2019-10-03 15:25:22 +10:00
Doug A 58825d4492 Corrected Formatting Issue
Missing space.
2019-10-02 20:45:16 -04:00
Medya Gh eaa01716ea move unit tests from util to command_runner 2019-10-02 15:56:21 -07:00
Medya Gh 88183240ca move teePrefix from util to ssh_runner 2019-10-02 15:09:42 -07:00
Medya Gh 809389c8d6 implementing new interface RunCmd for exec_runner & fake_runner 2019-10-02 14:29:14 -07:00
Marcin Niemira 5f1f109691
run goimports 2019-10-02 20:27:30 +10:00
Marcin Niemira eff9be260f
remove unix specific files from tests 2019-10-02 18:30:08 +10:00
Marcin Niemira 079e9d75b9
fix review comments 2019-10-02 18:01:48 +10:00
Marcin Niemira f0eb90d941
typofix 2019-10-02 17:52:31 +10:00
Marcin Niemira a99d6e9345
msg improvement 2019-10-01 23:54:25 +10:00
Marcin Niemira 8d95d98348
self review fixes 2019-10-01 23:51:40 +10:00
Marcin Niemira e3a84f5f60
add boilerplate 2019-10-01 23:46:07 +10:00
Marcin Niemira 6ef1ee3e17
improve test coverage in machine 2019-10-01 23:45:22 +10:00
Josh Woodcock 22cfacee29 Add ingress-dns addon 2019-10-01 04:55:16 -05:00
Doug A c9765993c9 Adjusted Terminal Style Detection
Added check for COLORTERM environment variable.
2019-10-01 00:57:55 -04:00
Zhongcheng Lao 4ab0834309
Change systemd unit files perm to 644
systemd complains about the conf file is not world-inaccessible

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-29 23:47:49 +08:00
Marcin Niemira a4da6a3e05
improve error msg 2019-09-29 22:55:40 +10:00
Zhongcheng Lao f43690c92f
Fixes repository for storage-provisioner
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-29 09:07:56 +08:00
Marek Schwarz 3396f5b8ab Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-28 14:46:36 +02:00
Marcin Niemira b4a647464b
Merge branch 'master' of https://github.com/kubernetes/minikube into improve-notify-test-coverage 2019-09-28 20:34:55 +10:00
Zhongcheng Lao a92493b800
Remove constant to make test happy
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-28 13:25:12 +08:00
Zhongcheng Lao d891526cc0
Moves runtime constants to kubeadm package
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-28 12:27:46 +08:00
Zhongcheng Lao baf0ba31ab
Rename config file const
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-28 12:26:06 +08:00
Zhongcheng Lao 630dba3af1
Merge remote-tracking branch 'origin/master' into crio-containerd-image-repo 2019-09-28 12:23:20 +08:00
Marek Schwarz 4551a17178 Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-27 18:28:07 +02:00
xichengliudui 7ebef128f3 Remove the redundant code in util.go
update pull request
2019-09-27 09:35:59 +08:00
Y.Horie 291b60b4b7 move DefaultWait,DefaultInterval to service #5375 2019-09-27 07:59:46 +09:00
Y.Horie ea60470a6c Move ConfigFile var into localpath #5375 2019-09-27 07:59:46 +09:00
u5surf 32cae3b739 Add copyrights new file #5375 2019-09-27 07:59:46 +09:00
u5surf 8bae58695b Move GithubMinikubeReleasesURL into notify #5375 2019-09-27 07:59:46 +09:00
u5surf 668146d102 Move guest constants to vmpath package #5375 2019-09-27 07:59:46 +09:00
yugo horie 878c3ca2b6 WIP: Remove all single-package constants from constants package #5375 2019-09-27 07:59:46 +09:00
Medya Ghazizadeh d24b337ffa
Merge pull request #5460 from tstromberg/vmx-sol
Add solution for VERR_VMX_MSR_ALL_VMX_DISABLED
2019-09-26 15:02:11 -07:00
Thomas Strömberg fedb06a450
Merge pull request #5466 from sharifelgamal/initial-translations
Initial translations for fr, es, de, ja, and zh-CN
2019-09-26 12:00:41 -07:00
Marek Schwarz e8c997d573 Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
2019-09-26 19:27:33 +02:00
Thomas Strömberg 6d58c180da
Merge pull request #5422 from afbjorklund/reportcard-1.4
Improve reportcard
2019-09-26 09:59:50 -07:00
Sharif Elgamal 9ab993da17
Initial translations for fr, es, de, ja, and zh-CN 2019-09-25 18:32:22 -07:00
Zhongcheng Lao e1a61e9910
Use switch over if-else
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-26 08:35:18 +08:00
Zhongcheng Lao b8b5065119
Adds new function descriptions
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-26 08:33:17 +08:00
Marek Schwarz 47ec8d3431 Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-25 20:43:03 +02:00
Marek Schwarz 3ec82dd00d Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
2019-09-25 20:42:33 +02:00
tstromberg d425ce1038 Add message for VERR_VMX_MSR_ALL_VMX_DISABLED 2019-09-25 09:34:39 -07:00
Marcin Niemira 7585bcafa8
rm old comment 2019-09-25 22:55:28 +10:00
Thomas Strömberg f8c9f4810e
Merge pull request #5441 from hwdef/fix-typo
Fix a variety of spelling mistakes and typos
2019-09-25 22:53:50 +10:00
Zhongcheng Lao e6986aa943
Do not pass all the kubernetes config to runtime
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-25 08:13:04 +08:00
Zhongcheng Lao 08161722b0
Adds PauseImage to get pause image names
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-25 08:12:32 +08:00
Zhongcheng Lao 29a3d27247
Fixes format 2019-09-24 23:53:22 +08:00
Zhongcheng Lao f3e245a862
Fixes containerd runtime not working with image repository flags
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-24 23:31:58 +08:00
Zhongcheng Lao 0306a8bd6f
Fixes CRI-O runtime not working with image repository flags
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-24 23:31:36 +08:00
Thomas Strömberg 8e138a7eea
Merge pull request #5441 from hwdef/fix-typo
Fix a variety of spelling mistakes and typos
2019-09-24 06:42:36 -07:00
Thomas Strömberg 63135f7189
Merge pull request #5443 from yuxiaobo96/minikube-update
registry /  go9p: Correct grammar and spelling in comments
2019-09-24 06:41:24 -07:00
Thomas Strömberg 5a1c296327
Merge pull request #5445 from n0npax/improve-out-test-coverage
Improve out test coverage
2019-09-24 06:40:00 -07:00
Thomas Strömberg b75d4abc16
Merge pull request #5363 from woodcockjosh/add-helm-addon
Add helm-tiller addon
2019-09-24 06:37:29 -07:00
yuxiaobo 7f1cb86734 Correct grammar and words 2019-09-24 17:49:02 +08:00
hwdef bfc26bbdf0 fix spelling mistake 2019-09-24 11:18:53 +08:00
Thomas Strömberg fb34a99415
Merge pull request #5427 from woodcockjosh/fix-node-internal-ip
Fix node InternalIP not matching host-only address
2019-09-23 12:48:15 -07:00
Josh Woodcock dba30af5e6 Rename helm addon to helm-tiller 2019-09-23 13:15:38 -05:00
Thomas Strömberg 213f93d6b6
Merge pull request #4980 from blueelvis/4459-delete-even-if-vm-doesnt-exist
Fix crash when deleting the cluster but it doesn't exist
2019-09-23 11:05:38 -07:00
Marcin Niemira ff1b7433b0
add header 2019-09-22 21:15:51 +10:00
Marcin Niemira dbae7f1342
Add tests for style.go 2019-09-22 21:15:00 +10:00
Pranav Jituri b14d83feaa
Fixed build error
Gofmt
2019-09-22 01:58:48 +05:30
Josh Woodcock 19adebd05f Fix node InternalIP not matching host-only address 2019-09-21 14:33:26 -05:00
Marek Schwarz 5cabb01a4f Removed certs 2019-09-21 14:55:24 +02:00
Marek Schwarz 42c017f5d6 Readded testdata 2019-09-21 14:47:02 +02:00
Marek Schwarz 02bea609cf Readded testdata 2019-09-21 14:45:48 +02:00
Marek Schwarz 79e8250da4 Use localpath 2019-09-21 14:39:35 +02:00
Marek Schwarz 01dd044b6f Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
#	pkg/minikube/config/profile.go
2019-09-21 14:19:13 +02:00
Anders F Björklund 67c7a7a81c Reduce cyclometric complexity by refactoring
19 cmd generateCfgFromFlags cmd/minikube/cmd/start.go:711:1
19 cmd runStart cmd/minikube/cmd/start.go:257:1
18 hyperkit (*Driver).Start pkg/drivers/hyperkit/driver.go:202:1
17 cmd runDelete cmd/minikube/cmd/delete.go:53:1
16 registry TestRegistry pkg/minikube/registry/registry_test.go:39:1
2019-09-21 09:24:39 +02:00
Anders F Björklund 869c08a5bc Address some minor comment issues raised by golint 2019-09-21 09:24:35 +02:00
Thomas Strömberg 35f45d1930
Merge pull request #5356 from n0npax/improve-storageclass-test-coverage
Improve storageclass test coverage
2019-09-20 15:29:00 -07:00
Thomas Strömberg 11af1a394b
Merge pull request #5409 from serhatcetinkaya/master
Remove all functions from constants.go
2019-09-20 15:27:03 -07:00
Marcin Niemira af5005a8ab
rm coverage.out 2019-09-20 22:22:00 +10:00
Marcin Niemira 6008ee6c88
Merge branch 'master' of https://github.com/kubernetes/minikube into improve-storageclass-test-coverage 2019-09-20 22:19:42 +10:00
Marcin Niemira 8b3aef88e3
refactor pkg due to CR 2019-09-20 22:08:35 +10:00
Thomas Strömberg 3e2958d7f4
Merge pull request #5283 from n0npax/improve-sshutil-test-coverage
improve test coverage for sshutil package
2019-09-19 13:59:21 -07:00
Thomas Strömberg db6a6119f9
Merge pull request #5258 from n0npax/improve-service-test-coverage
improve test coverage in service pkg
2019-09-19 13:45:59 -07:00
serhatcetinkaya dfa3ab0e4e goimports-ed bootstrapper.go 2019-09-19 23:45:07 +03:00
serhatcetinkaya f2d028c239 resolve circular import problem 2019-09-19 23:34:28 +03:00
serhatcetinkaya f539ce991e resolve conflicts in start.go by accepting current changes 2019-09-19 23:34:21 +03:00
serhatcetinkaya b9b317e594 removed unnecessary Get prefix 2019-09-19 23:31:52 +03:00
serhatcetinkaya d591951b4f moved constants.GetKubernetesReleaseURL and constants.GetKubernetesReleaseURLSHA1 to cache_binaries.go 2019-09-19 23:31:52 +03:00
serhatcetinkaya 5bb002d826 replaced constants.TunnelRegistryPath with tunnel.RegistryPath 2019-09-19 23:31:52 +03:00
serhatcetinkaya 3b2985a6a3 resolve conflicts in constants.go by accepting incoming changes 2019-09-19 23:28:36 +03:00
serhatcetinkaya 20a439de02 replaced constants.GetMinipath() with localpath.MiniPath() 2019-09-19 23:28:20 +03:00
serhatcetinkaya 204a444408 localpath package added 2019-09-19 23:28:20 +03:00
Thomas Strömberg bac18e23ec
Merge branch 'master' into addons-update2 2019-09-19 10:20:55 -07:00
Thomas Strömberg 67be861579
Merge pull request #5401 from tstromberg/not-found3
Remove duplicate handling of driver conflict, handle driver not-found…
2019-09-19 09:53:49 -07:00
Marek Schwarz 71a6cb5434 Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-19 17:14:31 +02:00
Thomas Stromberg 43a0d03562 Update image cache to addon-manager 9.0.2 2019-09-18 21:45:08 -07:00
Thomas Stromberg b3c3ca55a5 Add new dashboard assets 2019-09-18 21:42:18 -07:00
Thomas Stromberg 6bd89789c0 Upgrade dashboard to 2.0.0b4 2019-09-18 17:23:42 -07:00