Commit Graph

492 Commits (73e9f09f6b04876c5a37d7e39b47e3cbd88fc21f)

Author SHA1 Message Date
Priya Wadhwa 15088526cd clean up comments 2020-06-04 11:05:52 -07:00
Priya Wadhwa 7dfea631d4 Refactor downloading kic base image 2020-06-04 10:48:38 -07:00
Medya Gh 488e2003f4 fix image digest 2020-05-29 12:19:59 -07:00
Medya Gh bc8c3faf86 add docker hub fall back image 2020-05-29 11:55:21 -07:00
Anders F Björklund 14937e4677 Never use docker inspect, always provide the type
Should avoid errors like: map has no entry for key "State"

When inspecting a volume, rather than a container or image
2020-05-21 17:20:53 +02:00
Medya Ghazizadeh afab7c87c6
Merge pull request #7959 from afbjorklund/podman-prompt
Use noninteractive sudo when running podman
2020-05-11 21:02:22 +00:00
Medya Ghazizadeh d2ae2b35a0
Merge pull request #8057 from afbjorklund/podman-tar
Don't run the extraction tar container for podman
2020-05-11 19:22:48 +00:00
Medya Ghazizadeh 6b97ee8ee2
Merge pull request #8001 from afbjorklund/podman-start
podman: Wrap the start command with cgroup manager too
2020-05-11 17:59:39 +00:00
Anders F Björklund c578a7aa1e Add a PointToHost function for podman as well
And add an active variable, similiar to docker
2020-05-10 23:07:12 +02:00
Medya Ghazizadeh 7e3da0f8b0
Merge pull request #8017 from elegos/podman-volumes-extract-tarball-to-volume
Podman: disable selinux labels when extracting the tarball (permissions error)
2020-05-09 21:35:43 +00:00
Anders F Björklund cac41495cf Don't run the extraction tar container for podman
The preloaded images will be extracted anyway, using ssh.

But if creating them on the volume before the container is
booted, means that /var will not be fully copied over to it.
And without /var/lib/dpkg and others, kicbase will not boot.
So skip the parallel extraction for podman, do it afterwards.

Probably shouldn't mount all of /var, but just a sub-set...
2020-05-09 18:36:56 +02:00
Anders F Björklund 46025eccf5 Use the runCmd wrapper for start to not miss error 2020-05-09 14:07:18 +02:00
Anders F Björklund ac01e92012 Add comment about why podman looks at runtime.GOOS 2020-05-09 14:05:57 +02:00
Anders F Björklund a7a5148ff6 Don't add cgroup manager param for podman-remote
Since it doesn't work for either "run" or "start"

	Error: unknown flag: --cgroup-manager
2020-05-09 14:04:04 +02:00
Anders F Björklund 85fae62d4a Wrap the start command with cgroup manager too
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
Anders F Björklund 934ad06a82 Use noninteractive sudo when running podman
To avoid asking for a password in the middle of minikube commands.

The setup process is supposed to involve adding podman to sudoers...
2020-05-09 13:23:46 +02:00
Priya Wadhwa ba267702af Merge branch 'master' of https://github.com/kubernetes/minikube into embed-certs 2020-05-08 12:38:02 -07:00
Thomas Stromberg 436cee2d84 Fix minikube/kubernetes capitalization, make short help consistent 2020-05-07 14:12:10 -07:00
Priya Wadhwa 163ab88408 Restart kubelet in a function that is called on soft start 2020-05-07 13:22:09 -07:00
Priya Wadhwa a353d564dd Add comments 2020-05-07 13:03:07 -07:00
Priya Wadhwa c037a97392 Restart kubeadm on soft `minikube start`
This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different.

This should fix the embed-certs integration test which has been flaky for a while.
2020-05-07 12:59:55 -07:00
Giacomo Mr. Wolf Furlan 9c43c47b06 Podman: disable selinux labels when extracting the tarball to prevent permission errors 2020-05-07 02:09:09 +02:00
Medya Gh 7914d057d1 fall back to github if gcr.io is not available 2020-05-04 13:12:50 -07:00
Medya Ghazizadeh 6eeb929b3d
Merge pull request #7962 from afbjorklund/podman-gateway
Get the gateway by inspecting container network
2020-05-04 20:05:56 +00:00
Medya Ghazizadeh 1da92a1c84
Merge pull request #7961 from afbjorklund/podman-preload
Use the correct binary for unpacking the preload
2020-05-04 20:04:19 +00:00
Medya Ghazizadeh e0685c8f5d
Merge pull request #7984 from medyagh/detect_windows_container
Detect windows container and exit with instructions
2020-05-04 20:01:17 +00:00
Anders F Björklund cc6506d2c9 Remove logging statement from containerGateway 2020-05-03 09:42:32 +02:00
Medya Gh bcecda8e20 add comment for error type 2020-05-02 18:48:52 -07:00
Medya Gh 2102a20605 wrap errors 2020-05-02 18:38:23 -07:00
Medya Gh 4572d0634f exit with usage if container type is windows 2020-05-02 18:29:33 -07:00
Medya Gh ee9004f93b add os type to DaemonInfo 2020-05-02 17:02:19 -07:00
Anders F Björklund 743f9f7efc Don't show any podman hint about restarting sudo 2020-05-01 22:21:32 +02:00
Anders F Björklund e2d7d94dfc Use the correct binary for unpacking the preload
Previously hardcoded to *always* use a Docker volume,
even if using a different container driver (podman).
2020-05-01 22:11:28 +02:00
Anders F Björklund 3531efda7b Get the gateway by inspecting container network 2020-05-01 15:05:21 +02:00
Thomas Strömberg 7b39b102d6
Merge pull request #7930 from sharifelgamal/cni
Automatically apply CNI on multinode clusters
2020-04-29 09:14:38 -07:00
Thomas Strömberg dee6d518ce
Merge pull request #7631 from afbjorklund/podman-sudo
Add "sudo" to podman calls
2020-04-29 08:53:41 -07:00
Thomas Strömberg 2f78bff4ed
Merge pull request #7858 from priyawadhwa/upgrade-kic
Upgrade docker driver base image to v0.0.10
2020-04-29 08:48:45 -07:00
Anders F Björklund 78a22f5056 Remove prefix parameter and add prefix command
Move the "sudo" prefix to a central location, instead of
having it all over the place. Assume only needed on Linux.
2020-04-28 13:52:52 +02:00
Sharif Elgamal 5848bbe011 Merge branch 'master' of github.com:kubernetes/minikube into cni 2020-04-27 14:15:19 -07:00
Sharif Elgamal 228c1b092c automatically apply kic overlay when detecting multinode clusters 2020-04-27 14:15:12 -07:00
Anders F Björklund 1744ffe773 Restore the configured state added for podman
Reverted 22aa1aff22 by accident
2020-04-27 22:27:53 +02:00
Priya Wadhwa 2459caea75 update SHA 2020-04-27 10:47:10 -07:00
Anders F Björklund 998ab840fb Use simple version of podman info format parameter
So that it works with the older versions of podman
2020-04-26 22:54:45 +02:00
Anders F Björklund 795128131f Remove old Copy function added in merge conflict 2020-04-26 22:52:10 +02:00
Anders F Björklund 28106fa2d7 Use constants instead of the KIC prefix strings 2020-04-26 15:22:57 +02:00
Anders F Björklund 88c8a24d55 Pass the container implementation on to systemd 2020-04-25 22:43:40 +02:00
Anders F Björklund 7185140c57 Remove extra quotes added in conflict resolution
Reverted f264ac171e by accident
2020-04-25 22:09:52 +02:00
Anders F Björklund 7647b1f998 Don't try to limit podman memory without cgroup
Podman requires both memcg and memcg_swap for it (--memory).

Docker will still limit memory, without swap limit support.
2020-04-25 22:01:51 +02:00
Anders F Björklund 6644c5cc64 Merge branch 'master' into podman-sudo 2020-04-25 18:05:33 +02:00
Medya Gh 63f9bfbb61
addres review comments 2020-04-24 14:07:54 -07:00