Commit Graph

2860 Commits (6f463931239d419b94b37e53f7304bdab5a64f2f)

Author SHA1 Message Date
Song Shukun 884c30a5f6 Fix: disable a disabled addon cause error 2020-02-27 19:21:08 +09:00
Jose Donizetti 7a6ff58384 kic on mac: improve error reporting service tunnel 2020-02-26 22:21:44 -03:00
Jose Donizetti 1752d7c004 kic on mac: add random port support to service cmd 2020-02-26 22:09:48 -03:00
Jose Donizetti 5f73506ff6 Remove old code 2020-02-26 20:51:36 -03:00
Jose Donizetti f390d4bf30 kic on mac: add service cmd support 2020-02-26 20:49:58 -03:00
Medya Ghazizadeh 3cf2c9bbe3
Merge pull request #6807 from medyagh/delete_hang
warn about "stuck docker"  in minikube delete
2020-02-26 14:32:18 -08:00
Medya Ghazizadeh 8f887a5e41
Merge pull request #6810 from josedonizetti/fix-kic-tunnel-known-hosts-issue
tunnel on docker driver on mac: fix known_hosts issue
2020-02-26 14:01:31 -08:00
Medya Gh 8d0c41392b continue instead of nest 2020-02-26 13:50:42 -08:00
Jose Donizetti a57a282027 kic: fix known_hosts issue 2020-02-26 18:27:24 -03:00
Medya Ghazizadeh 47012f724d
Merge pull request #6803 from medyagh/d_cpu_ram
Display more meaningful system info for kic Drivers
2020-02-26 12:47:37 -08:00
Medya Gh 4709af55df resolve review comments 2020-02-26 12:44:25 -08:00
priyawadhwa f77e942e59
Merge pull request #6701 from sshukun/increase-timeout
hyperv detection: increase timeout from 2s to 8s
2020-02-26 11:11:10 -08:00
Medya Gh e8c85543f7 limit time waiting for delete 2020-02-26 10:57:46 -08:00
Medya Gh 6651e0b5a5 docker podman sysinfo 2020-02-26 09:15:25 -08:00
Medya Gh f64b167c3b Display more meaninful system info for docker/podman driver 2020-02-25 18:08:53 -08:00
Medya Gh f3c171eaa3 show info for docker damemon 2020-02-25 17:34:03 -08:00
Medya Gh e60b034c84 Add Daemon Info func to oci 2020-02-25 17:16:49 -08:00
Medya Gh 9c7e5f4534 mark docker driver from experimental to fallback 2020-02-24 17:10:58 -08:00
Medya Ghazizadeh 946bdff626
Merge pull request #6279 from afbjorklund/image-arch
Add platform option when downloading images
2020-02-24 16:35:05 -08:00
Medya Ghazizadeh 0b316d9029
Merge pull request #6789 from josedonizetti/refactor-kic-tunnel-ignore-exit-error
kic tunnel avoid printing exit as error
2020-02-24 16:12:53 -08:00
Jose Donizetti 83a7bafbda Fix linter 2020-02-24 21:03:41 -03:00
Jose Donizetti c01ab3cd4c Add TODO kic tunnel 2020-02-24 20:51:10 -03:00
Jose Donizetti fc7b13aa06 Fix kic tunnel to avoid asking ssh permission 2020-02-24 20:48:33 -03:00
Jose Donizetti b0ea2fd4d7 kic tunnel avoid printing exit as error 2020-02-24 20:43:53 -03:00
Priya Wadhwa aefbf2cd18 Rebased on master 2020-02-24 13:41:06 -08:00
sayboras 2584457f05 Fix boilerplate 2020-02-25 08:15:19 +11:00
sayboras ff17e26b5b Fix typo detected by linter 2020-02-25 08:08:00 +11:00
Medya Ghazizadeh 5fe81c806d
Merge pull request #6460 from josedonizetti/kic-darwin-tunnel
WIP: kic darwin tunnel
2020-02-24 11:28:00 -08:00
Anders F Björklund 0b00ed7668 Add platform option when downloading images
For now, assume that all the containers will have the same
architecture as the current platform (minikube binary arch)
2020-02-23 14:18:39 +01:00
Medya Ghazizadeh c7f39fc13b
Merge pull request #6756 from medyagh/crio_kic
Add cri-o runtime to kic drivers and improve kic image
2020-02-22 19:33:03 -08:00
Medya Ghazizadeh d4f33edf61
Merge pull request #6760 from medyagh/metric_test
improve elevate permissions
2020-02-22 19:32:43 -08:00
Medya Ghazizadeh 727beb6893
Merge pull request #6744 from kppullin/docker-env-fish-fix
Generate fish compatible docker-env hint
2020-02-22 18:42:08 -08:00
Medya Gh 27eb4ef045 create cluster role bindnig smarter 2020-02-22 18:14:31 -08:00
Medya Gh 6100115374 add client 2020-02-22 17:11:07 -08:00
Medya Gh cbe0eed240 improve warnning for elevate 2020-02-22 16:57:57 -08:00
Medya Gh 665c7fc3a6 do not retry elevate 2020-02-22 16:55:25 -08:00
Medya Gh acfa0b4a77 enable cluster permissions for kic drivers as well 2020-02-22 16:49:25 -08:00
Medya Gh 5f8740a15e update kic sha 2020-02-22 15:41:12 -08:00
Medya Gh 988a1b983a fix sha format 2020-02-22 14:23:43 -08:00
Medya Gh 73c4c4c323 bump kic version to 7 2020-02-22 14:07:43 -08:00
Medya Gh 95402af363 bump kic version 2020-02-22 13:51:42 -08:00
Medya Gh 9b91ef7590 Add CIO-o runtime to kic drivers and improve kic image 2020-02-22 13:46:17 -08:00
Medya Ghazizadeh 9634132a42
Merge pull request #6745 from sharifelgamal/cpip
Specifying control plane IP in kubeadm config template
2020-02-22 11:00:27 -08:00
Anders F Björklund fa9f7f9794 Add comments to avoid warnings from go lint 2020-02-22 16:12:42 +01:00
sayboras ab8f1df30f Fix compiled issue 2020-02-22 17:51:39 +11:00
Sharif Elgamal fca51013a4 fix build error 2020-02-21 22:07:35 -08:00
Sharif Elgamal 81e9bcb753 Merge branch 'master' of github.com:kubernetes/minikube into cpip 2020-02-21 17:49:52 -08:00
Sharif Elgamal 32a5846659 Specifying control plane IP in kubeadm config template 2020-02-21 17:48:24 -08:00
Medya Ghazizadeh f31ec1bc1b
Merge pull request #6741 from sharifelgamal/clusterconfig
Change MachineConfig to ClusterConfig
2020-02-21 17:19:49 -08:00
Kevin Pullin 8d78c95aea Generate fish compatible docker-env hint
`fish`'s eval handling does not properly process multiple lines.

Instead the recommendation is to pipe the output to `source`.

This PR updates the usage hint of the `docker-env` command
when running on `fish`:

```
eval (minikube -p fish docker-env) => (minikube -p fish docker-env) | source
```

Ref: https://github.com/fish-shell/fish-shell/issues/3993
Signed-off-by: Kevin Pullin <kevin.pullin@gmail.com>
2020-02-21 17:11:43 -08:00
Medya Ghazizadeh 44e7cb20ac
Merge pull request #6717 from medyagh/annotate_node
label minikube nodes
2020-02-21 17:00:07 -08:00
Priya Wadhwa 8409fc3816 wait to finish downloading kic artifacts before starting machine 2020-02-21 16:19:00 -08:00
Sharif Elgamal 6e9cf2de2f Change MachineConfig to ClusterConfig 2020-02-21 16:09:05 -08:00
Priya Wadhwa dee885267b Don't require authentication to get checksum 2020-02-21 15:59:36 -08:00
Priya Wadhwa 97bf128703 only use preloaded volumes for docker runtime 2020-02-21 12:53:24 -08:00
Priya Wadhwa 328466f1e1 Check if preloaded volume is attached before skipping binary transfer 2020-02-21 12:41:33 -08:00
Tam Mach 1d0267f23c Fix unit test 2020-02-22 07:18:16 +11:00
Priya Wadhwa cc1a6f11f0 Delete volume if it isn't extracted properly so future runs don't try to use it 2020-02-21 12:13:34 -08:00
Priya Wadhwa c99bf76ee4 Add checksum verification 2020-02-21 12:03:31 -08:00
Medya Gh 6ffba941d3 lint 2020-02-21 09:55:32 -08:00
sayboras 4201bbcfe3 Address one simple linter error 2020-02-21 14:55:22 +11:00
Priya Wadhwa 86df9ffb2c Rebased on master 2020-02-20 16:20:54 -08:00
Priya Wadhwa dcbf242192 Add SHA as constant 2020-02-20 15:56:00 -08:00
Priya Wadhwa 94737b4a14 Add lz4 to kic base image and upgrade to v0.0.6 2020-02-20 15:53:09 -08:00
Priya Wadhwa 55dd40efc5 Debugging 2020-02-20 15:05:07 -08:00
Priya Wadhwa 5ac8520ab8 skip transferring binaries and transferring imagse if using preloaded volume 2020-02-20 14:59:43 -08:00
Priya Wadhwa b0f685c072 Move all preloading code into preload package 2020-02-20 14:43:24 -08:00
Medya Ghazizadeh 7fddd05bf5
Merge pull request #6630 from medyagh/mount_kic
add mount feature to kic drivers
2020-02-20 14:11:15 -08:00
Priya Wadhwa 19fa296625 Compress with lz4 2020-02-20 14:07:03 -08:00
Medya Gh a2be045f16 remove debugging 2020-02-20 14:01:04 -08:00
Medya Gh c85fe4955d Add integration tests for node labels 2020-02-20 13:57:09 -08:00
Medya Gh b62c12b7f2 label minikube nodes 2020-02-20 12:09:58 -08:00
Thomas Strömberg 38437b2fa4
Set timeout to an outrageous 8s, based on the bug 2020-02-20 11:16:58 -08:00
Priya Wadhwa 0e88697f16 Delete container once it has finished executing 2020-02-20 10:06:15 -08:00
Priya Wadhwa 055e4bb618 Add run to docker command 2020-02-20 09:57:19 -08:00
Priya Wadhwa 335637f4a3 Name tarball by k8s version name 2020-02-20 09:42:04 -08:00
Priya Wadhwa b8bc461157 Rebased on master 2020-02-20 09:18:12 -08:00
Song Shukun 96d992c8ca Increase detection timeout from 2s to 4s for hyperV 2020-02-20 17:24:51 +09:00
Medya Gh 30a38e5a9d wrap error 2020-02-20 00:07:36 -08:00
Medya Gh 4fe9ca5f05 break done delete and prune into two funcs better error handling 2020-02-20 00:07:36 -08:00
Medya Gh e1ffa5fb0f return error instead of logging 2020-02-20 00:07:36 -08:00
Medya Gh 354ff6256d improve comments 2020-02-20 00:07:36 -08:00
Medya Gh 6c94880149 dont list empty ones 2020-02-20 00:07:36 -08:00
Medya Gh d84aa9f447 lint 2020-02-20 00:07:36 -08:00
Medya Gh b1d139c24b code review comments 2020-02-20 00:07:35 -08:00
Medya Gh efd4aabde4 clean up containers first then delete volume 2020-02-20 00:07:35 -08:00
Medya Gh b235255196 fix volume clean up 2020-02-20 00:07:35 -08:00
Medya Ghazizadeh 8700f8a1e0
Merge pull request #6700 from medyagh/resource_limit
fix inverted logic for resource logic
2020-02-19 23:57:16 -08:00
Priya Wadhwa bb11bc666b Create volume of preloaded images and mount it in 2020-02-19 23:02:36 -08:00
Medya Ghazizadeh 0af5734bc9
Merge pull request #6696 from priyawadhwa/install-addons
Fix bug in --install-addons flag
2020-02-19 22:33:50 -08:00
Medya Gh 597798395f lint 2020-02-19 22:01:45 -08:00
Medya Gh 3a7041c3b2 add logging 2020-02-19 22:01:45 -08:00
Medya Gh d548eabdc6 added kic mount 2020-02-19 22:01:45 -08:00
Medya Gh ef0765609b remove duplicate code 2020-02-19 22:01:45 -08:00
Medya Gh 1ee08c7517 add funcs to get routable host ip from inside container 2020-02-19 22:01:45 -08:00
Priya Wadhwa d506aa18b4 Download preloaded images tarball with --download-only flag 2020-02-19 21:53:44 -08:00
Medya Gh ec7c6ba4fa fix inverted logic 2020-02-19 21:33:24 -08:00
Priya Wadhwa 5ad4d6ebf5 Fix bug in --install-addons flag
Respect --install-addons flag, don't install anything if it is false
2020-02-19 14:56:09 -08:00
Medya Ghazizadeh 98294b5ec1
Merge pull request #6693 from tstromberg/mount-try
Explicitly set TCP as the default 9p transmission method
2020-02-19 14:41:45 -08:00
Thomas Stromberg 58eaa66825 Explicitly set TCP as the default 9p transmission method 2020-02-19 12:56:00 -08:00
Sharif Elgamal 14af1fc14a
Merge pull request #6573 from wmuizelaar/bump-gvisor
Update gvisor runsc version
2020-02-19 11:50:54 -08:00
Thomas Strömberg f08f325d83
Merge pull request #6602 from tstromberg/v1.17.3
Bump default Kubernetes version to v1.17.3
2020-02-19 09:08:21 -08:00
Thomas Stromberg be1b471dea Address lint error 2020-02-18 10:16:01 -08:00
Thomas Stromberg a720355627 Merge branch 'sha256-checksum' of github.com:tstromberg/minikube into sha256-checksum 2020-02-18 08:32:12 -08:00
Jose Donizetti b201d4b5c9 Add glog logging 2020-02-18 13:29:56 -03:00
Medya Ghazizadeh 52c200a6cf
Merge pull request #6635 from medyagh/kic_volume
improve delete by labeling created docker volumes
2020-02-17 19:01:53 -08:00
Medya Gh 1da0a370ff code review comments 2020-02-17 10:55:53 -08:00
Jose Donizetti 2bfcb72b96 Remove not used code 2020-02-17 10:22:11 -03:00
Wietse Muizelaar 8691127c0a See if newer gvisor fixes the kvm build 2020-02-17 13:20:40 +01:00
Wietse Muizelaar 6077aa0146 Update gvisor runsc version 2020-02-17 13:20:40 +01:00
Medya Gh 3ce0164281 add logging for prune 2020-02-16 11:54:56 -08:00
Medya Ghazizadeh 625900e362
Merge pull request #6605 from tstromberg/copy-confusion
sync: Fix path confusion and directory creation bugs
2020-02-15 00:46:53 -07:00
Jose Donizetti b0d19e51b5 Refactor kic ssh tunnel 2020-02-14 21:01:32 -03:00
Jose Donizetti 08b0b654a0 Refactor PatchServicesIP 2020-02-14 13:01:43 -03:00
Jose Donizetti 073558e21e Add cleanup to kic tunnel 2020-02-14 12:43:26 -03:00
Medya Gh a007c0790c Delete volumes created by kic 2020-02-14 01:39:16 -08:00
Medya Gh a4ee4186bd create docker volumes explictily with a label 2020-02-14 01:01:53 -08:00
Medya Ghazizadeh f74c956701
Merge pull request #6625 from priyawadhwa/fail-fast
Fail fast if waiting for SSH to be available
2020-02-14 00:09:35 -07:00
tstromberg ccec3babb0 Merge conflict 2020-02-13 16:54:25 -08:00
tstromberg 9b1d2da478 Return an entire options struct 2020-02-13 16:50:53 -08:00
Priya Wadhwa 59abf60d7e reinsert comment 2020-02-13 16:30:38 -08:00
Priya Wadhwa 01039b2020 rebased on master 2020-02-13 16:20:24 -08:00
Sharif Elgamal ba9463d933 Stopped and running machines should count as existing 2020-02-13 16:15:00 -08:00
tstromberg 250e00564b Select the checksum algorithm based on Kubernetes version 2020-02-13 14:57:03 -08:00
Sharif Elgamal 6d8a112abe don\'t return that the machine doesn\'t exist if the k8s is stopped 2020-02-13 14:20:58 -08:00
Priya Wadhwa 8fc787bc20 Fail fast if waiting for SSH to be available
Integration tests were running long because we'd wait up to 22 minutes for SSH to succeed while creating the host. This commit introduces a two minute timer on creating the host. On my Macbook Pro with the docker driver, creating the host takes 5 seconds, so 2 minutes should be more than enough time.

Refer to #6608
2020-02-13 14:06:33 -08:00
tstromberg 8c2115b292 Bump constants back to v1.17.3 2020-02-13 12:39:40 -08:00
tstromberg 8a58274441 Merge conflict 2020-02-13 12:39:21 -08:00
tstromberg 2ee5c20a1d Merge branch 'master' into sha256-checksum 2020-02-13 11:56:08 -08:00
Thomas Stromberg 19695856ee Skip mkdir if there is no work to be done 2020-02-13 11:47:19 -08:00
Sharif Elgamal c1a3e4348d fix unit tests and fix merge conflicts 2020-02-13 10:30:12 -08:00
Sharif Elgamal 2785d292f5 Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-13 10:15:04 -08:00
Medya Ghazizadeh 4c6b435f68
revert docker volume host path (#6616) 2020-02-13 10:57:23 -07:00
Jose Donizetti 3f0fceb769 Add patch services 2020-02-13 11:36:25 -03:00
Tam Mach b911e8f038
Bump go-containerregistry to latest (#6073)
* Bump go-containerregistry to latest

Signed-off-by: sayboras <sayboras@yahoo.com>

* Fix integration for cache image
2020-02-13 02:20:32 -07:00
Sharif Elgamal 8c55c9ca60 holy crap cyclical import hell sucks 2020-02-12 18:34:44 -08:00
Thomas Strömberg f528df1f9a
Quote the node name to avoid YAML interpretation (#6606) 2020-02-12 19:15:23 -07:00
Medya Ghazizadeh 398c7ef00b
Add podman driver (#6515) 2020-02-12 19:11:44 -07:00
tstromberg c25b03cf13 Update test data 2020-02-12 15:36:04 -08:00
tstromberg 1f346e43e8 Remove unnecessary range arg 2020-02-12 15:20:58 -08:00
tstromberg 52eec8cf77 Add more tests 2020-02-12 15:12:02 -08:00
tstromberg 2313b72a7d sync: Fix path confusion and directory creation bugs 2020-02-12 14:26:38 -08:00
tstromberg bf6f8bc708 Use SHA256 for Kubernetes release checksums 2020-02-12 13:31:17 -08:00
tstromberg 71c072ae02 Bump default Kubernetes version to v1.17.3 2020-02-12 13:29:33 -08:00
priyawadhwa af353314e0
Separate cached kubernetes binaries by OS on host machine (#6586)
* Separate cached kubernetes binaries by OS on host machine

This way, all kubernetes binaries stored in ~/.minikube/cache/linux will be copied over to the VM and used for `minikube kubectl` on linux machines. kubectl will be stored in `~/.minikube/cache/{windows or darwin}` on windows/darwin so that `minikube kubectl` still works.

* Review comment

* Update integration test

* Make sure --download-only includes OS specific kubectl

Update integration test to make sure we download
OS specific kubectl on darwin/windows when using --download-only flag
2020-02-11 23:23:37 -07:00
Sharif Elgamal b427dc5663 fixed commands, they mostly work now 2020-02-11 21:11:22 -08:00
Sharif Elgamal 9830d91c09 linting nonsense 2020-02-11 18:39:59 -08:00
Sharif Elgamal adc1a56903 search and replace cleanup 2020-02-11 17:11:23 -08:00
Sharif Elgamal 744efaa330 REFACTOR COMPLETE? 2020-02-11 17:06:59 -08:00
Sharif Elgamal b6a429dc9d hey did you want more files? good 2020-02-11 15:45:49 -08:00