b983c47145
Merge branch 'master' into persistent
2019-08-14 08:12:25 -07:00
f17f3408a8
convert all RetryAfter to retry.Expo
2019-08-13 23:48:30 -07:00
e8824b76b2
Merge pull request #5052 from tstromberg/doc-redirect
...
Update code references to new documentation URL's
2019-08-12 18:26:01 -07:00
f2acb4a33e
Update code references to new documentation URL's
2019-08-12 14:51:41 -07:00
a817bffab1
Remove all minikube dependencies from drivers ( #4933 )
...
* Remove all minikube dependencies in driver code
* removing all default config
* okay we need some defaults
* code comments
* hyperkit builds now
* sleep for an appropriate amount of time
* remove constant in favor of string
* try goproxy for travis
* try goproxy for travis
* try goproxy for travis
* let's not try goproxy for now
* let's try goproxy once again
* maybe use the correct url for the proxy
* fix go mod
2019-08-12 14:42:11 -07:00
2f1a11d8d3
Move reusable files (images, binaries, certs) to /data
2019-08-09 15:04:07 -07:00
fdc3b39e49
lower case errors
2019-08-01 13:52:46 -07:00
1c8a655154
make none stop work on old systemd
2019-08-01 13:52:16 -07:00
c603300781
more reliable stop for none driver ( #4871 )
...
* more reliable stop for none driver
* print stop error
* better error logging
* misspell
* error formatting
* Passing lint interfacer nag
2019-07-25 13:19:21 -07:00
82d4c7dd2c
Merge pull request #4688 from kairen/better-comment
...
Add space after // comments
2019-07-11 11:53:15 -07:00
c5f695e8a0
Better comment syntax
2019-07-05 11:17:10 +08:00
99ac1a81e7
moving command runner to its own package
2019-07-04 16:31:07 -07:00
2aac268ba6
Merge pull request #4593 from josedonizetti/add-hyperkit-version
...
Add version to hyperkit driver
2019-07-01 14:38:30 -07:00
449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check
...
Added validation for start memory size
2019-06-30 15:17:28 -07:00
037e9a5d56
Merge pull request #4641 from josedonizetti/improve-kvm-connection-error-message
...
Improve kvm connection error message
2019-06-30 12:08:44 -07:00
4d00a093d1
Fix error naming convention
2019-06-29 11:28:54 -03:00
23ae121f2b
kvm2: simplify connection error message
2019-06-29 10:53:13 -03:00
4812761f05
Add gitCommitID to hyperkit version
2019-06-29 09:32:21 -03:00
931a0a557b
Add hyperkit version
2019-06-29 09:22:51 -03:00
7fe2247692
Improve hyperkit vm stop
2019-06-28 16:36:36 -07:00
9dfe660c64
Add support to custom qemu uri on kvm2 driver
2019-06-28 14:12:58 -07:00
8acf4824df
Add commit id to docker-machine-driver-kvm2 version
2019-06-28 13:45:54 -07:00
6222e74267
Add hyperkit doc
2019-06-28 13:44:15 -07:00
d6a839b20a
Fix kvm2 vm driver remove domain
2019-06-26 18:36:52 -07:00
380883dee3
Fix failing Hyperkit test
2019-06-26 01:45:12 +05:30
6ba1725c08
Added Memory Size Checking
2019-06-26 00:22:41 +05:30
c7bf1ce7cd
type check for drivers
2019-06-24 14:39:21 -07:00
f20f223c02
Decrease cyclomatic complexity
...
Here is the report (from gocyclo), before:
21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
2019-06-22 17:21:42 +02:00
02b8032b59
Merge pull request #4385 from josedonizetti/refactor-drivers-restart
...
Refactor: improve readability drivers.Restart
2019-06-21 08:07:35 +08:00
4610663674
Merge pull request #4398 from josedonizetti/add-kvm-version-flag
...
Add kvm2 --version
2019-06-20 07:41:18 +08:00
a2d844ef51
Add kvm network name validation
...
closes for #3581
2019-06-15 13:56:12 -07:00
a024c6d22a
Add kvm2 --version
2019-06-04 16:45:14 -03:00
6d57b28fdd
changing string driver name to checked type
2019-06-03 20:27:26 -07:00
0e633533c2
Refactor: improve readability drivers.Restart
2019-05-30 17:24:28 -03:00
986c61d15e
Fix kvm gpu log
2019-05-30 14:56:46 -03:00
dbc64c053b
Merge pull request #4355 from josedonizetti/fix-kvm-remove-when-domain-is-not-defined
...
Fix kvm remove when domain is not defined
2019-05-28 17:07:53 -07:00
dcb10332a0
Merge pull request #4334 from josedonizetti/refactor-kvm-lookup-status-ip
...
Refactor kvm lookupIPFromStatusFile
2019-05-28 10:26:02 -07:00
c09913070d
Fix kvm remove when domain is not defined
2019-05-25 09:23:40 -03:00
8f9a3f448d
Merge pull request #4344 from josedonizetti/fix-kvm-remove-when-domain-is-not-running
...
Fix kvm remove when domain is not running
2019-05-24 13:55:04 -07:00
bb56fd2eb7
Merge pull request #4323 from josedonizetti/fix-kvm-ensure-network
...
kvm2: Add support for --kvm-network to ensureNetwork
2019-05-24 10:47:41 -07:00
48237d95b8
Clean up kvm Remove code
2019-05-24 14:27:55 -03:00
b65c7403cf
Add error warp to destroyRunningDomain
2019-05-24 14:27:55 -03:00
3124f11e1b
Fix kvm remove when domain is not running
2019-05-24 14:27:55 -03:00
81f0d9ba37
Fix kvm remove warn message
2019-05-24 12:38:00 -03:00
1852a72caf
Refactor kvm lookupIPFromStatusFile
2019-05-23 15:38:02 -03:00
fc2e2e52c5
Skip kvm network deletion if private network doesn't exist
2019-05-23 06:17:12 -03:00
93329f1619
Remove obsolete comment
2019-05-22 17:25:27 -03:00
e3bf4bd7ec
Fix kvm ensureNetwork
2019-05-22 16:19:09 -03:00
e9a450df66
Validate kvm network exists
2019-05-21 16:19:15 -03:00
e53c0339ea
This is my testament to Chesterton's Fence
2019-05-15 11:44:16 -07:00
88f34bd0e3
Pass up better error messages
2019-05-15 10:25:34 -07:00
340c8faced
Remove crazy recursive permissions check that was chowning /home
2019-05-15 10:17:44 -07:00
f8c5fad437
Mark as darwin only, to match network.go
2019-05-14 09:05:34 -07:00
6e693d22ee
lint-a-geddon is here
2019-05-13 21:43:52 -07:00
9a9f9edf5f
First pass at lint-ageddon
2019-05-13 18:31:55 -07:00
6491e35c20
Add explicit kvm2 flag for hidden KVM signature
2019-03-24 09:47:38 +01:00
edf46f003f
Document all exported functions outside minikube
2019-03-16 16:57:37 +01:00
46640cef68
Address all lint except undocumented and stutter
...
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"
"type name will be used as foo.FooBar by other packages,
and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
df5bbc3c8a
Fix minikube logs for other container runtimes
...
It is only Docker that adds the "k8s_" prefix, since CRI
only handles containers that are used by Kubernetes anyway.
Also need to use "sudo" when running all crictl commands,
including logs. And only list containers that are running.
2019-03-01 20:56:45 +01:00
cd156b3f98
Merge branch 'master' into container-killing2
2019-02-15 09:10:19 -08:00
07fc64fbe1
Warnf -> Debugf so that it doesn't interfere with output
2019-02-14 20:12:34 -08:00
c3db098d4a
ListContainers should return empty list when no containers match
2019-02-14 16:10:33 -08:00
7dd7e5417d
glog, not golog
2019-02-14 14:43:22 -08:00
531e6b0f72
Use h.SetLogger
2019-02-14 14:40:32 -08:00
0c8a452e97
lowercase error messages
2019-02-14 14:40:16 -08:00
ba9492c314
Merge branch 'master' into hyperkit-debugging
2019-02-14 14:03:52 -08:00
5c1a72f428
Switch Infof statements to Debugf/Warningf, as they go to stderr
2019-02-14 10:14:41 -08:00
473f5983cb
Allow driver name to be com.docker.hyper, as seen in integration testing
2019-02-13 13:36:45 -08:00
4b875ddd7f
Run goimports
2019-02-13 13:35:28 -08:00
2045dc9ba4
Lint cleanup
2019-02-13 13:35:08 -08:00
5f65dc80fa
Remove error uploads, consolidate fatal error handling into exit package
2019-02-13 12:37:44 -08:00
888978c3a9
Improve VM re-use reliability: detect crashing and/or badly installed hyperkit
2019-02-12 13:58:18 -08:00
f346e5628b
Add logging around the DHCP discovery process
2019-02-12 13:57:02 -08:00
d57d8d1a1e
Fix broken tests: hyperkit driver format mismatch, console spacing mismatch
2019-02-08 13:58:02 -08:00
9f09f02e39
Address PR comments, make sure PullImages code path is exercised
2019-02-07 15:39:31 -08:00
966b245dc6
Refactor and centralize container runtime code into a cruntime package
2019-02-05 14:42:12 -08:00
17c0244cf7
reverting unnecessary change
2019-01-28 17:28:57 -08:00
5af2f1eafc
formatting / removed extra comment
2019-01-28 13:47:24 -08:00
f70e6a0385
fixing review remarks
2019-01-28 13:42:43 -08:00
933356e477
lint
2019-01-25 17:20:57 -08:00
9b97a85a8f
fix stale hyperkit.pid making minikube start hang
2019-01-25 17:08:31 -08:00
0687fea66a
Added defaultDiskSize setup to hyperkit driver
...
fmt fix
2019-01-14 17:04:07 +02:00
7ba01b40a9
Hide KVM signature
2018-12-15 21:47:41 +11:00
57f4d9247e
Only require docker for the docker runtime ( #3303 )
...
Closes #3295
2018-11-27 14:15:08 -08:00
3706b3b8ac
Fix dangling format issues.
2018-09-28 16:48:37 -07:00
055c8002b1
Replace %s format directives with %v for errors.
...
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
5d0e12327a
turning error into a warning log message
2018-09-26 13:53:57 -07:00
4eb2cdb120
inlining deleteNetwork into if statement
2018-09-24 14:04:01 -07:00
5e38bf4819
kvm2 driver: fixed documentation link in error text
2018-09-21 10:28:52 -07:00
34ee59192b
kvm2 driver: be more robust with creating of the network, don't delete the network if it is in use
2018-09-21 10:28:47 -07:00
b35e908dec
kvm2 driver: generate separate random MACs for default and private network NICs
2018-09-21 10:28:43 -07:00
c4ef7ad197
kvm2 driver: separated activating and creating of networks
2018-09-21 10:28:37 -07:00
d1995d24f0
kvm2 driver: fixed private network creation and setup
2018-09-21 10:28:33 -07:00
22ab50aa7e
Correct typo in the returned message
...
coundn't->couldn't
2018-09-04 05:49:04 -05:00
232080ae0c
Remove some more vendored k8s.
2018-07-26 08:23:21 -07:00
a4606583e4
remove all localkube references from code, change /var/lib/localkube to /var/lib/minikube
2018-07-24 12:36:42 -07:00
23fc22e532
Fix docs for kvm2
2018-07-23 09:02:33 -07:00
87d7a3208a
Update KVM driver installation instructions.
...
Move the latest instructions out of the comments and move old instructions into the comments.
2018-07-20 07:57:14 -07:00
268c932240
Add GPU support to minikube.
2018-07-08 22:25:48 -07:00
05161c1b18
Fixes https://github.com/kubernetes/minikube/issues/2274
2018-07-04 09:26:50 -07:00
0df67ee4af
Changes to make 'virsh console minikube' work.
2018-06-11 08:45:59 -07:00
ee73cbde6b
Added hyperkit options for enterprise VPN support
...
The purpose of these changes is to enhance Hyperkit support from the
minikube command line for better integration with enterprise networks
behind a VPN.
uuid: Provide VM UUID to restore MAC address (only supported with
Hyperkit driver).
vpnkitSock: Location of the VPNKit socket used for networking. If empty,
disables Hyperkit VPNKitSock, if 'auto' uses Docker for Mac
VPNKit connection, otherwise uses the specified VSock."
vsockPorts: List of guest VSock ports that should be exposed as sockets
on the host (Only supported on with hyperkit now).
Note:
tests pass but file:
`vendor/github.com/google/certificate-transparency/go/x509/root_darwin.go`
has to be edited to correct an issue - not committed since this is in
the vendor directory.
2018-06-04 09:46:20 -07:00
8c6afecc88
Move the etc data directory to data/minikube to make cleanup safer.
2018-05-17 13:27:19 -07:00
b54950fb2b
Start the default network for the kvm2 driver.
2018-05-11 13:07:19 -07:00
6bb278a958
Typo fix: priviledges->privileges
...
priviledges->privileges
2018-05-03 12:06:25 +02:00
9ad5b4a190
Disable dnsmasq on minikube-net network for kvm driver
2018-04-20 07:40:43 -07:00
cc356e63c4
Miscellaneous none driver fixes.
2018-04-04 13:58:50 -07:00
ee58133538
kvm2: Switch to CPU passthrough mode by default
...
With passthrough mode we can enable KVM nesting for guests.
Fixes #2553
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
2018-02-22 10:42:20 -08:00
b08b8ab8ae
Revert "kvm: Passthrough host CPU in order to allow nesting"
...
This reverts commit 7a4babe1d6
2018-02-22 10:42:20 -08:00
3ddf9d65f6
kvm: Passthrough host CPU in order to allow nesting
...
Before this patch the virtual CPU was the stock qemu CPU, in the sense that
the virtual CPU features were set according to the default qemu CPU.
With this change the CPU features of the host will be copied at start to the
domain definition. This includes features like svm and vmx, which in turn allow
to run nested virtualization if the host is configured accordingly i.e.
`kvm_intel nested=y` in `/etc/modprobe.d/kvm.conf`.
To turn on nesting, a user has to specify `--kvm-cpu-model host-model` when
creating the VM.
Resolves #2553
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
2018-02-22 10:42:20 -08:00
23d9fde284
Fix none driver stop commands.
2018-02-15 11:51:37 -08:00
cebd704bd7
Issue #2416 : Added UUID to hyperkit driver section in minikube configuration to be able to regenerate the same mac address for the machine after restarts to give DHCP a change of assigning the previously used IP address.
2018-01-11 09:41:35 -08:00
bc55b8b8be
Cleanup NFS Exports after stop and delete
2018-01-03 10:21:04 -08:00
59274b22da
Code review feedback.
2018-01-02 16:18:54 -08:00
e3f3727b4d
Move GetNetAddr.
...
The build constraints in vmnet.go cause issues.
2018-01-02 16:18:54 -08:00
7d9413ccd1
remove the hyperkit prefix so we can move this to other drivers as well with time and fix vendoring issue
2018-01-02 16:18:54 -08:00
e1903b7423
support NFS sharing with the hyperkit driver
2018-01-02 16:18:54 -08:00
5df299c7e9
Make other lifecycle commands work.
2018-01-02 12:01:37 -08:00
fcdd1404e8
Use the real GetIP function.
2018-01-02 12:01:37 -08:00
4077763003
Make none driver work with kubeadm
2018-01-02 12:01:37 -08:00
8f91c37bba
Properly support the "minikube-net" network.
2017-12-13 21:18:00 -08:00
56608e418d
kvm2: Set group executable bit on machine-specific directory and up
...
Ensure that the directories leading to the KVM image have enough
permission for libvirt/QEMU to traverse, especially in the case where
libvirt/QEMU group is set to to `kvm`/`users`.
2017-12-10 17:49:54 -08:00
fdf906cf3b
Add an error message when running hyperkit without permissions.
2017-11-26 17:31:01 -08:00
bc20281f1e
Update hyperkit go driver.
2017-11-20 11:52:20 -05:00
9fc8eed51d
Merge pull request #2076 from r2d4/kvm-mac
...
Use mac instead of hostname to find IP
2017-11-01 08:40:55 -07:00
2c2c45d7a6
DOM_SHUTDOWN should return state.Running
...
Technically, DOMAIN_SHUTDOWN just means that the VM is in the process
of shutting down. We should still return state.Running so that we
don't return from `minikube stop` before the domain is actually
stopped. This should fix a few flakes.
2017-10-23 11:23:58 -07:00
ea31492976
use consistent path for localkube.service
...
/usr/lib/systemd/system is not consistent across different distribution
/etc/systemd/system should be used.
See issue: #2098
2017-10-20 14:09:03 -07:00
a19f90fd91
import erorr
2017-10-19 16:23:47 -04:00
02f0d41c1d
Split out hyperkit into CGO needed stub
...
This allows us to use the hyperkit Driver struct in minikube, without
needing CGO_ENABLED=1. For the hyperkit driver binary, the
CGO_ENABLED=1 function will work.
2017-10-19 16:07:38 -04:00
b7012aefcc
Use mac instead of hostname to find IP
2017-10-19 09:16:24 -07:00
c6d2e491a3
Merge pull request #1774 from aaron-prindle/none-docker-rm-kill
...
Added command to remove and kill all kubernetes containers from docke…
2017-10-04 11:30:57 -07:00
10e6e6ade1
added cleanup for docker containers in none driver
2017-10-02 11:48:35 -07:00
547d22f638
Clean up unused files, add tar rules
2017-09-19 15:45:18 -07:00
ebbc34d2ba
Move drivers to pkg/drivers, share utils
...
Share most of the disk image setup between hyperkit and kvm drivers.
Move and remove a lot of shared configuration between all the in-tree
drivers: kvm, hyperkit, none.
2017-09-12 14:29:22 -07:00
53341aa30d
golint, go vet, etc. changes
2017-09-11 14:17:58 -07:00
48b165808c
Bring KVM driver in-tree
...
Add boilerplate
Review feedback
2017-08-28 11:52:35 -07:00
Thomas Stromberg
Medya Gh
Sharif Elgamal
Medya Ghazizadeh
Kyle Bai
josedonizetti
Jituri, Pranav
Anders F Björklund
balopat
bpopovschi
Alasdair Tran
Marcus Heese
AdamDang
dlorenc
Aaron Prindle
dlorenc
Rohit Agarwal
Luke Weber
seborama
Viktor Safronov
Fabian Deutsch
basp
Hugues Alary
Mohit Gupta
Matt Rickard
Zak B. Elep
Matt Rickard
Yisui Hu