Sharif Elgamal
06ed3378b9
create special error to skip addons without erroring out
2021-08-13 13:42:02 -07:00
Medya Gh
ccf4af0997
change depricated golint to revive and fix lint issues
2021-08-12 18:11:16 -07:00
Sharif Elgamal
ca04178ced
exit prematurely in specific case for gcp-auth
2021-08-12 14:13:51 -07:00
Sharif Elgamal
163a4b2934
fix lint
2021-08-11 11:56:45 -07:00
Sharif Elgamal
1319fe729f
fix file existence check
2021-08-11 09:58:03 -07:00
Sharif Elgamal
f99b234c7e
simplify logic
2021-08-10 15:56:15 -07:00
Sharif Elgamal
e150129172
refactor EnableOrDisableAddon to reduce cyclotomic complexity
2021-08-10 15:54:12 -07:00
Sharif Elgamal
19b763fd36
do not start pods if no creds
2021-08-10 15:16:41 -07:00
Sharif Elgamal
dfef0ad478
read blessed cloud shell config file
2021-08-10 13:46:49 -07:00
Sharif Elgamal
3acbd2fc90
gcp-auth: improve flow for GCE/Cloud Shell
2021-08-10 12:57:10 -07:00
Sharif Elgamal
9995961a77
Merge pull request #12106 from sharifelgamal/more-reg
...
configure gcp-auth addon pull secret to work with all GCR and AR mirrors
2021-08-09 12:02:31 -07:00
Sharif Elgamal
b2bc913596
gcp-auth: always create the pull secret and don't require --force if GOOGLE_APPLICATION_CREDENTIALS env var is set
2021-08-04 16:35:26 -07:00
Sharif Elgamal
3d79bba97d
configure gcp-auth addon pull secret to work with all GCR and AR mirrors
2021-08-03 11:48:20 -07:00
Sharif Elgamal
6d710b4e59
only use update if the secret already exists
2021-07-23 13:11:07 -07:00
Sharif Elgamal
a940203ed4
update instead of delete/create
2021-07-23 12:22:51 -07:00
Sharif Elgamal
4dd89f8713
Merge branch 'master' of github.com:kubernetes/minikube into gcp-sa
2021-07-13 13:31:34 -07:00
Sharif Elgamal
a8d366ffbf
don't try to recreate pull secrets for refreshing gcp-auth
2021-07-08 16:15:44 -07:00
balasu
e833905678
for portainer add-on
2021-07-08 13:22:01 +00:00
Andriy Dzikh
cec98ef11a
Template auto-pause.service to allow injecting the correct container runtime.
2021-07-01 13:12:44 -07:00
Medya Gh
306fa828b1
enable auto-puase on arm64
2021-06-24 17:25:14 -04:00
Sharif Elgamal
31417806b7
Merge pull request #11486 from sharifelgamal/gcp-auth-restart
...
gcp-auth addon: do not reapply gcp-auth yamls on minikube restart
2021-05-27 15:05:34 -07:00
Sharif Elgamal
a790bd1361
better wrapper name
2021-05-27 10:35:30 -07:00
Sharif Elgamal
ad1fc0b8fe
wrap pull secret error
2021-05-27 10:22:42 -07:00
Sharif Elgamal
643cfb91f4
fix last bool
2021-05-26 09:33:33 -07:00
Sharif Elgamal
6db4a51cbb
swap to --refresh
2021-05-26 09:26:10 -07:00
Sharif Elgamal
a823439257
allow pods to be refreshed
2021-05-25 13:43:25 -07:00
Sharif Elgamal
86f9feb535
do not reapply gcp-auth yamls on minikube restart
2021-05-21 17:04:49 -07:00
Utkarsh Srivastava
aa99526399
change variable name from addonList to addonListFlag
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-21 13:39:05 +05:30
Utkarsh Srivastava
69b30c06df
change variable name from addonListName to addonList
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 22:25:38 +05:30
Utkarsh Srivastava
5a3843b074
replace addonList variable with viper provided data
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 21:39:07 +05:30
Andriy Dzikh
040e7e7a8d
Persist custom addon image settings.
2021-05-18 14:10:37 -07:00
Medya Gh
8ca3d1f799
remove debug
2021-05-17 18:54:02 -07:00
Medya Gh
0068f92327
add port to addons templates
2021-05-17 18:50:12 -07:00
Brian de Alwis
25433a4065
Fix autopause issue link
2021-05-06 15:47:36 -04:00
Medya Ghazizadeh
f854a086b1
Merge pull request #11158 from spowelljr/addLogFileToGithubIssue
...
Add log file to GitHub issue output
2021-04-24 09:52:45 -07:00
Steven Powell
cd93ee9eb4
added message to box
2021-04-21 16:43:06 -07:00
Medya Gh
1207de734b
bump golang lint ci to latest
2021-04-19 15:16:31 -07:00
Medya Gh
d1c46aea43
add auto-pause to VMs
2021-04-07 19:36:48 -07:00
Medya Ghazizadeh
660cc42e88
Merge pull request #10823 from azhao155/yzhao/feature/auto-hook
...
Add auto-pause webhook to inject env into pods for redirecting in-cluster kubectl request to reverse proxy of api server.
2021-03-29 09:53:14 -07:00
Kent Iso
26dac162b8
bump metrics-server to v0.4.2
2021-03-29 23:32:08 +09:00
Sharif Elgamal
df4224a058
fix lint
2021-03-24 17:11:11 -07:00
Sharif Elgamal
63b43cc640
allow access to artifact registry as well
2021-03-24 15:09:43 -07:00
Sharif Elgamal
73641d2b4e
break
2021-03-24 13:52:29 -07:00
Sharif Elgamal
03b3113b13
remove unnecessary exits
2021-03-24 13:50:17 -07:00
Sharif Elgamal
af57dbc001
account for new API, add extra checks for stability
2021-03-24 13:47:18 -07:00
Sharif Elgamal
afccdd2acc
Merge branch 'master' of github.com:kubernetes/minikube into gcr-auth
2021-03-23 16:19:37 -07:00
Sharif Elgamal
1767631abe
don't fail if token isn't valid
2021-03-23 15:50:57 -07:00
Sharif Elgamal
36deb4cb06
allow tests to pass with dummy creds
2021-03-23 14:41:04 -07:00
Yanshu Zhao
9ea99ae129
Add skip into label object of web hook, clean up code
2021-03-23 07:03:42 +00:00
Medya Ghazizadeh
141a7da152
Merge pull request #10818 from afbjorklund/box-cli
...
Add a red box around docker desktop registry port
2021-03-22 18:48:51 -07:00
Kent Iso
fb216ddc93
Upgrade ingress addon files according to upstream(ingress-nginx v0.44.0)
2021-03-20 04:07:21 +09:00
Sharif Elgamal
bd71b3d8aa
lint
2021-03-18 23:12:05 -07:00
Sharif Elgamal
da1477f3f8
delete secret on disable
2021-03-17 13:39:55 -07:00
Yanshu Zhao
107331275c
Add template for reverse proxy ip
2021-03-17 18:52:55 +00:00
Sharif Elgamal
24457b1875
use token source instead of json directly
2021-03-16 19:17:29 -07:00
Sharif Elgamal
cfd9556468
Merge branch 'master' of github.com:kubernetes/minikube into gcr-auth
2021-03-16 15:15:09 -07:00
Anders F Björklund
9b8eac8380
Moved Boxed output to a new helper in out module
...
And remove the extra newline inside the box,
plus remove the color if not using the emoji.
2021-03-16 21:58:11 +01:00
Sharif Elgamal
294f044821
add creds for docker pull to gcp-auth
2021-03-15 11:39:06 -07:00
Anders F Björklund
5cf8dce944
Add a red box around docker desktop registry port
...
To make it harder to miss the notice, with the rest of the emojis
Also remove some stray "on" text, but do add "driver" and "port"
2021-03-14 16:18:53 +01:00
tripolkaandrey
e2acd0d657
added check for enabled registry addon
2021-03-12 12:24:25 +02:00
Medya Gh
ee74d42eba
merge conflict
2021-03-11 01:14:06 -08:00
Sharif Elgamal
3063e9e720
change filenames to be more descriptive
2021-03-09 15:54:30 -08:00
Sharif Elgamal
fa31737792
fix boilerplate date
2021-03-09 15:32:49 -08:00
Sharif Elgamal
aee9afe223
move constants to proper file
2021-03-09 15:20:02 -08:00
Sharif Elgamal
a3544ae90a
create detect package
2021-03-09 15:11:54 -08:00
Sharif Elgamal
d314d73c3a
pull out addon specific code into their own files
2021-03-09 14:59:54 -08:00
Sharif Elgamal
eb1ee1f931
account for GCE in addons test
2021-03-09 14:32:02 -08:00
Sharif Elgamal
15c44bf7ac
reorganize addons to make force flag more generic
2021-03-09 13:32:09 -08:00
Sharif Elgamal
afd7a785ab
fix message
2021-03-09 12:53:48 -08:00
Sharif Elgamal
f0e70b4e17
initialize bool
2021-03-08 14:57:40 -08:00
Sharif Elgamal
16a2ac9c47
generate docs
2021-03-08 13:10:43 -08:00
Sharif Elgamal
e6cb33fa6d
oh dear global variable
2021-03-08 12:15:05 -08:00
Sharif Elgamal
6fc42a549e
allow --force
2021-03-05 16:41:27 -08:00
Sharif Elgamal
1ed86db109
auto-detect gce and do not enable gcp auth addon
2021-03-05 13:45:36 -08:00
Steven Powell
a2989a119e
reverted actions from Styled to Step
2021-03-02 17:23:43 -07:00
Steven Powell
e9d16eb42d
replaced non-step logging with Styled
2021-03-02 17:23:43 -07:00
Medya Gh
f272822d15
bump kic base
2021-02-24 13:45:53 -08:00
Medya Gh
7f3b2c2a7b
addres review comments
2021-02-24 12:48:39 -08:00
Medya Gh
43cf3fa826
fix build
2021-02-24 12:30:06 -08:00
Medya Gh
48c5f1e42e
rename func
2021-02-24 12:30:06 -08:00
Medya Gh
50642f4bba
fix kubecontext
2021-02-24 12:30:06 -08:00
Medya Gh
1bd0b6daae
add final touch
2021-02-24 12:30:06 -08:00
Medya Gh
8a652887ef
add helpers to enable disable autopause
2021-02-24 12:30:06 -08:00
Medya Gh
8df298f348
fix build
2021-02-24 12:30:06 -08:00
Medya Gh
8412efbc02
add addons
2021-02-24 12:30:06 -08:00
Sharif Elgamal
b71728b27f
fix syntax
2021-02-10 12:16:06 -08:00
Sharif Elgamal
adf6f91ee3
Merge branch 'master' of github.com:kubernetes/minikube into ingress-none
2021-02-10 11:42:21 -08:00
Kent Iso
b1030dc28a
Fix configuration of the metallb with empty load balancing IP range
2021-02-07 23:43:05 +09:00
Ling Samuel
b949034e1a
Manage addon images in code, support custom addon images
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:00 +08:00
Daehyeok Mun
36d94a2d88
Migrate MachineName function.
...
Migrate MachineName function from driver package to config package.
2021-01-08 11:26:10 -08:00
Jituri, Pranav
0ae11fd5c8
fix linting error
2020-12-15 18:22:36 +05:30
Sharif Elgamal
ad330b21ad
Merge branch 'master' of github.com:kubernetes/minikube into ingress-none
2020-12-09 11:12:23 -08:00
Jituri, Pranav
6bbc5f986b
Enable Ingress Addon for Docker Windows
2020-11-21 16:01:06 +05:30
Sharif Elgamal
bef7a2a2b7
Merge branch 'master' of github.com:kubernetes/minikube into ingress-none
2020-11-13 09:55:13 -08:00
Evgeny Shmarnev
f88040aad9
Merge branch 'master' into ISSUE-9664
2020-11-12 13:47:12 +01:00
Evgeny Shmarnev
db93039f9c
Addressing comments
2020-11-12 13:45:33 +01:00
Sharif Elgamal
c01e106b48
better comment
2020-11-11 13:37:40 -08:00
Sharif Elgamal
b23cb6c20d
find special cloud shell spot for creds
2020-11-11 12:26:50 -08:00
Sharif Elgamal
4f4124c69d
try to create credentials file if using env to authenticate
2020-11-10 15:53:54 -08:00
Sharif Elgamal
cda2d13d21
Turn on ingress addon on linux baremetal
2020-10-28 12:19:26 -07:00
zouyu
3130c9fce0
Add unit test
...
Signed-off-by: zouyu <zouy.fnst@cn.fujitsu.com>
2020-10-23 10:13:38 +08:00
Thomas Stromberg
e2fdc077f8
Use 6 minutes, to use the philosophy of doubling timeouts you hit
2020-10-21 09:54:01 -07:00
Thomas Stromberg
20d1645ce7
Wait up to 5 minutes for addon pods, improve error message
2020-10-21 09:44:39 -07:00
Priya Modali
8936a8c7f8
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-13 09:08:27 -07:00
Sharif Elgamal
b04610ef9b
simplify addon code by fixing gcp-auth failure policy
2020-10-06 16:14:44 -07:00
Priya Modali
43ea47f4e0
Fixed merge conflicts.
2020-09-29 16:17:31 -07:00
Priya Modali
97d96bf925
Switching from glob library to klog library.
2020-09-29 15:49:41 -07:00
Sharif Elgamal
ff051f9a33
Make sure gcp-auth addon can be enabled on startup ( #9318 )
...
* fix documentation for gcp-auth addon
* make sure kube-system pods are up before enabling gcp-auth
* fix lint
* add failurePolicy for webhook
* only install addons if asked
* better comment
* slightly less hacky code
* defer addons properly
* simplify code for performance
2020-09-29 13:29:14 -07:00
jjanik
ae92c289b8
add csi-hostpath-driver addon
2020-09-04 18:54:33 +02:00
jjanik
c5ae7b9580
add volumesnapshots addon
2020-09-04 17:10:54 +02:00
Sharif Elgamal
ed4271ffbc
trim whitespace when setting gcp project id
2020-09-02 11:42:47 -07:00
Thomas Strömberg
3fbbb557b1
Merge pull request #9032 from zhijianli88/cleanup-tempfiles2
...
Cleanup tempfiles2
2020-09-01 16:25:00 -07:00
Thomas Strömberg
fba4de74cf
Merge pull request #8787 from saltbo/master
...
fix error usage for the WaitGroup in the pkg addons
2020-09-01 16:21:51 -07:00
Thomas Stromberg
2c5e8fdaee
Add detailed JSON & status codes for all error paths
2020-08-30 17:25:11 -07:00
Li Zhijian
95e7203900
add a temp MinikubeHome for TestStart
...
this test will write a config.json into MinikubeHome, create a temp dir for it
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 11:49:07 +08:00
Li Zhijian
50459e0566
add testing cleanup hook for createTestProfile
...
T.cleanup() is introduced since go-1.14
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-19 18:10:07 +08:00
Medya Ghazizadeh
a13e5e5512
Merge pull request #8870 from Dean-Coakley/add-ingress-noneDriver-warn
...
Add warning for ingress addon enabled with driver of none
2020-08-10 13:17:54 -07:00
Sharif Elgamal
02930c0d51
fix tip output and do not output ending tip disabling
2020-08-06 13:45:46 -07:00
Sharif Elgamal
16ba55d05f
better error message
2020-08-06 12:36:54 -07:00
Sharif Elgamal
90dadd0ce6
better error messages for not finding creds
2020-08-06 11:47:09 -07:00
Dean Coakley
9c23485dfb
Remove list of alternative drivers
2020-07-29 09:40:43 +01:00
Dean Coakley
4b2974472d
Improve error message text
2020-07-28 22:40:55 +01:00
Dean Coakley
b27440d4ae
Add warning for ingress addon with driver of none
2020-07-28 22:40:15 +01:00
Medya Ghazizadeh
85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
...
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal
1b6eee675b
Automated GCP Credentials Addon Prototype ( #8682 )
...
* metadata addon works
* Add code for metadata server image and makefile rules
* remove log message
* update to work with v1.13.11
* update readme
* fix metadata addon stuff for newer codebase
* buncha changes
* just so many changes
* ch-ch-ch-ch-changes
* addon works
* update readme
* boilerplate
* revert unrelated change
* move server code to another repo
* switch addon name to gcp-auth
* metadata -> gcp-auth
* missed one
* automate finding of credentials
* remove unnecessary comment
* address comments
* Update README.md
* Update README.md
* use mustload everywhere
* swap selector condition
* upgrade kube-webhook-certgen to 1.3
* move paths to constants
* add notice to user on addon enable
* adding addon documentation
* move addons documentation inside handbook
* remove old addons docs location
Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Shubham
f42f79e56d
(Addons) Create a new command in every retry
...
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd )
states that "... Cmd cannot be reused after calling its Run or
Start methods."
This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.
Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.
Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
Ambor
e00cf6c1e1
fix error usage for the WaitGroup in the pkg addons
2020-07-21 11:57:06 +08:00
Priya Wadhwa
3a290606db
Merge branch 'master' of https://github.com/kubernetes/minikube into json-output
2020-07-10 19:12:50 -04:00
Medya Ghazizadeh
d8106f7d06
Merge pull request #8454 from colvin/addon-podsecuritypolicies
...
Include a podsecuritypolicies addon
2020-07-07 15:52:03 -07:00
Priya Wadhwa
bd94872a10
add additional steps
2020-07-07 14:25:27 -04:00
Medya Gh
e829341b9d
improve logging
2020-06-26 15:12:15 -07:00
Medya Gh
64553e281b
revert debugging
2020-06-26 15:11:03 -07:00
Medya Gh
742dcd6b00
add addon status verification for 3 addons
2020-06-26 15:08:38 -07:00
Medya Gh
66421a6492
wait for ingress pod be running
2020-06-26 14:22:17 -07:00
Medya Gh
52f4e130b5
lint
2020-06-26 13:20:31 -07:00
Medya Gh
5fbf197b18
remove unrelated changes
2020-06-26 13:20:31 -07:00
Medya Gh
96781c61a2
remove unrelated changes
2020-06-26 13:20:30 -07:00
Medya Gh
058a732909
ingress addon validate deployment after enable
2020-06-26 13:20:30 -07:00
Medya Gh
c47854b8fd
add validate ingress
2020-06-26 13:20:30 -07:00
Medya Gh
a0c33f82c1
ingress addon wait for it
2020-06-26 13:20:30 -07:00
Priya Wadhwa
1b8eaaf76c
Move kubectl binary function to kapi package to prevent future cyclic import dependencies
2020-06-25 09:40:14 -07:00
Priya Wadhwa
6d3a0c4eca
Reduce coredns replicas from 2 to 1
...
This is an easy way to improve overhead, and users can always scale this back up if they need to.
2020-06-24 17:42:12 -07:00
colvin
3d2ae5423c
Rename podsecuritypolicies addon to pod-security-policy
2020-06-18 17:00:08 -04:00
Kenta Iso
ab58dca23d
replace to metrics-server in case of `minikube start --addons heapster`
2020-06-13 01:07:16 +09:00
Kenta Iso
803461ddcf
if the specified addon doesn't exist, skip enabling
2020-06-13 00:46:12 +09:00
Kenta Iso
9d71fc635b
remove unneccesary config
2020-06-13 00:46:12 +09:00
Kenta Iso
d76b58c3ae
Add heapster alias to metrics-server addon
2020-06-13 00:46:12 +09:00
colvin
b32cb5e6ba
Create a podsecuritypolicies addon
...
Create a new addon, `podsecuritypolicies` that applies the
PodSecurityPolicy and related RBAC configuration from the
https://minikube.sigs.k8s.io/docs/tutorials/using_psp/ tutorial.
Apparently, recent work on the addons system has invalidated the
procedure shown in that tutorial, as the configuration is no longer
automatically applied. The last known working version is `1.6.2`.
This allows clusters started with
`--extra-configs=apiserver.enable-admission-plugins=PodSecurityPolicy`
to succeed, so long as they also include `--addons=podsecuritypolicies`.
2020-06-11 09:51:13 -04:00
gashirar
a85b5aa984
fix logviewer config.
2020-06-05 04:55:18 -07:00
Medya Ghazizadeh
4eb09e760b
Merge pull request #8275 from ashleyschuett/add-kubevirt-addon
...
Add KubeVirt addon
2020-06-03 22:23:09 +00:00