c603300781
more reliable stop for none driver ( #4871 )
...
* more reliable stop for none driver
* print stop error
* better error logging
* misspell
* error formatting
* Passing lint interfacer nag
2019-07-25 13:19:21 -07:00
82d4c7dd2c
Merge pull request #4688 from kairen/better-comment
...
Add space after // comments
2019-07-11 11:53:15 -07:00
c5f695e8a0
Better comment syntax
2019-07-05 11:17:10 +08:00
99ac1a81e7
moving command runner to its own package
2019-07-04 16:31:07 -07:00
2aac268ba6
Merge pull request #4593 from josedonizetti/add-hyperkit-version
...
Add version to hyperkit driver
2019-07-01 14:38:30 -07:00
449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check
...
Added validation for start memory size
2019-06-30 15:17:28 -07:00
037e9a5d56
Merge pull request #4641 from josedonizetti/improve-kvm-connection-error-message
...
Improve kvm connection error message
2019-06-30 12:08:44 -07:00
4d00a093d1
Fix error naming convention
2019-06-29 11:28:54 -03:00
23ae121f2b
kvm2: simplify connection error message
2019-06-29 10:53:13 -03:00
4812761f05
Add gitCommitID to hyperkit version
2019-06-29 09:32:21 -03:00
931a0a557b
Add hyperkit version
2019-06-29 09:22:51 -03:00
7fe2247692
Improve hyperkit vm stop
2019-06-28 16:36:36 -07:00
9dfe660c64
Add support to custom qemu uri on kvm2 driver
2019-06-28 14:12:58 -07:00
8acf4824df
Add commit id to docker-machine-driver-kvm2 version
2019-06-28 13:45:54 -07:00
6222e74267
Add hyperkit doc
2019-06-28 13:44:15 -07:00
d6a839b20a
Fix kvm2 vm driver remove domain
2019-06-26 18:36:52 -07:00
380883dee3
Fix failing Hyperkit test
2019-06-26 01:45:12 +05:30
6ba1725c08
Added Memory Size Checking
2019-06-26 00:22:41 +05:30
c7bf1ce7cd
type check for drivers
2019-06-24 14:39:21 -07:00
f20f223c02
Decrease cyclomatic complexity
...
Here is the report (from gocyclo), before:
21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
2019-06-22 17:21:42 +02:00
02b8032b59
Merge pull request #4385 from josedonizetti/refactor-drivers-restart
...
Refactor: improve readability drivers.Restart
2019-06-21 08:07:35 +08:00
4610663674
Merge pull request #4398 from josedonizetti/add-kvm-version-flag
...
Add kvm2 --version
2019-06-20 07:41:18 +08:00
a2d844ef51
Add kvm network name validation
...
closes for #3581
2019-06-15 13:56:12 -07:00
a024c6d22a
Add kvm2 --version
2019-06-04 16:45:14 -03:00
6d57b28fdd
changing string driver name to checked type
2019-06-03 20:27:26 -07:00
0e633533c2
Refactor: improve readability drivers.Restart
2019-05-30 17:24:28 -03:00
986c61d15e
Fix kvm gpu log
2019-05-30 14:56:46 -03:00
dbc64c053b
Merge pull request #4355 from josedonizetti/fix-kvm-remove-when-domain-is-not-defined
...
Fix kvm remove when domain is not defined
2019-05-28 17:07:53 -07:00
dcb10332a0
Merge pull request #4334 from josedonizetti/refactor-kvm-lookup-status-ip
...
Refactor kvm lookupIPFromStatusFile
2019-05-28 10:26:02 -07:00
c09913070d
Fix kvm remove when domain is not defined
2019-05-25 09:23:40 -03:00
8f9a3f448d
Merge pull request #4344 from josedonizetti/fix-kvm-remove-when-domain-is-not-running
...
Fix kvm remove when domain is not running
2019-05-24 13:55:04 -07:00
bb56fd2eb7
Merge pull request #4323 from josedonizetti/fix-kvm-ensure-network
...
kvm2: Add support for --kvm-network to ensureNetwork
2019-05-24 10:47:41 -07:00
48237d95b8
Clean up kvm Remove code
2019-05-24 14:27:55 -03:00
b65c7403cf
Add error warp to destroyRunningDomain
2019-05-24 14:27:55 -03:00
3124f11e1b
Fix kvm remove when domain is not running
2019-05-24 14:27:55 -03:00
81f0d9ba37
Fix kvm remove warn message
2019-05-24 12:38:00 -03:00
1852a72caf
Refactor kvm lookupIPFromStatusFile
2019-05-23 15:38:02 -03:00
fc2e2e52c5
Skip kvm network deletion if private network doesn't exist
2019-05-23 06:17:12 -03:00
93329f1619
Remove obsolete comment
2019-05-22 17:25:27 -03:00
e3bf4bd7ec
Fix kvm ensureNetwork
2019-05-22 16:19:09 -03:00
e9a450df66
Validate kvm network exists
2019-05-21 16:19:15 -03:00
e53c0339ea
This is my testament to Chesterton's Fence
2019-05-15 11:44:16 -07:00
88f34bd0e3
Pass up better error messages
2019-05-15 10:25:34 -07:00
340c8faced
Remove crazy recursive permissions check that was chowning /home
2019-05-15 10:17:44 -07:00
f8c5fad437
Mark as darwin only, to match network.go
2019-05-14 09:05:34 -07:00
6e693d22ee
lint-a-geddon is here
2019-05-13 21:43:52 -07:00
9a9f9edf5f
First pass at lint-ageddon
2019-05-13 18:31:55 -07:00
6491e35c20
Add explicit kvm2 flag for hidden KVM signature
2019-03-24 09:47:38 +01:00
edf46f003f
Document all exported functions outside minikube
2019-03-16 16:57:37 +01:00
46640cef68
Address all lint except undocumented and stutter
...
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"
"type name will be used as foo.FooBar by other packages,
and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
Medya Ghazizadeh
Thomas Strömberg
Kyle Bai
Medya Gh
josedonizetti
Jituri, Pranav
Anders F Björklund