Commit Graph

64 Commits (672d1a228133f0617a92a99fb774658a2af02308)

Author SHA1 Message Date
Steven Powell 50e9147e4e fix lint errors 2023-03-20 12:43:07 -07:00
Predrag Rogic 6d40ab38c7
move StartLimitIntervalSec param from [Service] to [Unit] section 2021-02-08 23:32:28 +00:00
Yanshu Zhao bb37572a44 Fix docker reload issue in docker-env cmd 2020-12-23 01:00:23 +00:00
Medya Gh 8ae3bda7d6 use docker recommendation 2020-11-24 15:13:56 -08:00
Medya Gh 46ea96d638 restart on failure 2020-11-24 13:00:33 -08:00
Medya Gh 9637c1fdf9 restart inner docker daemon using systemd 2020-11-24 12:48:41 -08:00
Priya Modali 97d96bf925 Switching from glob library to klog library. 2020-09-29 15:49:41 -07:00
Medya Gh bb327e250d adjust try 2020-04-16 15:14:59 -07:00
Sharif Elgamal 06dca45553 lint 2020-03-24 16:10:20 -07:00
Sharif Elgamal 4a24cfcf30 add cluster name to provisioner object directly 2020-03-24 15:54:39 -07:00
Sharif Elgamal 28672dec78 remove ClusterNameFromMachine 2020-03-24 14:43:11 -07:00
Thomas Stromberg ea6d6832e5 Only restart docker service if unit file has updated 2020-03-19 17:40:02 -07:00
Medya Gh 3ec8d429e1 more refactor 2020-03-13 12:25:37 -07:00
Medya Gh 0da027cdb2 refactor 2020-03-13 12:01:28 -07:00
Medya Gh 70c9304724 code review comments 2020-03-13 10:37:29 -07:00
Medya Gh 2e5b4ece36 hard code docker port 2020-03-12 14:50:19 -07:00
Medya Gh 4f097cb369 fix 2020-03-12 14:29:17 -07:00
Medya Gh 1b0fb63fc9 try again 2020-03-12 14:27:31 -07:00
Medya Gh 7d3117916e daemon-reload 2020-03-12 14:17:06 -07:00
Medya Gh 92eeb3c10b refactor provision 2020-02-03 22:29:27 -08:00
Sharif Elgamal 9a49c587d5
Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-24 15:54:04 -08:00
tstromberg 2e24d7a123 Combine error conditions 2020-01-24 13:08:26 -08:00
Sharif Elgamal 791f28ff4c things work now 2020-01-23 13:21:21 -08:00
Thomas Stromberg 412e78e54c minimize the number of commands executed 2020-01-23 11:11:28 -08:00
Priya Wadhwa 43259cc363 Reorganize buildroot.go by container runtime and remove unnecessary "sudo systemctl restart crio" to save time on 'minikube start' 2020-01-22 11:00:10 -08:00
Medya Gh 35ad8e2915 make profile name mandatory for config.Load 2019-12-09 14:47:20 -08:00
Sharif Elgamal c03aee8322
Refactor config.Config to prepare for multinode (#5889)
* Refactor config.Config to prepare for multinode

* merge conflict
2019-11-11 17:52:15 -08:00
tstromberg f6bd4df15c Address feedback 2019-10-29 14:21:53 -07:00
Thomas Stromberg f34b51db65 default-ulimit should be an arg, not an environment var 2019-10-29 07:56:31 -07:00
Thomas Stromberg 9bacb6a8e4 Remove test settings from buildroot 2019-10-28 22:33:18 -07:00
Thomas Stromberg 205376fc6d WIP: Consistently set 'ulimit -n' across runtimes 2019-10-28 22:31:57 -07:00
Thomas Stromberg 6d7d589a52 Consolidate driver-interaction code into pkg/minikube/driver 2019-10-18 13:00:07 -07:00
Anders F Björklund eec1a06921 Add warning that using --no-pivot is not secure
It is only intended for compatibility with the old
rootfs ISO, and not needed with the new tmpfs ISO.
2019-08-24 16:18:48 +02:00
Anders F Björklund edea8f93a5 Only use DOCKER_RAMDISK on fstype rootfs
The docker configuration is determined at runtime,
so make it work with both old rootfs and new tmpfs.
2019-08-24 16:12:52 +02:00
Anders F Björklund aa121cdce0 Only provision buildroot with BuildrootProvisioner 2019-08-16 18:07:44 +02:00
Medya Gh f17f3408a8 convert all RetryAfter to retry.Expo 2019-08-13 23:48:30 -07:00
Medya Gh 99ac1a81e7 moving command runner to its own package 2019-07-04 16:31:07 -07:00
Anders F Björklund a73dfc5f9e Merge branch 'master' into cyclo 2019-04-12 20:03:20 +02:00
Jan Janik e3cd27264d Escape systemd special chars in —docker-env 2019-03-29 16:56:51 +13:00
Anders F Björklund 4667c28164 Merge branch 'master' into cyclo 2019-03-26 07:16:28 +01:00
Anders F Björklund 00c9846a19 Decrease cyclomatic complexity for code
Mostly by using the "extract method" pattern.

Here was the report (from gocyclo), before:

16 kubeadm (*KubeadmBootstrapper).UpdateCluster pkg/minikube/bootstrapper/kubeadm/kubeadm.go:374:1
16 cluster StartHost pkg/minikube/cluster/cluster.go:64:1
16 tunnel setupRoute pkg/minikube/tunnel/tunnel.go:135:1
16 provision configureAuth pkg/provision/buildroot.go:218:1
21 util setElement pkg/util/config.go:50:1
2019-03-16 22:18:14 +01:00
Anders F Björklund edf46f003f Document all exported functions outside minikube 2019-03-16 16:57:37 +01:00
Anders F Björklund 6f909684e7 Still generate docker.service unit, even if unused
The dynamically generated docker.service file should still be there,
otherwise the statically provided docker.socket file gets confused.
2019-01-20 15:22:37 +01:00
priyawadhwa ed8f7124a0 Only restart docker service if container runtime is docker (#3426)
* Only restart docker service if container runtime is docker

Only allow the buildroot provisioner to restart docker if the container
runtime is docker. This change should fix the bug in #3424, since now
docker will not be restarted if the container runtime is containerd.

* Added files to fix FileContent--proc-sys-net-bridge-bridge-nf-call-iptables precheck error

From this issue: https://github.com/kubernetes/kubeadm/issues/1062
these files need to be added to prevent this precheck error (which occurs when running any container runtime that isn't docker).

Also, save the machine config on the user's filesystem earlier so that the buildprovisioner can access it.
2018-12-07 12:08:59 -08:00
Balint Pato a681603daa
Fix `minikube tunnel` for hyperkit (#3349)
This change is a bit of a hack to make IP routing work over the virtio-net interface - it forces the virtio-net interface (bridge100) created by hyperkit/xhyve to reset via removing and readding the single member of the interface. Without this "reset" packets are just simply lost most of the time, despite a completely healthy IP route.

This error was also the reason for a large percentage of our integration test failures. While reducing the flakiness of tunnel related tests I also increased the timeout requirement and adding retries to the nginx request in TestTunnel.
2018-11-21 13:39:48 -08:00
Thomas Stromberg 055c8002b1 Replace %s format directives with %v for errors.
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
dlorenc 9fe9154614 Make a crio restart failure a warning instead of an error.
This is a mismatch issue between new minikube versions and old ISO versions. It's
also unlikely to cause a real issue because it requires users to opt-into crio and
modify crio-specific settings to cause trouble.
2018-02-15 11:52:24 -08:00
Matt Rickard a2665d0dd8
Merge pull request #2545 from jeis2497052/master
Propose fix a typo
2018-02-13 13:49:44 -08:00
John Eismeier 7f3a46bfb3
Propose fix a typo 2018-02-13 14:48:11 -05:00
Yongkun Anfernee Gui c07258b45a Fix more permissions 2018-02-09 14:32:53 -08:00