Commit Graph

4217 Commits (61583d62492e2be0387563f460c56b1afba264c1)

Author SHA1 Message Date
Thomas Stromberg c6e6013d40 Update unit tests 2020-07-29 14:08:48 -07:00
Thomas Stromberg 59d0d7335a Add HTTP-like status codes, remove unused fields 2020-07-29 13:57:06 -07:00
Thomas Stromberg aa3d2a2a8a Improve handling of pause/unpause/stop/delete steps 2020-07-28 13:26:09 -07:00
Thomas Stromberg ac1f901160 Allow non-start steps 2020-07-28 13:07:37 -07:00
Thomas Stromberg 448ec75c8c Add support for storing/retrieving transient status 2020-07-27 21:34:52 -07:00
Sharif Elgamal d546ea1b5c
Merge pull request #8817 from sharifelgamal/restart-kubelet
restart kubelet if config changes
2020-07-24 15:48:53 -07:00
Medya Gh 47ed4bc23c update lint version 2020-07-24 14:45:15 -07:00
Medya Ghazizadeh 1395c8017c
Merge pull request #8784 from Dean-Coakley/disable-podman2
Warn user for podman2 version
2020-07-24 14:40:18 -07:00
Medya Ghazizadeh 8f404164d0
Merge pull request #8745 from littleroad/error_detect
Add error handling for os.RemoveAll
2020-07-24 14:38:10 -07:00
Dean Coakley dc566bec0b Remove warning prefix 2020-07-24 21:49:13 +01:00
Dean Coakley 57649f8ee8 Quote version numbers 2020-07-24 21:42:20 +01:00
Dean Coakley fa04c83b83 Use UI for logging 2020-07-24 21:25:19 +01:00
Thomas Stromberg 9c0618f102 Merge to master 2020-07-24 11:22:59 -07:00
Medya Ghazizadeh 76b98ace96
Merge pull request #8827 from tstromberg/kic-longer
Increase maximum container startup wait from 13 seconds to 25 seconds
2020-07-24 11:10:39 -07:00
Sharif Elgamal b9c218261d adding debugging 2020-07-24 10:45:14 -07:00
Thomas Stromberg f8f689b5cc Merge branch 'master' into kic-show-errs 2020-07-24 09:06:56 -07:00
Thomas Stromberg bd713ffd45 Increase maximum container startup wait from 13 seconds to 25 seconds 2020-07-24 09:02:32 -07:00
Thomas Stromberg dee9c0b427 Show 'docker logs' excerpt if container dies 2020-07-24 08:58:09 -07:00
Thomas Stromberg e172a7ee1c Avoid panic: runtime error: invalid memory address or nil pointer dereference 2020-07-24 08:48:20 -07:00
Dean Coakley db4bf9ec2a Log warning instead of exit with error 2020-07-24 11:30:23 +01:00
Sharif Elgamal be160406ec remove space 2020-07-23 14:45:42 -07:00
Sharif Elgamal 82c4d49eb8 restart kubelet if config changes 2020-07-23 14:43:23 -07:00
Medya Ghazizadeh 993504e054
Merge pull request #8800 from priyawadhwa/improve-json
Improve json integration test
2020-07-23 10:23:36 -07:00
Medya Ghazizadeh f230ca0c55
Merge pull request #8804 from medyagh/hot_upgrade_fix
Stop kube-system containers before applying configuration updates
2020-07-23 10:03:54 -07:00
Medya Ghazizadeh b7b26ea2d5
Merge pull request #8737 from dddddai/master
Use RWMutex instead of Mutex
2020-07-23 09:57:25 -07:00
Medya Gh 44b6703e68 update comment 2020-07-23 09:17:30 -07:00
Medya Gh d5cc6afc9b update comment 2020-07-23 09:17:06 -07:00
Priya Wadhwa 2cba801d50 fix order 2020-07-22 20:47:41 -04:00
Priya Wadhwa a03f25e976 add step to register 2020-07-22 18:50:42 -04:00
Priya Wadhwa 22226ffc8f fixed merge conflict 2020-07-22 18:46:57 -04:00
priyawadhwa 25566c90f0
Merge pull request #8796 from priyawadhwa/error
Add support for Error type to JSON output
2020-07-22 18:43:46 -04:00
Priya Wadhwa df0bc948bc Add logging to none driver 2020-07-22 18:42:38 -04:00
Medya Gh 9fa1dfdaec
stop conainers before hot upgrade 2020-07-22 15:14:57 -07:00
Priya Wadhwa 3f18ecb052 add log 2020-07-22 15:01:22 -04:00
Priya Wadhwa efe1ce278a Add docs 2020-07-22 14:20:41 -04:00
Medya Ghazizadeh f2100e365d
Merge pull request #8697 from medyagh/improv_sa_apply
improve applying default service account
2020-07-22 11:00:07 -07:00
Sharif Elgamal ad083ba7ac
Merge pull request #8778 from sharifelgamal/hyerpv
allow for prefixed interface names for hyperv
2020-07-21 16:07:42 -07:00
Sharif Elgamal 58d4b0c32f add less restrictive interface name matching 2020-07-21 15:32:38 -07:00
Priya Wadhwa 6a33c03df2 fix unit test 2020-07-21 18:23:22 -04:00
Priya Wadhwa 8bc875d520 Rebased on master; fixed json_output integration test 2020-07-21 18:20:02 -04:00
priyawadhwa 6df5d19d70
Merge pull request #8793 from priyawadhwa/warning
Implement Warning type for JSON output
2020-07-21 18:17:54 -04:00
Medya Ghazizadeh 85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
Sharif Elgamal 1b6eee675b
Automated GCP Credentials Addon Prototype (#8682)
* metadata addon works

* Add code for metadata server image and makefile rules

* remove log message

* update to work with v1.13.11

* update readme

* fix metadata addon stuff for newer codebase

* buncha changes

* just so many changes

* ch-ch-ch-ch-changes

* addon works

* update readme

* boilerplate

* revert unrelated change

* move server code to another repo

* switch addon name to gcp-auth

* metadata -> gcp-auth

* missed one

* automate finding of credentials

* remove unnecessary comment

* address comments

* Update README.md

* Update README.md

* use mustload everywhere

* swap selector condition

* upgrade kube-webhook-certgen to 1.3

* move paths to constants

* add notice to user on addon enable

* adding addon documentation

* move addons documentation inside handbook

* remove old addons docs location

Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
Medya Ghazizadeh 24fa6280dc
Merge pull request #8588 from afbjorklund/preload-crio-2
Use preloaded tarball for cri-o container runtime
2020-07-21 13:59:03 -07:00
Priya Wadhwa 6ca72229bb add json unit tests 2020-07-21 15:56:26 -04:00
Priya Wadhwa b4b9013057 Add unit test for problem.DisplayJSON() 2020-07-21 15:51:47 -04:00
Priya Wadhwa 482b9befd6 implement errors in JSON 2020-07-21 15:43:19 -04:00
Medya Ghazizadeh f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
Priya Wadhwa c60e754624 Implement warning type for JSON output 2020-07-21 14:40:31 -04:00
Shubham f42f79e56d (Addons) Create a new command in every retry
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd)
states that "... Cmd cannot be reused after calling its Run or
Start methods."

This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.

Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.

Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30