Commit Graph

113 Commits (5d16b30514ab68de1da8844e3a6c5a5869fe0eab)

Author SHA1 Message Date
josedonizetti 4d00a093d1 Fix error naming convention 2019-06-29 11:28:54 -03:00
josedonizetti 23ae121f2b kvm2: simplify connection error message 2019-06-29 10:53:13 -03:00
Jose Donizetti 9dfe660c64 Add support to custom qemu uri on kvm2 driver 2019-06-28 14:12:58 -07:00
Jose Donizetti 8acf4824df Add commit id to docker-machine-driver-kvm2 version 2019-06-28 13:45:54 -07:00
Jose Donizetti d6a839b20a Fix kvm2 vm driver remove domain 2019-06-26 18:36:52 -07:00
Pranav Jituri 6ba1725c08 Added Memory Size Checking 2019-06-26 00:22:41 +05:30
Medya Gh c7bf1ce7cd type check for drivers 2019-06-24 14:39:21 -07:00
Anders F Björklund f20f223c02 Decrease cyclomatic complexity
Here is the report (from gocyclo), before:

21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
2019-06-22 17:21:42 +02:00
Thomas Strömberg 4610663674
Merge pull request #4398 from josedonizetti/add-kvm-version-flag
Add kvm2 --version
2019-06-20 07:41:18 +08:00
Jose Donizetti a2d844ef51 Add kvm network name validation
closes for #3581
2019-06-15 13:56:12 -07:00
josedonizetti a024c6d22a Add kvm2 --version 2019-06-04 16:45:14 -03:00
josedonizetti 986c61d15e Fix kvm gpu log 2019-05-30 14:56:46 -03:00
Thomas Strömberg dbc64c053b
Merge pull request #4355 from josedonizetti/fix-kvm-remove-when-domain-is-not-defined
Fix kvm remove when domain is not defined
2019-05-28 17:07:53 -07:00
Thomas Strömberg dcb10332a0
Merge pull request #4334 from josedonizetti/refactor-kvm-lookup-status-ip
Refactor kvm lookupIPFromStatusFile
2019-05-28 10:26:02 -07:00
josedonizetti c09913070d Fix kvm remove when domain is not defined 2019-05-25 09:23:40 -03:00
Thomas Strömberg 8f9a3f448d
Merge pull request #4344 from josedonizetti/fix-kvm-remove-when-domain-is-not-running
Fix kvm remove when domain is not running
2019-05-24 13:55:04 -07:00
Thomas Strömberg bb56fd2eb7
Merge pull request #4323 from josedonizetti/fix-kvm-ensure-network
kvm2: Add support for --kvm-network to ensureNetwork
2019-05-24 10:47:41 -07:00
josedonizetti 48237d95b8 Clean up kvm Remove code 2019-05-24 14:27:55 -03:00
josedonizetti b65c7403cf Add error warp to destroyRunningDomain 2019-05-24 14:27:55 -03:00
josedonizetti 3124f11e1b Fix kvm remove when domain is not running 2019-05-24 14:27:55 -03:00
josedonizetti 81f0d9ba37 Fix kvm remove warn message 2019-05-24 12:38:00 -03:00
josedonizetti 1852a72caf Refactor kvm lookupIPFromStatusFile 2019-05-23 15:38:02 -03:00
josedonizetti fc2e2e52c5 Skip kvm network deletion if private network doesn't exist 2019-05-23 06:17:12 -03:00
josedonizetti 93329f1619 Remove obsolete comment 2019-05-22 17:25:27 -03:00
josedonizetti e3bf4bd7ec Fix kvm ensureNetwork 2019-05-22 16:19:09 -03:00
josedonizetti e9a450df66 Validate kvm network exists 2019-05-21 16:19:15 -03:00
tstromberg e53c0339ea This is my testament to Chesterton's Fence 2019-05-15 11:44:16 -07:00
tstromberg 340c8faced Remove crazy recursive permissions check that was chowning /home 2019-05-15 10:17:44 -07:00
Thomas Stromberg 6e693d22ee lint-a-geddon is here 2019-05-13 21:43:52 -07:00
tstromberg 9a9f9edf5f First pass at lint-ageddon 2019-05-13 18:31:55 -07:00
Anders F Björklund 6491e35c20 Add explicit kvm2 flag for hidden KVM signature 2019-03-24 09:47:38 +01:00
Anders F Björklund edf46f003f Document all exported functions outside minikube 2019-03-16 16:57:37 +01:00
Anders F Björklund 46640cef68 Address all lint except undocumented and stutter
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"

"type name will be used as foo.FooBar by other packages,
 and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
Alasdair Tran 7ba01b40a9 Hide KVM signature 2018-12-15 21:47:41 +11:00
Thomas Stromberg 3706b3b8ac Fix dangling format issues. 2018-09-28 16:48:37 -07:00
Thomas Stromberg 055c8002b1 Replace %s format directives with %v for errors.
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
Marcus Heese 5d0e12327a
turning error into a warning log message 2018-09-26 13:53:57 -07:00
Marcus Heese 4eb2cdb120
inlining deleteNetwork into if statement 2018-09-24 14:04:01 -07:00
Marcus Heese 5e38bf4819
kvm2 driver: fixed documentation link in error text 2018-09-21 10:28:52 -07:00
Marcus Heese 34ee59192b
kvm2 driver: be more robust with creating of the network, don't delete the network if it is in use 2018-09-21 10:28:47 -07:00
Marcus Heese b35e908dec
kvm2 driver: generate separate random MACs for default and private network NICs 2018-09-21 10:28:43 -07:00
Marcus Heese c4ef7ad197
kvm2 driver: separated activating and creating of networks 2018-09-21 10:28:37 -07:00
Marcus Heese d1995d24f0
kvm2 driver: fixed private network creation and setup 2018-09-21 10:28:33 -07:00
AdamDang 22ab50aa7e Correct typo in the returned message
coundn't->couldn't
2018-09-04 05:49:04 -05:00
dlorenc 23fc22e532 Fix docs for kvm2 2018-07-23 09:02:33 -07:00
Rohit Agarwal 87d7a3208a Update KVM driver installation instructions.
Move the latest instructions out of the comments and move old instructions into the comments.
2018-07-20 07:57:14 -07:00
Rohit Agarwal 268c932240 Add GPU support to minikube. 2018-07-08 22:25:48 -07:00
Luke Weber 05161c1b18 Fixes https://github.com/kubernetes/minikube/issues/2274 2018-07-04 09:26:50 -07:00
Rohit Agarwal 0df67ee4af Changes to make 'virsh console minikube' work. 2018-06-11 08:45:59 -07:00
dlorenc b54950fb2b Start the default network for the kvm2 driver. 2018-05-11 13:07:19 -07:00
Viktor Safronov 9ad5b4a190 Disable dnsmasq on minikube-net network for kvm driver 2018-04-20 07:40:43 -07:00
Fabian Deutsch ee58133538 kvm2: Switch to CPU passthrough mode by default
With passthrough mode we can enable KVM nesting for guests.

Fixes #2553

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
2018-02-22 10:42:20 -08:00
Fabian Deutsch b08b8ab8ae Revert "kvm: Passthrough host CPU in order to allow nesting"
This reverts commit 7a4babe1d6.

For now we just hard-code passthrough.

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
2018-02-22 10:42:20 -08:00
Fabian Deutsch 3ddf9d65f6 kvm: Passthrough host CPU in order to allow nesting
Before this patch the virtual CPU was the stock qemu CPU, in the sense that
the virtual CPU features were set according to the default qemu CPU.

With this change the CPU features of the host will be copied at start to the
domain definition. This includes features like svm and vmx, which in turn allow
to run nested virtualization if the host is configured accordingly i.e.
`kvm_intel nested=y` in `/etc/modprobe.d/kvm.conf`.

To turn on nesting, a user has to specify `--kvm-cpu-model host-model` when
creating the VM.

Resolves #2553

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
2018-02-22 10:42:20 -08:00
dlorenc 8f91c37bba Properly support the "minikube-net" network. 2017-12-13 21:18:00 -08:00
Zak B. Elep 56608e418d kvm2: Set group executable bit on machine-specific directory and up
Ensure that the directories leading to the KVM image have enough
permission for libvirt/QEMU to traverse, especially in the case where
libvirt/QEMU group is set to to `kvm`/`users`.
2017-12-10 17:49:54 -08:00
Matt Rickard 9fc8eed51d
Merge pull request #2076 from r2d4/kvm-mac
Use mac instead of hostname to find IP
2017-11-01 08:40:55 -07:00
Matt Rickard 2c2c45d7a6 DOM_SHUTDOWN should return state.Running
Technically, DOMAIN_SHUTDOWN just means that the VM is in the process
of shutting down.  We should still return state.Running so that we
don't return from `minikube stop` before the domain is actually
stopped.  This should fix a few flakes.
2017-10-23 11:23:58 -07:00
Matt Rickard b7012aefcc Use mac instead of hostname to find IP 2017-10-19 09:16:24 -07:00
Matt Rickard 547d22f638 Clean up unused files, add tar rules 2017-09-19 15:45:18 -07:00
Matt Rickard ebbc34d2ba Move drivers to pkg/drivers, share utils
Share most of the disk image setup between hyperkit and kvm drivers.
Move and remove a lot of shared configuration between all the in-tree
drivers: kvm, hyperkit, none.
2017-09-12 14:29:22 -07:00
Matt Rickard 53341aa30d golint, go vet, etc. changes 2017-09-11 14:17:58 -07:00
Matt Rickard 48b165808c Bring KVM driver in-tree
Add boilerplate

Review feedback
2017-08-28 11:52:35 -07:00