Medya Gh
40a011c49a
use api port for host binding port
2020-01-08 16:09:24 -08:00
Medya Gh
cf9e6e512f
fix ineffectual assignment
2020-01-08 15:21:57 -08:00
Medya Gh
ddf5ab027a
add extra option fail swap for kic
2020-01-08 12:53:29 -08:00
Medya Gh
f80572bb4c
code review
2020-01-07 13:59:41 -08:00
Medya Gh
618b150bcd
fix setup kubeconfig for kic
2020-01-07 13:54:00 -08:00
Medya Gh
d298593d8a
refactor api server verification
2020-01-07 13:54:00 -08:00
Medya Gh
e9b7451278
auto set podsubnet for kic improve none auto set
2020-01-07 13:54:00 -08:00
Medya Gh
860ce25bf2
Add podSubnet to templates
2020-01-07 13:54:00 -08:00
Medya Gh
c7bc61af2c
Add overlay network for kic
2020-01-07 13:54:00 -08:00
Medya Gh
6cf2554877
add flag for kic host binding port
2020-01-07 13:54:00 -08:00
Medya Gh
a358aff093
fix ocibinary
2020-01-07 13:52:47 -08:00
Medya Ghazizadeh
19e7ea4c40
Merge pull request #6217 from tiendc/unit_test_config_get
...
Add unit test for cmd/minikube/cmd/config/get.go
2020-01-07 11:48:11 -08:00
Medya Ghazizadeh
d23b446d2e
Merge pull request #6218 from afbjorklund/reportcard-minor
...
Improve reportcard by refactoring and commenting
2020-01-07 11:42:55 -08:00
Dao Cong Tien
60f514c0a5
Add unit test for cmd/minikube/cmd/config/set.go
...
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
2020-01-07 14:02:05 +07:00
Thomas Strömberg
af4ee5cf1f
Merge pull request #6124 from priyawadhwa/addon-per-profile-refactor
...
Enable or disable addons per profile
2020-01-06 16:33:01 -08:00
Anders F Björklund
ea7a2d7e33
Improve reportcard by refactoring and commenting
...
golint: 99%
pkg/minikube/localpath/localpath.go
Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
pkg/minikube/cluster/cluster.go
Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
cmd/minikube/cmd/start.go
Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
Dao Cong Tien
743c67d40e
Add unit test for cmd/minikube/cmd/config/get.go
...
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
2020-01-06 18:49:31 +07:00
Anders F Björklund
81622e2a00
Minor: change assignment to declaration
...
"warning: ineffectual assignment to updated (ineffassign)"
2020-01-04 10:23:16 +01:00
Priya Wadhwa
e47cde6ae4
Rebased on master, moved istio addon into new package
2019-12-30 10:10:05 -05:00
Medya Ghazizadeh
df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
...
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
fenglixa
c2ba574f2e
generate istio document page and layout
2019-12-26 14:35:13 +08:00
andylibrian
f42c8a49fb
fixed comment
2019-12-21 18:34:40 +07:00
andylibrian
76714aca84
implemented options command #5036
...
This is to fix help command showing invalid "minikube <command> options".
It happened because minikube reuses kubectl templates which expects
options cmd to be there.
2019-12-21 11:09:36 +07:00
Medya Gh
d5f56477bc
code review resolve
2019-12-20 17:14:14 -08:00
Medya Gh
3b2cfa6c32
rename funcs
2019-12-20 16:53:35 -08:00
Medya Gh
83cd426436
refactor more
2019-12-20 16:11:05 -08:00
Medya Gh
cf6bde8eaf
refactor image specific funcs to image package
2019-12-20 16:05:08 -08:00
Medya Gh
be8a1ad107
resolve code reviews
2019-12-20 12:43:13 -08:00
Priya Wadhwa
6c25cd3848
Rebased on master
2019-12-20 12:34:48 -08:00
Medya Gh
5eb384cf7d
check error and fix logging msg
2019-12-20 12:24:05 -08:00
Medya Gh
a3e16fae72
add reload command
2019-12-20 12:06:26 -08:00
Medya Gh
2d1fffe1d1
better names
2019-12-20 12:06:26 -08:00
Medya Gh
679a9c114b
more clear func names
2019-12-20 12:06:26 -08:00
Medya Gh
71a896fc0a
unexport func cacheImage
2019-12-20 12:06:25 -08:00
Medya Gh
193d16dd0c
rename funcs for more clarity
2019-12-20 12:06:25 -08:00
Medya Gh
03c717c7b0
unexport cacheImagesInConfigFile func
2019-12-20 12:06:25 -08:00
Medya Ghazizadeh
031126b358
Merge pull request #6112 from medyagh/kic_start_xmas
...
kic-xmas edition
2019-12-20 11:40:46 -08:00
Medya Gh
1014a57ea8
better names for bs type
2019-12-20 01:01:10 -08:00
tstromberg
bf183603c5
Disable StartHost retry. It caused more problems than it solved
2019-12-19 16:10:44 -08:00
Priya Wadhwa
b64a33a6e9
updated dashboard command to use new addons library
2019-12-19 15:39:29 -08:00
Priya Wadhwa
fa08e18e8d
goimports
2019-12-19 13:33:19 -08:00
Priya Wadhwa
859420c083
Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor
2019-12-19 13:06:07 -08:00
Priya Wadhwa
f6c61b7a80
Make sure minikube start --addons works
2019-12-19 12:44:32 -08:00
Thomas Strömberg
4e0454d6b4
Merge pull request #6111 from tstromberg/awful-offl
...
Offline: always transfer image if lookup fails, always download drivers
2019-12-19 11:52:28 -08:00
Thomas Strömberg
aca49067fa
Merge pull request #6110 from digitalcoyote/master
...
Fixed IPv6 format for SSH
2019-12-19 11:51:55 -08:00
Priya Wadhwa
4c7b94971c
Address review comments
...
Remove old TODO and remove function to get current profile as it can
create errors when trying to get multiple profiles.
2019-12-19 10:41:01 -08:00
Kenta Iso
6316959739
Fix update-context to use KUBECONFIG when the env is set and add integration test
2019-12-19 00:28:39 -08:00
Priya Wadhwa
921fee7432
Moved unit tests to addons package and refactored them
2019-12-18 22:02:10 -08:00
Priya Wadhwa
e72cb80cbf
Enable/disable addons works per profile
...
However, this means that addon information won't persist beyond a 'minikube delete'
2019-12-18 21:35:46 -08:00
Medya Gh
b8d07daef3
move reusabe parts of kubeadm to a package
2019-12-18 17:22:42 -08:00