tstromberg
b97124207c
Move addon enablement to addons module + lint fixes
2020-01-30 17:46:25 -08:00
tstromberg
d5a83c7b24
Add addon enablement to start
2020-01-30 15:54:04 -08:00
Priya Wadhwa
8d8ea98378
check cmd.Remove error for linting
2020-01-22 15:11:33 -08:00
Priya Wadhwa
15a5209841
Update unit tests
2020-01-22 14:23:32 -08:00
Priya Wadhwa
7247a7dee6
Switched to using kubectl apply and kubectl delete for addons
...
kubectl apply with --prune wasn't working because it requires the
--namespace flag to be passed in and we have multiple namespaces for
addons.
We tried to split up addons within /etc/kubernetes/addons by
namespace, but this didn't work when disabling dashboard addon because
there were no files left in the kubernetes-dashboard subdirectory. So,
kubectl apply complained when trying to prune dashboard because no files
were being passed in.
So, I ended up removing all dependencies on prune and instead running
`kubectl apply` when enabling an addon and running `kubectl delete` when
disabling an addon.
2020-01-22 14:18:20 -08:00
Priya Wadhwa
de4ecb9706
Rebased on master
2020-01-22 13:10:50 -08:00
Priya Wadhwa
180b23f2c8
Save addons in subdirectories, separated by namespace
...
This way we can pass the correct --namespace flag into 'kubectl apply'
such that it works with '--prune' for kubectl >=v.17.0
2020-01-22 13:09:37 -08:00
Priya Wadhwa
28148c5f3d
Remove addon manager
2020-01-16 11:47:01 -08:00
Priya Wadhwa
f5be457399
fix unit tests
2020-01-14 12:12:47 -08:00
Priya Wadhwa
9a2de2ae7f
Hook up new addon manager logic to existing addons code
2020-01-14 10:52:27 -08:00
Anders F Björklund
d265162fe2
Fix some minor issues from gofmt and golint
2020-01-13 21:38:59 +01:00
Priya Wadhwa
6ad7e4a9a0
address code review comments
...
add better error handling and remove duplication in enableOrDisableAddonsInternal
2020-01-06 13:42:09 -08:00
Priya Wadhwa
e47cde6ae4
Rebased on master, moved istio addon into new package
2019-12-30 10:10:05 -05:00
Priya Wadhwa
4c7b94971c
Address review comments
...
Remove old TODO and remove function to get current profile as it can
create errors when trying to get multiple profiles.
2019-12-19 10:41:01 -08:00
Priya Wadhwa
43a7267079
make public methods that aren't used outside of the package private
2019-12-18 22:33:00 -08:00
Priya Wadhwa
ceb4938c7a
Add more unit tests
2019-12-18 22:27:32 -08:00
Priya Wadhwa
921fee7432
Moved unit tests to addons package and refactored them
2019-12-18 22:02:10 -08:00
Priya Wadhwa
e72cb80cbf
Enable/disable addons works per profile
...
However, this means that addon information won't persist beyond a 'minikube delete'
2019-12-18 21:35:46 -08:00
Priya Wadhwa
ba8b723978
Move addon related logic to pkg/addons for better organization
2019-12-18 11:31:29 -08:00