Commit Graph

4609 Commits (4fc095df772e5d9387abcc03497e211f91253c90)

Author SHA1 Message Date
Medya Gh fa0afb220d lint 2020-09-29 14:14:25 -07:00
Medya Gh f0f10d6135 first version 2020-09-29 14:14:24 -07:00
Medya Gh 9cd42163b1 add network create funcs 2020-09-29 14:14:24 -07:00
Sharif Elgamal ff051f9a33
Make sure gcp-auth addon can be enabled on startup (#9318)
* fix documentation for gcp-auth addon

* make sure kube-system pods are up before enabling gcp-auth

* fix lint

* add failurePolicy for webhook

* only install addons if asked

* better comment

* slightly less hacky code

* defer addons properly

* simplify code for performance
2020-09-29 13:29:14 -07:00
Medya Ghazizadeh 09dd4b748d
Merge pull request #9342 from tstromberg/logs-api
hyperv: Make interface search name match case-insensitive
2020-09-29 15:26:34 -05:00
Medya Ghazizadeh 0d6b6fcce7
Merge pull request #9343 from tstromberg/docker-detect
Add 'docker status' check, improve deadline-exceeded error message
2020-09-29 15:24:43 -05:00
Medya Gh b3401405f0 update kicbase image to ubuntu-based 2020-09-29 13:03:11 -07:00
Thomas Stromberg 91a32541e8 Use %d for exit code 2020-09-29 09:49:30 -07:00
Thomas Stromberg 8eaa3ee4f3 Use oci.CachedDaemonInfo for status check 2020-09-29 09:19:14 -07:00
Medya Ghazizadeh be496e1053
Merge pull request #9346 from afbjorklund/gofmt-register
Run gofmt on code, to avoid modified workspace
2020-09-29 11:15:43 -05:00
Medya Ghazizadeh 3b26a646e8
Merge pull request #9348 from priyawadhwa/unable-to-download
Compare fully qualified image names when pulling kic base image
2020-09-29 11:14:12 -05:00
Priya Wadhwa c2642c3a5c Compare fully qualified image names when pulling kic
Fixes a small bug where we were comparing one fully qualified image (tag+digest) to an image that had only tag specified. This resulted in an unnecessary warning, which only showed up when the base image was loaded from a tarball. This happens on Cloud Shell.
2020-09-28 16:35:33 -04:00
Anders F Björklund cf7df774a1 Run gofmt on code, to avoid modified workspace 2020-09-28 21:42:55 +02:00
Anders F Björklund 647c857fe1 Fix error in unittest, as pointed out by warning
"conversion from int to string yields a string of one rune,
not a string of digits (did you mean fmt.Sprint(x)?)"
2020-09-28 21:40:14 +02:00
Thomas Stromberg 4fa2e414fb Merge branch 'master' into docker-detect 2020-09-28 11:36:18 -07:00
Thomas Stromberg 1ffd800c29 Add comment 2020-09-28 11:27:05 -07:00
Thomas Stromberg 96e35e0d70 Add 'docker status' check, improve deadline-exceeded error message 2020-09-28 11:17:59 -07:00
Thomas Stromberg d34a24020f hyperv: Make interface search name match case-insensitive 2020-09-28 09:56:19 -07:00
Anders F Björklund e6b510543e Don't trim whitespace while extracting strings
Remove some leading and trailing whitespace from non-string
constructs like description and automatic extraction filters.

But don't change all the translations or the translations here,
since that would make this code change impossible to review.
2020-09-27 17:59:06 +02:00
Sharif Elgamal fb878f6f62
Merge pull request #9324 from sharifelgamal/time-cmd
give the logs test a little wiggle room
2020-09-25 12:23:32 -07:00
Thomas Strömberg 75332f7c89
Merge pull request #8901 from bluestealth/MiB
Use mebibytes instead of megabytes
2020-09-25 11:28:41 -07:00
Thomas Strömberg ed6b756da0
Merge pull request #9308 from priyawadhwa/performance-monit
Add PR bot code to repo
2020-09-25 10:34:36 -07:00
Sharif Elgamal b4b181b647 give the logs test a little wiggle room 2020-09-25 10:06:45 -07:00
Priya Wadhwa c005cda301 Print solution message when there is no space left on device
during preload extraction.
2020-09-24 13:03:57 -04:00
Medya Ghazizadeh 183bdb2354
Merge pull request #9302 from dominikbraun/#9297-reason-for-missing-config-permissions
Return ExHostPermission for insufficient config file permissions
2020-09-23 14:20:41 -05:00
Dominik Braun 02cdb59184 Use HostHomePermission variable in known_issues.go 2020-09-22 21:40:26 +02:00
Priya Wadhwa 3f457dbdc1 fix error handling 2020-09-22 14:14:04 -04:00
Priya Wadhwa 3d547a937f Fix Makefile rule to build bot 2020-09-22 14:00:27 -04:00
Priya Wadhwa 3f44d470eb Add performance monitor code 2020-09-22 13:54:23 -04:00
Dominik Braun 8f4127b202 Use HOST_HOME_PERMISSION kind for insufficient permissions 2020-09-22 18:04:24 +02:00
Dominik Braun 603ae8fc6d Return ExHostPermission for insufficient config file permissions 2020-09-22 10:16:27 +02:00
Priya Wadhwa f6b524b372 add profile arg 2020-09-21 19:05:58 -04:00
Priya Wadhwa 98591a6656 Add advice for the DRV_CP_ENDPOINT error 2020-09-21 16:35:50 -04:00
Sharif Elgamal 615b05bf9e
Merge pull request #9265 from tstromberg/v1.19.2
Update DefaultKubernetesVersion to v1.19.2
2020-09-18 16:14:17 -07:00
Thomas Stromberg 464a742a7e Merge branch 'master' into v1.19.2 2020-09-18 11:48:03 -07:00
Sharif Elgamal cf0e99adf6 Merge branch 'master' of github.com:kubernetes/minikube into windows-mount 2020-09-17 16:07:50 -07:00
Sharif Elgamal 1168b1aa7d Merge branch 'master' of github.com:kubernetes/minikube into revert-native 2020-09-17 14:40:24 -07:00
Sharif Elgamal f097a0de12 dates, take two 2020-09-17 13:20:35 -07:00
Sharif Elgamal 775e047517 dates 2020-09-17 13:18:53 -07:00
Sharif Elgamal 3cb6ba0f75 actually add unit tests 2020-09-17 13:16:07 -07:00
Sharif Elgamal 84ee6d351b unit tests 2020-09-17 13:11:01 -07:00
Sharif Elgamal 39ae4fbdd2 check for windows style pathing with a regex 2020-09-17 12:15:54 -07:00
Sharif Elgamal 23e7989c07 Merge branch 'master' of github.com:kubernetes/minikube into windows-mount 2020-09-17 11:12:35 -07:00
Sharif Elgamal b98580c820 fix up if statement 2020-09-17 10:31:10 -07:00
Sharif Elgamal eab92dc455 Reduce cyclotomic complexity of CreateContainerNode to fix lint 2020-09-17 10:22:28 -07:00
Thomas Stromberg 942eb539e6 Update DefaultKubernetesVersion to v1.19.2 2020-09-16 17:44:15 -07:00
Medya Ghazizadeh a2c2a83903
Merge pull request #8918 from Dean-Coakley/add-pruneDocker-helper
Add prune docker images instructions
2020-09-16 16:44:02 -07:00
Sharif Elgamal 4a004dd58e simplify more 2020-09-16 16:39:03 -07:00
Sharif Elgamal 14a5b0b264 simplify append 2020-09-16 16:04:10 -07:00
Sharif Elgamal 6e9b1b7bc0 fix mounting for docker driver in windows 2020-09-16 14:55:40 -07:00
Medya Ghazizadeh dc0b1aaa3a
Merge pull request #9239 from afbjorklund/podman-storage
Add podman storage warning to match docker
2020-09-16 14:53:56 -07:00
Sharif Elgamal 070cbb99ee
Merge pull request #8461 from 11janci/jjanik-enable-volumesnapshots
CSI Hostpath Driver & VolumeSnapshots addons
2020-09-16 11:57:42 -07:00
Medya Ghazizadeh 022d4ceefc
Merge pull request #9207 from tstromberg/v1.19.1
Update default Kubernetes release to v1.19.1
2020-09-15 16:10:22 -07:00
Medya Ghazizadeh 44c6f36362
Merge pull request #9255 from afbjorklund/cpus-cfs
Make sure CFS_BANDWIDTH is available for --cpus
2020-09-15 16:07:12 -07:00
Medya Ghazizadeh 48a32a02a8
Merge pull request #9237 from afbjorklund/podman2-port
Fix ForwardedPort for podman version 2.0.1 and up
2020-09-15 14:51:44 -07:00
Anders F Björklund 359efd68b2 Avoid setting time for memory assets
These do not have any file modification time

Previously used '0001-01-01 00:00:00 +0000'
2020-09-15 17:15:16 +02:00
Anders F Björklund f718e39ab9 Make sure CFS_BANDWIDTH is available for --cpus 2020-09-15 12:54:39 +02:00
Sharif Elgamal 13f6c042db revert native-ssh change 2020-09-14 16:45:34 -07:00
Anders F Björklund b4d4be8e23 Add podman storage warning to match docker 2020-09-13 23:04:31 +02:00
Anders F Björklund af5d6d060b Fix ForwardedPort for podman version 2.0.1 and up
Increasing Docker compatibility broke Podman v1
2020-09-13 22:17:36 +02:00
Medya Ghazizadeh ef7e7e8e6f
Merge pull request #9152 from zhijianli88/extract
fix make extract
2020-09-09 15:01:35 -07:00
Sharif Elgamal ee5b8f130f
Merge pull request #8831 from priyawadhwa/overlay
Set preload=false if not using overlay2 as docker storage driver
2020-09-09 11:45:52 -07:00
Thomas Stromberg c401b42622 Update default Kubernetes release to v1.19.1 2020-09-09 11:20:45 -07:00
Dean Coakley dcd00b2150 Make prune conditional. Add podman to prune instruction 2020-09-08 23:37:25 +01:00
jjanik ae92c289b8 add csi-hostpath-driver addon 2020-09-04 18:54:33 +02:00
jjanik c5ae7b9580 add volumesnapshots addon 2020-09-04 17:10:54 +02:00
Li Zhijian 2ad4cae53a fix make extract
> err_map.go is not gone, it was just renamed in a recent refactor:
> https://github.com/kubernetes/minikube/blob/master/pkg/minikube/reason/known_issues.go

$ make extract
go run cmd/extract/extract.go
panic: err_map.go doesn't exist

goroutine 1 [running]:
main.main()
	/home/lizj/workspace/k8s/minikube/cmd/extract/extract.go:47 +0x1b4
exit status 2
Makefile:304: recipe for target 'extract' failed
make: *** [extract] Error 1

Fixes #9126
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-09-04 16:53:58 +08:00
Sharif Elgamal d2073c1191 Merge branch 'master' of github.com:kubernetes/minikube into add-kubectl 2020-09-03 13:30:18 -07:00
Sharif Elgamal 3f9c6d10d9
Merge pull request #9177 from tstromberg/known_issues3
Refresh known issues map
2020-09-03 11:03:41 -07:00
Thomas Stromberg 257ef16de8 Fix --insecure-registry typo 2020-09-03 09:54:03 -07:00
Asare Worae d9ce04f18a fix GuestMountConflict exit code 2020-09-03 18:51:46 +02:00
Asare Worae 4e772347d4 exit on existing cluster start with KiC driver mount configuration change 2020-09-03 18:25:10 +02:00
Thomas Stromberg d0228ddf20 Refresh known issues map 2020-09-03 09:21:26 -07:00
Sharif Elgamal 3c86db01f4
Merge pull request #9166 from priyawadhwa/revert-static-ip
Revert static IP for docker
2020-09-02 15:49:40 -07:00
Thomas Strömberg dab20a2e12
Merge pull request #9163 from tstromberg/driver-advice
docker: Improve overlay module check (behavior & UX)
2020-09-02 14:56:04 -07:00
Thomas Strömberg 914f10b458
Merge pull request #9149 from tstromberg/docker-no-swap
Disable swap in Docker & podman containers
2020-09-02 14:55:44 -07:00
Sharif Elgamal cffd317731 Merge branch 'master' of github.com:kubernetes/minikube into add-kubectl 2020-09-02 13:38:11 -07:00
Priya Wadhwa 22b40e215a revert static IP 2020-09-02 16:33:38 -04:00
Sharif Elgamal dd48dab036
Merge pull request #9164 from sharifelgamal/trim-project
trim whitespace when setting gcp project id
2020-09-02 13:28:54 -07:00
Sharif Elgamal ed4271ffbc trim whitespace when setting gcp project id 2020-09-02 11:42:47 -07:00
Thomas Stromberg 1fdf1637d7 Fix sysfs path 2020-09-02 11:39:02 -07:00
Thomas Stromberg 0ca05d92af Docker instead of Docker Service 2020-09-02 11:35:46 -07:00
Thomas Stromberg 465e15efe3 Use sysfs for a less-complicated overlay check 2020-09-02 11:33:57 -07:00
Thomas Stromberg 56cf67febe Don't suggest overlay kernel module if we are unable to check the status 2020-09-02 11:06:02 -07:00
Thomas Stromberg 0c1a117ef7 Docker for Desktop was renamed to Docker Desktop 2020-09-02 10:55:20 -07:00
Priya Wadhwa c91e47619b Better error message if binary does not exist 2020-09-02 13:43:04 -04:00
Thomas Stromberg c59210e1ef Skip overlay module suggestion on distros which do not support kernel modules, like WSL 2020-09-02 10:39:36 -07:00
Thomas Strömberg 78deeb5d1b
Merge pull request #9159 from priyawadhwa/upgrade-preload
Increase preload version to v6
2020-09-02 10:18:59 -07:00
Thomas Strömberg d1010424ac
Merge pull request #9151 from tstromberg/storage-provisioner-tag3
Bump storage-provisioner version to v3
2020-09-02 10:17:55 -07:00
Priya Wadhwa 1953f9310f Increase preload version to v6
We upgraded the dashboard image in #9129, this will rebuild tarballs to include the latest version.

This should also fix a small performance regression, where start time was increased by 25% on kvm2, probably becaues we were waiting for the new dashboard image to download. [PR bot comment](https://github.com/kubernetes/minikube/pull/9129#issuecomment-684035146)
2020-09-02 10:54:06 -04:00
Thomas Strömberg e3774449d5
Merge pull request #9143 from tstromberg/kc-recover
Repair kubecontext before checking cluster health
2020-09-02 07:53:59 -07:00
Priya Wadhwa ea5af644ec fix merge conflict 2020-09-02 09:31:42 -04:00
Thomas Strömberg d66a8e68c9
Merge pull request #8907 from sharifelgamal/external-ssh
respect native-ssh flag
2020-09-01 22:37:37 -07:00
Thomas Strömberg f8358d65d2
Merge pull request #9019 from AlexanderChen1989/master
fix multiple node calico-node not ready
2020-09-01 22:36:22 -07:00
Thomas Strömberg 939a3568ff
Merge pull request #9139 from priyawadhwa/download-only-mkcmp
mkcmp: download artifacts before timing start
2020-09-01 22:35:05 -07:00
Michael Ryan Dempsey 1859274e8a
refactor conversion functions into util 2020-09-01 21:21:07 -07:00
Michael Ryan Dempsey ad1e2e2de5
Use same conversion logic for bytes -> MiB everywhere 2020-09-01 21:20:09 -07:00
Michael Ryan Dempsey 6ad47f9560
use MiB for raw disk allocations 2020-09-01 21:20:08 -07:00
Michael Ryan Dempsey 9ff030942d
use MiB with kvm driver 2020-09-01 21:20:02 -07:00
Thomas Stromberg 72e786f73e Merge to master 2020-09-01 18:17:25 -07:00
Thomas Stromberg 51d1f2091c Update testdata 2020-09-01 16:49:49 -07:00
Thomas Strömberg 2dac55abf4
Merge pull request #9062 from kadern0/issue-8131
docker: Choose the appropriate bridge interface when multiple exist
2020-09-01 16:46:01 -07:00
Thomas Strömberg fae2358791
Merge pull request #8839 from staticdev/nginx-slow-version
Bump nginx-ingress-controller
2020-09-01 16:35:33 -07:00
Thomas Strömberg 8a26881552
Merge pull request #8159 from Asarew/docker-host-volumes
Support for mounting host volumes on start with docker driver
2020-09-01 16:30:45 -07:00
Thomas Strömberg 3fbbb557b1
Merge pull request #9032 from zhijianli88/cleanup-tempfiles2
Cleanup tempfiles2
2020-09-01 16:25:00 -07:00
Thomas Strömberg fba4de74cf
Merge pull request #8787 from saltbo/master
fix error usage for the WaitGroup in the pkg addons
2020-09-01 16:21:51 -07:00
Thomas Strömberg 79de7b116a
Merge pull request #9109 from vinu2003/fix-jsontypevalue-latestminikubeversion-startcmd
start: fixed the type value for latest minikube version availability message
2020-09-01 16:18:21 -07:00
Thomas Strömberg c31e6c6158
Merge pull request #9145 from tstromberg/mem-exit
Fix incorrect exit code for RsrcInsufficientDarwinDockerMemory
2020-09-01 16:05:23 -07:00
Thomas Strömberg b9d8aeaa31
Merge pull request #9148 from tstromberg/none-doc
Improve none usage documentation
2020-09-01 16:05:04 -07:00
Thomas Strömberg d84f87b3f2
Merge pull request #9129 from tstromberg/dashboard-bump
Update dashboard to v2.0.3
2020-09-01 16:01:47 -07:00
Thomas Strömberg 543247a1af
Merge pull request #9136 from priyawadhwa/leader-elect-bug
Fix --extra-config for scheduler/controllerManager by removing hardcoded values
2020-09-01 16:00:45 -07:00
Pablo Caderno 0408d3ba1a Added code to inspect docker networks to get the bridgeID correctly
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-09-02 08:44:07 +10:00
Priya Wadhwa a8bc207caf Merge branch 'master' of https://github.com/kubernetes/minikube into download-only-mkcmp 2020-09-01 17:33:46 -04:00
Thomas Stromberg 7fc0299c6f Disable swap in Docker/podman by setting --memory-swap to --memory 2020-09-01 13:57:52 -07:00
Thomas Stromberg 085bd38a09 Improve none usage documentation 2020-09-01 13:20:42 -07:00
Thomas Stromberg 2ec39f0ad6 Fix incorrect exit code for RsrcInsufficientDarwinDockerMemory 2020-09-01 10:59:27 -07:00
Dean Coakley 481cb50f74 Add leading newline for clarity 2020-09-01 15:08:57 +01:00
Dean Coakley e4a8e59cfa Add prune docker images instructions 2020-09-01 15:01:06 +01:00
Thomas Stromberg 4b53b465ce Repair missing/invalid kubecontext before checking cluster health 2020-09-01 06:24:23 -07:00
vinu2003 3e79f85065 start: fixed the type value for latest minikube version availability message 2020-09-01 22:54:09 +10:00
Thomas Strömberg 51a3155cfd
Merge pull request #9126 from tstromberg/error-code-for-everyone
Add a machine readable reason to all error paths
2020-08-31 22:34:24 -07:00
Thomas Strömberg cf7484ed59
Merge pull request #9128 from tstromberg/pvc-directory
Add namespace to persistent volume path
2020-08-31 22:34:03 -07:00
Priya Wadhwa 4a0d3fc703 fix lint' 2020-08-31 18:35:37 -04:00
Priya Wadhwa c2680cc9e4 Merge branch 'master' of https://github.com/kubernetes/minikube into unit-test 2020-08-31 18:35:19 -04:00
Priya Wadhwa 640f7254bc Fix unit test 2020-08-31 18:28:42 -04:00
Priya Wadhwa 5da473e46f fix unit test 2020-08-31 18:27:49 -04:00
Priya Wadhwa 12c9d7f1a8 print stderr to stderr 2020-08-31 18:22:05 -04:00
Priya Wadhwa f31d7781b0 Merge branch 'master' of https://github.com/kubernetes/minikube into download-only 2020-08-31 18:17:47 -04:00
Priya Wadhwa 7750b3c445 mkcmp: download artifacts before timing starT 2020-08-31 18:17:15 -04:00
Priya Wadhwa 695117f3d7 use GCS client to download binaries 2020-08-31 16:30:47 -04:00
Priya Wadhwa e323a6f86e Set leader-elect=false in code instead of in config
This sets leader-elect=false as extra options for the scheduler and controller manager. This way, users can easily override those values. This will also allow users to specify additional flags via `--extra-config` without overwriting the leader-elect section in the config.
2020-08-31 16:03:42 -04:00
Thomas Strömberg df906e5895
Merge pull request #9127 from kubernetes/windows-emoji
Add MINIKUBE_IN_STYLE auto-detection for Windows terminal
2020-08-31 12:58:12 -07:00
Thomas Stromberg 750cf39f1e Code review comments 2020-08-31 12:57:48 -07:00
Thomas Stromberg 09cdf602b8 Update TestFunctional/parallel/DryRun and TestJSONOutputError to match new behavior 2020-08-31 11:21:23 -07:00
Thomas Stromberg 69214c08bb Update test data 2020-08-31 11:11:25 -07:00
Thomas Stromberg 464bd48ea1 Update dashboard to v2.0.3 2020-08-30 22:32:20 -07:00
Thomas Stromberg c152570f6c Add namespace to persistent volume path 2020-08-30 22:27:04 -07:00
Thomas Stromberg b91b5f9cc4 Merge remote-tracking branch 'upstream/master' into windows-emoji 2020-08-30 22:11:27 -07:00
Thomas Stromberg 764f4a0b27 Add MINIKUBE_IN_STYLE auto-detection for Windows terminal 2020-08-30 21:54:36 -07:00
Thomas Stromberg f3cce500b0 Improve error disambiguation, especially for non-running drivers 2020-08-30 20:49:16 -07:00
Thomas Stromberg 7f5a06b606 Unwrap unnecessary level of error annotation for improved messages 2020-08-30 20:48:55 -07:00
Thomas Stromberg cd91fb8470 Unwrap unnecessary level of error annotation for improved messages 2020-08-30 20:48:20 -07:00
Thomas Stromberg 2c5e8fdaee Add detailed JSON & status codes for all error paths 2020-08-30 17:25:11 -07:00
Thomas Stromberg 305d3580ba Merge branch 'master' into 1.19.0-rc.4-updated 2020-08-28 10:33:17 -07:00
Thomas Strömberg c25a2e645c
Merge pull request #9111 from priyawadhwa/fix-kubelet
Don't enable kubelet until after kubeadm generates config
2020-08-28 10:32:40 -07:00
Priya Wadhwa 52724f956b Run kubelet-start after kubeconfig as recommended in 1.19 changelog 2020-08-28 12:23:25 -04:00
Priya Wadhwa b9aa9c0f0f Don't enable kubelet until after kubeadm generates /var/lib/kubelet/config.yaml 2020-08-28 12:19:36 -04:00
Thomas Stromberg a63a1ddcda Update to v1.19.0 final release 2020-08-26 13:27:05 -07:00
Thomas Stromberg cffa2ad0c7 Merge branch 'master' into 1.19.0-rc.4-updated 2020-08-26 13:26:05 -07:00
Priya Wadhwa 8a2ebd505b also output final event when complete 2020-08-26 12:16:17 -04:00