Anders F Björklund
46640cef68
Address all lint except undocumented and stutter
...
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"
"type name will be used as foo.FooBar by other packages,
and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
Thomas Strömberg
794bc6cedd
Merge pull request #3780 from afbjorklund/logs
...
Fix minikube logs for other container runtimes
2019-03-01 15:49:23 -08:00
Anders F Björklund
df5bbc3c8a
Fix minikube logs for other container runtimes
...
It is only Docker that adds the "k8s_" prefix, since CRI
only handles containers that are used by Kubernetes anyway.
Also need to use "sudo" when running all crictl commands,
including logs. And only list containers that are running.
2019-03-01 20:56:45 +01:00
Thomas Stromberg
b9675da28b
Add comment about optimization
2019-03-01 11:03:06 -08:00
Thomas Stromberg
a11e1c3c27
retry updateKubeProxyConfigMap
2019-03-01 10:54:18 -08:00
Thomas Stromberg
eae5b34100
Only restart kube-proxy if necessary, make certain steps retialble
2019-03-01 10:53:55 -08:00
Thomas Stromberg
a2865f183a
Back to the original 10 minute timeout :(
2019-03-01 10:50:39 -08:00
Thomas Stromberg
2f1f52edba
Add reconfiguring style
2019-02-28 16:40:55 -08:00
Thomas Stromberg
c40602b327
ReasonableStartTime = 8, for folks with CrashLooping DNS on none
2019-02-28 16:40:46 -08:00
Thomas Stromberg
a4be5ee438
Have StartCluster/RestartCluster block until system pods are healthy
2019-02-28 16:27:35 -08:00
Thomas Stromberg
3b2a81d409
Increase ReasonableStartTime from 5 to 9 minutes
2019-02-28 16:26:42 -08:00
Anders F Björklund
167d1584a6
Add flag for disabling the VirtualBox VTX check
...
Currently this is broken upstream, provide workaround...
Already available in docker-machine, so port to minikube.
2019-02-22 18:29:29 +01:00
Thomas Stromberg
5f77fc6c1a
Only call trySSHPowerOff if we are using hyperv
2019-02-16 07:47:00 -08:00
Thomas Strömberg
4142c6d967
Merge pull request #3680 from tstromberg/better-none
...
none UX: Reword warnings and other strings for accuracy
2019-02-15 10:38:07 -08:00
Anders F Björklund
166b423e6e
Implement CRI method ContainerLogCmd for rkt
2019-02-15 19:24:44 +01:00
Anders Björklund
1473c36fb9
Merge pull request #3678 from afbjorklund/rkt
...
Add implementation of the deprecated rkt runtime
2019-02-15 19:20:30 +01:00
Anders Björklund
4ae8fed6cd
Merge pull request #3675 from afbjorklund/images
...
Upgrade the list of images for 1.12 and 1.13
2019-02-15 19:19:02 +01:00
Thomas Stromberg
54b22649e9
Forgot to remove a warning
2019-02-15 10:07:09 -08:00
Thomas Stromberg
bb752098df
Drop all empty strings from containers list, add fake prefix in log messages
2019-02-15 09:46:15 -08:00
Thomas Stromberg
b80498fcb4
Merge from HEAD
2019-02-15 09:24:35 -08:00
Thomas Stromberg
f345fe4b08
Less warnings, consistent info messages
2019-02-15 09:11:46 -08:00
Thomas Stromberg
cd156b3f98
Merge branch 'master' into container-killing2
2019-02-15 09:10:19 -08:00
Thomas Strömberg
8e5fd5b275
Merge pull request #3686 from tstromberg/7-bit-console
...
Implement 7-bit ASCII prefixes for when MINIKUBE_IN_COLOR=false
2019-02-15 09:08:17 -08:00
Thomas Stromberg
18adab13fa
Remove duplicate keys from merge
2019-02-15 07:21:40 -08:00
Thomas Stromberg
4a1feb6531
Reduce text clutter
2019-02-15 07:16:41 -08:00
Thomas Stromberg
1d0733e1e4
Merge
2019-02-15 07:06:22 -08:00
Thomas Stromberg
5013af7917
Change LowPrefix for internet. It looked strange with the indented options
2019-02-15 07:03:31 -08:00
Thomas Stromberg
3838442440
Implement 7-bit ASCII prefixes
2019-02-15 06:52:33 -08:00
Thomas Strömberg
71971667a0
Merge pull request #3501 from laozc/master
...
addons: Fixes multiple files behavior in files rootfs
2019-02-15 05:34:49 -08:00
Thomas Strömberg
ceb324b4ad
Merge pull request #3660 from tstromberg/hyperkit-debugging
...
Make hyperkit driver more robust: detect crashing, misinstallation, other process names
2019-02-15 05:23:09 -08:00
Thomas Stromberg
07fc64fbe1
Warnf -> Debugf so that it doesn't interfere with output
2019-02-14 20:12:34 -08:00
Thomas Stromberg
2588a98435
Back to Run -- I was mistaken
2019-02-14 17:17:54 -08:00
Thomas Stromberg
71eafef5ce
Overhaul how we handle kubectl, as it isn't actually required except for the dashboard
2019-02-14 17:10:03 -08:00
Thomas Stromberg
c3db098d4a
ListContainers should return empty list when no containers match
2019-02-14 16:10:33 -08:00
Thomas Stromberg
7dd7e5417d
glog, not golog
2019-02-14 14:43:22 -08:00
Thomas Stromberg
531e6b0f72
Use h.SetLogger
2019-02-14 14:40:32 -08:00
Thomas Stromberg
0c8a452e97
lowercase error messages
2019-02-14 14:40:16 -08:00
Thomas Stromberg
ba9492c314
Merge branch 'master' into hyperkit-debugging
2019-02-14 14:03:52 -08:00
Anders F Björklund
dc618b70f9
Add implementation of the deprecated rkt runtime
...
This is currently good for one thing: turning it off!
Using rktlet with kubernetes hasn't worked in a while.
2019-02-14 23:02:08 +01:00
Thomas Stromberg
45303bac07
Code review comments
2019-02-14 13:59:08 -08:00
Balint Pato
5029f8a66e
Update pkg/minikube/exit/exit.go
...
Co-Authored-By: tstromberg <tstromberg@google.com>
2019-02-14 13:17:32 -08:00
Balint Pato
4c2ba19455
Update pkg/minikube/logs/logs_test.go
...
Co-Authored-By: tstromberg <tstromberg@google.com>
2019-02-14 13:16:57 -08:00
Thomas Stromberg
c2194e191d
Fix merge conflicts
2019-02-14 11:58:07 -08:00
Anders F Björklund
a02802d056
Upgrade the list of images for 1.12 and 1.13
...
Getting tired of downloading newer etcd again
2019-02-14 20:48:12 +01:00
Thomas Stromberg
4cfe77294d
Fix style merge conflict
2019-02-14 11:25:42 -08:00
Thomas Strömberg
3714bbd787
Merge pull request #3659 from tstromberg/console
...
Clearer output when re-using VM's so that users know what they are waiting on
2019-02-14 11:03:50 -08:00
Thomas Strömberg
4608a137bd
Merge pull request #3671 from tstromberg/kubeadm-eviction
...
Disable kubelet disk eviction by default
2019-02-14 11:02:58 -08:00
Thomas Strömberg
10d8487417
Merge pull request #3665 from tstromberg/sudo-poweroff
...
Run poweroff before delete, only call uninstall if driver is None
2019-02-14 10:30:31 -08:00
Thomas Stromberg
5c1a72f428
Switch Infof statements to Debugf/Warningf, as they go to stderr
2019-02-14 10:14:41 -08:00
Thomas Stromberg
247e957e8f
Revert accidental indentation
2019-02-13 21:47:54 -08:00