342b52b8cd
Merge branch 'master' of github.com:kubernetes/minikube into remove-addon-manager
2020-01-14 16:16:42 -08:00
2c301bd4ef
more node changes yay
2020-01-14 14:25:20 -08:00
2813cf4120
Merge branch 'master' of github.com:sharifelgamal/minikube into m2
2020-01-14 13:44:40 -08:00
f5be457399
fix unit tests
2020-01-14 12:12:47 -08:00
577a04b02e
disable istio provisioner by default
2020-01-14 12:05:32 -08:00
9a2de2ae7f
Hook up new addon manager logic to existing addons code
2020-01-14 10:52:27 -08:00
2029d6012c
Rebased on master
2020-01-14 10:27:39 -08:00
c017dc986c
Merge branch 'master' into crio-conf
2020-01-14 18:10:14 +01:00
708bf5c6d5
Revert unnecessary change to the extra flags order
2020-01-14 17:49:09 +01:00
2d97a0d3b7
Merge pull request #6220 from afbjorklund/crictl-local
...
Use absolute path, when calling the crictl command
2020-01-13 14:31:01 -08:00
8718a54d91
Merge pull request #6256 from tstromberg/dry-run
...
Add --dry-run option to start
2020-01-13 13:37:15 -08:00
9e317ac2bd
Do not use an arch suffix for the coredns name
...
They are using multi-arch images instead...
So don't append something like -arm64 to it.
Just use e.g. "k8s.gcr.io/coredns:1.6.5",
and Docker will pull the right platform image.
2020-01-13 22:34:19 +01:00
b665640421
Merge pull request #6277 from medyagh/kic_addon
...
add addons for kic
2020-01-13 12:56:06 -08:00
13873028ae
Merge master
2020-01-13 12:46:47 -08:00
d265162fe2
Fix some minor issues from gofmt and golint
2020-01-13 21:38:59 +01:00
13e2a3e601
Merge pull request #6276 from tstromberg/qemu-system
...
Pass --kvm-qemu-uri value into kvm2 health check
2020-01-13 11:16:07 -08:00
f959a21d87
Make sure to pass runner to UpdateCluster runtime
2020-01-12 22:19:50 +01:00
0e83dd4b4e
Use the cgroup-driver from runtime for kubelet
2020-01-12 19:29:07 +01:00
27f8adf912
Add CGroupDriver function to cruntime interface
2020-01-12 18:46:47 +01:00
62e3bc4b72
add addons for kic
2020-01-10 17:14:47 -08:00
1085d47a24
Pass in the value of *kvmQemuURI for behavioral consistency
2020-01-10 16:07:07 -08:00
5008d4cdc9
Explicitly set LIBVIRT_DEFAULT_URI default for health checking
2020-01-10 15:49:01 -08:00
0c07e80821
Remove unused import from merge
2020-01-10 09:55:50 -08:00
5568ab005a
Merge branch 'master' into unthread-start
2020-01-10 09:54:02 -08:00
19c8ddee9f
Merge pull request #6151 from medyagh/kic_exp
...
Experimental verison of kic
2020-01-10 00:42:01 -08:00
f98b5b85c7
Fix some typos and improve documents
2020-01-10 17:35:07 +09:00
59ecf3fd06
rename verify pkg to kverify
2020-01-09 16:28:23 -08:00
ef7469f3f3
Merge pull request #6261 from tstromberg/ssh_mock_race
...
ssh_mock: Copy buffer to avoid data race
2020-01-09 16:27:46 -08:00
b92c22ee5b
remove debugging message
2020-01-09 16:16:53 -08:00
851d1d5d3a
ssh_mock: Copy buffer to avoid data race
2020-01-09 16:04:54 -08:00
9eb855a9c0
lint code
2020-01-09 15:58:31 -08:00
7198566db7
fix test data for crio for new tmpl
2020-01-09 15:49:07 -08:00
381187f339
fix test data for default
2020-01-09 15:43:58 -08:00
8895dacd1a
De-parallelize GetServiceURL tests: the mocks are not thread safe
2020-01-09 15:42:05 -08:00
2ed25c72af
fix dns test data and also add tests for v17
2020-01-09 15:38:37 -08:00
70f8b96d1f
fix test data for options for new tmpl
2020-01-09 15:31:29 -08:00
aea63baa70
fix crio-options test data for new tmpl
2020-01-09 15:25:25 -08:00
2f3ad44d78
fix test data for containerd tmpl
2020-01-09 15:14:58 -08:00
b4fa45fe39
fix testdata for cidr tmpl
2020-01-09 15:08:47 -08:00
9a16a52e2f
fix containerd tmplate unittest
2020-01-09 15:01:22 -08:00
8403350a17
fix image unittest
2020-01-09 14:52:01 -08:00
4f3afcd1fa
Merge branch 'master' into unthread-start
2020-01-09 14:50:17 -08:00
418082e368
Log machine name and how long we held the lock for
2020-01-09 14:46:56 -08:00
727beb50c7
Merge pull request #6240 from tstromberg/bitflip
...
Fix inverted logic for showing issue link
2020-01-09 14:10:11 -08:00
e5fd7a6a81
Replace integration-test specific hacks with actual protection against racey events
2020-01-09 12:58:10 -08:00
7acf688f7a
Merge master
2020-01-09 11:13:25 -08:00
c5e917366f
Add --dry-run option to start
2020-01-09 11:10:23 -08:00
29deded5f4
proxy_test: improve TestIsValidEnv unit test
...
Add test under the ture case to complete this unit test.
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-09 13:33:41 +08:00
b9f5afa8f9
fix unit tests kudebadm template crio
2020-01-08 17:21:49 -08:00
890878b469
Fix unit tests and go tempalte block
2020-01-08 17:08:11 -08:00
40a011c49a
use api port for host binding port
2020-01-08 16:09:24 -08:00
867f62a9e9
move more funcs to bsutil
2020-01-08 15:47:48 -08:00
b1242e29e3
unexport funcs in images package
2020-01-08 15:33:47 -08:00
cf9e6e512f
fix ineffectual assignment
2020-01-08 15:21:57 -08:00
de0d603c7f
convert base image to a const
2020-01-08 13:56:23 -08:00
8a0c840e52
move kic docker image to minikube gcr
2020-01-08 13:52:07 -08:00
f908468bec
Fix inverted logic for showing issue link
2020-01-08 13:32:34 -08:00
88bef295c8
remove debugging msgs and add sysverification ignore
2020-01-08 13:19:34 -08:00
ddf5ab027a
add extra option fail swap for kic
2020-01-08 12:53:29 -08:00
6da07be75d
Merge pull request #6175 from q384566678/oci-remove-todo
...
pkg/drivers/kic/oci: delete TODO info
2020-01-08 10:40:32 -08:00
4a06fde1cf
Check for nil ref and img before passing them into go-containerregistry
2020-01-08 10:02:11 -08:00
7e0b89cc9d
code optimization
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-08 16:25:11 +08:00
444b36161b
Merge pull request #6193 from q384566678/oci-status
...
kic/oci: parse all kind of states
2020-01-07 14:54:42 -08:00
5a23d635d5
package comment
2020-01-07 14:49:05 -08:00
4013158328
rename package to ktmpl
2020-01-07 14:16:16 -08:00
f80572bb4c
code review
2020-01-07 13:59:41 -08:00
07c0e32954
improve kic image
2020-01-07 13:54:00 -08:00
77394db9aa
add Dockerfile for kic images
2020-01-07 13:54:00 -08:00
618b150bcd
fix setup kubeconfig for kic
2020-01-07 13:54:00 -08:00
d76eb6d28c
use net join for kubeconfig port
2020-01-07 13:54:00 -08:00
a64a2721d5
Add localhost to ca cert
2020-01-07 13:54:00 -08:00
d298593d8a
refactor api server verification
2020-01-07 13:54:00 -08:00
e9b7451278
auto set podsubnet for kic improve none auto set
2020-01-07 13:54:00 -08:00
ae45bb75e3
add podsubnet to all tempaltes
2020-01-07 13:54:00 -08:00
860ce25bf2
Add podSubnet to templates
2020-01-07 13:54:00 -08:00
4dd9866e9d
Add addons to kic too
2020-01-07 13:54:00 -08:00
c7bc61af2c
Add overlay network for kic
2020-01-07 13:54:00 -08:00
6cf2554877
add flag for kic host binding port
2020-01-07 13:54:00 -08:00
35c47b9dc4
Ignore iptables for kic and fix chmod +x permission
2020-01-07 13:53:19 -08:00
ea207b34a1
add output to logs kubeadm init
2020-01-07 13:53:19 -08:00
0b85aa9daf
Add start restart to kic bs
2020-01-07 13:53:19 -08:00
08c715af8b
move verify clusters to its own package
2020-01-07 13:53:19 -08:00
af1b77a164
implement pull images for kicbs
2020-01-07 13:52:47 -08:00
1de4adf273
Implement images list for kic
2020-01-07 13:52:47 -08:00
ac97b51058
implement setup certs for kicbs
2020-01-07 13:52:47 -08:00
a358aff093
fix ocibinary
2020-01-07 13:52:47 -08:00
be79843f75
Merge pull request #6214 from laozc/hostport-join
...
Fixes IPv6 address handling in kubeadm
2020-01-07 11:45:32 -08:00
d23b446d2e
Merge pull request #6218 from afbjorklund/reportcard-minor
...
Improve reportcard by refactoring and commenting
2020-01-07 11:42:55 -08:00
af4ee5cf1f
Merge pull request #6124 from priyawadhwa/addon-per-profile-refactor
...
Enable or disable addons per profile
2020-01-06 16:33:01 -08:00
6ad7e4a9a0
address code review comments
...
add better error handling and remove duplication in enableOrDisableAddonsInternal
2020-01-06 13:42:09 -08:00
655da9091c
Make helper function less generic, to please lint
...
`getCommandPath` - `cmd` always receives `"crictl"` (unparam)
2020-01-06 18:33:07 +01:00
4d0446afa5
Use absolute path, when calling the crictl command
...
To work on CentOS, which has a weird path in sudo
2020-01-06 16:55:05 +01:00
118451f4b2
Refactor: move usage of crictl to cruntime package
...
We don't want the crictl or docker commands outside
2020-01-06 15:55:10 +01:00
723f1f941b
Update the crio.conf instead of overwriting it
...
We are only changing one config value, anyway
2020-01-06 15:19:57 +01:00
024dfe18dc
Refactor: move the crio config to the crio runtime
...
For some reason it was left with the generic CRI
2020-01-06 14:55:18 +01:00
ea7a2d7e33
Improve reportcard by refactoring and commenting
...
golint: 99%
pkg/minikube/localpath/localpath.go
Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
pkg/minikube/cluster/cluster.go
Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
cmd/minikube/cmd/start.go
Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
f388f69220
Remove duplicated words
...
Although it is spelling mistakes, it might make an affects while reading.
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-06 15:54:27 +07:00
5f8a4503eb
Fixes IPv6 address handling in kubeadm
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-05 23:37:00 +08:00
62bfc39404
Fix comment
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-03 09:31:55 +08:00
c1859c44e3
kic/oci: parse all kind of states
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-02 14:16:54 +08:00
e5f5abda89
Merge pull request #6179 from q384566678/fix-pause
...
pkg/drivers/kic: fix wrong command in Unpause
2019-12-30 18:42:28 -08:00
e47cde6ae4
Rebased on master, moved istio addon into new package
2019-12-30 10:10:05 -05:00
9c4e3fbd3c
pkg/drivers/kic: fix wrong command in Unpause
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:54:48 +08:00
ae61e56594
pkg/drivers/kic/oci: fix Status info
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:21:03 +08:00
aa52255be0
pkg/drivers/kic/oci: delete TODO info
...
When the docker exit status is 125, it is not entirely certain that it is caused by duplicate names.There may also be other errors.
e.g:
➜ minikube git:(oci-remove-todo) ✗ docker run -itzz
unknown shorthand flag: 'z' in -zz
See 'docker run --help'.
➜ minikube git:(oci-remove-todo) ✗ echo $?
125
So delete this TODO info.
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 14:43:11 +08:00
df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
...
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
c2ba574f2e
generate istio document page and layout
2019-12-26 14:35:13 +08:00
ce4b9503ae
Merge pull request #6137 from q384566678/add-constants-test
...
Add constants_test
2019-12-23 01:13:50 -08:00
d5f56477bc
code review resolve
2019-12-20 17:14:14 -08:00
3b2cfa6c32
rename funcs
2019-12-20 16:53:35 -08:00
83cd426436
refactor more
2019-12-20 16:11:05 -08:00
cf6bde8eaf
refactor image specific funcs to image package
2019-12-20 16:05:08 -08:00
cde5503d3e
add two mechanism to find local image digest
2019-12-20 14:09:18 -08:00
9d03e56ece
resolve merge conflict
2019-12-20 12:44:09 -08:00
be8a1ad107
resolve code reviews
2019-12-20 12:43:13 -08:00
6c25cd3848
Rebased on master
2019-12-20 12:34:48 -08:00
5eb384cf7d
check error and fix logging msg
2019-12-20 12:24:05 -08:00
502f3b7f8f
use docker cli lib to get image id
2019-12-20 12:18:55 -08:00
4d9e53389a
improve logging
2019-12-20 12:12:48 -08:00
2d1fffe1d1
better names
2019-12-20 12:06:26 -08:00
679a9c114b
more clear func names
2019-12-20 12:06:26 -08:00
71a896fc0a
unexport func cacheImage
2019-12-20 12:06:25 -08:00
031126b358
Merge pull request #6112 from medyagh/kic_start_xmas
...
kic-xmas edition
2019-12-20 11:40:46 -08:00
2167655006
add unit test for GetDNSIP
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-20 17:32:50 +08:00
6a5497510a
add unit test for GetServiceClusterIP
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-20 17:27:24 +08:00
f9e7a54eb8
rename kicdocker to docker
2019-12-20 01:26:38 -08:00
f39ba0deb0
add unit test for feature gate supports
2019-12-20 01:17:33 -08:00
1014a57ea8
better names for bs type
2019-12-20 01:01:10 -08:00
cae166e74c
Merge branch 'master' into advice-refresh
2019-12-19 16:23:25 -08:00
f438bb7ec8
Merge branch 'master' into less-catastrophic
2019-12-19 16:15:47 -08:00
512b3cb314
Refresh advice, flip hide vs show default for links
2019-12-19 16:04:34 -08:00
7360edc8e0
add kic cni
2019-12-19 15:11:22 -08:00
83aca57dd4
Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor
2019-12-19 13:20:12 -08:00
859420c083
Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor
2019-12-19 13:06:07 -08:00
6cc860e911
Add build tags so that the test only runs on Darwin
2019-12-19 13:05:47 -08:00
0796d866df
Further clarification
2019-12-19 12:51:02 -08:00
4e0454d6b4
Merge pull request #6111 from tstromberg/awful-offl
...
Offline: always transfer image if lookup fails, always download drivers
2019-12-19 11:52:28 -08:00
28c4c82bd7
Merge pull request #5833 from govargo/fix-without-hyperkit-errormsg
...
Add hyperkit version check whether user's hyperkit is newer
2019-12-19 11:44:58 -08:00
cce503033d
rename CreateParam to CreateConfig
2019-12-19 11:12:49 -08:00
e1d5704170
get rid of default oci
2019-12-19 11:08:05 -08:00
6cbdfe3961
remove more codefrom node
2019-12-19 10:47:07 -08:00
4c7b94971c
Address review comments
...
Remove old TODO and remove function to get current profile as it can
create errors when trying to get multiple profiles.
2019-12-19 10:41:01 -08:00
310cef80de
get rid of node cache
2019-12-19 10:37:15 -08:00
f001dd703a
convert kic restart to case switch
2019-12-19 10:01:18 -08:00
80b15e8e6c
Add comment for config structs
2019-12-19 09:52:53 -08:00
d864ac3f04
pkg/util: add CalculateSizeInMB test
...
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
2019-12-19 18:36:05 +08:00
6e87872fa1
make ConfigFileAssets more reusable
2019-12-19 01:19:32 -08:00
62cd3102c0
move funcs to related files
2019-12-19 00:28:39 -08:00
33523677bc
unexport extraConfig
2019-12-19 00:28:39 -08:00
5c445dcca2
unexport funcs and move to better place
2019-12-19 00:28:39 -08:00
79657f904b
unexport func
2019-12-19 00:28:39 -08:00
c4c87ef6e2
move test data
2019-12-18 23:20:42 -08:00
43a7267079
make public methods that aren't used outside of the package private
2019-12-18 22:33:00 -08:00
ceb4938c7a
Add more unit tests
2019-12-18 22:27:32 -08:00
921fee7432
Moved unit tests to addons package and refactored them
2019-12-18 22:02:10 -08:00
e72cb80cbf
Enable/disable addons works per profile
...
However, this means that addon information won't persist beyond a 'minikube delete'
2019-12-18 21:35:46 -08:00
04c7e561db
moving kubernetes config templates to a package
2019-12-18 17:30:19 -08:00
b8d07daef3
move reusabe parts of kubeadm to a package
2019-12-18 17:22:42 -08:00
36893766c4
Not a crash, but an error
2019-12-18 16:12:20 -08:00
31ad90d3cb
Add place holder bootstrapper for kicbs
2019-12-18 16:11:50 -08:00
19560a631b
Add kic specific machine creation message
2019-12-18 15:53:34 -08:00
2243847f98
add kic command runner to machine
2019-12-18 13:57:32 -08:00
c627f58fbb
add default image
2019-12-18 13:04:09 -08:00
ba8b723978
Move addon related logic to pkg/addons for better organization
2019-12-18 11:31:29 -08:00
b6dbf3bd0d
add auto-set container-runtime for kic
2019-12-17 22:19:39 -08:00
2bf1289bf3
adding place holder for kicbs
2019-12-17 22:06:45 -08:00
71b260292c
remove more code
2019-12-17 21:53:36 -08:00
12df013810
simplify overlaping structs
2019-12-17 21:36:37 -08:00
ca68beae6a
remove not needed code
2019-12-17 19:33:54 -08:00
0f77b9d7f2
change variable name
2019-12-17 19:03:49 -08:00
5ae0c4d41b
added docker to supported drivers
2019-12-17 18:45:10 -08:00
7a433cc6a9
Add kic specifc fields to machine config
2019-12-17 17:47:37 -08:00
b6506007b8
refactor: remove warning log to avoid duplicate logging and remove useless getter func
2019-12-18 10:36:50 +09:00
39f71346a6
rename constant name and shorten warining message of version old
2019-12-18 10:36:50 +09:00
f9d4762765
Improve hyperkit specific version check
2019-12-18 10:36:50 +09:00
fcbf4d1b4d
Add hyperkit version checker: whether user's hyperkit is new
2019-12-18 10:36:50 +09:00
379bf2ac0c
fix boilerplate formats
2019-12-17 16:38:56 -08:00
46df68ca4b
move cri to oci package
2019-12-17 16:04:03 -08:00
e46c586764
more refactor fun
2019-12-17 15:53:37 -08:00
5c1145bcd8
add kic command runner
2019-12-17 15:32:06 -08:00
d7273d36c9
Add kic driver
2019-12-17 15:18:31 -08:00
04486049d2
Always transfer images when local reference lookups fail
2019-12-17 13:21:34 -08:00
84ce2dbd62
Fixed bug, using version when should use profile
2019-12-17 12:09:42 -08:00
d21db02c76
Apply addons to all profiles
2019-12-17 11:58:26 -08:00
5003684b5b
rebased on master
2019-12-16 10:49:55 -08:00
9f2217d803
sketches of the node commands
2019-12-12 17:38:29 -08:00
47d918f1b3
making more arbitrary node changes
2019-12-12 10:35:33 -08:00
6c8bcf0aa4
Merge branch 'm2' of github.com:sharifelgamal/minikube into m2
2019-12-11 13:07:47 -08:00
de0fbca8b3
initial commit
2019-12-11 12:21:31 -08:00
d811f6e428
Remove unused forceID var
2019-12-11 12:10:28 -08:00
3171493e51
Rename to PathMutexSpec
2019-12-11 12:01:32 -08:00
c5f65baf61
Remove uid from hash name, as it is not necessary now that we lock on filenames rather than descriptive names
2019-12-11 11:52:36 -08:00
129b6a870b
Update log messages
2019-12-11 09:54:44 -08:00
af4e690837
Use sha1 for a larger hash, truncated to 40 chars
2019-12-11 09:14:20 -08:00
cfe0f5a5b7
Use md5 to generate unique lock names
2019-12-11 08:13:12 -08:00
bef508d461
Remove high-ASCII characters from comment
2019-12-10 15:23:47 -08:00
a1ddd283fe
Check errors, remove docker.io prefix used by crio
2019-12-10 14:28:40 -08:00
e0b6a1eb49
Address review comments
...
Address nits and remove integration test to make sure addon manager pod
is up and running since we will no longer enable it by default.
2019-12-10 14:16:28 -08:00
661ebf843f
Merge master
2019-12-10 14:07:02 -08:00
32e0732e15
Add integration test
2019-12-10 14:02:12 -08:00
Priya Wadhwa
Sharif Elgamal
Medya Gh
Anders F Björklund
Medya Ghazizadeh
Thomas Stromberg
sshukun
Zhou Hao
Kim Bao Long
Zhongcheng Lao
fenglixa
Kenta Iso