Commit Graph

1454 Commits (405290dc1c75719f54c572c2b632c65ca35ea2a8)

Author SHA1 Message Date
Medya Gh 78c192cb40 lint 2020-02-20 00:07:36 -08:00
Medya Gh dcff758753 lint 2020-02-20 00:07:36 -08:00
Medya Gh 4fe9ca5f05 break done delete and prune into two funcs better error handling 2020-02-20 00:07:36 -08:00
Medya Gh 8d45b236de less ambigous error log 2020-02-20 00:07:36 -08:00
Medya Gh d84aa9f447 lint 2020-02-20 00:07:36 -08:00
Medya Gh b1d139c24b code review comments 2020-02-20 00:07:35 -08:00
Medya Gh d3b86cfeb9 improve logging 2020-02-20 00:07:35 -08:00
Medya Gh efd4aabde4 clean up containers first then delete volume 2020-02-20 00:07:35 -08:00
Medya Gh b235255196 fix volume clean up 2020-02-20 00:07:35 -08:00
Medya Ghazizadeh 8700f8a1e0
Merge pull request #6700 from medyagh/resource_limit
fix inverted logic for resource logic
2020-02-19 23:57:16 -08:00
Medya Ghazizadeh 0af5734bc9
Merge pull request #6696 from priyawadhwa/install-addons
Fix bug in --install-addons flag
2020-02-19 22:33:50 -08:00
Medya Gh ec7c6ba4fa fix inverted logic 2020-02-19 21:33:24 -08:00
Priya Wadhwa 5ad4d6ebf5 Fix bug in --install-addons flag
Respect --install-addons flag, don't install anything if it is false
2020-02-19 14:56:09 -08:00
aallbright 089deef706 Do not create profiles that do not exist 2020-02-18 05:59:37 -05:00
Medya Gh 1da0a370ff code review comments 2020-02-17 10:55:53 -08:00
Medya Gh 23ef3f6d16 lint 2020-02-16 19:51:59 -08:00
Medya Gh a007c0790c Delete volumes created by kic 2020-02-14 01:39:16 -08:00
Sharif Elgamal c1a3e4348d fix unit tests and fix merge conflicts 2020-02-13 10:30:12 -08:00
Sharif Elgamal 2785d292f5 Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-13 10:15:04 -08:00
Medya Ghazizadeh 25167e1b75
Fix docker-env and add unit and integration tests (#6604)
* Fix docker cert env in docker-env for docker driver

* add unit tests

* add integration tests for docker-env cmd

* lint

* fix lint

* merge conflict

* improve docker-env integraiton test

* linting
2020-02-13 02:17:11 -07:00
Sharif Elgamal 8c55c9ca60 holy crap cyclical import hell sucks 2020-02-12 18:34:44 -08:00
Medya Ghazizadeh 398c7ef00b
Add podman driver (#6515) 2020-02-12 19:11:44 -07:00
priyawadhwa af353314e0
Separate cached kubernetes binaries by OS on host machine (#6586)
* Separate cached kubernetes binaries by OS on host machine

This way, all kubernetes binaries stored in ~/.minikube/cache/linux will be copied over to the VM and used for `minikube kubectl` on linux machines. kubectl will be stored in `~/.minikube/cache/{windows or darwin}` on windows/darwin so that `minikube kubectl` still works.

* Review comment

* Update integration test

* Make sure --download-only includes OS specific kubectl

Update integration test to make sure we download
OS specific kubectl on darwin/windows when using --download-only flag
2020-02-11 23:23:37 -07:00
Sharif Elgamal b427dc5663 fixed commands, they mostly work now 2020-02-11 21:11:22 -08:00
Sharif Elgamal 9830d91c09 linting nonsense 2020-02-11 18:39:59 -08:00
Sharif Elgamal 744efaa330 REFACTOR COMPLETE? 2020-02-11 17:06:59 -08:00
Sharif Elgamal b6a429dc9d hey did you want more files? good 2020-02-11 15:45:49 -08:00
Sharif Elgamal f2ebbb9c67 Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-11 09:44:10 -08:00
Sharif Elgamal 69aa54ff82
begin start refactor 2020-02-11 09:38:15 -08:00
Anders Björklund ff763db1e7
Add podman-env for connecting with podman-remote (#6351)
* Refactor: add the docker vars after the shell vars

* Move shell handling functions to separate package

* Rename env source file to docker-env like command

* Add podman-env for connecting with podman-remote

* Remove leading Shell prefix from the shell package

* Add some documentation describing podman service

* Address some podman-env issues pointed out by lint
2020-02-10 22:59:37 -07:00
anencore94 a283fd695a
Fix to kubeConfigPath could be set from env (#6568)
* Fix to kubeConfigPath could be set from env

Fix to use kubeConfigPath by using kubeconfig.PathFromEnv
function not from just $HOME/.kube/config

Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>

* Delete redundant logic to get kubeConfigPath

- change to use already present util function
 to set up kubeConfigPath

Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>

Co-authored-by: SOPHAL HONG <hongsophal.hsp@gmail.com>
Co-authored-by: Woohyung Han <woohhan@gmail.com>
2020-02-10 16:08:07 -07:00
go_vargo e18e4d083b
Fix `minikube start` in order to be able to start VM even if machine does not exist (#5730)
* fix startHost in order to be able to  start VM even if machine does not exist

* Update func StartHost() and its unit test no to use config.GetMachineName()

* Add handle case when the kic image isn't pulled
2020-02-10 11:37:30 -07:00
Zhongcheng Lao 239be7ed94 Create Hyper-V External Switch (#6264)
* Create and manager Hyper-V switch
* Adds new flag for Hyper-V driver
* Move switch creation out of chooseSwitch
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-02-07 21:22:19 -07:00
Sharif Elgamal e1fc3ce734
let's rearrange some stuff 2020-02-07 17:00:24 -08:00
Thomas Strömberg 8762c48921
Merge pull request #6541 from anencore94/deleteContext
Fix to delete context when delete minikube
2020-02-07 16:15:56 -08:00
Thomas Strömberg 2c08f62ed2
Let DeleteContext determine the KUBECONFIG path 2020-02-07 15:34:31 -08:00
priyawadhwa 914e7de860
Merge pull request #6536 from tstromberg/wait-nada2
Add --install-addons toggle for users who don't want them
2020-02-07 11:47:24 -08:00
anencore94 460f8d0187 Fix bug to delete context when delete minikube
- when `minikube delete`, minikube must delete its config which
  are set when `minikube start`.
- But, there was some mistakes in the function that does this
  logic

Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2020-02-07 20:00:08 +09:00
Thomas Stromberg c195d5a55f Merge branch 'master' into powershell-env-bugfixes 2020-02-06 23:17:26 -08:00
Thomas Strömberg 10ef863f7d
Merge pull request #6527 from tstromberg/powershell-env
Bug-compatible refactor of docker-env + output tests
2020-02-06 21:57:25 -08:00
Thomas Stromberg 63954700d7 Address review comments 2020-02-06 17:32:08 -08:00
Thomas Stromberg 4ba0f52f57 Add flag to toggle installation of addons 2020-02-06 17:29:19 -08:00
Thomas Stromberg 5d59e83b64 Rewrite unsetScript to fix a variety of bugs 2020-02-06 17:01:05 -08:00
Thomas Stromberg 0cac457126 Transition TestGetNodeDockerEnvIPv6 to env_test 2020-02-06 16:05:05 -08:00
Thomas Stromberg 6e19c62896 Update tests to include all current output quirks 2020-02-06 15:54:57 -08:00
Thomas Stromberg b478fbaa1a Minimize changes 2020-02-06 15:40:24 -08:00
Thomas Stromberg 32bc0ff76a Refactor docker-env for testability 2020-02-06 15:32:00 -08:00
Sharif Elgamal f6f8b503c4 fill in cmd code 2020-02-06 13:38:42 -08:00
Priya Wadhwa 6ef60c1964 Add warnings back in 2020-02-06 13:27:49 -08:00
Priya Wadhwa 59ab0ba89e Fix lint errors 2020-02-06 10:11:38 -08:00