Commit Graph

13 Commits (3f40bdcc470869c87e76df68ff51ec0a307627b3)

Author SHA1 Message Date
tstromberg 9a9f9edf5f First pass at lint-ageddon 2019-05-13 18:31:55 -07:00
Thomas Stromberg 055c8002b1 Replace %s format directives with %v for errors.
Previously we were mixed between the two forms. This commit picks %v,
which is consistent with the Kubernetes code base. They both effectively
do the same thing in this case, though %v works with any object, and %s
only with string objects.
2018-09-28 16:05:27 -07:00
Matt Rickard d56d41b956 Add duration as a configurable type for localkube 2017-07-19 14:16:33 -07:00
Matt Rickard 3b46c27b16 Minikube changes for v1.6.0-alpha.1 2017-03-31 13:23:59 -07:00
dlorenc 63ac7e8a76 Fix tests. 2017-03-13 10:21:14 -07:00
dlorenc c220ada63b Fix tests. 2017-03-07 15:00:19 -05:00
Dale Hamel 107e3324a6 Add support for parsing CIDRs to config 2017-03-07 14:59:36 -05:00
Eden Li c632321122 support componentconfigs with native type aliases
Some componentconfig options are aliased to native convertible types
(e.g. ProxyMode) but FindAndSet() was unable to detect that and so it
wasn't possible to set these values via `--extra-config`.

This change addresses that by using the reflected value's Kind instead
of a type assertion on its interface.

It's also worth noting that any value with the type Duration (e.g.
proxy.IPTablesSyncPeriod) is also unable to be set for the same reason,
but this commit does not address that.

See https://github.com/kubernetes/minikube/issues/1217
2017-03-03 01:29:46 -08:00
Jimmi Dyson 23a1e4ada4
Allow setting string slices in extra config 2017-01-12 12:10:53 +00:00
Dan Lorenc bd0acdf480 Fix the type referenced for PortRange. 2016-11-23 09:04:38 -08:00
dlorenc f72dadbe03 Add PortRange to the extra-config parser. 2016-11-22 09:56:55 -08:00
Dan Lorenc e8d8cc0ba3 Add support for net.IP to the configurator. 2016-10-28 14:33:36 -07:00
dlorenc 8611a455ca Initial configurator commit. 2016-09-30 10:05:14 -07:00